Vote Up/Down - 6.x-2.x

Test status
StatusResult
Last receivedWed, 01/11/2012 - 03:06:37
Last requestedWed, 01/11/2012 - 03:07:03
Last testedWed, 01/11/2012 - 03:07:32
Test count79
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier6.x-2.x
ProjectVote Up/Down
LinkProject information
SummaryPASSED: [[Coder]]: [Code review] 0 minor(s), 1 critical(s), and 16 normal(s); [[SimpleTest]]: [MySQL] 129 pass(es).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing
129 pass(es), 0 fail(s), and 0 exception(s)
Test namePassFailException
LeafVote Up/Down (VudWebTestCase) [Vote Up/down]2200
LeafVote Up/Down Node (VudNodeWebTestCase) [Vote Up/down]10700

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
0 minor(s), 1 critical(s), and 16 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandvud.module002
MessageGroupFilenameLineFunctionStatus
Use sentence case, not title case, for end-user strings. (Wikipedia)Othervud.module62N/A
Function summaries should be one line only. (Drupal Docs)Othervud.module209N/A
Expandvud.test006
MessageGroupFilenameLineFunctionStatus
Doxygen uses @todo and @bug to markup things to be done.Othervud.test9N/A
Function summaries should be one line only. (Drupal Docs)Othervud.test9N/A
Doxygen uses @todo and @bug to markup things to be done.Othervud.test10N/A
Function documentation should be less than 80 characters per line.Othervud.test10N/A
Doxygen uses @todo and @bug to markup things to be done.Othervud.test11N/A
Separate comments from comment syntax by a space.Othervud.test51N/A
Expandvud.theme.inc001
MessageGroupFilenameLineFunctionStatus
Use sentence case, not title case, for end-user strings. (Wikipedia)Othervud.theme.inc398N/A
Expandvud_comment/views/vud_comment.views.inc001
MessageGroupFilenameLineFunctionStatus
Use sentence case, not title case, for end-user strings. (Wikipedia)Othervud_comment.views.inc14N/A
Expandvud_node/views/vud_node.views.inc001
MessageGroupFilenameLineFunctionStatus
Use sentence case, not title case, for end-user strings. (Wikipedia)Othervud_node.views.inc14N/A
Expandvud_node/views/vud_node_handler_field_widget.inc010
MessageGroupFilenameLineFunctionStatus
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Othervud_node_handler_field_widget.inc37N/A
Expandvud_node/vud_node.test001
MessageGroupFilenameLineFunctionStatus
Separate comments from comment syntax by a space.Othervud_node.test55N/A
Expandvud_term/views/vud_term.views.inc001
MessageGroupFilenameLineFunctionStatus
Use sentence case, not title case, for end-user strings. (Wikipedia)Othervud_term.views.inc15N/A
Expandvud_term/vud_term.module001
MessageGroupFilenameLineFunctionStatus
The $text argument to l() should be enclosed within t() so that it is translatable.Othervud_term.module123N/A
Expandwidgets/plain/widget.tpl.php001
MessageGroupFilenameLineFunctionStatus
the final ?> should be omitted from all code filesOtherwidget.tpl.php28N/A
Expandwidgets/upanddown/widget.tpl.php001
MessageGroupFilenameLineFunctionStatus
Doxygen uses @todo and @bug to markup things to be done.Otherwidget.tpl.php8N/A

All

Test nameMinorCriticalNormal
Leafhook_vud.php000
Leafvud.install000
Expandvud.module002
MessageGroupFilenameLineFunctionStatus
Use sentence case, not title case, for end-user strings. (Wikipedia)Othervud.module62N/A
Function summaries should be one line only. (Drupal Docs)Othervud.module209N/A
Expandvud.test006
MessageGroupFilenameLineFunctionStatus
Doxygen uses @todo and @bug to markup things to be done.Othervud.test9N/A
Function summaries should be one line only. (Drupal Docs)Othervud.test9N/A
Doxygen uses @todo and @bug to markup things to be done.Othervud.test10N/A
Function documentation should be less than 80 characters per line.Othervud.test10N/A
Doxygen uses @todo and @bug to markup things to be done.Othervud.test11N/A
Separate comments from comment syntax by a space.Othervud.test51N/A
Expandvud.theme.inc001
MessageGroupFilenameLineFunctionStatus
Use sentence case, not title case, for end-user strings. (Wikipedia)Othervud.theme.inc398N/A
Expandvud_comment/views/vud_comment.views.inc001
MessageGroupFilenameLineFunctionStatus
Use sentence case, not title case, for end-user strings. (Wikipedia)Othervud_comment.views.inc14N/A
Leafvud_comment/views/vud_comment_handler_field_widget.inc000
Leafvud_comment/vud_comment.install000
Leafvud_comment/vud_comment.module000
Leafvud_comment/vud_comment.test000
Expandvud_node/views/vud_node.views.inc001
MessageGroupFilenameLineFunctionStatus
Use sentence case, not title case, for end-user strings. (Wikipedia)Othervud_node.views.inc14N/A
Expandvud_node/views/vud_node_handler_field_widget.inc010
MessageGroupFilenameLineFunctionStatus
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Othervud_node_handler_field_widget.inc37N/A
Leafvud_node/vud_node.install000
Leafvud_node/vud_node.module000
Expandvud_node/vud_node.test001
MessageGroupFilenameLineFunctionStatus
Separate comments from comment syntax by a space.Othervud_node.test55N/A
Expandvud_term/views/vud_term.views.inc001
MessageGroupFilenameLineFunctionStatus
Use sentence case, not title case, for end-user strings. (Wikipedia)Othervud_term.views.inc15N/A
Leafvud_term/views/vud_term_handler_field_widget.inc000
Leafvud_term/vud_term.install000
Expandvud_term/vud_term.module001
MessageGroupFilenameLineFunctionStatus
The $text argument to l() should be enclosed within t() so that it is translatable.Othervud_term.module123N/A
Leafvud_term/vud_term.test000
Leafwidgets/alternate/alternate.inc000
Leafwidgets/alternate/widget.tpl.php000
Leafwidgets/plain/plain.inc000
Leafwidgets/plain/votes.tpl.php000
Expandwidgets/plain/widget.tpl.php001
MessageGroupFilenameLineFunctionStatus
the final ?> should be omitted from all code filesOtherwidget.tpl.php28N/A
Leafwidgets/upanddown/upanddown.inc000
Expandwidgets/upanddown/widget.tpl.php001
MessageGroupFilenameLineFunctionStatus
Doxygen uses @todo and @bug to markup things to be done.Otherwidget.tpl.php8N/A
Leafwidgets/updown/updown.inc000
Leafwidgets/updown/widget.tpl.php000