Views OAI-PMH - 6.x-2.x | Drupal Quality Assurance

Latest changes

So Long and Thanks for all the Tests

1 week 2 days ago

Support

In case of troubles

check the FAQ. Please make sure you've tried the test locally.
search known testbot issues and then create a new issue if yours isn't there already. Please give a link to the test.

Test client logs

No clients to display.

Views OAI-PMH - 6.x-2.x

Test status

Status	Result
Last received	Sat, 01/26/2013 - 01:24:10
Last requested	Sat, 01/26/2013 - 01:25:01
Last tested	Sat, 01/26/2013 - 01:25:37
Test count	2

Environment status

MySQL	pass
Code review	fail

Overall Result	pass

Branch information

Identifier	6.x-2.x
Project	Views OAI-PMH
Link	Project information

Event logView entire log

ID	Message	Timestamp
5295728	Result retrieved by project client.	3 years 4 weeks ago
5295723	Result retrieved by project client.	3 years 4 weeks ago
5295713	Result received from test client #664.	3 years 4 weeks ago
5295703	Result received from test client #813.	3 years 4 weeks ago
5295698	Requested by test client #813.	3 years 4 weeks ago
5295693	Requested by test client #664.	3 years 4 weeks ago
5295688	Test request received.	3 years 4 weeks ago

SummaryPASSED: [[Coder]]: [Code review] 156 minor(s), 1 critical(s), and 9 normal(s); [[SimpleTest]]: [MySQL] 0 pass(es).

Details

MySQL
Code review

MySQL

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a Drupal installation failure
Detect a test run failure
Detect a failing test
Complete test suite with all tests passing

Review log

Code review

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a review run failure
Detect coder flags
Ensure that your code follows the Drupal standard and passes a coder review.
Complete coder review with all passed

156 minor(s), 1 critical(s), and 9 normal(s)

Non-pass

Test name

Minor

Critical

Normal

plugins/views_oai_pmh_plugin_row_dc.inc

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	views_oai_pmh_plugin_row_dc.inc	-1	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	views_oai_pmh_plugin_row_dc.inc	25	N/A
Use an indent of 2 spaces, with no tabs	Other	views_oai_pmh_plugin_row_dc.inc	44	N/A
Use an indent of 2 spaces, with no tabs	Other	views_oai_pmh_plugin_row_dc.inc	45	N/A

plugins/views_oai_pmh_plugin_row_etdms.inc

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	views_oai_pmh_plugin_row_etdms.inc	-1	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	views_oai_pmh_plugin_row_etdms.inc	23	N/A
Use an indent of 2 spaces, with no tabs	Other	views_oai_pmh_plugin_row_etdms.inc	42	N/A
Use an indent of 2 spaces, with no tabs	Other	views_oai_pmh_plugin_row_etdms.inc	43	N/A

theme/views-oai-pmh-response.tpl.php

Message	Group	Filename	Line	Function	Status
@file block missing (Drupal Docs)	Other	views-oai-pmh-response.tpl.php	-1	N/A
use lowercase html tags to comply with XHTML	Other	views-oai-pmh-response.tpl.php	2	N/A

theme/views_oai_pmh.theme.inc

Message	Group	Filename	Line	Function
There should be no trailing spaces	Other	views_oai_pmh.theme.inc	16	N/A
There should be no trailing spaces	Other	views_oai_pmh.theme.inc	19	N/A
There should be no trailing spaces	Other	views_oai_pmh.theme.inc	24	N/A
There should be no trailing spaces	Other	views_oai_pmh.theme.inc	29	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	views_oai_pmh.theme.inc	35	N/A
There should be no trailing spaces	Other	views_oai_pmh.theme.inc	49	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	views_oai_pmh.theme.inc	55	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	views_oai_pmh.theme.inc	61	N/A
There should be no trailing spaces	Other	views_oai_pmh.theme.inc	64	N/A
There should be no trailing spaces	Other	views_oai_pmh.theme.inc	69	N/A
There should be no trailing spaces	Other	views_oai_pmh.theme.inc	74	N/A
There should be no trailing spaces	Other	views_oai_pmh.theme.inc	79	N/A
There should be no trailing spaces	Other	views_oai_pmh.theme.inc	82	N/A
There should be no trailing spaces	Other	views_oai_pmh.theme.inc	103	N/A
There should be no trailing spaces	Other	views_oai_pmh.theme.inc	110	N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)	Other	views_oai_pmh.theme.inc	176	N/A
There should be no trailing spaces	Other	views_oai_pmh.theme.inc	225	N/A

views_oai_pmh.install

Message	Group	Filename	Line	Function	Status
@file block missing (Drupal Docs)	Other	views_oai_pmh.install	-1	N/A
Missing period	Other	views_oai_pmh.install	12	N/A

views_oai_pmh.views_default.inc

Message	Group	Filename	Line	Function	Status
@file block missing (Drupal Docs)	Other	views_oai_pmh.views_default.inc	-1	N/A

All

Test name

Minor

Critical

Normal

plugins/includes/views_oai_pmh_metadata_type.inc

Message	Group	Filename	Line	Function
There should be no trailing spaces	Other	views_oai_pmh_metadata_type.inc	11	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type.inc	18	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type.inc	21	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type.inc	24	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type.inc	27	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type.inc	33	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type.inc	39	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type.inc	45	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type.inc	51	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type.inc	57	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type.inc	63	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type.inc	69	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type.inc	72	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type.inc	75	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type.inc	81	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type.inc	83	N/A

plugins/includes/views_oai_pmh_metadata_type_definitions.inc

Message	Group	Filename	Line	Function
There should be no trailing spaces	Other	views_oai_pmh_metadata_type_definitions.inc	10	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type_definitions.inc	12	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type_definitions.inc	17	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type_definitions.inc	58	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type_definitions.inc	78	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type_definitions.inc	157	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type_definitions.inc	176	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type_definitions.inc	181	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type_definitions.inc	185	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type_definitions.inc	189	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type_definitions.inc	202	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type_definitions.inc	210	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type_definitions.inc	219	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type_definitions.inc	223	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type_definitions.inc	241	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type_definitions.inc	248	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type_definitions.inc	255	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type_definitions.inc	260	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type_definitions.inc	275	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type_definitions.inc	294	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type_definitions.inc	299	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type_definitions.inc	303	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type_definitions.inc	307	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type_definitions.inc	320	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type_definitions.inc	328	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type_definitions.inc	337	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type_definitions.inc	341	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type_definitions.inc	359	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type_definitions.inc	366	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type_definitions.inc	373	N/A
There should be no trailing spaces	Other	views_oai_pmh_metadata_type_definitions.inc	378	N/A

plugins/includes/views_oai_pmh_xml_node.inc

Message	Group	Filename	Line	Function
There should be no trailing spaces	Other	views_oai_pmh_xml_node.inc	9	N/A
There should be no trailing spaces	Other	views_oai_pmh_xml_node.inc	33	N/A
There should be no trailing spaces	Other	views_oai_pmh_xml_node.inc	36	N/A
There should be no trailing spaces	Other	views_oai_pmh_xml_node.inc	41	N/A
There should be no trailing spaces	Other	views_oai_pmh_xml_node.inc	53	N/A
There should be no trailing spaces	Other	views_oai_pmh_xml_node.inc	68	N/A
There should be no trailing spaces	Other	views_oai_pmh_xml_node.inc	72	N/A
There should be no trailing spaces	Other	views_oai_pmh_xml_node.inc	76	N/A
There should be no trailing spaces	Other	views_oai_pmh_xml_node.inc	84	N/A
There should be no trailing spaces	Other	views_oai_pmh_xml_node.inc	96	N/A
There should be no trailing spaces	Other	views_oai_pmh_xml_node.inc	128	N/A
There should be no trailing spaces	Other	views_oai_pmh_xml_node.inc	132	N/A
There should be no trailing spaces	Other	views_oai_pmh_xml_node.inc	138	N/A
There should be no trailing spaces	Other	views_oai_pmh_xml_node.inc	167	N/A
There should be no trailing spaces	Other	views_oai_pmh_xml_node.inc	232	N/A
There should be no trailing spaces	Other	views_oai_pmh_xml_node.inc	235	N/A

plugins/views_oai_pmh_plugin_display.inc

Message	Group	Filename	Line	Function
There should be no trailing spaces	Other	views_oai_pmh_plugin_display.inc	8	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_display.inc	57	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_display.inc	61	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_display.inc	63	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_display.inc	67	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	views_oai_pmh_plugin_display.inc	216	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	views_oai_pmh_plugin_display.inc	231	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	views_oai_pmh_plugin_display.inc	307	N/A
Use an indent of 2 spaces, with no tabs	Other	views_oai_pmh_plugin_display.inc	388	N/A
Use an indent of 2 spaces, with no tabs	Other	views_oai_pmh_plugin_display.inc	495	N/A

plugins/views_oai_pmh_plugin_row_auto.inc

Message	Group	Filename	Line	Function
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_auto.inc	11	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_auto.inc	14	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_auto.inc	17	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_auto.inc	23	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_auto.inc	26	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_auto.inc	29	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_auto.inc	38	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_auto.inc	43	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_auto.inc	54	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_auto.inc	67	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_auto.inc	93	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_auto.inc	97	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_auto.inc	106	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_auto.inc	117	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_auto.inc	126	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_auto.inc	136	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_auto.inc	145	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_auto.inc	154	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_auto.inc	173	N/A

plugins/views_oai_pmh_plugin_row_dc.inc

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	views_oai_pmh_plugin_row_dc.inc	-1	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	views_oai_pmh_plugin_row_dc.inc	25	N/A
Use an indent of 2 spaces, with no tabs	Other	views_oai_pmh_plugin_row_dc.inc	44	N/A
Use an indent of 2 spaces, with no tabs	Other	views_oai_pmh_plugin_row_dc.inc	45	N/A

plugins/views_oai_pmh_plugin_row_etdms.inc

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	views_oai_pmh_plugin_row_etdms.inc	-1	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	views_oai_pmh_plugin_row_etdms.inc	23	N/A
Use an indent of 2 spaces, with no tabs	Other	views_oai_pmh_plugin_row_etdms.inc	42	N/A
Use an indent of 2 spaces, with no tabs	Other	views_oai_pmh_plugin_row_etdms.inc	43	N/A

plugins/views_oai_pmh_plugin_row_misc.inc

Message	Group	Filename	Line	Function
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_misc.inc	27	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_misc.inc	47	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_misc.inc	54	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_misc.inc	57	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_misc.inc	70	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_misc.inc	73	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_misc.inc	76	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_misc.inc	79	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_misc.inc	90	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	views_oai_pmh_plugin_row_misc.inc	94	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_misc.inc	120	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	views_oai_pmh_plugin_row_misc.inc	134	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_misc.inc	170	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_misc.inc	173	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_misc.inc	184	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_misc.inc	187	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_misc.inc	207	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_misc.inc	220	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_row_misc.inc	224	N/A

plugins/views_oai_pmh_plugin_style.inc

Message	Group	Filename	Line	Function	Status
There should be no trailing spaces	Other	views_oai_pmh_plugin_style.inc	34	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_style.inc	90	N/A

plugins/views_oai_pmh_plugin_style_auto.inc

Message	Group	Filename	Line	Function
There should be no trailing spaces	Other	views_oai_pmh_plugin_style_auto.inc	11	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_style_auto.inc	14	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_style_auto.inc	17	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_style_auto.inc	23	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_style_auto.inc	26	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_style_auto.inc	29	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_style_auto.inc	38	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_style_auto.inc	43	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_style_auto.inc	49	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_style_auto.inc	55	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_style_auto.inc	73	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_style_auto.inc	92	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_style_auto.inc	96	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_style_auto.inc	105	N/A

plugins/views_oai_pmh_plugin_style_dc.inc

plugins/views_oai_pmh_plugin_style_etdms.inc

plugins/views_oai_pmh_plugin_style_misc.inc

Message	Group	Filename	Line	Function
There should be no trailing spaces	Other	views_oai_pmh_plugin_style_misc.inc	13	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_style_misc.inc	21	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_style_misc.inc	42	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_style_misc.inc	47	N/A
There should be no trailing spaces	Other	views_oai_pmh_plugin_style_misc.inc	52	N/A

theme/views-oai-pmh-response.tpl.php

Message	Group	Filename	Line	Function	Status
@file block missing (Drupal Docs)	Other	views-oai-pmh-response.tpl.php	-1	N/A
use lowercase html tags to comply with XHTML	Other	views-oai-pmh-response.tpl.php	2	N/A

theme/views_oai_pmh.theme.inc

Message	Group	Filename	Line	Function
There should be no trailing spaces	Other	views_oai_pmh.theme.inc	16	N/A
There should be no trailing spaces	Other	views_oai_pmh.theme.inc	19	N/A
There should be no trailing spaces	Other	views_oai_pmh.theme.inc	24	N/A
There should be no trailing spaces	Other	views_oai_pmh.theme.inc	29	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	views_oai_pmh.theme.inc	35	N/A
There should be no trailing spaces	Other	views_oai_pmh.theme.inc	49	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	views_oai_pmh.theme.inc	55	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	views_oai_pmh.theme.inc	61	N/A
There should be no trailing spaces	Other	views_oai_pmh.theme.inc	64	N/A
There should be no trailing spaces	Other	views_oai_pmh.theme.inc	69	N/A
There should be no trailing spaces	Other	views_oai_pmh.theme.inc	74	N/A
There should be no trailing spaces	Other	views_oai_pmh.theme.inc	79	N/A
There should be no trailing spaces	Other	views_oai_pmh.theme.inc	82	N/A
There should be no trailing spaces	Other	views_oai_pmh.theme.inc	103	N/A
There should be no trailing spaces	Other	views_oai_pmh.theme.inc	110	N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)	Other	views_oai_pmh.theme.inc	176	N/A
There should be no trailing spaces	Other	views_oai_pmh.theme.inc	225	N/A

views_oai_pmh.install

Message	Group	Filename	Line	Function	Status
@file block missing (Drupal Docs)	Other	views_oai_pmh.install	-1	N/A
Missing period	Other	views_oai_pmh.install	12	N/A

views_oai_pmh.module

views_oai_pmh.views.inc

Message	Group	Filename	Line	Function
There should be no trailing spaces	Other	views_oai_pmh.views.inc	39	N/A
There should be no trailing spaces	Other	views_oai_pmh.views.inc	47	N/A
There should be no trailing spaces	Other	views_oai_pmh.views.inc	69	N/A
indent secondary line of comment one space	Other	views_oai_pmh.views.inc	126	N/A

views_oai_pmh.views_default.inc

Message	Group	Filename	Line	Function	Status
@file block missing (Drupal Docs)	Other	views_oai_pmh.views_default.inc	-1	N/A

Review log