Bakery Single Sign-On System - 6.x-2.x

Test status
StatusResult
Last receivedFri, 01/25/2013 - 20:45:16
Last requestedFri, 01/25/2013 - 20:46:03
Last testedFri, 01/25/2013 - 20:46:20
Test count2
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier6.x-2.x
ProjectBakery Single Sign-On System
LinkProject information
SummaryPASSED: [[Coder]]: [Code review] 4 minor(s), 3 critical(s), and 17 normal(s); [[SimpleTest]]: [MySQL] 0 pass(es).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
4 minor(s), 3 critical(s), and 17 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandbakery.install003
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherbakery.install-1N/A
Use update_sql() instead of db_query() in hook_update_N()Otherbakery.install47N/A
Use update_sql() instead of db_query() in hook_update_N()Otherbakery.install60N/A
Expandbakery.module4314
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherbakery.module-1N/A
Use "elseif" in place of "else if"Otherbakery.module107N/A
Use "elseif" in place of "else if"Otherbakery.module120N/A
Use "elseif" in place of "else if"Otherbakery.module133N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otherbakery.module154N/A
Use "elseif" in place of "else if"Otherbakery.module173N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherbakery.module180N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otherbakery.module208N/A
Control statements should have one space between the control keyword and opening parenthesisOtherbakery.module216N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otherbakery.module377N/A
Use ANSI standard <> instead of !=Otherbakery.module900N/A
Use ANSI standard <> instead of !=Otherbakery.module903N/A
Use ANSI standard <> instead of !=Otherbakery.module906N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)Otherbakery.module1196N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)Otherbakery.module1323N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherbakery.module1428N/A
Use ANSI standard <> instead of !=Otherbakery.module1562N/A
Use ANSI standard <> instead of !=Otherbakery.module1563N/A
Use "elseif" in place of "else if"Otherbakery.module1597N/A
Use "elseif" in place of "else if"Otherbakery.module1602N/A
Use "elseif" in place of "else if"Otherbakery.module1609N/A

All

Test nameMinorCriticalNormal
Leafbakery.drush.inc000
Expandbakery.install003
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherbakery.install-1N/A
Use update_sql() instead of db_query() in hook_update_N()Otherbakery.install47N/A
Use update_sql() instead of db_query() in hook_update_N()Otherbakery.install60N/A
Expandbakery.module4314
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherbakery.module-1N/A
Use "elseif" in place of "else if"Otherbakery.module107N/A
Use "elseif" in place of "else if"Otherbakery.module120N/A
Use "elseif" in place of "else if"Otherbakery.module133N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otherbakery.module154N/A
Use "elseif" in place of "else if"Otherbakery.module173N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherbakery.module180N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otherbakery.module208N/A
Control statements should have one space between the control keyword and opening parenthesisOtherbakery.module216N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otherbakery.module377N/A
Use ANSI standard <> instead of !=Otherbakery.module900N/A
Use ANSI standard <> instead of !=Otherbakery.module903N/A
Use ANSI standard <> instead of !=Otherbakery.module906N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)Otherbakery.module1196N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)Otherbakery.module1323N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherbakery.module1428N/A
Use ANSI standard <> instead of !=Otherbakery.module1562N/A
Use ANSI standard <> instead of !=Otherbakery.module1563N/A
Use "elseif" in place of "else if"Otherbakery.module1597N/A
Use "elseif" in place of "else if"Otherbakery.module1602N/A
Use "elseif" in place of "else if"Otherbakery.module1609N/A