Views OAI-PMH - 7.x-1.x

Test status
StatusResult
Last receivedFri, 01/25/2013 - 01:55:11
Last requestedFri, 01/25/2013 - 02:40:55
Last testedFri, 01/25/2013 - 02:41:11
Test count2
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier7.x-1.x
ProjectViews OAI-PMH
LinkProject information
SummaryPASSED: [[SimpleTest]]: [MySQL] 0 pass(es); [[Coder]]: [Code review] 13 minor(s), 2 critical(s), and 22 normal(s).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
13 minor(s), 2 critical(s), and 22 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandplugins/views_oai_pmh_plugin_display.inc512
MessageGroupFilenameLineFunctionStatus
Control statements should have one space between the control keyword and opening parenthesisOtherviews_oai_pmh_plugin_display.inc68N/A
missing space after commaOtherviews_oai_pmh_plugin_display.inc195N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherviews_oai_pmh_plugin_display.inc228N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherviews_oai_pmh_plugin_display.inc243N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Otherviews_oai_pmh_plugin_display.inc269N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherviews_oai_pmh_plugin_display.inc319N/A
Use an indent of 2 spaces, with no tabsOtherviews_oai_pmh_plugin_display.inc400N/A
Use an indent of 2 spaces, with no tabsOtherviews_oai_pmh_plugin_display.inc500N/A
Expandplugins/views_oai_pmh_plugin_row_dc.inc103
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherviews_oai_pmh_plugin_row_dc.inc-1N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherviews_oai_pmh_plugin_row_dc.inc23N/A
Use an indent of 2 spaces, with no tabsOtherviews_oai_pmh_plugin_row_dc.inc43N/A
Use an indent of 2 spaces, with no tabsOtherviews_oai_pmh_plugin_row_dc.inc44N/A
Expandplugins/views_oai_pmh_plugin_row_etdms.inc103
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherviews_oai_pmh_plugin_row_etdms.inc-1N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherviews_oai_pmh_plugin_row_etdms.inc23N/A
Use an indent of 2 spaces, with no tabsOtherviews_oai_pmh_plugin_row_etdms.inc42N/A
Use an indent of 2 spaces, with no tabsOtherviews_oai_pmh_plugin_row_etdms.inc43N/A
Expandplugins/views_oai_pmh_plugin_style.inc002
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherviews_oai_pmh_plugin_style.inc-1N/A
Control statements should have one space between the control keyword and opening parenthesisOtherviews_oai_pmh_plugin_style.inc41N/A
Expandtheme/views-oai-pmh-response.tpl.php101
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherviews-oai-pmh-response.tpl.php-1N/A
use lowercase html tags to comply with XHTMLOtherviews-oai-pmh-response.tpl.php2N/A
Expandtheme/views_oai_pmh.theme.inc115
MessageGroupFilenameLineFunctionStatus
Use an indent of 2 spaces, with no tabsOtherviews_oai_pmh.theme.inc40N/A
Use an indent of 2 spaces, with no tabsOtherviews_oai_pmh.theme.inc49N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Otherviews_oai_pmh.theme.inc67N/A
Use an indent of 2 spaces, with no tabsOtherviews_oai_pmh.theme.inc70N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherviews_oai_pmh.theme.inc85N/A
Use an indent of 2 spaces, with no tabsOtherviews_oai_pmh.theme.inc86N/A
curly braces { should end a line, not start oneOtherviews_oai_pmh.theme.inc174N/A
Expandviews_oai_pmh.install101
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherviews_oai_pmh.install-1N/A
Missing periodOtherviews_oai_pmh.install4N/A
Expandviews_oai_pmh.module002
MessageGroupFilenameLineFunctionStatus
Use an indent of 2 spaces, with no tabsOtherviews_oai_pmh.module24N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherviews_oai_pmh.module24N/A
Expandviews_oai_pmh.views.inc302
MessageGroupFilenameLineFunctionStatus
Functions should be called with no spaces between the function name and opening parenthesesOtherviews_oai_pmh.views.inc26N/A
Use an indent of 2 spaces, with no tabsOtherviews_oai_pmh.views.inc52N/A
Use an indent of 2 spaces, with no tabsOtherviews_oai_pmh.views.inc56N/A
indent secondary line of comment one space Otherviews_oai_pmh.views.inc80N/A
indent secondary line of comment one space Otherviews_oai_pmh.views.inc111N/A
Expandviews_oai_pmh.views_default.inc001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherviews_oai_pmh.views_default.inc-1N/A

All

Test nameMinorCriticalNormal
Expandplugins/views_oai_pmh_plugin_display.inc512
MessageGroupFilenameLineFunctionStatus
Control statements should have one space between the control keyword and opening parenthesisOtherviews_oai_pmh_plugin_display.inc68N/A
missing space after commaOtherviews_oai_pmh_plugin_display.inc195N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherviews_oai_pmh_plugin_display.inc228N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherviews_oai_pmh_plugin_display.inc243N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Otherviews_oai_pmh_plugin_display.inc269N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherviews_oai_pmh_plugin_display.inc319N/A
Use an indent of 2 spaces, with no tabsOtherviews_oai_pmh_plugin_display.inc400N/A
Use an indent of 2 spaces, with no tabsOtherviews_oai_pmh_plugin_display.inc500N/A
Expandplugins/views_oai_pmh_plugin_row_dc.inc103
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherviews_oai_pmh_plugin_row_dc.inc-1N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherviews_oai_pmh_plugin_row_dc.inc23N/A
Use an indent of 2 spaces, with no tabsOtherviews_oai_pmh_plugin_row_dc.inc43N/A
Use an indent of 2 spaces, with no tabsOtherviews_oai_pmh_plugin_row_dc.inc44N/A
Expandplugins/views_oai_pmh_plugin_row_etdms.inc103
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherviews_oai_pmh_plugin_row_etdms.inc-1N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherviews_oai_pmh_plugin_row_etdms.inc23N/A
Use an indent of 2 spaces, with no tabsOtherviews_oai_pmh_plugin_row_etdms.inc42N/A
Use an indent of 2 spaces, with no tabsOtherviews_oai_pmh_plugin_row_etdms.inc43N/A
Expandplugins/views_oai_pmh_plugin_style.inc002
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherviews_oai_pmh_plugin_style.inc-1N/A
Control statements should have one space between the control keyword and opening parenthesisOtherviews_oai_pmh_plugin_style.inc41N/A
Leafplugins/views_oai_pmh_plugin_style_dc.inc000
Leafplugins/views_oai_pmh_plugin_style_etdms.inc000
Expandtheme/views-oai-pmh-response.tpl.php101
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherviews-oai-pmh-response.tpl.php-1N/A
use lowercase html tags to comply with XHTMLOtherviews-oai-pmh-response.tpl.php2N/A
Expandtheme/views_oai_pmh.theme.inc115
MessageGroupFilenameLineFunctionStatus
Use an indent of 2 spaces, with no tabsOtherviews_oai_pmh.theme.inc40N/A
Use an indent of 2 spaces, with no tabsOtherviews_oai_pmh.theme.inc49N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Otherviews_oai_pmh.theme.inc67N/A
Use an indent of 2 spaces, with no tabsOtherviews_oai_pmh.theme.inc70N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherviews_oai_pmh.theme.inc85N/A
Use an indent of 2 spaces, with no tabsOtherviews_oai_pmh.theme.inc86N/A
curly braces { should end a line, not start oneOtherviews_oai_pmh.theme.inc174N/A
Expandviews_oai_pmh.install101
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherviews_oai_pmh.install-1N/A
Missing periodOtherviews_oai_pmh.install4N/A
Expandviews_oai_pmh.module002
MessageGroupFilenameLineFunctionStatus
Use an indent of 2 spaces, with no tabsOtherviews_oai_pmh.module24N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherviews_oai_pmh.module24N/A
Expandviews_oai_pmh.views.inc302
MessageGroupFilenameLineFunctionStatus
Functions should be called with no spaces between the function name and opening parenthesesOtherviews_oai_pmh.views.inc26N/A
Use an indent of 2 spaces, with no tabsOtherviews_oai_pmh.views.inc52N/A
Use an indent of 2 spaces, with no tabsOtherviews_oai_pmh.views.inc56N/A
indent secondary line of comment one space Otherviews_oai_pmh.views.inc80N/A
indent secondary line of comment one space Otherviews_oai_pmh.views.inc111N/A
Expandviews_oai_pmh.views_default.inc001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherviews_oai_pmh.views_default.inc-1N/A