Contact Forms - 7.x-1.6 | Drupal Quality Assurance

Latest changes

So Long and Thanks for all the Tests

1 week 1 day ago

Support

In case of troubles

check the FAQ. Please make sure you've tried the test locally.
search known testbot issues and then create a new issue if yours isn't there already. Please give a link to the test.

Test client logs

No clients to display.

Contact Forms - 7.x-1.6

Test status

Status	Result
Last received	Fri, 01/18/2013 - 14:20:30
Last requested	Fri, 01/18/2013 - 14:21:54
Last tested	Fri, 01/18/2013 - 14:22:05
Test count	2

Environment status

MySQL	pass
Code review	fail

Overall Result	pass

Branch information

Identifier	7.x-1.6
Project	Contact Forms
Link	Project information

Event logView entire log

ID	Message	Timestamp
5238538	Result retrieved by project client.	3 years 5 weeks ago
5238533	Result retrieved by project client.	3 years 5 weeks ago
5238528	Result received from test client #664.	3 years 5 weeks ago
5238523	Requested by test client #664.	3 years 5 weeks ago
5238518	Result received from test client #664.	3 years 5 weeks ago
5238513	Requested by test client #664.	3 years 5 weeks ago
5238503	Test request received.	3 years 5 weeks ago

SummaryPASSED: [[SimpleTest]]: [MySQL] 0 pass(es); [[Coder]]: [Code review] 19 minor(s), 3 critical(s), and 31 normal(s).

Details

MySQL
Code review

MySQL

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a Drupal installation failure
Detect a test run failure
Detect a failing test
Complete test suite with all tests passing

Review log

Code review

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a review run failure
Detect coder flags
Ensure that your code follows the Drupal standard and passes a coder review.
Complete coder review with all passed

19 minor(s), 3 critical(s), and 31 normal(s)

Non-pass

Test name Minor Critical Normal

contact_forms.install 0 1 6

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	contact_forms.install	-1	N/A
Commits to the Git repository do not require the CVS $Id$ keyword in each file. (Drupal Docs)	Other	contact_forms.install	2	N/A
Functions should be called with no spaces between the function name and opening parentheses	Other	contact_forms.install	15	N/A
Use st() instead of t() in hook_install(), hook_uninstall() and hook_update_N()	Other	contact_forms.install	16	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	contact_forms.install	16	N/A
The $text argument to l() should be enclosed within st() so that it is translatable from within the install.	Other	contact_forms.install	17	N/A
Functions should be called with no spaces between the function name and opening parentheses	Other	contact_forms.install	41	N/A

contact_forms.module 10 1 10

Message	Group	Filename	Line	Function
Commits to the Git repository do not require the CVS $Id$ keyword in each file. (Drupal Docs)	Other	contact_forms.module	2	N/A
put a space between the asterisk and the comment text	Other	contact_forms.module	19	N/A
Missing parenthesis after function name	Other	contact_forms.module	26	N/A
Missing parenthesis after function name	Other	contact_forms.module	64	N/A
use a space between the closing parenthesis and the open bracket	Other	contact_forms.module	66	N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE	Other	contact_forms.module	77	N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE	Other	contact_forms.module	87	N/A
Use an indent of 2 spaces, with no tabs	Other	contact_forms.module	96	N/A
Missing period	Other	contact_forms.module	103	N/A
missing space after comma	Other	contact_forms.module	119	N/A
Potential problem: drupal_set_title() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	contact_forms.module	136	N/A
Use an indent of 2 spaces, with no tabs	Other	contact_forms.module	149	N/A
missing space after comma	Other	contact_forms.module	151	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	contact_forms.module	175	N/A
use a space between the closing parenthesis and the open bracket	Other	contact_forms.module	175	N/A
Missing parenthesis after function name	Other	contact_forms.module	214	N/A
Use an indent of 2 spaces, with no tabs	Other	contact_forms.module	216	N/A
l() already contains a check_plain() call by default	Other	contact_forms.module	261	N/A
Missing parenthesis after function name	Other	contact_forms.module	284	N/A
Use an indent of 2 spaces, with no tabs	Other	contact_forms.module	290	N/A
Use an indent of 2 spaces, with no tabs	Other	contact_forms.module	297	N/A

contact_forms_int/contact_forms_int.install 9 0 10

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	contact_forms_int.install	-1	N/A
indent secondary line of comment one space	Other	contact_forms_int.install	5	N/A
Format should be `* Implementation of hook_foo().`	Other	contact_forms_int.install	5	N/A
indent secondary line of comment one space	Other	contact_forms_int.install	6	N/A
indent secondary line of comment one space	Other	contact_forms_int.install	7	N/A
indent secondary line of comment one space	Other	contact_forms_int.install	8	N/A
indent secondary line of comment one space	Other	contact_forms_int.install	9	N/A
indent secondary line of comment one space	Other	contact_forms_int.install	10	N/A
use a space between the closing parenthesis and the open bracket	Other	contact_forms_int.install	35	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	contact_forms_int.install	51	N/A
use a space between the closing parenthesis and the open bracket	Other	contact_forms_int.install	51	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	contact_forms_int.install	55	N/A
use a space between the closing parenthesis and the open bracket	Other	contact_forms_int.install	55	N/A
Missing period	Other	contact_forms_int.install	67	N/A
There should be no trailing spaces	Other	contact_forms_int.install	72	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	contact_forms_int.install	77	N/A
use a space between the closing parenthesis and the open bracket	Other	contact_forms_int.install	77	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	contact_forms_int.install	85	N/A
use a space between the closing parenthesis and the open bracket	Other	contact_forms_int.install	85	N/A

contact_forms_int/contact_forms_int.module 0 1 5

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	contact_forms_int.module	-1	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	contact_forms_int.module	28	N/A
use a space between the closing parenthesis and the open bracket	Other	contact_forms_int.module	28	N/A
Potential problem: drupal_set_title() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)	Other	contact_forms_int.module	29	N/A
The $string argument to t() should not begin or end with a space. (Drupal Docs)	Other	contact_forms_int.module	53	N/A
The $string argument to t() should not begin or end with a space. (Drupal Docs)	Other	contact_forms_int.module	63	N/A

All