Drupal Sync - 7.x-1.x

Test status
StatusResult
Last receivedTue, 01/15/2013 - 15:27:10
Last requestedTue, 01/15/2013 - 15:28:05
Last testedTue, 01/15/2013 - 15:28:36
Test count2
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier7.x-1.x
ProjectDrupal Sync
LinkProject information
SummaryPASSED: [[Coder]]: [Code review] 22 minor(s), 1 critical(s), and 10 normal(s); [[SimpleTest]]: [MySQL] 0 pass(es).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
22 minor(s), 1 critical(s), and 10 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expanddrupal_sync.module612
MessageGroupFilenameLineFunctionStatus
put a space between the asterisk and the comment textOtherdrupal_sync.module88N/A
put a space between the asterisk and the comment textOtherdrupal_sync.module123N/A
Format should be * Implementation of hook_foo().Otherdrupal_sync.module126N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherdrupal_sync.module143N/A
put a space between the asterisk and the comment textOtherdrupal_sync.module165N/A
use <br /> instead of <br>Otherdrupal_sync.module257N/A
use <br /> instead of <br>Otherdrupal_sync.module277N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherdrupal_sync.module277N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherdrupal_sync.module278N/A
Expandmodules/drupal_sync_manager/drupal_sync_manager.module508
MessageGroupFilenameLineFunctionStatus
The $text argument to l() should be enclosed within t() so that it is translatable.Otherdrupal_sync_manager.module109N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherdrupal_sync_manager.module110N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherdrupal_sync_manager.module111N/A
use <br /> instead of <br>Otherdrupal_sync_manager.module128N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherdrupal_sync_manager.module128N/A
use <br /> instead of <br>Otherdrupal_sync_manager.module130N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherdrupal_sync_manager.module130N/A
Use an indent of 2 spaces, with no tabsOtherdrupal_sync_manager.module190N/A
use <br /> instead of <br>Otherdrupal_sync_manager.module223N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherdrupal_sync_manager.module223N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherdrupal_sync_manager.module269N/A
use <br /> instead of <br>Otherdrupal_sync_manager.module286N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherdrupal_sync_manager.module286N/A

All

Test nameMinorCriticalNormal
Expanddrupal_sync.admin.inc300
MessageGroupFilenameLineFunctionStatus
put a space between the asterisk and the comment textOtherdrupal_sync.admin.inc168N/A
put a space between the asterisk and the comment textOtherdrupal_sync.admin.inc254N/A
put a space between the asterisk and the comment textOtherdrupal_sync.admin.inc260N/A
Leafdrupal_sync.api.php000
Leafdrupal_sync.install000
Expanddrupal_sync.module612
MessageGroupFilenameLineFunctionStatus
put a space between the asterisk and the comment textOtherdrupal_sync.module88N/A
put a space between the asterisk and the comment textOtherdrupal_sync.module123N/A
Format should be * Implementation of hook_foo().Otherdrupal_sync.module126N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherdrupal_sync.module143N/A
put a space between the asterisk and the comment textOtherdrupal_sync.module165N/A
use <br /> instead of <br>Otherdrupal_sync.module257N/A
use <br /> instead of <br>Otherdrupal_sync.module277N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherdrupal_sync.module277N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherdrupal_sync.module278N/A
Leafincludes/drupal_sync.api.inc000
Expandincludes/drupal_sync.entity.inc300
MessageGroupFilenameLineFunctionStatus
Use an indent of 2 spaces, with no tabsOtherdrupal_sync.entity.inc35N/A
Use an indent of 2 spaces, with no tabsOtherdrupal_sync.entity.inc37N/A
Use an indent of 2 spaces, with no tabsOtherdrupal_sync.entity.inc121N/A
Leafincludes/drupal_sync.forms.inc000
Leafincludes/drupal_sync.queue.inc000
Expandincludes/drupal_sync.xmlrpc.inc100
MessageGroupFilenameLineFunctionStatus
Format should be * Implementation of hook_foo().Otherdrupal_sync.xmlrpc.inc383N/A
Leafmodules/drupal_sync_additional_taxonomy_rules/drupal_sync_additional_taxonomy_rules.admin.inc000
Leafmodules/drupal_sync_additional_taxonomy_rules/drupal_sync_additional_taxonomy_rules.install000
Leafmodules/drupal_sync_additional_taxonomy_rules/drupal_sync_additional_taxonomy_rules.module000
Leafmodules/drupal_sync_initial_setup/drupal_sync_initial_setup.admin.inc000
Leafmodules/drupal_sync_initial_setup/drupal_sync_initial_setup.install000
Expandmodules/drupal_sync_initial_setup/drupal_sync_initial_setup.module100
MessageGroupFilenameLineFunctionStatus
use <br /> instead of <br>Otherdrupal_sync_initial_setup.module116N/A
Expandmodules/drupal_sync_manager/drupal_sync_manager.module508
MessageGroupFilenameLineFunctionStatus
The $text argument to l() should be enclosed within t() so that it is translatable.Otherdrupal_sync_manager.module109N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherdrupal_sync_manager.module110N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherdrupal_sync_manager.module111N/A
use <br /> instead of <br>Otherdrupal_sync_manager.module128N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherdrupal_sync_manager.module128N/A
use <br /> instead of <br>Otherdrupal_sync_manager.module130N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherdrupal_sync_manager.module130N/A
Use an indent of 2 spaces, with no tabsOtherdrupal_sync_manager.module190N/A
use <br /> instead of <br>Otherdrupal_sync_manager.module223N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherdrupal_sync_manager.module223N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherdrupal_sync_manager.module269N/A
use <br /> instead of <br>Otherdrupal_sync_manager.module286N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherdrupal_sync_manager.module286N/A
Expandmodules/drupal_sync_menu/drupal_sync_menu.module300
MessageGroupFilenameLineFunctionStatus
put a space between the asterisk and the comment textOtherdrupal_sync_menu.module32N/A
Format should be * Implementation of hook_foo().Otherdrupal_sync_menu.module210N/A
put a space between the asterisk and the comment textOtherdrupal_sync_menu.module332N/A