Rabbit Hole - 7.x-2.x

Test status
StatusResult
Last receivedTue, 01/15/2013 - 12:10:34
Last requestedTue, 01/15/2013 - 12:11:05
Last testedTue, 01/15/2013 - 12:11:34
Test count2
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier7.x-2.x
ProjectRabbit Hole
LinkProject information
SummaryPASSED: [[Coder]]: [Code review] 33 minor(s), 2 critical(s), and 1 normal(s); [[SimpleTest]]: [MySQL] 0 pass(es).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
33 minor(s), 2 critical(s), and 1 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandmodules/rh_taxonomy/rh_taxonomy.install001
MessageGroupFilenameLineFunctionStatus
Use update_sql() instead of db_query() in hook_update_N()Otherrh_taxonomy.install13N/A
Expandrabbit_hole.module2520
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherrabbit_hole.module25N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherrabbit_hole.module31N/A
There should be no trailing spacesOtherrabbit_hole.module32N/A
There should be no trailing spacesOtherrabbit_hole.module37N/A
There should be no trailing spacesOtherrabbit_hole.module43N/A
There should be no trailing spacesOtherrabbit_hole.module97N/A
There should be no trailing spacesOtherrabbit_hole.module103N/A
There should be no trailing spacesOtherrabbit_hole.module136N/A
There should be no trailing spacesOtherrabbit_hole.module139N/A
There should be no trailing spacesOtherrabbit_hole.module148N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherrabbit_hole.module159N/A
There should be no trailing spacesOtherrabbit_hole.module172N/A
There should be no trailing spacesOtherrabbit_hole.module190N/A
There should be no trailing spacesOtherrabbit_hole.module260N/A
There should be no trailing spacesOtherrabbit_hole.module274N/A
There should be no trailing spacesOtherrabbit_hole.module280N/A
There should be no trailing spacesOtherrabbit_hole.module284N/A
There should be no trailing spacesOtherrabbit_hole.module291N/A
There should be no trailing spacesOtherrabbit_hole.module314N/A
Using eval() or drupal_eval() in your module's code could have a security risk if the PHP input provided to the function contains malicious code. (Drupal Docs)Otherrabbit_hole.module355N/A
There should be no trailing spacesOtherrabbit_hole.module529N/A
@see references should be separated by "," followed by a single space and with no trailing punctuationOtherrabbit_hole.module536N/A
There should be no trailing spacesOtherrabbit_hole.module546N/A
There should be no trailing spacesOtherrabbit_hole.module569N/A
There should be no trailing spacesOtherrabbit_hole.module596N/A
There should be no trailing spacesOtherrabbit_hole.module603N/A
There should be no trailing spacesOtherrabbit_hole.module637N/A

All

Test nameMinorCriticalNormal
Expandmodules/rh_node/rh_node.module200
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherrh_node.module34N/A
@see references should be separated by "," followed by a single space and with no trailing punctuationOtherrh_node.module71N/A
Expandmodules/rh_taxonomy/rh_taxonomy.install001
MessageGroupFilenameLineFunctionStatus
Use update_sql() instead of db_query() in hook_update_N()Otherrh_taxonomy.install13N/A
Expandmodules/rh_taxonomy/rh_taxonomy.module100
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherrh_taxonomy.module56N/A
Expandmodules/rh_user/rh_user.module100
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherrh_user.module56N/A
Expandrabbit_hole.install400
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherrabbit_hole.install44N/A
There should be no trailing spacesOtherrabbit_hole.install65N/A
There should be no trailing spacesOtherrabbit_hole.install74N/A
There should be no trailing spacesOtherrabbit_hole.install95N/A
Expandrabbit_hole.module2520
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherrabbit_hole.module25N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherrabbit_hole.module31N/A
There should be no trailing spacesOtherrabbit_hole.module32N/A
There should be no trailing spacesOtherrabbit_hole.module37N/A
There should be no trailing spacesOtherrabbit_hole.module43N/A
There should be no trailing spacesOtherrabbit_hole.module97N/A
There should be no trailing spacesOtherrabbit_hole.module103N/A
There should be no trailing spacesOtherrabbit_hole.module136N/A
There should be no trailing spacesOtherrabbit_hole.module139N/A
There should be no trailing spacesOtherrabbit_hole.module148N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherrabbit_hole.module159N/A
There should be no trailing spacesOtherrabbit_hole.module172N/A
There should be no trailing spacesOtherrabbit_hole.module190N/A
There should be no trailing spacesOtherrabbit_hole.module260N/A
There should be no trailing spacesOtherrabbit_hole.module274N/A
There should be no trailing spacesOtherrabbit_hole.module280N/A
There should be no trailing spacesOtherrabbit_hole.module284N/A
There should be no trailing spacesOtherrabbit_hole.module291N/A
There should be no trailing spacesOtherrabbit_hole.module314N/A
Using eval() or drupal_eval() in your module's code could have a security risk if the PHP input provided to the function contains malicious code. (Drupal Docs)Otherrabbit_hole.module355N/A
There should be no trailing spacesOtherrabbit_hole.module529N/A
@see references should be separated by "," followed by a single space and with no trailing punctuationOtherrabbit_hole.module536N/A
There should be no trailing spacesOtherrabbit_hole.module546N/A
There should be no trailing spacesOtherrabbit_hole.module569N/A
There should be no trailing spacesOtherrabbit_hole.module596N/A
There should be no trailing spacesOtherrabbit_hole.module603N/A
There should be no trailing spacesOtherrabbit_hole.module637N/A