Site Disclaimer - 6.x-1.0

Test status
StatusResult
Last receivedSun, 01/13/2013 - 17:24:10
Last requestedSun, 01/13/2013 - 17:31:08
Last testedSun, 01/13/2013 - 17:31:17
Test count2
Environment status
MySQLfail
Code reviewfail
Overall Resultfail
Branch information
Identifier6.x-1.0
ProjectSite Disclaimer
LinkProject information
SummaryFAILED: [[SimpleTest]]: [MySQL] 120 pass(es), 1 fail(s), and 59 exception(s); [[Coder]]: [Code review] 20 minor(s), 0 critical(s), and 10 normal(s).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
    Review the test failures below then if necessary run them locally until the problem has been fixed.
  10. Complete test suite with all tests passing
120 pass(es), 1 fail(s), and 59 exception(s)

Non-pass

Test namePassFailException
ExpandSite Disclaimer Basic (SiteDisclaimerSettingsTestCase) [Site Disclaimer]120159
MessageGroupFilenameLineFunctionStatus
Constant SITE_DISCLAIMER_SETTINGS_PATH already definedNoticesite_disclaimer.module15include_once()
Undefined index: Noticesite_disclaimer.admin.inc717_site_disclaimer_prep_allowed_paths()
Undefined offset: 0Noticeform.inc839form_get_error()
Undefined index: #nameNoticeform.inc1893theme_checkbox()
Undefined index: #idNoticeform.inc1894theme_checkbox()
Undefined index: #valueNoticeform.inc1896theme_checkbox()
Undefined index: #idNoticeform.inc1900theme_checkbox()
Undefined offset: 0Noticeform.inc839form_get_error()
Undefined index: #nameNoticeform.inc1893theme_checkbox()
Undefined index: #idNoticeform.inc1894theme_checkbox()
Undefined index: #valueNoticeform.inc1896theme_checkbox()
Undefined index: #idNoticeform.inc1900theme_checkbox()
Undefined index: #idNoticeform.inc1979theme_button()
Undefined offset: 0Noticeform.inc839form_get_error()
Undefined index: #nameNoticeform.inc1893theme_checkbox()
Undefined index: #idNoticeform.inc1894theme_checkbox()
Undefined index: #valueNoticeform.inc1896theme_checkbox()
Undefined index: #idNoticeform.inc1900theme_checkbox()
Undefined offset: 0Noticeform.inc839form_get_error()
Undefined index: #nameNoticeform.inc1893theme_checkbox()
Undefined index: #idNoticeform.inc1894theme_checkbox()
Undefined index: #valueNoticeform.inc1896theme_checkbox()
Undefined index: #idNoticeform.inc1900theme_checkbox()
Undefined index: #idNoticeform.inc1979theme_button()
Undefined index: Noticesite_disclaimer.admin.inc717_site_disclaimer_prep_allowed_paths()
Undefined offset: 0Noticeform.inc839form_get_error()
Undefined index: #nameNoticeform.inc1893theme_checkbox()
Undefined index: #idNoticeform.inc1894theme_checkbox()
Undefined index: #valueNoticeform.inc1896theme_checkbox()
Undefined index: #idNoticeform.inc1900theme_checkbox()
Undefined offset: 0Noticeform.inc839form_get_error()
Undefined index: #nameNoticeform.inc1893theme_checkbox()
Undefined index: #idNoticeform.inc1894theme_checkbox()
Undefined index: #valueNoticeform.inc1896theme_checkbox()
Undefined index: #idNoticeform.inc1900theme_checkbox()
Undefined index: #idNoticeform.inc1979theme_button()
Undefined offset: 0Noticeform.inc839form_get_error()
Undefined index: #nameNoticeform.inc1893theme_checkbox()
Undefined index: #idNoticeform.inc1894theme_checkbox()
Undefined index: #valueNoticeform.inc1896theme_checkbox()
Undefined index: #idNoticeform.inc1900theme_checkbox()
Undefined offset: 0Noticeform.inc839form_get_error()
Undefined index: #nameNoticeform.inc1893theme_checkbox()
Undefined index: #idNoticeform.inc1894theme_checkbox()
Undefined index: #valueNoticeform.inc1896theme_checkbox()
Undefined index: #idNoticeform.inc1900theme_checkbox()
Undefined index: #idNoticeform.inc1979theme_button()
Undefined index: Noticesite_disclaimer.admin.inc717_site_disclaimer_prep_allowed_paths()
Undefined offset: 0Noticeform.inc839form_get_error()
Undefined index: #nameNoticeform.inc1893theme_checkbox()
Undefined index: #idNoticeform.inc1894theme_checkbox()
Undefined index: #valueNoticeform.inc1896theme_checkbox()
Undefined index: #idNoticeform.inc1900theme_checkbox()
Undefined offset: 0Noticeform.inc839form_get_error()
Undefined index: #nameNoticeform.inc1893theme_checkbox()
Undefined index: #idNoticeform.inc1894theme_checkbox()
Undefined index: #valueNoticeform.inc1896theme_checkbox()
Undefined index: #idNoticeform.inc1900theme_checkbox()
Undefined index: #idNoticeform.inc1979theme_button()
'site_disclaimer_allow_nodes=Array ( [0] => 2 ) 'Debugsite_disclaimer.test161SiteDisclaimerSettingsTestCase->testSiteDisclaimerBasic()
node linked from Site Disclaimer node foundOthersite_disclaimer.test182SiteDisclaimerSettingsTestCase->testSiteDisclaimerBasic()

All

Test namePassFailException
ExpandSite Disclaimer Basic (SiteDisclaimerSettingsTestCase) [Site Disclaimer]120159
MessageGroupFilenameLineFunctionStatus
Constant SITE_DISCLAIMER_SETTINGS_PATH already definedNoticesite_disclaimer.module15include_once()
Undefined index: Noticesite_disclaimer.admin.inc717_site_disclaimer_prep_allowed_paths()
Undefined offset: 0Noticeform.inc839form_get_error()
Undefined index: #nameNoticeform.inc1893theme_checkbox()
Undefined index: #idNoticeform.inc1894theme_checkbox()
Undefined index: #valueNoticeform.inc1896theme_checkbox()
Undefined index: #idNoticeform.inc1900theme_checkbox()
Undefined offset: 0Noticeform.inc839form_get_error()
Undefined index: #nameNoticeform.inc1893theme_checkbox()
Undefined index: #idNoticeform.inc1894theme_checkbox()
Undefined index: #valueNoticeform.inc1896theme_checkbox()
Undefined index: #idNoticeform.inc1900theme_checkbox()
Undefined index: #idNoticeform.inc1979theme_button()
Undefined offset: 0Noticeform.inc839form_get_error()
Undefined index: #nameNoticeform.inc1893theme_checkbox()
Undefined index: #idNoticeform.inc1894theme_checkbox()
Undefined index: #valueNoticeform.inc1896theme_checkbox()
Undefined index: #idNoticeform.inc1900theme_checkbox()
Undefined offset: 0Noticeform.inc839form_get_error()
Undefined index: #nameNoticeform.inc1893theme_checkbox()
Undefined index: #idNoticeform.inc1894theme_checkbox()
Undefined index: #valueNoticeform.inc1896theme_checkbox()
Undefined index: #idNoticeform.inc1900theme_checkbox()
Undefined index: #idNoticeform.inc1979theme_button()
Undefined index: Noticesite_disclaimer.admin.inc717_site_disclaimer_prep_allowed_paths()
Undefined offset: 0Noticeform.inc839form_get_error()
Undefined index: #nameNoticeform.inc1893theme_checkbox()
Undefined index: #idNoticeform.inc1894theme_checkbox()
Undefined index: #valueNoticeform.inc1896theme_checkbox()
Undefined index: #idNoticeform.inc1900theme_checkbox()
Undefined offset: 0Noticeform.inc839form_get_error()
Undefined index: #nameNoticeform.inc1893theme_checkbox()
Undefined index: #idNoticeform.inc1894theme_checkbox()
Undefined index: #valueNoticeform.inc1896theme_checkbox()
Undefined index: #idNoticeform.inc1900theme_checkbox()
Undefined index: #idNoticeform.inc1979theme_button()
Undefined offset: 0Noticeform.inc839form_get_error()
Undefined index: #nameNoticeform.inc1893theme_checkbox()
Undefined index: #idNoticeform.inc1894theme_checkbox()
Undefined index: #valueNoticeform.inc1896theme_checkbox()
Undefined index: #idNoticeform.inc1900theme_checkbox()
Undefined offset: 0Noticeform.inc839form_get_error()
Undefined index: #nameNoticeform.inc1893theme_checkbox()
Undefined index: #idNoticeform.inc1894theme_checkbox()
Undefined index: #valueNoticeform.inc1896theme_checkbox()
Undefined index: #idNoticeform.inc1900theme_checkbox()
Undefined index: #idNoticeform.inc1979theme_button()
Undefined index: Noticesite_disclaimer.admin.inc717_site_disclaimer_prep_allowed_paths()
Undefined offset: 0Noticeform.inc839form_get_error()
Undefined index: #nameNoticeform.inc1893theme_checkbox()
Undefined index: #idNoticeform.inc1894theme_checkbox()
Undefined index: #valueNoticeform.inc1896theme_checkbox()
Undefined index: #idNoticeform.inc1900theme_checkbox()
Undefined offset: 0Noticeform.inc839form_get_error()
Undefined index: #nameNoticeform.inc1893theme_checkbox()
Undefined index: #idNoticeform.inc1894theme_checkbox()
Undefined index: #valueNoticeform.inc1896theme_checkbox()
Undefined index: #idNoticeform.inc1900theme_checkbox()
Undefined index: #idNoticeform.inc1979theme_button()
'site_disclaimer_allow_nodes=Array ( [0] => 2 ) 'Debugsite_disclaimer.test161SiteDisclaimerSettingsTestCase->testSiteDisclaimerBasic()
node linked from Site Disclaimer node foundOthersite_disclaimer.test182SiteDisclaimerSettingsTestCase->testSiteDisclaimerBasic()

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
20 minor(s), 0 critical(s), and 10 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandsite_disclaimer.admin.inc702
MessageGroupFilenameLineFunctionStatus
Use "elseif" in place of "else if"Othersite_disclaimer.admin.inc53N/A
use <br /> instead of <br>Othersite_disclaimer.admin.inc257N/A
use <br /> instead of <br>Othersite_disclaimer.admin.inc275N/A
Use "elseif" in place of "else if"Othersite_disclaimer.admin.inc322N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)Othersite_disclaimer.admin.inc379N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOthersite_disclaimer.admin.inc654N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOthersite_disclaimer.admin.inc727N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOthersite_disclaimer.admin.inc737N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOthersite_disclaimer.admin.inc739N/A
Expandsite_disclaimer.module602
MessageGroupFilenameLineFunctionStatus
in most cases, replace the string function with the drupal_ equivalent string functionsOthersite_disclaimer.module124N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOthersite_disclaimer.module125N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOthersite_disclaimer.module128N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOthersite_disclaimer.module131N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOthersite_disclaimer.module140N/A
Functions should be called with no spaces between the function name and opening parenthesesOthersite_disclaimer.module250N/A
l() already contains a check_plain() call by defaultOthersite_disclaimer.module385N/A
Use "elseif" in place of "else if"Othersite_disclaimer.module410N/A
Expandtests/site_disclaimer.test201
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOthersite_disclaimer.test52N/A
missing space after commaOthersite_disclaimer.test161N/A
There should be no trailing spacesOthersite_disclaimer.test179N/A
Expandviews/handlers/site_disclaimer_handler_field_tou_version.inc001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Othersite_disclaimer_handler_field_tou_version.inc-1N/A
Expandviews/handlers/site_disclaimer_handler_sort_tou_version.inc104
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Othersite_disclaimer_handler_sort_tou_version.inc-1N/A
indent secondary line of comment one space Othersite_disclaimer_handler_sort_tou_version.inc13N/A
Use an indent of 2 spaces, with no tabsOthersite_disclaimer_handler_sort_tou_version.inc17N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOthersite_disclaimer_handler_sort_tou_version.inc20N/A
missing space after commaOthersite_disclaimer_handler_sort_tou_version.inc20N/A

All

Test nameMinorCriticalNormal
Expandsite_disclaimer.admin.inc702
MessageGroupFilenameLineFunctionStatus
Use "elseif" in place of "else if"Othersite_disclaimer.admin.inc53N/A
use <br /> instead of <br>Othersite_disclaimer.admin.inc257N/A
use <br /> instead of <br>Othersite_disclaimer.admin.inc275N/A
Use "elseif" in place of "else if"Othersite_disclaimer.admin.inc322N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)Othersite_disclaimer.admin.inc379N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOthersite_disclaimer.admin.inc654N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOthersite_disclaimer.admin.inc727N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOthersite_disclaimer.admin.inc737N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOthersite_disclaimer.admin.inc739N/A
Leafsite_disclaimer.install000
Expandsite_disclaimer.module602
MessageGroupFilenameLineFunctionStatus
in most cases, replace the string function with the drupal_ equivalent string functionsOthersite_disclaimer.module124N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOthersite_disclaimer.module125N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOthersite_disclaimer.module128N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOthersite_disclaimer.module131N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOthersite_disclaimer.module140N/A
Functions should be called with no spaces between the function name and opening parenthesesOthersite_disclaimer.module250N/A
l() already contains a check_plain() call by defaultOthersite_disclaimer.module385N/A
Use "elseif" in place of "else if"Othersite_disclaimer.module410N/A
Expandsite_disclaimer.pages.inc200
MessageGroupFilenameLineFunctionStatus
Use an indent of 2 spaces, with no tabsOthersite_disclaimer.pages.inc42N/A
Use an indent of 2 spaces, with no tabsOthersite_disclaimer.pages.inc45N/A
Expandtests/site_disclaimer.test201
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOthersite_disclaimer.test52N/A
missing space after commaOthersite_disclaimer.test161N/A
There should be no trailing spacesOthersite_disclaimer.test179N/A
Expandviews/handlers/site_disclaimer_handler_field_tou_version.inc001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Othersite_disclaimer_handler_field_tou_version.inc-1N/A
Expandviews/handlers/site_disclaimer_handler_sort_tou_version.inc104
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Othersite_disclaimer_handler_sort_tou_version.inc-1N/A
indent secondary line of comment one space Othersite_disclaimer_handler_sort_tou_version.inc13N/A
Use an indent of 2 spaces, with no tabsOthersite_disclaimer_handler_sort_tou_version.inc17N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOthersite_disclaimer_handler_sort_tou_version.inc20N/A
missing space after commaOthersite_disclaimer_handler_sort_tou_version.inc20N/A
Expandviews/site_disclaimer.views.inc200
MessageGroupFilenameLineFunctionStatus
Missing periodOthersite_disclaimer.views.inc15N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOthersite_disclaimer.views.inc105N/A