Site Disclaimer - 7.x-1.0 | Drupal Quality Assurance

Latest changes

So Long and Thanks for all the Tests

1 week 2 days ago

Support

In case of troubles

check the FAQ. Please make sure you've tried the test locally.
search known testbot issues and then create a new issue if yours isn't there already. Please give a link to the test.

Test client logs

No clients to display.

Site Disclaimer - 7.x-1.0

Test status

Status	Result
Last received	Sun, 01/13/2013 - 17:24:10
Last requested	Sun, 01/13/2013 - 17:30:34
Last tested	Sun, 01/13/2013 - 17:30:43
Test count	2

Environment status

MySQL	fail
Code review	fail

Overall Result	fail

Branch information

Identifier	7.x-1.0
Project	Site Disclaimer
Link	Project information

Event logView entire log

ID	Message	Timestamp
5199483	Result retrieved by project client.	3 years 6 weeks ago
5199478	Result retrieved by project client.	3 years 6 weeks ago
5199433	Result received from test client #958.	3 years 6 weeks ago
5199428	Requested by test client #958.	3 years 6 weeks ago
5199423	Result received from test client #958.	3 years 6 weeks ago
5199383	Requested by test client #958.	3 years 6 weeks ago
5199048	Test request received.	3 years 6 weeks ago

SummaryFAILED: [[SimpleTest]]: [MySQL] 0 pass(es), 2 fail(s), and 0 exception(s); [[Coder]]: [Code review] 19 minor(s), 0 critical(s), and 9 normal(s).

Details

MySQL
Code review

MySQL

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a Drupal installation failure
Detect a test run failure
Detect a failing test
Review the test failures below then if necessary run them locally until the problem has been fixed.
Complete test suite with all tests passing

0 pass(es), 2 fail(s), and 0 exception(s)

Non-pass

Test name

Pass

Fail

Exception

Site Disclaimer Basic (SiteDisclaimerSettingsTestCase) [Site Disclaimer]

Message	Group	Filename	Line	Function	Status
The test did not complete due to a fatal error.	Completion check	site_disclaimer.test	84	SiteDisclaimerSettingsTestCase->testSiteDisclaimerBasic()
Undefined offset: 8192	PHP Notice	site_disclaimer.module	426	Unknown

All

Test name

Pass

Fail

Exception

Site Disclaimer Basic (SiteDisclaimerSettingsTestCase) [Site Disclaimer]

Message	Group	Filename	Line	Function	Status
The test did not complete due to a fatal error.	Completion check	site_disclaimer.test	84	SiteDisclaimerSettingsTestCase->testSiteDisclaimerBasic()
Undefined offset: 8192	PHP Notice	site_disclaimer.module	426	Unknown

Review log

Code review

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a review run failure
Detect coder flags
Ensure that your code follows the Drupal standard and passes a coder review.
Complete coder review with all passed

19 minor(s), 0 critical(s), and 9 normal(s)

Non-pass

Test name

Minor

Critical

Normal

site_disclaimer.admin.inc

Message	Group	Filename	Line	Function
Use "elseif" in place of "else if"	Other	site_disclaimer.admin.inc	51	N/A
use <br /> instead of <br>	Other	site_disclaimer.admin.inc	246	N/A
use <br /> instead of <br>	Other	site_disclaimer.admin.inc	265	N/A
Use "elseif" in place of "else if"	Other	site_disclaimer.admin.inc	312	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	site_disclaimer.admin.inc	583	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	site_disclaimer.admin.inc	660	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	site_disclaimer.admin.inc	670	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	site_disclaimer.admin.inc	672	N/A

site_disclaimer.module

Message	Group	Filename	Line	Function
in most cases, replace the string function with the drupal_ equivalent string functions	Other	site_disclaimer.module	117	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	site_disclaimer.module	118	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	site_disclaimer.module	121	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	site_disclaimer.module	124	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	site_disclaimer.module	134	N/A
l() already contains a check_plain() call by default	Other	site_disclaimer.module	385	N/A
Use "elseif" in place of "else if"	Other	site_disclaimer.module	403	N/A

tests/site_disclaimer.test

Message	Group	Filename	Line	Function
There should be no trailing spaces	Other	site_disclaimer.test	52	N/A
missing space after comma	Other	site_disclaimer.test	161	N/A
There should be no trailing spaces	Other	site_disclaimer.test	179	N/A

views/handlers/site_disclaimer_handler_field_tou_version.inc

Message	Group	Filename	Line	Function	Status
@file block missing (Drupal Docs)	Other	site_disclaimer_handler_field_tou_version.inc	-1	N/A

views/handlers/site_disclaimer_handler_sort_tou_version.inc

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	site_disclaimer_handler_sort_tou_version.inc	-1	N/A
indent secondary line of comment one space	Other	site_disclaimer_handler_sort_tou_version.inc	13	N/A
Use an indent of 2 spaces, with no tabs	Other	site_disclaimer_handler_sort_tou_version.inc	17	N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	site_disclaimer_handler_sort_tou_version.inc	20	N/A
missing space after comma	Other	site_disclaimer_handler_sort_tou_version.inc	20	N/A

All

Test name

Minor

Critical

Normal

site_disclaimer.admin.inc

Message	Group	Filename	Line	Function
Use "elseif" in place of "else if"	Other	site_disclaimer.admin.inc	51	N/A
use <br /> instead of <br>	Other	site_disclaimer.admin.inc	246	N/A
use <br /> instead of <br>	Other	site_disclaimer.admin.inc	265	N/A
Use "elseif" in place of "else if"	Other	site_disclaimer.admin.inc	312	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	site_disclaimer.admin.inc	583	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	site_disclaimer.admin.inc	660	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	site_disclaimer.admin.inc	670	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	site_disclaimer.admin.inc	672	N/A

site_disclaimer.install

site_disclaimer.module

Message	Group	Filename	Line	Function
in most cases, replace the string function with the drupal_ equivalent string functions	Other	site_disclaimer.module	117	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	site_disclaimer.module	118	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	site_disclaimer.module	121	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	site_disclaimer.module	124	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	site_disclaimer.module	134	N/A
l() already contains a check_plain() call by default	Other	site_disclaimer.module	385	N/A
Use "elseif" in place of "else if"	Other	site_disclaimer.module	403	N/A

site_disclaimer.pages.inc

Message	Group	Filename	Line	Function	Status
Use an indent of 2 spaces, with no tabs	Other	site_disclaimer.pages.inc	42	N/A
Use an indent of 2 spaces, with no tabs	Other	site_disclaimer.pages.inc	45	N/A

tests/site_disclaimer.test

Message	Group	Filename	Line	Function
There should be no trailing spaces	Other	site_disclaimer.test	52	N/A
missing space after comma	Other	site_disclaimer.test	161	N/A
There should be no trailing spaces	Other	site_disclaimer.test	179	N/A

views/handlers/site_disclaimer_handler_field_tou_version.inc

Message	Group	Filename	Line	Function	Status
@file block missing (Drupal Docs)	Other	site_disclaimer_handler_field_tou_version.inc	-1	N/A

views/handlers/site_disclaimer_handler_sort_tou_version.inc

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	site_disclaimer_handler_sort_tou_version.inc	-1	N/A
indent secondary line of comment one space	Other	site_disclaimer_handler_sort_tou_version.inc	13	N/A
Use an indent of 2 spaces, with no tabs	Other	site_disclaimer_handler_sort_tou_version.inc	17	N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	site_disclaimer_handler_sort_tou_version.inc	20	N/A
missing space after comma	Other	site_disclaimer_handler_sort_tou_version.inc	20	N/A

views/site_disclaimer.views.inc

Message	Group	Filename	Line	Function	Status
Missing period	Other	site_disclaimer.views.inc	15	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	site_disclaimer.views.inc	105	N/A

Review log