EXIF Custom - 7.x-1.7 | Drupal Quality Assurance

Latest changes

So Long and Thanks for all the Tests

1 week 1 day ago

Support

In case of troubles

check the FAQ. Please make sure you've tried the test locally.
search known testbot issues and then create a new issue if yours isn't there already. Please give a link to the test.

Test client logs

No clients to display.

EXIF Custom - 7.x-1.7

Test status

Status	Result
Last received	Thu, 01/10/2013 - 22:35:11
Last requested	Thu, 01/10/2013 - 22:36:35
Last tested	Thu, 01/10/2013 - 22:36:45
Test count	2

Environment status

MySQL	pass
Code review	fail

Overall Result	pass

Branch information

Identifier	7.x-1.7
Project	EXIF Custom
Link	Project information

Event logView entire log

ID	Message	Timestamp
5182968	Result retrieved by project client.	3 years 6 weeks ago
5182963	Result retrieved by project client.	3 years 6 weeks ago
5182938	Result received from test client #983.	3 years 6 weeks ago
5182923	Requested by test client #983.	3 years 6 weeks ago
5182918	Result received from test client #983.	3 years 6 weeks ago
5182908	Requested by test client #983.	3 years 6 weeks ago
5182898	Test request received.	3 years 6 weeks ago

SummaryPASSED: [[SimpleTest]]: [MySQL] 0 pass(es); [[Coder]]: [Code review] 6 minor(s), 1 critical(s), and 129 normal(s).

Details

MySQL
Code review

MySQL

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a Drupal installation failure
Detect a test run failure
Detect a failing test
Complete test suite with all tests passing

Review log

Code review

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a review run failure
Detect coder flags
Ensure that your code follows the Drupal standard and passes a coder review.
Complete coder review with all passed

6 minor(s), 1 critical(s), and 129 normal(s)

Non-pass

Test name

Minor

Critical

Normal

exif_custom.install

Message	Group	Filename	Line	Function	Status
@file block missing (Drupal Docs)	Other	exif_custom.install	-1	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.install	3	N/A

exif_custom.module

127

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	exif_custom.module	-1	N/A
There should be no trailing spaces	Other	exif_custom.module	5	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	9	N/A
Menu item titles and descriptions should NOT be enclosed within t(). (Drupal Docs)	Other	exif_custom.module	16	N/A
Menu item titles and descriptions should NOT be enclosed within t(). (Drupal Docs)	Other	exif_custom.module	26	N/A
Menu item titles and descriptions should NOT be enclosed within t(). (Drupal Docs)	Other	exif_custom.module	39	N/A
Menu item titles and descriptions should NOT be enclosed within t(). (Drupal Docs)	Other	exif_custom.module	53	N/A
Menu item titles and descriptions should NOT be enclosed within t(). (Drupal Docs)	Other	exif_custom.module	66	N/A
Menu item titles and descriptions should NOT be enclosed within t(). (Drupal Docs)	Other	exif_custom.module	79	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	86	N/A
Use an indent of 2 spaces, with no tabs	Other	exif_custom.module	87	N/A
Use an indent of 2 spaces, with no tabs	Other	exif_custom.module	88	N/A
Use an indent of 2 spaces, with no tabs	Other	exif_custom.module	89	N/A
Use an indent of 2 spaces, with no tabs	Other	exif_custom.module	90	N/A
Use an indent of 2 spaces, with no tabs	Other	exif_custom.module	91	N/A
Use an indent of 2 spaces, with no tabs	Other	exif_custom.module	92	N/A
Use an indent of 2 spaces, with no tabs	Other	exif_custom.module	93	N/A
Use an indent of 2 spaces, with no tabs	Other	exif_custom.module	94	N/A
Use an indent of 2 spaces, with no tabs	Other	exif_custom.module	95	N/A
Use an indent of 2 spaces, with no tabs	Other	exif_custom.module	96	N/A
Use an indent of 2 spaces, with no tabs	Other	exif_custom.module	97	N/A
Use an indent of 2 spaces, with no tabs	Other	exif_custom.module	98	N/A
Use an indent of 2 spaces, with no tabs	Other	exif_custom.module	99	N/A
Use an indent of 2 spaces, with no tabs	Other	exif_custom.module	100	N/A
There should be no trailing spaces	Other	exif_custom.module	101	N/A
There should be no trailing spaces	Other	exif_custom.module	104	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	107	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	123	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	123	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	137	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	141	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	141	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	154	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	160	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	160	N/A
else statements should begin on a new line	Other	exif_custom.module	162	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	167	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	177	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	179	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	179	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	192	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	204	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	204	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	210	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	210	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	248	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	252	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	255	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	255	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	271	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	271	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	272	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	272	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	exif_custom.module	272	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	exif_custom.module	275	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	285	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	287	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	287	N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE	Other	exif_custom.module	287	N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.	Other	exif_custom.module	288	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	292	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	292	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	293	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	293	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	295	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	295	N/A
else statements should begin on a new line	Other	exif_custom.module	295	N/A
else statements should begin on a new line	Other	exif_custom.module	297	N/A
The $text argument to l() should be enclosed within t() so that it is translatable.	Other	exif_custom.module	300	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	306	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	326	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	332	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	332	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	338	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	358	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	358	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)	Other	exif_custom.module	367	N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.	Other	exif_custom.module	367	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	370	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	376	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	377	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	377	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	382	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	383	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	383	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	384	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	384	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	387	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	388	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	388	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	392	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	392	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	395	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	395	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	397	N/A
There should be no trailing spaces	Other	exif_custom.module	399	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	415	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	419	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	419	N/A
Use ANSI standard <> instead of !=	Other	exif_custom.module	422	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	429	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	433	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	433	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	434	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	434	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	435	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	435	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	436	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	436	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	445	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	445	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	448	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	450	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	450	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	452	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	452	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	458	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	458	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	459	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	459	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	465	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	469	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	473	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	473	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	476	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	476	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	479	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	482	N/A
else statements should begin on a new line	Other	exif_custom.module	484	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	496	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	496	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	497	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	497	N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE	Other	exif_custom.module	508	N/A

All