EXIF Custom - 7.x-1.8 | Drupal Quality Assurance

Latest changes

So Long and Thanks for all the Tests

1 week 1 day ago

Support

In case of troubles

check the FAQ. Please make sure you've tried the test locally.
search known testbot issues and then create a new issue if yours isn't there already. Please give a link to the test.

Test client logs

No clients to display.

EXIF Custom - 7.x-1.8

Test status

Status	Result
Last received	Thu, 01/10/2013 - 22:34:12
Last requested	Thu, 01/10/2013 - 22:35:06
Last tested	Thu, 01/10/2013 - 22:36:35
Test count	2

Environment status

MySQL	pass
Code review	fail

Overall Result	pass

Branch information

Identifier	7.x-1.8
Project	EXIF Custom
Link	Project information

Event logView entire log

ID	Message	Timestamp
5182958	Result retrieved by project client.	3 years 6 weeks ago
5182953	Result retrieved by project client.	3 years 6 weeks ago
5182928	Result received from test client #978.	3 years 6 weeks ago
5182903	Result received from test client #983.	3 years 6 weeks ago
5182888	Requested by test client #983.	3 years 6 weeks ago
5182883	Requested by test client #978.	3 years 6 weeks ago
5182873	Test request received.	3 years 6 weeks ago

SummaryPASSED: [[Coder]]: [Code review] 25 minor(s), 1 critical(s), and 157 normal(s); [[SimpleTest]]: [MySQL] 0 pass(es).

Details

MySQL
Code review

MySQL

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a Drupal installation failure
Detect a test run failure
Detect a failing test
Complete test suite with all tests passing

Review log

Code review

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a review run failure
Detect coder flags
Ensure that your code follows the Drupal standard and passes a coder review.
Complete coder review with all passed

25 minor(s), 1 critical(s), and 157 normal(s)

Non-pass

Test name

Minor

Critical

Normal

exif_custom.install

Message	Group	Filename	Line	Function	Status
@file block missing (Drupal Docs)	Other	exif_custom.install	-1	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.install	3	N/A

exif_custom.module

155

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	exif_custom.module	-1	N/A
There should be no trailing spaces	Other	exif_custom.module	5	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	9	N/A
Menu item titles and descriptions should NOT be enclosed within t(). (Drupal Docs)	Other	exif_custom.module	16	N/A
Menu item titles and descriptions should NOT be enclosed within t(). (Drupal Docs)	Other	exif_custom.module	26	N/A
Menu item titles and descriptions should NOT be enclosed within t(). (Drupal Docs)	Other	exif_custom.module	39	N/A
Menu item titles and descriptions should NOT be enclosed within t(). (Drupal Docs)	Other	exif_custom.module	53	N/A
Menu item titles and descriptions should NOT be enclosed within t(). (Drupal Docs)	Other	exif_custom.module	66	N/A
Menu item titles and descriptions should NOT be enclosed within t(). (Drupal Docs)	Other	exif_custom.module	79	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	86	N/A
There should be no trailing spaces	Other	exif_custom.module	104	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	107	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	123	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	123	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	137	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	141	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	141	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	154	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	160	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	160	N/A
else statements should begin on a new line	Other	exif_custom.module	162	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	167	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	177	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	179	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	179	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	192	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	207	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	207	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	213	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	213	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	251	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	255	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	258	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	258	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	274	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	274	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	275	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	275	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	exif_custom.module	275	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	exif_custom.module	278	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	288	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	290	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	290	N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE	Other	exif_custom.module	290	N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.	Other	exif_custom.module	291	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	295	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	295	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	296	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	296	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	298	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	298	N/A
else statements should begin on a new line	Other	exif_custom.module	298	N/A
else statements should begin on a new line	Other	exif_custom.module	300	N/A
The $text argument to l() should be enclosed within t() so that it is translatable.	Other	exif_custom.module	303	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	309	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	329	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	335	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	335	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	341	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	361	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	361	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)	Other	exif_custom.module	370	N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.	Other	exif_custom.module	370	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	373	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	379	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	380	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	380	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	385	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	387	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	387	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	388	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	388	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	391	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	391	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	392	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	392	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	394	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	394	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	401	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	401	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	404	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	404	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	406	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	406	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	419	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	419	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	432	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	436	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	436	N/A
Use ANSI standard <> instead of !=	Other	exif_custom.module	439	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	446	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	450	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	450	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	451	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	451	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	452	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	452	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	453	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	453	N/A
There should be no trailing spaces	Other	exif_custom.module	460	N/A
Use an indent of 2 spaces, with no tabs	Other	exif_custom.module	462	N/A
There should be no trailing spaces	Other	exif_custom.module	463	N/A
There should be no trailing spaces	Other	exif_custom.module	464	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	467	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	467	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	468	N/A
There should be no trailing spaces	Other	exif_custom.module	470	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	471	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	471	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	473	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	473	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	475	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	475	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	481	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	481	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	482	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	482	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	490	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	490	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	494	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	498	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	498	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	501	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	501	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	504	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	507	N/A
else statements should begin on a new line	Other	exif_custom.module	509	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	521	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	521	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	522	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	522	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	532	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	533	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	533	N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE	Other	exif_custom.module	533	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	exif_custom.module	546	N/A
There should be no trailing spaces	Other	exif_custom.module	554	N/A
There should be no trailing spaces	Other	exif_custom.module	557	N/A
There should be no trailing spaces	Other	exif_custom.module	561	N/A
Use an indent of 2 spaces, with no tabs	Other	exif_custom.module	562	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	562	N/A
Use an indent of 2 spaces, with no tabs	Other	exif_custom.module	563	N/A
There should be no trailing spaces	Other	exif_custom.module	565	N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	exif_custom.module	568	N/A
There should be no trailing spaces	Other	exif_custom.module	569	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	571	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	exif_custom.module	571	N/A
There should be no trailing spaces	Other	exif_custom.module	574	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	576	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	577	N/A
Arrays should be formatted with a space separating each element and assignment operator	Other	exif_custom.module	577	N/A
do not use mixed case (camelCase), use lower case and _	Other	exif_custom.module	577	N/A
do not use mixed case (camelCase), use lower case and _	Other	exif_custom.module	579	N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE	Other	exif_custom.module	579	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	580	N/A
do not use mixed case (camelCase), use lower case and _	Other	exif_custom.module	580	N/A
do not use mixed case (camelCase), use lower case and _	Other	exif_custom.module	581	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	exif_custom.module	581	N/A
do not use mixed case (camelCase), use lower case and _	Other	exif_custom.module	582	N/A
do not use mixed case (camelCase), use lower case and _	Other	exif_custom.module	584	N/A
do not use mixed case (camelCase), use lower case and _	Other	exif_custom.module	586	N/A
There should be no trailing spaces	Other	exif_custom.module	588	N/A
do not use mixed case (camelCase), use lower case and _	Other	exif_custom.module	590	N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE	Other	exif_custom.module	590	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	591	N/A
Arrays should be formatted with a space separating each element and assignment operator	Other	exif_custom.module	591	N/A
do not use mixed case (camelCase), use lower case and _	Other	exif_custom.module	591	N/A
do not use mixed case (camelCase), use lower case and _	Other	exif_custom.module	592	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	exif_custom.module	592	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	exif_custom.module	593	N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	exif_custom.module	594	N/A
do not use mixed case (camelCase), use lower case and _	Other	exif_custom.module	594	N/A
do not use mixed case (camelCase), use lower case and _	Other	exif_custom.module	596	N/A
There should be no trailing spaces	Other	exif_custom.module	597	N/A
use a space between the closing parenthesis and the open bracket	Other	exif_custom.module	601	N/A
There should be no trailing spaces	Other	exif_custom.module	604	N/A
Arrays should be formatted with a space separating each element and assignment operator	Other	exif_custom.module	606	N/A
Arrays should be formatted with a space separating each element and assignment operator	Other	exif_custom.module	607	N/A
Arrays should be formatted with a space separating each element and assignment operator	Other	exif_custom.module	608	N/A
Arrays should be formatted with a space separating each element and assignment operator	Other	exif_custom.module	609	N/A
There should be no trailing spaces	Other	exif_custom.module	611	N/A

All