Flag Cool Note - 7.x-1.3

Test status
StatusResult
Last receivedWed, 01/02/2013 - 13:25:55
Last requestedWed, 01/02/2013 - 13:26:29
Last testedWed, 01/02/2013 - 13:27:41
Test count2
Environment status
MySQLfail
Code reviewfail
Overall Resultfail
Branch information
Identifier7.x-1.3
ProjectFlag Cool Note
LinkProject information
SummaryFAILED: [[Coder]]: [Code review] 11 minor(s), 1 critical(s), and 4 normal(s); [[SimpleTest]]: [MySQL] 26 pass(es), 6 fail(s), and 0 exception(s).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
    Review the test failures below then if necessary run them locally until the problem has been fixed.
  10. Complete test suite with all tests passing
26 pass(es), 6 fail(s), and 0 exception(s)

Non-pass

Test namePassFailException
ExpandFlag Cool Note (FlagCoolNoteTestCase) [Flag]2660
MessageGroupFilenameLineFunctionStatus
Found the Submit buttonOtherflagcoolnote.test92FlagCoolNoteTestCase->testFlagCoolNoteCreate()
Found the requested form fields at admin/structure/flags/add/node/fgqmwkv4Otherflagcoolnote.test92FlagCoolNoteTestCase->testFlagCoolNoteCreate()
Failed to set field flags to fgqmwkv4Otherflagcoolnote.test110FlagCoolNoteTestCase->testFlagCoolNoteCreate()
Found the requested form fields at admin/structure/flagcoolnote/addOtherflagcoolnote.test110FlagCoolNoteTestCase->testFlagCoolNoteCreate()
Found the flag this node buttonOtherflagcoolnote.test116FlagCoolNoteTestCase->testFlagCoolNoteCreate()
Found the requested form fields at flag/confirm/flag/fgqmwkv4/1Otherflagcoolnote.test116FlagCoolNoteTestCase->testFlagCoolNoteCreate()

All

Test namePassFailException
ExpandFlag Cool Note (FlagCoolNoteTestCase) [Flag]2660
MessageGroupFilenameLineFunctionStatus
Found the Submit buttonOtherflagcoolnote.test92FlagCoolNoteTestCase->testFlagCoolNoteCreate()
Found the requested form fields at admin/structure/flags/add/node/fgqmwkv4Otherflagcoolnote.test92FlagCoolNoteTestCase->testFlagCoolNoteCreate()
Failed to set field flags to fgqmwkv4Otherflagcoolnote.test110FlagCoolNoteTestCase->testFlagCoolNoteCreate()
Found the requested form fields at admin/structure/flagcoolnote/addOtherflagcoolnote.test110FlagCoolNoteTestCase->testFlagCoolNoteCreate()
Found the flag this node buttonOtherflagcoolnote.test116FlagCoolNoteTestCase->testFlagCoolNoteCreate()
Found the requested form fields at flag/confirm/flag/fgqmwkv4/1Otherflagcoolnote.test116FlagCoolNoteTestCase->testFlagCoolNoteCreate()

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
11 minor(s), 1 critical(s), and 4 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandflagcoolnote.module814
MessageGroupFilenameLineFunctionStatus
put a space between the asterisk and the comment textOtherflagcoolnote.module17N/A
Format should be * Implementation of hook_foo().Otherflagcoolnote.module20N/A
Format should be * Implementation of hook_foo().Otherflagcoolnote.module60N/A
Format should be * Implementation of hook_foo().Otherflagcoolnote.module72N/A
put a space between the asterisk and the comment textOtherflagcoolnote.module233N/A
put a space between the asterisk and the comment textOtherflagcoolnote.module239N/A
put a space between the asterisk and the comment textOtherflagcoolnote.module253N/A
put a space between the asterisk and the comment textOtherflagcoolnote.module301N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Otherflagcoolnote.module373N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherflagcoolnote.module378N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherflagcoolnote.module379N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherflagcoolnote.module387N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherflagcoolnote.module498N/A

All

Test nameMinorCriticalNormal
Expandflagcoolnote.install300
MessageGroupFilenameLineFunctionStatus
Format should be * Implementation of hook_foo().Otherflagcoolnote.install9N/A
Format should be * Implementation of hook_foo().Otherflagcoolnote.install15N/A
Format should be * Implementation of hook_foo().Otherflagcoolnote.install93N/A
Expandflagcoolnote.module814
MessageGroupFilenameLineFunctionStatus
put a space between the asterisk and the comment textOtherflagcoolnote.module17N/A
Format should be * Implementation of hook_foo().Otherflagcoolnote.module20N/A
Format should be * Implementation of hook_foo().Otherflagcoolnote.module60N/A
Format should be * Implementation of hook_foo().Otherflagcoolnote.module72N/A
put a space between the asterisk and the comment textOtherflagcoolnote.module233N/A
put a space between the asterisk and the comment textOtherflagcoolnote.module239N/A
put a space between the asterisk and the comment textOtherflagcoolnote.module253N/A
put a space between the asterisk and the comment textOtherflagcoolnote.module301N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Otherflagcoolnote.module373N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherflagcoolnote.module378N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherflagcoolnote.module379N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherflagcoolnote.module387N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherflagcoolnote.module498N/A
Leaftests/flagcoolnote.test000
Leafviews/flagcoolnote.views.inc000
Leafviews/flagcoolnote_views_handler_field_node.inc000
Leafviews/flagcoolnote_views_handler_field_node_link.inc000