iContact - 7.x-2.x

Test status
StatusResult
Last receivedMon, 12/31/2012 - 18:21:11
Last requestedMon, 12/31/2012 - 18:21:33
Last testedMon, 12/31/2012 - 18:21:59
Test count14
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier7.x-2.x
ProjectiContact
LinkProject information
SummaryPASSED: [[Coder]]: [Code review] 19 minor(s), 2 critical(s), and 57 normal(s); [[SimpleTest]]: [MySQL] 0 pass(es).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
19 minor(s), 2 critical(s), and 57 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandmodules/icontact_subscribe/icontact_subscribe.admin.inc008
MessageGroupFilenameLineFunctionStatus
do not use mixed case (camelCase), use lower case and _Othericontact_subscribe.admin.inc17N/A
do not use mixed case (camelCase), use lower case and _Othericontact_subscribe.admin.inc18N/A
do not use mixed case (camelCase), use lower case and _Othericontact_subscribe.admin.inc19N/A
do not use mixed case (camelCase), use lower case and _Othericontact_subscribe.admin.inc20N/A
do not use mixed case (camelCase), use lower case and _Othericontact_subscribe.admin.inc21N/A
do not use mixed case (camelCase), use lower case and _Othericontact_subscribe.admin.inc22N/A
do not use mixed case (camelCase), use lower case and _Othericontact_subscribe.admin.inc23N/A
do not use mixed case (camelCase), use lower case and _Othericontact_subscribe.admin.inc24N/A
Expandmodules/icontact_subscribe/icontact_subscribe.module519
MessageGroupFilenameLineFunctionStatus
put a space between the asterisk and the comment textOthericontact_subscribe.module14N/A
do not use mixed case (camelCase), use lower case and _Othericontact_subscribe.module70N/A
do not use mixed case (camelCase), use lower case and _Othericontact_subscribe.module71N/A
do not use mixed case (camelCase), use lower case and _Othericontact_subscribe.module89N/A
do not use mixed case (camelCase), use lower case and _Othericontact_subscribe.module90N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOthericontact_subscribe.module136N/A
put a space between the asterisk and the comment textOthericontact_subscribe.module147N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Othericontact_subscribe.module224N/A
do not use mixed case (camelCase), use lower case and _Othericontact_subscribe.module270N/A
do not use mixed case (camelCase), use lower case and _Othericontact_subscribe.module273N/A
do not use mixed case (camelCase), use lower case and _Othericontact_subscribe.module279N/A
put a space between the asterisk and the comment textOthericontact_subscribe.module285N/A
do not use mixed case (camelCase), use lower case and _Othericontact_subscribe.module309N/A
do not use mixed case (camelCase), use lower case and _Othericontact_subscribe.module311N/A
put a space between the asterisk and the comment textOthericontact_subscribe.module338N/A
Expandmodules/icontact_ui/includes/icontact_ui.accounts.inc101
MessageGroupFilenameLineFunctionStatus
put a space between the asterisk and the comment textOthericontact_ui.accounts.inc184N/A
Arrays should be formatted with a space separating each element and assignment operatorOthericontact_ui.accounts.inc225N/A
Expandmodules/icontact_ui/includes/icontact_ui.clientfolders.inc1028
MessageGroupFilenameLineFunctionStatus
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc16N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc17N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc19N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc22N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc24N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc26N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc28N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc31N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc37N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc43N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc49N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc55N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc61N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc67N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc73N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc79N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc92N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc97N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc102N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc107N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc117N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc119N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc125N/A
put a space between the asterisk and the comment textOthericontact_ui.clientfolders.inc132N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc153N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc160N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc164N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc169N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc172N/A
Expandmodules/icontact_ui/includes/icontact_ui.contacts.inc112
MessageGroupFilenameLineFunctionStatus
Potential problem: form_set_error() and form_error() only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Othericontact_ui.contacts.inc126N/A
put a space between the asterisk and the comment textOthericontact_ui.contacts.inc393N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.contacts.inc415N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.contacts.inc416N/A
Expandmodules/icontact_ui/includes/icontact_ui.lists.inc107
MessageGroupFilenameLineFunctionStatus
put a space between the asterisk and the comment textOthericontact_ui.lists.inc99N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.lists.inc125N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.lists.inc126N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.lists.inc164N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.lists.inc165N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.lists.inc166N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.lists.inc167N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.lists.inc172N/A
Expandmodules/icontact_ui/includes/icontact_ui.messages.inc102
MessageGroupFilenameLineFunctionStatus
put a space between the asterisk and the comment textOthericontact_ui.messages.inc97N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.messages.inc119N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.messages.inc120N/A

All

Test nameMinorCriticalNormal
Leafclasses/iContact.class.inc000
Leafclasses/iContactAccount.class.inc000
Leafclasses/iContactClientFolder.class.inc000
Leafclasses/iContactContact.class.inc000
Leafclasses/iContactList.class.inc000
Leafclasses/iContactMessage.class.inc000
Leafclasses/iContactResource.class.inc000
Leafclasses/iContactSubscription.class.inc000
Leafclasses/iContactUser.class.inc000
Leaficontact.admin.inc000
Leaficontact.install000
Expandicontact.module500
MessageGroupFilenameLineFunctionStatus
put a space between the asterisk and the comment textOthericontact.module35N/A
put a space between the asterisk and the comment textOthericontact.module101N/A
put a space between the asterisk and the comment textOthericontact.module119N/A
put a space between the asterisk and the comment textOthericontact.module176N/A
There should be no trailing spacesOthericontact.module343N/A
Expandmodules/icontact_subscribe/icontact_subscribe.admin.inc008
MessageGroupFilenameLineFunctionStatus
do not use mixed case (camelCase), use lower case and _Othericontact_subscribe.admin.inc17N/A
do not use mixed case (camelCase), use lower case and _Othericontact_subscribe.admin.inc18N/A
do not use mixed case (camelCase), use lower case and _Othericontact_subscribe.admin.inc19N/A
do not use mixed case (camelCase), use lower case and _Othericontact_subscribe.admin.inc20N/A
do not use mixed case (camelCase), use lower case and _Othericontact_subscribe.admin.inc21N/A
do not use mixed case (camelCase), use lower case and _Othericontact_subscribe.admin.inc22N/A
do not use mixed case (camelCase), use lower case and _Othericontact_subscribe.admin.inc23N/A
do not use mixed case (camelCase), use lower case and _Othericontact_subscribe.admin.inc24N/A
Leafmodules/icontact_subscribe/icontact_subscribe.install000
Expandmodules/icontact_subscribe/icontact_subscribe.module519
MessageGroupFilenameLineFunctionStatus
put a space between the asterisk and the comment textOthericontact_subscribe.module14N/A
do not use mixed case (camelCase), use lower case and _Othericontact_subscribe.module70N/A
do not use mixed case (camelCase), use lower case and _Othericontact_subscribe.module71N/A
do not use mixed case (camelCase), use lower case and _Othericontact_subscribe.module89N/A
do not use mixed case (camelCase), use lower case and _Othericontact_subscribe.module90N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOthericontact_subscribe.module136N/A
put a space between the asterisk and the comment textOthericontact_subscribe.module147N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Othericontact_subscribe.module224N/A
do not use mixed case (camelCase), use lower case and _Othericontact_subscribe.module270N/A
do not use mixed case (camelCase), use lower case and _Othericontact_subscribe.module273N/A
do not use mixed case (camelCase), use lower case and _Othericontact_subscribe.module279N/A
put a space between the asterisk and the comment textOthericontact_subscribe.module285N/A
do not use mixed case (camelCase), use lower case and _Othericontact_subscribe.module309N/A
do not use mixed case (camelCase), use lower case and _Othericontact_subscribe.module311N/A
put a space between the asterisk and the comment textOthericontact_subscribe.module338N/A
Expandmodules/icontact_ui/icontact_ui.module300
MessageGroupFilenameLineFunctionStatus
put a space between the asterisk and the comment textOthericontact_ui.module19N/A
put a space between the asterisk and the comment textOthericontact_ui.module103N/A
put a space between the asterisk and the comment textOthericontact_ui.module109N/A
Expandmodules/icontact_ui/includes/icontact_ui.accounts.inc101
MessageGroupFilenameLineFunctionStatus
put a space between the asterisk and the comment textOthericontact_ui.accounts.inc184N/A
Arrays should be formatted with a space separating each element and assignment operatorOthericontact_ui.accounts.inc225N/A
Expandmodules/icontact_ui/includes/icontact_ui.clientfolders.inc1028
MessageGroupFilenameLineFunctionStatus
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc16N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc17N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc19N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc22N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc24N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc26N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc28N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc31N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc37N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc43N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc49N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc55N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc61N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc67N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc73N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc79N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc92N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc97N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc102N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc107N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc117N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc119N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc125N/A
put a space between the asterisk and the comment textOthericontact_ui.clientfolders.inc132N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc153N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc160N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc164N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc169N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.clientfolders.inc172N/A
Expandmodules/icontact_ui/includes/icontact_ui.contacts.inc112
MessageGroupFilenameLineFunctionStatus
Potential problem: form_set_error() and form_error() only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Othericontact_ui.contacts.inc126N/A
put a space between the asterisk and the comment textOthericontact_ui.contacts.inc393N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.contacts.inc415N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.contacts.inc416N/A
Expandmodules/icontact_ui/includes/icontact_ui.lists.inc107
MessageGroupFilenameLineFunctionStatus
put a space between the asterisk and the comment textOthericontact_ui.lists.inc99N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.lists.inc125N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.lists.inc126N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.lists.inc164N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.lists.inc165N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.lists.inc166N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.lists.inc167N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.lists.inc172N/A
Leafmodules/icontact_ui/includes/icontact_ui.menu.inc000
Expandmodules/icontact_ui/includes/icontact_ui.messages.inc102
MessageGroupFilenameLineFunctionStatus
put a space between the asterisk and the comment textOthericontact_ui.messages.inc97N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.messages.inc119N/A
do not use mixed case (camelCase), use lower case and _Othericontact_ui.messages.inc120N/A
Expandmodules/icontact_ui/includes/icontact_ui.users.inc100
MessageGroupFilenameLineFunctionStatus
put a space between the asterisk and the comment textOthericontact_ui.users.inc18N/A