iContact - 7.x-2.x | Drupal Quality Assurance

Latest changes

So Long and Thanks for all the Tests

1 week 2 days ago

Support

In case of troubles

check the FAQ. Please make sure you've tried the test locally.
search known testbot issues and then create a new issue if yours isn't there already. Please give a link to the test.

Test client logs

No clients to display.

iContact - 7.x-2.x

Test status

Status	Result
Last received	Mon, 12/31/2012 - 18:21:11
Last requested	Mon, 12/31/2012 - 18:21:33
Last tested	Mon, 12/31/2012 - 18:21:59
Test count	14

Environment status

MySQL	pass
Code review	fail

Overall Result	pass

Branch information

Identifier	7.x-2.x
Project	iContact
Link	Project information

Event logView entire log

ID	Message	Timestamp
5005293	Result retrieved by project client.	3 years 8 weeks ago
5005288	Result received from test client #813.	3 years 8 weeks ago
5005278	Result received from test client #978.	3 years 8 weeks ago
5005268	Requested by test client #978.	3 years 8 weeks ago
5005263	Requested by test client #813.	3 years 8 weeks ago
5005258	Test request received.	3 years 8 weeks ago
5005208	Result retrieved by project client.	3 years 8 weeks ago
5005203	Result received from test client #813.	3 years 8 weeks ago
5005198	Result received from test client #983.	3 years 8 weeks ago
5005193	Requested by test client #983.	3 years 8 weeks ago

SummaryPASSED: [[Coder]]: [Code review] 19 minor(s), 2 critical(s), and 57 normal(s); [[SimpleTest]]: [MySQL] 0 pass(es).

Details

MySQL
Code review

MySQL

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a Drupal installation failure
Detect a test run failure
Detect a failing test
Complete test suite with all tests passing

Review log

Code review

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a review run failure
Detect coder flags
Ensure that your code follows the Drupal standard and passes a coder review.
Complete coder review with all passed

19 minor(s), 2 critical(s), and 57 normal(s)

Non-pass

Test name

Minor

Critical

Normal

modules/icontact_subscribe/icontact_subscribe.admin.inc

Message	Group	Filename	Line	Function
do not use mixed case (camelCase), use lower case and _	Other	icontact_subscribe.admin.inc	17	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_subscribe.admin.inc	18	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_subscribe.admin.inc	19	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_subscribe.admin.inc	20	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_subscribe.admin.inc	21	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_subscribe.admin.inc	22	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_subscribe.admin.inc	23	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_subscribe.admin.inc	24	N/A

modules/icontact_subscribe/icontact_subscribe.module

Message	Group	Filename	Line	Function
put a space between the asterisk and the comment text	Other	icontact_subscribe.module	14	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_subscribe.module	70	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_subscribe.module	71	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_subscribe.module	89	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_subscribe.module	90	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	icontact_subscribe.module	136	N/A
put a space between the asterisk and the comment text	Other	icontact_subscribe.module	147	N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	icontact_subscribe.module	224	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_subscribe.module	270	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_subscribe.module	273	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_subscribe.module	279	N/A
put a space between the asterisk and the comment text	Other	icontact_subscribe.module	285	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_subscribe.module	309	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_subscribe.module	311	N/A
put a space between the asterisk and the comment text	Other	icontact_subscribe.module	338	N/A

modules/icontact_ui/includes/icontact_ui.accounts.inc

Message	Group	Filename	Line	Function	Status
put a space between the asterisk and the comment text	Other	icontact_ui.accounts.inc	184	N/A
Arrays should be formatted with a space separating each element and assignment operator	Other	icontact_ui.accounts.inc	225	N/A

modules/icontact_ui/includes/icontact_ui.clientfolders.inc

Message	Group	Filename	Line	Function
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.clientfolders.inc	16	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.clientfolders.inc	17	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.clientfolders.inc	19	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.clientfolders.inc	22	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.clientfolders.inc	24	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.clientfolders.inc	26	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.clientfolders.inc	28	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.clientfolders.inc	31	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.clientfolders.inc	37	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.clientfolders.inc	43	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.clientfolders.inc	49	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.clientfolders.inc	55	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.clientfolders.inc	61	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.clientfolders.inc	67	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.clientfolders.inc	73	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.clientfolders.inc	79	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.clientfolders.inc	92	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.clientfolders.inc	97	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.clientfolders.inc	102	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.clientfolders.inc	107	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.clientfolders.inc	117	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.clientfolders.inc	119	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.clientfolders.inc	125	N/A
put a space between the asterisk and the comment text	Other	icontact_ui.clientfolders.inc	132	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.clientfolders.inc	153	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.clientfolders.inc	160	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.clientfolders.inc	164	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.clientfolders.inc	169	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.clientfolders.inc	172	N/A

modules/icontact_ui/includes/icontact_ui.contacts.inc

Message	Group	Filename	Line	Function
Potential problem: form_set_error() and form_error() only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	icontact_ui.contacts.inc	126	N/A
put a space between the asterisk and the comment text	Other	icontact_ui.contacts.inc	393	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.contacts.inc	415	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.contacts.inc	416	N/A

modules/icontact_ui/includes/icontact_ui.lists.inc

Message	Group	Filename	Line	Function
put a space between the asterisk and the comment text	Other	icontact_ui.lists.inc	99	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.lists.inc	125	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.lists.inc	126	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.lists.inc	164	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.lists.inc	165	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.lists.inc	166	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.lists.inc	167	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.lists.inc	172	N/A

modules/icontact_ui/includes/icontact_ui.messages.inc

Message	Group	Filename	Line	Function
put a space between the asterisk and the comment text	Other	icontact_ui.messages.inc	97	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.messages.inc	119	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_ui.messages.inc	120	N/A

All

Test name

Minor

Critical

Normal

classes/iContact.class.inc

classes/iContactAccount.class.inc

classes/iContactClientFolder.class.inc

classes/iContactContact.class.inc

classes/iContactList.class.inc

classes/iContactMessage.class.inc

classes/iContactResource.class.inc

classes/iContactSubscription.class.inc

classes/iContactUser.class.inc

icontact.admin.inc

icontact.install

icontact.module

Message	Group	Filename	Line	Function
put a space between the asterisk and the comment text	Other	icontact.module	35	N/A
put a space between the asterisk and the comment text	Other	icontact.module	101	N/A
put a space between the asterisk and the comment text	Other	icontact.module	119	N/A
put a space between the asterisk and the comment text	Other	icontact.module	176	N/A
There should be no trailing spaces	Other	icontact.module	343	N/A

modules/icontact_subscribe/icontact_subscribe.admin.inc

Message	Group	Filename	Line	Function
do not use mixed case (camelCase), use lower case and _	Other	icontact_subscribe.admin.inc	17	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_subscribe.admin.inc	18	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_subscribe.admin.inc	19	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_subscribe.admin.inc	20	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_subscribe.admin.inc	21	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_subscribe.admin.inc	22	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_subscribe.admin.inc	23	N/A
do not use mixed case (camelCase), use lower case and _	Other	icontact_subscribe.admin.inc	24	N/A

modules/icontact_subscribe/icontact_subscribe.install