Role Change Notify - 6.x-2.x

Test status
StatusResult
Last receivedThu, 01/31/2013 - 03:45:18
Last requestedThu, 01/31/2013 - 03:45:20
Last testedThu, 01/31/2013 - 03:45:38
Test count13
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier6.x-2.x
ProjectRole Change Notify
LinkProject information
SummaryPASSED: [[Coder]]: [Code review] 1 minor(s), 2 critical(s), and 18 normal(s); [[SimpleTest]]: [MySQL] 33 pass(es).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing
33 pass(es), 0 fail(s), and 0 exception(s)
Test namePassFailException
LeafRoleChangeNotifyTestCase3300

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
1 minor(s), 2 critical(s), and 18 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandrole_change_notify.module1218
MessageGroupFilenameLineFunctionStatus
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otherrole_change_notify.module25N/A
global variables should start with a single underscore followed by the module and another underscoreOtherrole_change_notify.module56N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherrole_change_notify.module149N/A
Control statements should have one space between the control keyword and opening parenthesisOtherrole_change_notify.module254N/A
use a space between the closing parenthesis and the open bracketOtherrole_change_notify.module254N/A
Control statements should have one space between the control keyword and opening parenthesisOtherrole_change_notify.module257N/A
use a space between the closing parenthesis and the open bracketOtherrole_change_notify.module257N/A
else statements should begin on a new lineOtherrole_change_notify.module260N/A
Use an indent of 2 spaces, with no tabsOtherrole_change_notify.module325N/A
do not use mixed case (camelCase), use lower case and _Otherrole_change_notify.module325N/A
do not use mixed case (camelCase), use lower case and _Otherrole_change_notify.module332N/A
Control statements should have one space between the control keyword and opening parenthesisOtherrole_change_notify.module344N/A
use a space between the closing parenthesis and the open bracketOtherrole_change_notify.module344N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherrole_change_notify.module348N/A
do not use mixed case (camelCase), use lower case and _Otherrole_change_notify.module362N/A
do not use mixed case (camelCase), use lower case and _Otherrole_change_notify.module365N/A
Control statements should have one space between the control keyword and opening parenthesisOtherrole_change_notify.module373N/A
else statements should begin on a new lineOtherrole_change_notify.module398N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherrole_change_notify.module400N/A
Control statements should have one space between the control keyword and opening parenthesisOtherrole_change_notify.module421N/A
use a space between the closing parenthesis and the open bracketOtherrole_change_notify.module421N/A

All

Test nameMinorCriticalNormal
Leafrole_change_notify.install000
Expandrole_change_notify.module1218
MessageGroupFilenameLineFunctionStatus
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otherrole_change_notify.module25N/A
global variables should start with a single underscore followed by the module and another underscoreOtherrole_change_notify.module56N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherrole_change_notify.module149N/A
Control statements should have one space between the control keyword and opening parenthesisOtherrole_change_notify.module254N/A
use a space between the closing parenthesis and the open bracketOtherrole_change_notify.module254N/A
Control statements should have one space between the control keyword and opening parenthesisOtherrole_change_notify.module257N/A
use a space between the closing parenthesis and the open bracketOtherrole_change_notify.module257N/A
else statements should begin on a new lineOtherrole_change_notify.module260N/A
Use an indent of 2 spaces, with no tabsOtherrole_change_notify.module325N/A
do not use mixed case (camelCase), use lower case and _Otherrole_change_notify.module325N/A
do not use mixed case (camelCase), use lower case and _Otherrole_change_notify.module332N/A
Control statements should have one space between the control keyword and opening parenthesisOtherrole_change_notify.module344N/A
use a space between the closing parenthesis and the open bracketOtherrole_change_notify.module344N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherrole_change_notify.module348N/A
do not use mixed case (camelCase), use lower case and _Otherrole_change_notify.module362N/A
do not use mixed case (camelCase), use lower case and _Otherrole_change_notify.module365N/A
Control statements should have one space between the control keyword and opening parenthesisOtherrole_change_notify.module373N/A
else statements should begin on a new lineOtherrole_change_notify.module398N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherrole_change_notify.module400N/A
Control statements should have one space between the control keyword and opening parenthesisOtherrole_change_notify.module421N/A
use a space between the closing parenthesis and the open bracketOtherrole_change_notify.module421N/A
Leafrole_change_notify.test000