State Machine - 7.x-3.x

Test status
StatusResult
Last receivedTue, 10/09/2012 - 21:30:06
Last requestedTue, 10/09/2012 - 21:31:03
Last testedTue, 10/09/2012 - 21:33:29
Test count2
Environment status
MySQLfail
Code reviewfail
Overall Resultfail
Branch information
Identifier7.x-3.x
ProjectState Machine
LinkProject information
SummaryFAILED: [[Coder]]: [Code review] 22 minor(s), 1 critical(s), and 4 normal(s); [[SimpleTest]]: [MySQL] 85 pass(es), 1 fail(s), and 0 exception(s).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
    Review the test failures below then if necessary run them locally until the problem has been fixed.
  10. Complete test suite with all tests passing
85 pass(es), 1 fail(s), and 0 exception(s)

Non-pass

Test namePassFailException
ExpandStateFlow tests for sites with pre-existing nodes. (StateFlowWebTestCaseInstallOnExistingSite) [State Machine]1410
MessageGroupFilenameLineFunctionStatus
The test did not complete due to a fatal error.Completion checkstate_flow.test236StateFlowWebTestCaseInstallOnExistingSite->testStateFlowPreexistingNode()

All

Test namePassFailException
LeafStateFlow basic tests (StateFlowWebTestCase) [State Machine]7100
ExpandStateFlow tests for sites with pre-existing nodes. (StateFlowWebTestCaseInstallOnExistingSite) [State Machine]1410
MessageGroupFilenameLineFunctionStatus
The test did not complete due to a fatal error.Completion checkstate_flow.test236StateFlowWebTestCaseInstallOnExistingSite->testStateFlowPreexistingNode()

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
22 minor(s), 1 critical(s), and 4 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandmodules/state_flow_entity/plugins/state_flow_entity.inc001
MessageGroupFilenameLineFunctionStatus
Control statements should have one space between the control keyword and opening parenthesisOtherstate_flow_entity.inc258N/A
Expandmodules/state_flow_schedule/state_flow_schedule.module013
MessageGroupFilenameLineFunctionStatus
use a space between the closing parenthesis and the open bracketOtherstate_flow_schedule.module134N/A
use a space between the closing parenthesis and the open bracketOtherstate_flow_schedule.module164N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)Otherstate_flow_schedule.module181N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherstate_flow_schedule.module181N/A

All

Test nameMinorCriticalNormal
Leafinc/base.inc000
Leafmodules/state_flow/includes/views/state_flow.views.inc000
Leafmodules/state_flow/includes/views/state_flow_handler_field_is_node_revision_published.inc000
Leafmodules/state_flow/includes/views/state_flow_handler_field_workflow_link.inc000
Leafmodules/state_flow/includes/views/state_flow_handler_filter_state.inc000
Leafmodules/state_flow/includes/views/views/state_flow_history_by_node.inc000
Leafmodules/state_flow/includes/views/views/state_flow_states_by_node.inc000
Leafmodules/state_flow/plugins/state_flow_node.inc000
Leafmodules/state_flow/state_flow.admin.inc000
Expandmodules/state_flow/state_flow.module400
MessageGroupFilenameLineFunctionStatus
@see should always be followed by a filename, a URL, class/interface name (optionally including method), or a function name including ().Otherstate_flow.module154N/A
@see references should be separated by "," followed by a single space and with no trailing punctuationOtherstate_flow.module154N/A
@see should always be followed by a filename, a URL, class/interface name (optionally including method), or a function name including ().Otherstate_flow.module328N/A
@see references should be separated by "," followed by a single space and with no trailing punctuationOtherstate_flow.module328N/A
Leafmodules/state_flow/state_flow.pages.inc000
Leafmodules/state_flow/tests/state_flow.test000
Leafmodules/state_flow_entity/includes/views/state_flow_entity.views.inc000
Leafmodules/state_flow_entity/includes/views/state_flow_entity_handler_area_events_form.inc000
Leafmodules/state_flow_entity/includes/views/state_flow_entity_handler_field_events_form.inc000
Leafmodules/state_flow_entity/includes/views/state_flow_entity_handler_field_link.inc000
Leafmodules/state_flow_entity/includes/views/state_flow_entity_handler_field_state.inc000
Leafmodules/state_flow_entity/includes/views/state_flow_entity_handler_field_state_flow_states.inc000
Leafmodules/state_flow_entity/includes/views/state_flow_handler_available_events.inc000
Leafmodules/state_flow_entity/plugins/access/state_flow_entity_entity_in_state.inc000
Expandmodules/state_flow_entity/plugins/content_types/state_flow_entity_form.inc900
MessageGroupFilenameLineFunctionStatus
in most cases, replace the string function with the drupal_ equivalent string functionsOtherstate_flow_entity_form.inc46N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherstate_flow_entity_form.inc47N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherstate_flow_entity_form.inc49N/A
indent secondary line of comment one space Otherstate_flow_entity_form.inc66N/A
indent secondary line of comment one space Otherstate_flow_entity_form.inc67N/A
indent secondary line of comment one space Otherstate_flow_entity_form.inc117N/A
indent secondary line of comment one space Otherstate_flow_entity_form.inc118N/A
indent secondary line of comment one space Otherstate_flow_entity_form.inc148N/A
indent secondary line of comment one space Otherstate_flow_entity_form.inc149N/A
Leafmodules/state_flow_entity/plugins/relationships/state_flow_history_from_entity.inc000
Expandmodules/state_flow_entity/plugins/state_flow_entity.inc001
MessageGroupFilenameLineFunctionStatus
Control statements should have one space between the control keyword and opening parenthesisOtherstate_flow_entity.inc258N/A
Leafmodules/state_flow_entity/state_flow_entity.api.php000
Leafmodules/state_flow_entity/state_flow_entity.forms.inc000
Leafmodules/state_flow_entity/state_flow_entity.install000
Expandmodules/state_flow_entity/state_flow_entity.module500
MessageGroupFilenameLineFunctionStatus
Use an indent of 2 spaces, with no tabsOtherstate_flow_entity.module70N/A
Use an indent of 2 spaces, with no tabsOtherstate_flow_entity.module172N/A
Use an indent of 2 spaces, with no tabsOtherstate_flow_entity.module315N/A
@see should always be followed by a filename, a URL, class/interface name (optionally including method), or a function name including ().Otherstate_flow_entity.module370N/A
@see references should be separated by "," followed by a single space and with no trailing punctuationOtherstate_flow_entity.module370N/A
Leafmodules/state_flow_entity/state_flow_entity.rules.inc000
Leafmodules/state_flow_schedule/state_flow_schedule.drush.inc000
Leafmodules/state_flow_schedule/state_flow_schedule.install000
Expandmodules/state_flow_schedule/state_flow_schedule.module013
MessageGroupFilenameLineFunctionStatus
use a space between the closing parenthesis and the open bracketOtherstate_flow_schedule.module134N/A
use a space between the closing parenthesis and the open bracketOtherstate_flow_schedule.module164N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)Otherstate_flow_schedule.module181N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherstate_flow_schedule.module181N/A
Expandstate_machine.api.php400
MessageGroupFilenameLineFunctionStatus
@see should always be followed by a filename, a URL, class/interface name (optionally including method), or a function name including ().Otherstate_machine.api.php11N/A
@see references should be separated by "," followed by a single space and with no trailing punctuationOtherstate_machine.api.php11N/A
@see should always be followed by a filename, a URL, class/interface name (optionally including method), or a function name including ().Otherstate_machine.api.php22N/A
@see should always be followed by a filename, a URL, class/interface name (optionally including method), or a function name including ().Otherstate_machine.api.php38N/A
Leafstate_machine.install000
Leafstate_machine.module000
Leaftests/state_machine.test000