Organic Group Statistics - 6.x-1.x

Test status
StatusResult
Last receivedSat, 04/07/2012 - 15:27:38
Last requestedSat, 04/07/2012 - 15:28:03
Last testedSat, 04/07/2012 - 15:29:22
Test count13
Environment status
MySQLfail
Code reviewfail
Overall Resultfail
Branch information
Identifier6.x-1.x
ProjectOrganic Group Statistics
LinkProject information
SummaryFAILED: [[Coder]]: [Code review] 5 minor(s), 2 critical(s), and 11 normal(s); [[SimpleTest]]: [MySQL] 122 pass(es), 0 fail(s), and 75 exception(s).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
    Review the test failures below then if necessary run them locally until the problem has been fixed.
  10. Complete test suite with all tests passing
122 pass(es), 0 fail(s), and 75 exception(s)

Non-pass

Test namePassFailException
ExpandOrganic groups statistics (OgStatisticsTestCase) [Unknown]122075
MessageGroupFilenameLineFunctionStatus
Undefined index: develNoticeinstall.inc316drupal_install_modules()
Undefined index: develNoticeinstall.inc86drupal_get_installed_schema_version()
Trying to get property of non-objectNoticemodule.inc316module_enable()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined index: members_countNoticeog_statistics.module329og_statistics_add_user()
Undefined property: stdClass::$nidNoticecommon.inc3578drupal_write_record()
Undefined property: stdClass::$nidNoticecommon.inc3578drupal_write_record()
Undefined index: develNoticeinstall.inc316drupal_install_modules()
Undefined index: develNoticeinstall.inc86drupal_get_installed_schema_version()
Trying to get property of non-objectNoticemodule.inc316module_enable()
Undefined index: members_countNoticeog_statistics.module329og_statistics_add_user()
Undefined property: stdClass::$nidNoticecommon.inc3578drupal_write_record()
Undefined property: stdClass::$nidNoticecommon.inc3578drupal_write_record()
Undefined index: develNoticeinstall.inc316drupal_install_modules()
Undefined index: develNoticeinstall.inc86drupal_get_installed_schema_version()
Trying to get property of non-objectNoticemodule.inc316module_enable()
Undefined index: members_countNoticeog_statistics.module329og_statistics_add_user()
Undefined property: stdClass::$nidNoticecommon.inc3578drupal_write_record()
Undefined property: stdClass::$nidNoticecommon.inc3578drupal_write_record()
Undefined index: develNoticeinstall.inc316drupal_install_modules()
Undefined index: develNoticeinstall.inc86drupal_get_installed_schema_version()
Trying to get property of non-objectNoticemodule.inc316module_enable()
Undefined index: members_countNoticeog_statistics.module329og_statistics_add_user()
Undefined property: stdClass::$nidNoticecommon.inc3578drupal_write_record()
Undefined property: stdClass::$nidNoticecommon.inc3578drupal_write_record()
Undefined index: develNoticeinstall.inc316drupal_install_modules()
Undefined index: develNoticeinstall.inc86drupal_get_installed_schema_version()
Trying to get property of non-objectNoticemodule.inc316module_enable()
Undefined index: members_countNoticeog_statistics.module329og_statistics_add_user()
Undefined property: stdClass::$nidNoticecommon.inc3578drupal_write_record()
Undefined property: stdClass::$nidNoticecommon.inc3578drupal_write_record()
Undefined index: members_countNoticeog_statistics.module329og_statistics_add_user()
Undefined property: stdClass::$nidNoticecommon.inc3578drupal_write_record()
Undefined property: stdClass::$nidNoticecommon.inc3578drupal_write_record()

All

Test namePassFailException
ExpandOrganic groups statistics (OgStatisticsTestCase) [Unknown]122075
MessageGroupFilenameLineFunctionStatus
Undefined index: develNoticeinstall.inc316drupal_install_modules()
Undefined index: develNoticeinstall.inc86drupal_get_installed_schema_version()
Trying to get property of non-objectNoticemodule.inc316module_enable()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined property: views_display::$display_optionsNoticeviews_plugin_display.inc35views_plugin_display->init()
Undefined index: members_countNoticeog_statistics.module329og_statistics_add_user()
Undefined property: stdClass::$nidNoticecommon.inc3578drupal_write_record()
Undefined property: stdClass::$nidNoticecommon.inc3578drupal_write_record()
Undefined index: develNoticeinstall.inc316drupal_install_modules()
Undefined index: develNoticeinstall.inc86drupal_get_installed_schema_version()
Trying to get property of non-objectNoticemodule.inc316module_enable()
Undefined index: members_countNoticeog_statistics.module329og_statistics_add_user()
Undefined property: stdClass::$nidNoticecommon.inc3578drupal_write_record()
Undefined property: stdClass::$nidNoticecommon.inc3578drupal_write_record()
Undefined index: develNoticeinstall.inc316drupal_install_modules()
Undefined index: develNoticeinstall.inc86drupal_get_installed_schema_version()
Trying to get property of non-objectNoticemodule.inc316module_enable()
Undefined index: members_countNoticeog_statistics.module329og_statistics_add_user()
Undefined property: stdClass::$nidNoticecommon.inc3578drupal_write_record()
Undefined property: stdClass::$nidNoticecommon.inc3578drupal_write_record()
Undefined index: develNoticeinstall.inc316drupal_install_modules()
Undefined index: develNoticeinstall.inc86drupal_get_installed_schema_version()
Trying to get property of non-objectNoticemodule.inc316module_enable()
Undefined index: members_countNoticeog_statistics.module329og_statistics_add_user()
Undefined property: stdClass::$nidNoticecommon.inc3578drupal_write_record()
Undefined property: stdClass::$nidNoticecommon.inc3578drupal_write_record()
Undefined index: develNoticeinstall.inc316drupal_install_modules()
Undefined index: develNoticeinstall.inc86drupal_get_installed_schema_version()
Trying to get property of non-objectNoticemodule.inc316module_enable()
Undefined index: members_countNoticeog_statistics.module329og_statistics_add_user()
Undefined property: stdClass::$nidNoticecommon.inc3578drupal_write_record()
Undefined property: stdClass::$nidNoticecommon.inc3578drupal_write_record()
Undefined index: members_countNoticeog_statistics.module329og_statistics_add_user()
Undefined property: stdClass::$nidNoticecommon.inc3578drupal_write_record()
Undefined property: stdClass::$nidNoticecommon.inc3578drupal_write_record()

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
5 minor(s), 2 critical(s), and 11 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandog_statistics.admin.inc010
MessageGroupFilenameLineFunctionStatus
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Otherog_statistics.admin.inc27N/A
Expandog_statistics.module016
MessageGroupFilenameLineFunctionStatus
Function documentation should be less than 80 characters per line.Otherog_statistics.module13N/A
If you define a @param or @return, you should document it as well.Otherog_statistics.module40N/A
Remove the empty commented line in your function documentation.Otherog_statistics.module53N/A
Remove the empty commented line in your function documentation.Otherog_statistics.module203N/A
If you define a @param or @return, you should document it as well.Otherog_statistics.module373N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Otherog_statistics.module404N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherog_statistics.module428N/A
Expandog_statistics.test101
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherog_statistics.test-1N/A
There should be no trailing spacesOtherog_statistics.test47N/A
Expandog_statistics.views.inc004
MessageGroupFilenameLineFunctionStatus
Use sentence case, not title case, for end-user strings. (Wikipedia)Otherog_statistics.views.inc27N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otherog_statistics.views.inc42N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otherog_statistics.views.inc57N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otherog_statistics.views.inc83N/A

All

Test nameMinorCriticalNormal
Expandog_statistics.admin.inc010
MessageGroupFilenameLineFunctionStatus
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Otherog_statistics.admin.inc27N/A
Expandog_statistics.faceted_search.inc100
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherog_statistics.faceted_search.inc35N/A
Expandog_statistics.install300
MessageGroupFilenameLineFunctionStatus
Format should be * Implementation of hook_foo().Otherog_statistics.install9N/A
Format should be * Implementation of hook_foo().Otherog_statistics.install16N/A
Format should be * Implementation of hook_foo().Otherog_statistics.install117N/A
Expandog_statistics.module016
MessageGroupFilenameLineFunctionStatus
Function documentation should be less than 80 characters per line.Otherog_statistics.module13N/A
If you define a @param or @return, you should document it as well.Otherog_statistics.module40N/A
Remove the empty commented line in your function documentation.Otherog_statistics.module53N/A
Remove the empty commented line in your function documentation.Otherog_statistics.module203N/A
If you define a @param or @return, you should document it as well.Otherog_statistics.module373N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Otherog_statistics.module404N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherog_statistics.module428N/A
Expandog_statistics.test101
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherog_statistics.test-1N/A
There should be no trailing spacesOtherog_statistics.test47N/A
Expandog_statistics.views.inc004
MessageGroupFilenameLineFunctionStatus
Use sentence case, not title case, for end-user strings. (Wikipedia)Otherog_statistics.views.inc27N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otherog_statistics.views.inc42N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otherog_statistics.views.inc57N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otherog_statistics.views.inc83N/A