Webform Validation - 6.x-1.5

Test status
StatusResult
Last receivedFri, 09/14/2012 - 20:27:16
Last requestedFri, 09/14/2012 - 20:28:35
Last testedFri, 09/14/2012 - 20:28:44
Test count2
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier6.x-1.5
ProjectWebform Validation
LinkProject information
SummaryPASSED: [[SimpleTest]]: [MySQL] 0 pass(es); [[Coder]]: [Code review] 20 minor(s), 2 critical(s), and 25 normal(s).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
20 minor(s), 2 critical(s), and 25 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandwebform_validation.install111
MessageGroupFilenameLineFunctionStatus
Use update_sql() instead of db_query() in hook_update_N()Otherwebform_validation.install109N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherwebform_validation.install113N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherwebform_validation.install128N/A
Expandwebform_validation.module117
MessageGroupFilenameLineFunctionStatus
Use "elseif" in place of "else if"Otherwebform_validation.module114N/A
Use "elseif" in place of "else if"Otherwebform_validation.module117N/A
Potential problem: form_set_error() and form_error() only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherwebform_validation.module168N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherwebform_validation.module283N/A
use a space between the closing parenthesis and the open bracketOtherwebform_validation.module418N/A
Control statements should have one space between the control keyword and opening parenthesisOtherwebform_validation.module424N/A
use a space between the closing parenthesis and the open bracketOtherwebform_validation.module424N/A
Control statements should have one space between the control keyword and opening parenthesisOtherwebform_validation.module425N/A
use a space between the closing parenthesis and the open bracketOtherwebform_validation.module425N/A
Expandwebform_validation.validators.inc18017
MessageGroupFilenameLineFunctionStatus
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc316N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc316N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc317N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc317N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc318N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc318N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc320N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc320N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc321N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc321N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc322N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc322N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc323N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc323N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc324N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc324N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc325N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc325N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc326N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc326N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc327N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc327N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc328N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc328N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc330N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc330N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc331N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc331N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc332N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc332N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc333N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc333N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc334N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc334N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherwebform_validation.validators.inc363N/A

All

Test nameMinorCriticalNormal
Leafwebform_validation.admin.inc000
Expandwebform_validation.install111
MessageGroupFilenameLineFunctionStatus
Use update_sql() instead of db_query() in hook_update_N()Otherwebform_validation.install109N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherwebform_validation.install113N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherwebform_validation.install128N/A
Expandwebform_validation.module117
MessageGroupFilenameLineFunctionStatus
Use "elseif" in place of "else if"Otherwebform_validation.module114N/A
Use "elseif" in place of "else if"Otherwebform_validation.module117N/A
Potential problem: form_set_error() and form_error() only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherwebform_validation.module168N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherwebform_validation.module283N/A
use a space between the closing parenthesis and the open bracketOtherwebform_validation.module418N/A
Control statements should have one space between the control keyword and opening parenthesisOtherwebform_validation.module424N/A
use a space between the closing parenthesis and the open bracketOtherwebform_validation.module424N/A
Control statements should have one space between the control keyword and opening parenthesisOtherwebform_validation.module425N/A
use a space between the closing parenthesis and the open bracketOtherwebform_validation.module425N/A
Leafwebform_validation.rules.inc000
Expandwebform_validation.validators.inc18017
MessageGroupFilenameLineFunctionStatus
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc316N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc316N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc317N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc317N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc318N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc318N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc320N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc320N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc321N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc321N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc322N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc322N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc323N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc323N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc324N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc324N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc325N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc325N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc326N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc326N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc327N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc327N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc328N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc328N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc330N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc330N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc331N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc331N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc332N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc332N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc333N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc333N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc334N/A
Use an indent of 2 spaces, with no tabsOtherwebform_validation.validators.inc334N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherwebform_validation.validators.inc363N/A