Question/Answer - 7.x-1.x

Test status
StatusResult
Last receivedThu, 09/13/2012 - 21:01:40
Last requestedThu, 09/13/2012 - 21:02:03
Last testedThu, 09/13/2012 - 21:02:11
Test count2
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier7.x-1.x
ProjectQuestion/Answer
LinkProject information
SummaryPASSED: [[SimpleTest]]: [MySQL] 0 pass(es); [[Coder]]: [Code review] 2 minor(s), 2 critical(s), and 3 normal(s).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
2 minor(s), 2 critical(s), and 3 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandquestion_answer-answer.tpl.php002
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherquestion_answer-answer.tpl.php-1N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherquestion_answer-answer.tpl.php3N/A
Expandquestion_answer.module210
MessageGroupFilenameLineFunctionStatus
in most cases, replace the string function with the drupal_ equivalent string functionsOtherquestion_answer.module115N/A
There should be no trailing spacesOtherquestion_answer.module163N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otherquestion_answer.module268N/A
Expandquestion_answer.pages.inc011
MessageGroupFilenameLineFunctionStatus
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherquestion_answer.pages.inc28N/A
Use "elseif" in place of "else if"Otherquestion_answer.pages.inc67N/A

All

Test nameMinorCriticalNormal
Expandquestion_answer-answer.tpl.php002
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherquestion_answer-answer.tpl.php-1N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherquestion_answer-answer.tpl.php3N/A
Leafquestion_answer.install000
Expandquestion_answer.module210
MessageGroupFilenameLineFunctionStatus
in most cases, replace the string function with the drupal_ equivalent string functionsOtherquestion_answer.module115N/A
There should be no trailing spacesOtherquestion_answer.module163N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otherquestion_answer.module268N/A
Expandquestion_answer.pages.inc011
MessageGroupFilenameLineFunctionStatus
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherquestion_answer.pages.inc28N/A
Use "elseif" in place of "else if"Otherquestion_answer.pages.inc67N/A