Redis - 7.x-2.0-alpha11 | Drupal Quality Assurance

Latest changes

So Long and Thanks for all the Tests

1 week 2 days ago

Support

In case of troubles

check the FAQ. Please make sure you've tried the test locally.
search known testbot issues and then create a new issue if yours isn't there already. Please give a link to the test.

Test client logs

No clients to display.

Redis - 7.x-2.0-alpha11

Test status

Status	Result
Last received	Wed, 09/12/2012 - 16:48:15
Last requested	Wed, 09/12/2012 - 16:49:03
Last tested	Wed, 09/12/2012 - 16:49:39
Test count	2

Environment status

MySQL	fail
Code review	fail

Overall Result	fail

Branch information

Identifier	7.x-2.0-alpha11
Project	Redis
Link	Project information

Event logView entire log

ID	Message	Timestamp
4333693	Result retrieved by project client.	3 years 23 weeks ago
4333688	Result received from test client #953.	3 years 23 weeks ago
4333683	Result received from test client #958.	3 years 23 weeks ago
4333678	Requested by test client #958.	3 years 23 weeks ago
4333673	Requested by test client #953.	3 years 23 weeks ago
4333668	Test request received.	3 years 23 weeks ago

SummaryFAILED: [[Coder]]: [Code review] 35 minor(s), 0 critical(s), and 30 normal(s); [[SimpleTest]]: [MySQL] 21 pass(es), 13 fail(s), and 3 exception(s).

Details

MySQL
Code review

MySQL

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a Drupal installation failure
Detect a test run failure
Detect a failing test
Review the test failures below then if necessary run them locally until the problem has been fixed.
Complete test suite with all tests passing

21 pass(es), 13 fail(s), and 3 exception(s)

Non-pass

Test name

Pass

Fail

Exception

Redis variables (RedisAdminVariableTestCase) [Redis]

Message	Group	Filename	Line	Function
Failed to set field connection[redis_client_base] to	Other	admin_variables.test	32	RedisAdminVariableTestCase->testSave()
Failed to set field connection[redis_client_port] to 1234	Other	admin_variables.test	32	RedisAdminVariableTestCase->testSave()
Failed to set field connection[redis_client_host] to localhost	Other	admin_variables.test	32	RedisAdminVariableTestCase->testSave()
Failed to set field connection[redis_client_interface] to	Other	admin_variables.test	32	RedisAdminVariableTestCase->testSave()
Found the requested form fields at admin/config/development/performance/redis	Other	admin_variables.test	32	RedisAdminVariableTestCase->testSave()
Undefined index: redis_client_post	Notice	admin_variables.test	40	RedisAdminVariableTestCase->testSave()
Saved int is an int	Other	admin_variables.test	40	RedisAdminVariableTestCase->testSave()
Undefined index: redis_client_host	Notice	admin_variables.test	41	RedisAdminVariableTestCase->testSave()
Saved string is a string	Other	admin_variables.test	41	RedisAdminVariableTestCase->testSave()
Failed to set field connection[redis_client_base] to 0	Other	admin_variables.test	50	RedisAdminVariableTestCase->testSave()
Failed to set field connection[redis_client_port] to 1234	Other	admin_variables.test	50	RedisAdminVariableTestCase->testSave()
Failed to set field connection[redis_client_host] to localhost	Other	admin_variables.test	50	RedisAdminVariableTestCase->testSave()
Failed to set field connection[redis_client_interface] to	Other	admin_variables.test	50	RedisAdminVariableTestCase->testSave()
Found the requested form fields at admin/config/development/performance/redis	Other	admin_variables.test	50	RedisAdminVariableTestCase->testSave()
Undefined index: redis_client_base	Notice	admin_variables.test	56	RedisAdminVariableTestCase->testSave()
Saved 0 valueed int is an int	Other	admin_variables.test	56	RedisAdminVariableTestCase->testSave()

All

Test name

Pass

Fail

Exception

Redis variables (RedisAdminVariableTestCase) [Redis]

Message	Group	Filename	Line	Function
Failed to set field connection[redis_client_base] to	Other	admin_variables.test	32	RedisAdminVariableTestCase->testSave()
Failed to set field connection[redis_client_port] to 1234	Other	admin_variables.test	32	RedisAdminVariableTestCase->testSave()
Failed to set field connection[redis_client_host] to localhost	Other	admin_variables.test	32	RedisAdminVariableTestCase->testSave()
Failed to set field connection[redis_client_interface] to	Other	admin_variables.test	32	RedisAdminVariableTestCase->testSave()
Found the requested form fields at admin/config/development/performance/redis	Other	admin_variables.test	32	RedisAdminVariableTestCase->testSave()
Undefined index: redis_client_post	Notice	admin_variables.test	40	RedisAdminVariableTestCase->testSave()
Saved int is an int	Other	admin_variables.test	40	RedisAdminVariableTestCase->testSave()
Undefined index: redis_client_host	Notice	admin_variables.test	41	RedisAdminVariableTestCase->testSave()
Saved string is a string	Other	admin_variables.test	41	RedisAdminVariableTestCase->testSave()
Failed to set field connection[redis_client_base] to 0	Other	admin_variables.test	50	RedisAdminVariableTestCase->testSave()
Failed to set field connection[redis_client_port] to 1234	Other	admin_variables.test	50	RedisAdminVariableTestCase->testSave()
Failed to set field connection[redis_client_host] to localhost	Other	admin_variables.test	50	RedisAdminVariableTestCase->testSave()
Failed to set field connection[redis_client_interface] to	Other	admin_variables.test	50	RedisAdminVariableTestCase->testSave()
Found the requested form fields at admin/config/development/performance/redis	Other	admin_variables.test	50	RedisAdminVariableTestCase->testSave()
Undefined index: redis_client_base	Notice	admin_variables.test	56	RedisAdminVariableTestCase->testSave()
Saved 0 valueed int is an int	Other	admin_variables.test	56	RedisAdminVariableTestCase->testSave()

Review log

Code review

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a review run failure
Detect coder flags
Ensure that your code follows the Drupal standard and passes a coder review.
Complete coder review with all passed

35 minor(s), 0 critical(s), and 30 normal(s)

Non-pass

Test name

Minor

Critical

Normal

lib/Redis/Cache.php

Message	Group	Filename	Line	Function	Status
@file block missing (Drupal Docs)	Other	Cache.php	-1	N/A

lib/Redis/Cache/Base.php

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	Base.php	-1	N/A
There should be no trailing spaces	Other	Base.php	16	N/A
There should be no trailing spaces	Other	Base.php	18	N/A
else statements should begin on a new line	Other	Base.php	25	N/A
else statements should begin on a new line	Other	Base.php	37	N/A
else statements should begin on a new line	Other	Base.php	42	N/A
else statements should begin on a new line	Other	Base.php	46	N/A
else statements should begin on a new line	Other	Base.php	65	N/A

lib/Redis/Cache/PhpRedis.php

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	PhpRedis.php	-1	N/A
Use "elseif" in place of "else if"	Other	PhpRedis.php	110	N/A
Use "elseif" in place of "else if"	Other	PhpRedis.php	114	N/A

lib/Redis/Cache/Predis.php

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	Predis.php	-1	N/A
Functions should be called with no spaces between the function name and opening parentheses	Other	Predis.php	33	N/A
Functions should be called with no spaces between the function name and opening parentheses	Other	Predis.php	65	N/A
Use "elseif" in place of "else if"	Other	Predis.php	110	N/A
Use "elseif" in place of "else if"	Other	Predis.php	114	N/A

lib/Redis/Client.php

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	Client.php	-1	N/A
There should be no trailing spaces	Other	Client.php	80	N/A
There should be no trailing spaces	Other	Client.php	84	N/A
There should be no trailing spaces	Other	Client.php	107	N/A
There should be no trailing spaces	Other	Client.php	115	N/A
There should be no trailing spaces	Other	Client.php	135	N/A
There should be no trailing spaces	Other	Client.php	140	N/A
There should be no trailing spaces	Other	Client.php	143	N/A

lib/Redis/Client/Interface.php

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	Interface.php	-1	N/A
There should be no trailing spaces	Other	Interface.php	9	N/A
There should be no trailing spaces	Other	Interface.php	17	N/A
There should be no trailing spaces	Other	Interface.php	20	N/A

lib/Redis/Client/PhpRedis.php

Message	Group	Filename	Line	Function	Status
@file block missing (Drupal Docs)	Other	PhpRedis.php	-1	N/A

lib/Redis/Client/Predis.php

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	Predis.php	-1	N/A
There should be no trailing spaces	Other	Predis.php	12	N/A
There should be no trailing spaces	Other	Predis.php	23	N/A
else statements should begin on a new line	Other	Predis.php	26	N/A
There should be no trailing spaces	Other	Predis.php	30	N/A
else statements should begin on a new line	Other	Predis.php	33	N/A

lib/Redis/Lock.php

Message	Group	Filename	Line	Function	Status
@file block missing (Drupal Docs)	Other	Lock.php	-1	N/A
There should be no trailing spaces	Other	Lock.php	14	N/A

lib/Redis/Lock/Backend/Default.php

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	Default.php	-1	N/A
There should be no trailing spaces	Other	Default.php	9	N/A
There should be no trailing spaces	Other	Default.php	16	N/A
There should be no trailing spaces	Other	Default.php	23	N/A
@see should always be followed by a filename, a URL, class/interface name (optionally including method), or a function name including ().	Other	Default.php	24	N/A
There should be no trailing spaces	Other	Default.php	64	N/A
@see should always be followed by a filename, a URL, class/interface name (optionally including method), or a function name including ().	Other	Default.php	65	N/A

lib/Redis/Lock/Backend/Interface.php

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	Interface.php	-1	N/A
There should be no trailing spaces	Other	Interface.php	9	N/A
There should be no trailing spaces	Other	Interface.php	14	N/A
There should be no trailing spaces	Other	Interface.php	21	N/A
There should be no trailing spaces	Other	Interface.php	24	N/A
There should be no trailing spaces	Other	Interface.php	31	N/A
There should be no trailing spaces	Other	Interface.php	41	N/A
There should be no trailing spaces	Other	Interface.php	48	N/A
There should be no trailing spaces	Other	Interface.php	57	N/A

lib/Redis/Lock/Backend/PhpRedis.php

Message	Group	Filename	Line	Function	Status
@file block missing (Drupal Docs)	Other	PhpRedis.php	-1	N/A

lib/Redis/Lock/Backend/Predis.php

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	Predis.php	-1	N/A
Functions should be called with no spaces between the function name and opening parentheses	Other	Predis.php	35	N/A
Functions should be called with no spaces between the function name and opening parentheses	Other	Predis.php	58	N/A

redis.admin.inc

Message	Group	Filename	Line	Function	Status
else statements should begin on a new line	Other	redis.admin.inc	94	N/A

tests/admin_variables.test

Message	Group	Filename	Line	Function	Status
@file block missing (Drupal Docs)	Other	admin_variables.test	-1	N/A

All

Test name

Minor

Critical

Normal

lib/Redis/Cache.php

Message	Group	Filename	Line	Function	Status
@file block missing (Drupal Docs)	Other	Cache.php	-1	N/A

lib/Redis/Cache/Base.php

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	Base.php	-1	N/A
There should be no trailing spaces	Other	Base.php	16	N/A
There should be no trailing spaces	Other	Base.php	18	N/A
else statements should begin on a new line	Other	Base.php	25	N/A
else statements should begin on a new line	Other	Base.php	37	N/A
else statements should begin on a new line	Other	Base.php	42	N/A
else statements should begin on a new line	Other	Base.php	46	N/A
else statements should begin on a new line	Other	Base.php	65	N/A

lib/Redis/Cache/PhpRedis.php

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	PhpRedis.php	-1	N/A
Use "elseif" in place of "else if"	Other	PhpRedis.php	110	N/A
Use "elseif" in place of "else if"	Other	PhpRedis.php	114	N/A

lib/Redis/Cache/Predis.php

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	Predis.php	-1	N/A
Functions should be called with no spaces between the function name and opening parentheses	Other	Predis.php	33	N/A
Functions should be called with no spaces between the function name and opening parentheses	Other	Predis.php	65	N/A
Use "elseif" in place of "else if"	Other	Predis.php	110	N/A
Use "elseif" in place of "else if"	Other	Predis.php	114	N/A

lib/Redis/Client.php

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	Client.php	-1	N/A
There should be no trailing spaces	Other	Client.php	80	N/A
There should be no trailing spaces	Other	Client.php	84	N/A
There should be no trailing spaces	Other	Client.php	107	N/A
There should be no trailing spaces	Other	Client.php	115	N/A
There should be no trailing spaces	Other	Client.php	135	N/A
There should be no trailing spaces	Other	Client.php	140	N/A
There should be no trailing spaces	Other	Client.php	143	N/A

lib/Redis/Client/Interface.php

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	Interface.php	-1	N/A
There should be no trailing spaces	Other	Interface.php	9	N/A
There should be no trailing spaces	Other	Interface.php	17	N/A
There should be no trailing spaces	Other	Interface.php	20	N/A

lib/Redis/Client/PhpRedis.php

Message	Group	Filename	Line	Function	Status
@file block missing (Drupal Docs)	Other	PhpRedis.php	-1	N/A

lib/Redis/Client/Predis.php

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	Predis.php	-1	N/A
There should be no trailing spaces	Other	Predis.php	12	N/A
There should be no trailing spaces	Other	Predis.php	23	N/A
else statements should begin on a new line	Other	Predis.php	26	N/A
There should be no trailing spaces	Other	Predis.php	30	N/A
else statements should begin on a new line	Other	Predis.php	33	N/A

lib/Redis/Lock.php

Message	Group	Filename	Line	Function	Status
@file block missing (Drupal Docs)	Other	Lock.php	-1	N/A
There should be no trailing spaces	Other	Lock.php	14	N/A

lib/Redis/Lock/Backend/Default.php

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	Default.php	-1	N/A
There should be no trailing spaces	Other	Default.php	9	N/A
There should be no trailing spaces	Other	Default.php	16	N/A
There should be no trailing spaces	Other	Default.php	23	N/A
@see should always be followed by a filename, a URL, class/interface name (optionally including method), or a function name including ().	Other	Default.php	24	N/A
There should be no trailing spaces	Other	Default.php	64	N/A
@see should always be followed by a filename, a URL, class/interface name (optionally including method), or a function name including ().	Other	Default.php	65	N/A

lib/Redis/Lock/Backend/Interface.php

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	Interface.php	-1	N/A
There should be no trailing spaces	Other	Interface.php	9	N/A
There should be no trailing spaces	Other	Interface.php	14	N/A
There should be no trailing spaces	Other	Interface.php	21	N/A
There should be no trailing spaces	Other	Interface.php	24	N/A
There should be no trailing spaces	Other	Interface.php	31	N/A
There should be no trailing spaces	Other	Interface.php	41	N/A
There should be no trailing spaces	Other	Interface.php	48	N/A
There should be no trailing spaces	Other	Interface.php	57	N/A

lib/Redis/Lock/Backend/PhpRedis.php

Message	Group	Filename	Line	Function	Status
@file block missing (Drupal Docs)	Other	PhpRedis.php	-1	N/A

lib/Redis/Lock/Backend/Predis.php

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	Predis.php	-1	N/A
Functions should be called with no spaces between the function name and opening parentheses	Other	Predis.php	35	N/A
Functions should be called with no spaces between the function name and opening parentheses	Other	Predis.php	58	N/A

redis.admin.inc

Message	Group	Filename	Line	Function	Status
else statements should begin on a new line	Other	redis.admin.inc	94	N/A

redis.autoload.inc

redis.install

redis.lock.inc

Message	Group	Filename	Line	Function	Status
There should be no trailing spaces	Other	redis.lock.inc	6	N/A
There should be no trailing spaces	Other	redis.lock.inc	9	N/A

redis.module

Message	Group	Filename	Line	Function
There should be no trailing spaces	Other	redis.module	6	N/A
There should be no trailing spaces	Other	redis.module	41	N/A
There should be no trailing spaces	Other	redis.module	42	N/A

tests/admin_variables.test

Message	Group	Filename	Line	Function	Status
@file block missing (Drupal Docs)	Other	admin_variables.test	-1	N/A

Review log