FAQ_Ask - 7.x-1.0-alpha1

Test status
StatusResult
Last receivedMon, 09/03/2012 - 08:13:05
Last requestedMon, 09/03/2012 - 08:14:04
Last testedMon, 09/03/2012 - 08:15:07
Test count2
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier7.x-1.0-alpha1
ProjectFAQ_Ask
LinkProject information
SummaryPASSED: [[Coder]]: [Code review] 48 minor(s), 1 critical(s), and 2 normal(s); [[SimpleTest]]: [MySQL] 971 pass(es).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing
971 pass(es), 0 fail(s), and 0 exception(s)
Test namePassFailException
LeafAccess to FAQ pages (Faq_AskAccessTestClass) [FAQ-Ask]9800
LeafAsk a Question Block (BlockFaq_AskTestCase) [FAQ-Ask]28200
LeafCRAUD Unanswered Question (CRAUDFaq_AskTestCase) [FAQ-Ask]32700
LeafCreate FAQ node (CreateFaq_AskTestCase) [FAQ-Ask]17700
LeafDoes FAQ page exist? (FaqExistsFaq_AskTestCase) [FAQ-Ask]8700

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
48 minor(s), 1 critical(s), and 2 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandfaq-ask-unanswered-block.tpl.php201
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherfaq-ask-unanswered-block.tpl.php28N/A
There should be no trailing spacesOtherfaq-ask-unanswered-block.tpl.php30N/A
the final ?> should be omitted from all code filesOtherfaq-ask-unanswered-block.tpl.php46N/A
Expandfaq_ask.install101
MessageGroupFilenameLineFunctionStatus
Use update_sql() instead of db_query() in hook_update_N()Otherfaq_ask.install131N/A
Use an indent of 2 spaces, with no tabsOtherfaq_ask.install207N/A
Expandfaq_ask.module2810
MessageGroupFilenameLineFunctionStatus
indent secondary line of comment one space Otherfaq_ask.module140N/A
Use an indent of 2 spaces, with no tabsOtherfaq_ask.module277N/A
Use an indent of 2 spaces, with no tabsOtherfaq_ask.module278N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherfaq_ask.module369N/A
Missing periodOtherfaq_ask.module434N/A
Use an indent of 2 spaces, with no tabsOtherfaq_ask.module593N/A
Use an indent of 2 spaces, with no tabsOtherfaq_ask.module594N/A
Use an indent of 2 spaces, with no tabsOtherfaq_ask.module595N/A
Use an indent of 2 spaces, with no tabsOtherfaq_ask.module597N/A
Use an indent of 2 spaces, with no tabsOtherfaq_ask.module599N/A
Use an indent of 2 spaces, with no tabsOtherfaq_ask.module600N/A
Use an indent of 2 spaces, with no tabsOtherfaq_ask.module601N/A
Use an indent of 2 spaces, with no tabsOtherfaq_ask.module602N/A
Use an indent of 2 spaces, with no tabsOtherfaq_ask.module603N/A
Use an indent of 2 spaces, with no tabsOtherfaq_ask.module605N/A
Use an indent of 2 spaces, with no tabsOtherfaq_ask.module607N/A
Use an indent of 2 spaces, with no tabsOtherfaq_ask.module608N/A
Use an indent of 2 spaces, with no tabsOtherfaq_ask.module609N/A
Potential problem: drupal_set_title() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherfaq_ask.module801N/A
indent secondary line of comment one space Otherfaq_ask.module979N/A
put a space between the asterisk and the comment textOtherfaq_ask.module1113N/A
indent secondary line of comment one space Otherfaq_ask.module1249N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherfaq_ask.module1395N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherfaq_ask.module1620N/A
Use an indent of 2 spaces, with no tabsOtherfaq_ask.module1622N/A
Missing periodOtherfaq_ask.module1705N/A
Format should be * Implementation of hook_foo().Otherfaq_ask.module1743N/A
Missing periodOtherfaq_ask.module1759N/A
Missing periodOtherfaq_ask.module1775N/A

All

Test nameMinorCriticalNormal
Expandfaq-ask-unanswered-block.tpl.php201
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherfaq-ask-unanswered-block.tpl.php28N/A
There should be no trailing spacesOtherfaq-ask-unanswered-block.tpl.php30N/A
the final ?> should be omitted from all code filesOtherfaq-ask-unanswered-block.tpl.php46N/A
Leaffaq-ask-unanswered.tpl.php000
Expandfaq_ask.install101
MessageGroupFilenameLineFunctionStatus
Use update_sql() instead of db_query() in hook_update_N()Otherfaq_ask.install131N/A
Use an indent of 2 spaces, with no tabsOtherfaq_ask.install207N/A
Expandfaq_ask.module2810
MessageGroupFilenameLineFunctionStatus
indent secondary line of comment one space Otherfaq_ask.module140N/A
Use an indent of 2 spaces, with no tabsOtherfaq_ask.module277N/A
Use an indent of 2 spaces, with no tabsOtherfaq_ask.module278N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherfaq_ask.module369N/A
Missing periodOtherfaq_ask.module434N/A
Use an indent of 2 spaces, with no tabsOtherfaq_ask.module593N/A
Use an indent of 2 spaces, with no tabsOtherfaq_ask.module594N/A
Use an indent of 2 spaces, with no tabsOtherfaq_ask.module595N/A
Use an indent of 2 spaces, with no tabsOtherfaq_ask.module597N/A
Use an indent of 2 spaces, with no tabsOtherfaq_ask.module599N/A
Use an indent of 2 spaces, with no tabsOtherfaq_ask.module600N/A
Use an indent of 2 spaces, with no tabsOtherfaq_ask.module601N/A
Use an indent of 2 spaces, with no tabsOtherfaq_ask.module602N/A
Use an indent of 2 spaces, with no tabsOtherfaq_ask.module603N/A
Use an indent of 2 spaces, with no tabsOtherfaq_ask.module605N/A
Use an indent of 2 spaces, with no tabsOtherfaq_ask.module607N/A
Use an indent of 2 spaces, with no tabsOtherfaq_ask.module608N/A
Use an indent of 2 spaces, with no tabsOtherfaq_ask.module609N/A
Potential problem: drupal_set_title() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherfaq_ask.module801N/A
indent secondary line of comment one space Otherfaq_ask.module979N/A
put a space between the asterisk and the comment textOtherfaq_ask.module1113N/A
indent secondary line of comment one space Otherfaq_ask.module1249N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherfaq_ask.module1395N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherfaq_ask.module1620N/A
Use an indent of 2 spaces, with no tabsOtherfaq_ask.module1622N/A
Missing periodOtherfaq_ask.module1705N/A
Format should be * Implementation of hook_foo().Otherfaq_ask.module1743N/A
Missing periodOtherfaq_ask.module1759N/A
Missing periodOtherfaq_ask.module1775N/A
Expandfaq_ask.test200
MessageGroupFilenameLineFunctionStatus
in most cases, replace the string function with the drupal_ equivalent string functionsOtherfaq_ask.test185N/A
indent secondary line of comment one space Otherfaq_ask.test762N/A
Expandfaq_ask.unanswered.inc1500
MessageGroupFilenameLineFunctionStatus
indent secondary line of comment one space Otherfaq_ask.unanswered.inc3N/A
indent secondary line of comment one space Otherfaq_ask.unanswered.inc4N/A
indent secondary line of comment one space Otherfaq_ask.unanswered.inc5N/A
indent secondary line of comment one space Otherfaq_ask.unanswered.inc33N/A
indent secondary line of comment one space Otherfaq_ask.unanswered.inc34N/A
indent secondary line of comment one space Otherfaq_ask.unanswered.inc35N/A
indent secondary line of comment one space Otherfaq_ask.unanswered.inc36N/A
indent secondary line of comment one space Otherfaq_ask.unanswered.inc37N/A
indent secondary line of comment one space Otherfaq_ask.unanswered.inc38N/A
indent secondary line of comment one space Otherfaq_ask.unanswered.inc39N/A
indent secondary line of comment one space Otherfaq_ask.unanswered.inc60N/A
indent secondary line of comment one space Otherfaq_ask.unanswered.inc61N/A
indent secondary line of comment one space Otherfaq_ask.unanswered.inc62N/A
indent secondary line of comment one space Otherfaq_ask.unanswered.inc63N/A
indent secondary line of comment one space Otherfaq_ask.unanswered.inc64N/A