Controller - 7.x-1.0-alpha4

Test status
StatusResult
Last receivedWed, 08/22/2012 - 18:42:30
Last requestedWed, 08/22/2012 - 18:43:01
Last testedWed, 08/22/2012 - 18:45:50
Test count2
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier7.x-1.0-alpha4
ProjectController
LinkProject information
SummaryPASSED: [[Coder]]: [Code review] 4 minor(s), 1 critical(s), and 9 normal(s); [[SimpleTest]]: [MySQL] 5 pass(es).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing
5 pass(es), 0 fail(s), and 0 exception(s)
Test namePassFailException
LeafControllerDefaultMenuItemNormalizerTest (ControllerDefaultMenuItemNormalizerTest) [MVC]200
LeafControllerMenuItemNormalizerTest (ControllerMenuItemNormalizerTest) [MVC]100
LeafControllerMenuItemsCollectorTest (ControllerMenuItemsCollectorTest) [MVC]100
LeafControllerPhpDocParserTest (ControllerPhpDocParserTest) [MVC]100

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
4 minor(s), 1 critical(s), and 9 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandlib/DefaultMenuItemNormalizer.php001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)OtherDefaultMenuItemNormalizer.php-1N/A
Expandlib/MenuItemNormalizerInterface.php001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)OtherMenuItemNormalizerInterface.php-1N/A
Expandlib/MenuItemsCollector.php110
MessageGroupFilenameLineFunctionStatus
in most cases, replace the string function with the drupal_ equivalent string functionsOtherMenuItemsCollector.php39N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.OtherMenuItemsCollector.php61N/A
Expandlib/MethodDocParser.php201
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)OtherMethodDocParser.php-1N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherMethodDocParser.php45N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherMethodDocParser.php46N/A
Expandlib/ParserInterface.php001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)OtherParserInterface.php-1N/A
Expandlib/StubMenuItemNormalizer.php001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)OtherStubMenuItemNormalizer.php-1N/A
Expandtests/DefaultMenuItemNormalizer.test001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)OtherDefaultMenuItemNormalizer.test-1N/A
Expandtests/MenuItemNormalizer.test001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)OtherMenuItemNormalizer.test-1N/A
Expandtests/MenuItemsCollector.test001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)OtherMenuItemsCollector.test-1N/A
Expandtests/PhpDocParser.test001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)OtherPhpDocParser.test-1N/A

All

Test nameMinorCriticalNormal
Leafcontroller.api.php000
Leafcontroller.module000
Leafcontrollers/SettingsController.php000
Leafforms/export_form.inc000
Leafforms/settings_form.inc000
Leaflib/CodeFormatter.php000
Expandlib/DefaultMenuItemNormalizer.php001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)OtherDefaultMenuItemNormalizer.php-1N/A
Expandlib/MenuItemNormalizer.php100
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherMenuItemNormalizer.php45N/A
Expandlib/MenuItemNormalizerInterface.php001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)OtherMenuItemNormalizerInterface.php-1N/A
Expandlib/MenuItemsCollector.php110
MessageGroupFilenameLineFunctionStatus
in most cases, replace the string function with the drupal_ equivalent string functionsOtherMenuItemsCollector.php39N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.OtherMenuItemsCollector.php61N/A
Expandlib/MethodDocParser.php201
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)OtherMethodDocParser.php-1N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherMethodDocParser.php45N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherMethodDocParser.php46N/A
Expandlib/ParserInterface.php001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)OtherParserInterface.php-1N/A
Expandlib/StubMenuItemNormalizer.php001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)OtherStubMenuItemNormalizer.php-1N/A
Expandtests/DefaultMenuItemNormalizer.test001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)OtherDefaultMenuItemNormalizer.test-1N/A
Expandtests/MenuItemNormalizer.test001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)OtherMenuItemNormalizer.test-1N/A
Expandtests/MenuItemsCollector.test001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)OtherMenuItemsCollector.test-1N/A
Expandtests/PhpDocParser.test001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)OtherPhpDocParser.test-1N/A
Leaftests/TestCase.php000
Leaftests/_files/MyBarController.php000
Leaftests/_files/MyFooController.php000