SoundManager2 - 7.x-2.x

Test status
StatusResult
Last receivedTue, 08/21/2012 - 02:20:15
Last requestedTue, 08/21/2012 - 02:21:03
Last testedTue, 08/21/2012 - 02:21:27
Test count2
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier7.x-2.x
ProjectSoundManager2
LinkProject information
SummaryPASSED: [[Coder]]: [Code review] 6 minor(s), 0 critical(s), and 8 normal(s); [[SimpleTest]]: [MySQL] 0 pass(es).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
6 minor(s), 0 critical(s), and 8 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandsoundmanager2-ui360.tpl.php001
MessageGroupFilenameLineFunctionStatus
the final ?> should be omitted from all code filesOthersoundmanager2-ui360.tpl.php17N/A
Expandsoundmanager2.install003
MessageGroupFilenameLineFunctionStatus
Use "elseif" in place of "else if"Othersoundmanager2.install39N/A
Use update_sql() instead of db_query() in hook_update_N()Othersoundmanager2.install54N/A
Use update_sql() instead of db_query() in hook_update_N()Othersoundmanager2.install55N/A
Expandsoundmanager2.module604
MessageGroupFilenameLineFunctionStatus
Format should be * Implementation of hook_foo().Othersoundmanager2.module108N/A
put a space between the asterisk and the comment textOthersoundmanager2.module229N/A
There should be no trailing spacesOthersoundmanager2.module289N/A
Use an indent of 2 spaces, with no tabsOthersoundmanager2.module301N/A
Use "elseif" in place of "else if"Othersoundmanager2.module400N/A
There should be no trailing spacesOthersoundmanager2.module404N/A
else statements should begin on a new lineOthersoundmanager2.module406N/A
Use "elseif" in place of "else if"Othersoundmanager2.module413N/A
There should be no trailing spacesOthersoundmanager2.module420N/A
Use an indent of 2 spaces, with no tabsOthersoundmanager2.module479N/A

All

Test nameMinorCriticalNormal
Leafsoundmanager2-inline-player.tpl.php000
Leafsoundmanager2-page-player.tpl.php000
Expandsoundmanager2-ui360.tpl.php001
MessageGroupFilenameLineFunctionStatus
the final ?> should be omitted from all code filesOthersoundmanager2-ui360.tpl.php17N/A
Expandsoundmanager2.install003
MessageGroupFilenameLineFunctionStatus
Use "elseif" in place of "else if"Othersoundmanager2.install39N/A
Use update_sql() instead of db_query() in hook_update_N()Othersoundmanager2.install54N/A
Use update_sql() instead of db_query() in hook_update_N()Othersoundmanager2.install55N/A
Expandsoundmanager2.module604
MessageGroupFilenameLineFunctionStatus
Format should be * Implementation of hook_foo().Othersoundmanager2.module108N/A
put a space between the asterisk and the comment textOthersoundmanager2.module229N/A
There should be no trailing spacesOthersoundmanager2.module289N/A
Use an indent of 2 spaces, with no tabsOthersoundmanager2.module301N/A
Use "elseif" in place of "else if"Othersoundmanager2.module400N/A
There should be no trailing spacesOthersoundmanager2.module404N/A
else statements should begin on a new lineOthersoundmanager2.module406N/A
Use "elseif" in place of "else if"Othersoundmanager2.module413N/A
There should be no trailing spacesOthersoundmanager2.module420N/A
Use an indent of 2 spaces, with no tabsOthersoundmanager2.module479N/A