Hierarchical Select - 6.x-3.x | Drupal Quality Assurance

Latest changes

So Long and Thanks for all the Tests

1 week 2 days ago

Support

In case of troubles

check the FAQ. Please make sure you've tried the test locally.
search known testbot issues and then create a new issue if yours isn't there already. Please give a link to the test.

Test client logs

No clients to display.

Hierarchical Select - 6.x-3.x

Test status

Status	Result
Last received	Mon, 08/06/2012 - 20:50:15
Last requested	Mon, 08/06/2012 - 20:51:03
Last tested	Mon, 08/06/2012 - 20:52:24
Test count	2

Environment status

MySQL	fail
Code review	fail

Overall Result	fail

Branch information

Identifier	6.x-3.x
Project	Hierarchical Select
Link	Project information

Event logView entire log

ID	Message	Timestamp
4102488	Result retrieved by project client.	3 years 29 weeks ago
4102483	Result received from test client #659.	3 years 29 weeks ago
4102478	Result received from test client #664.	3 years 29 weeks ago
4102473	Requested by test client #664.	3 years 29 weeks ago
4102468	Requested by test client #659.	3 years 29 weeks ago
4102463	Test request received.	3 years 29 weeks ago

SummaryFAILED: [[Coder]]: [Code review] 35 minor(s), 11 critical(s), and 25 normal(s); [[SimpleTest]]: [MySQL] 25 pass(es), 13 fail(s), and 14 exception(s).

Details

MySQL
Code review

MySQL

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a Drupal installation failure
Detect a test run failure
Detect a failing test
Review the test failures below then if necessary run them locally until the problem has been fixed.
Complete test suite with all tests passing

25 pass(es), 13 fail(s), and 14 exception(s)

Non-pass

Test name

Pass

Fail

Exception

Internals (HierarchicalSelectInternals) [Hierarchical Select]

Message	Group	Filename	Line	Function
Undefined variable: special_items	Notice	hierarchical_select.module	1710	_hierarchical_select_hierarchy_generate()
Undefined variable: special_items	Notice	hierarchical_select.module	1783	_hierarchical_select_hierarchy_generate()
Hierarchy lineage is correct.	Other	internals.test	158	HierarchicalSelectInternals->testAllSettingsOff()
Hierarchy levels is correct.	Other	internals.test	158	HierarchicalSelectInternals->testAllSettingsOff()
Undefined variable: special_items	Notice	hierarchical_select.module	1783	_hierarchical_select_hierarchy_generate()
Hierarchy levels is correct.	Other	internals.test	175	HierarchicalSelectInternals->testAllSettingsOff()
Undefined variable: special_items	Notice	hierarchical_select.module	1783	_hierarchical_select_hierarchy_generate()
Hierarchy levels is correct.	Other	internals.test	183	HierarchicalSelectInternals->testAllSettingsOff()
Undefined variable: special_items	Notice	hierarchical_select.module	1783	_hierarchical_select_hierarchy_generate()
Hierarchy levels is correct.	Other	internals.test	210	HierarchicalSelectInternals->testAllSettingsOff()
Undefined variable: special_items	Notice	hierarchical_select.module	1783	_hierarchical_select_hierarchy_generate()
Hierarchy levels is correct.	Other	internals.test	229	HierarchicalSelectInternals->testAllSettingsOff()
Undefined variable: special_items	Notice	hierarchical_select.module	1783	_hierarchical_select_hierarchy_generate()
Hierarchy levels is correct.	Other	internals.test	245	HierarchicalSelectInternals->testAllSettingsOff()
Undefined variable: special_items	Notice	hierarchical_select.module	1710	_hierarchical_select_hierarchy_generate()
Undefined variable: special_items	Notice	hierarchical_select.module	1783	_hierarchical_select_hierarchy_generate()
Hierarchy levels is correct.	Other	internals.test	305	HierarchicalSelectInternals->testEnforceDeepest()
Undefined variable: special_items	Notice	hierarchical_select.module	1783	_hierarchical_select_hierarchy_generate()
Hierarchy levels is correct.	Other	internals.test	330	HierarchicalSelectInternals->testEnforceDeepest()
Undefined variable: special_items	Notice	hierarchical_select.module	1783	_hierarchical_select_hierarchy_generate()
Hierarchy levels is correct.	Other	internals.test	340	HierarchicalSelectInternals->testEnforceDeepest()
Undefined variable: special_items	Notice	hierarchical_select.module	1783	_hierarchical_select_hierarchy_generate()
Hierarchy levels is correct.	Other	internals.test	365	HierarchicalSelectInternals->testEnforceDeepest()
Undefined variable: special_items	Notice	hierarchical_select.module	1783	_hierarchical_select_hierarchy_generate()
Hierarchy levels is correct.	Other	internals.test	383	HierarchicalSelectInternals->testEnforceDeepest()
Undefined variable: special_items	Notice	hierarchical_select.module	1783	_hierarchical_select_hierarchy_generate()
Hierarchy levels is correct.	Other	internals.test	398	HierarchicalSelectInternals->testEnforceDeepest()

All

Test name

Pass

Fail

Exception

Internals (HierarchicalSelectInternals) [Hierarchical Select]

Message	Group	Filename	Line	Function
Undefined variable: special_items	Notice	hierarchical_select.module	1710	_hierarchical_select_hierarchy_generate()
Undefined variable: special_items	Notice	hierarchical_select.module	1783	_hierarchical_select_hierarchy_generate()
Hierarchy lineage is correct.	Other	internals.test	158	HierarchicalSelectInternals->testAllSettingsOff()
Hierarchy levels is correct.	Other	internals.test	158	HierarchicalSelectInternals->testAllSettingsOff()
Undefined variable: special_items	Notice	hierarchical_select.module	1783	_hierarchical_select_hierarchy_generate()
Hierarchy levels is correct.	Other	internals.test	175	HierarchicalSelectInternals->testAllSettingsOff()
Undefined variable: special_items	Notice	hierarchical_select.module	1783	_hierarchical_select_hierarchy_generate()
Hierarchy levels is correct.	Other	internals.test	183	HierarchicalSelectInternals->testAllSettingsOff()
Undefined variable: special_items	Notice	hierarchical_select.module	1783	_hierarchical_select_hierarchy_generate()
Hierarchy levels is correct.	Other	internals.test	210	HierarchicalSelectInternals->testAllSettingsOff()
Undefined variable: special_items	Notice	hierarchical_select.module	1783	_hierarchical_select_hierarchy_generate()
Hierarchy levels is correct.	Other	internals.test	229	HierarchicalSelectInternals->testAllSettingsOff()
Undefined variable: special_items	Notice	hierarchical_select.module	1783	_hierarchical_select_hierarchy_generate()
Hierarchy levels is correct.	Other	internals.test	245	HierarchicalSelectInternals->testAllSettingsOff()
Undefined variable: special_items	Notice	hierarchical_select.module	1710	_hierarchical_select_hierarchy_generate()
Undefined variable: special_items	Notice	hierarchical_select.module	1783	_hierarchical_select_hierarchy_generate()
Hierarchy levels is correct.	Other	internals.test	305	HierarchicalSelectInternals->testEnforceDeepest()
Undefined variable: special_items	Notice	hierarchical_select.module	1783	_hierarchical_select_hierarchy_generate()
Hierarchy levels is correct.	Other	internals.test	330	HierarchicalSelectInternals->testEnforceDeepest()
Undefined variable: special_items	Notice	hierarchical_select.module	1783	_hierarchical_select_hierarchy_generate()
Hierarchy levels is correct.	Other	internals.test	340	HierarchicalSelectInternals->testEnforceDeepest()
Undefined variable: special_items	Notice	hierarchical_select.module	1783	_hierarchical_select_hierarchy_generate()
Hierarchy levels is correct.	Other	internals.test	365	HierarchicalSelectInternals->testEnforceDeepest()
Undefined variable: special_items	Notice	hierarchical_select.module	1783	_hierarchical_select_hierarchy_generate()
Hierarchy levels is correct.	Other	internals.test	383	HierarchicalSelectInternals->testEnforceDeepest()
Undefined variable: special_items	Notice	hierarchical_select.module	1783	_hierarchical_select_hierarchy_generate()
Hierarchy levels is correct.	Other	internals.test	398	HierarchicalSelectInternals->testEnforceDeepest()

Review log

Code review

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a review run failure
Detect coder flags
Ensure that your code follows the Drupal standard and passes a coder review.
Complete coder review with all passed

35 minor(s), 11 critical(s), and 25 normal(s)

Non-pass

Test name

Minor

Critical

Normal

hierarchical_select.admin.inc

Message	Group	Filename	Line	Function	Status
Using eval() or drupal_eval() in your module's code could have a security risk if the PHP input provided to the function contains malicious code. (Drupal Docs)	Other	hierarchical_select.admin.inc	207	N/A

hierarchical_select.install

Message	Group	Filename	Line	Function
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.	Other	hierarchical_select.install	144	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)	Other	hierarchical_select.install	144	N/A
Use update_sql() instead of db_query() in hook_update_N()	Other	hierarchical_select.install	210	N/A

hierarchical_select.module

Message	Group	Filename	Line	Function
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	hierarchical_select.module	319	N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	hierarchical_select.module	324	N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	hierarchical_select.module	366	N/A
Use "elseif" in place of "else if"	Other	hierarchical_select.module	378	N/A
There should be no trailing spaces	Other	hierarchical_select.module	407	N/A
Use an indent of 2 spaces, with no tabs	Other	hierarchical_select.module	448	N/A
Use an indent of 2 spaces, with no tabs	Other	hierarchical_select.module	449	N/A
Use an indent of 2 spaces, with no tabs	Other	hierarchical_select.module	452	N/A
Use an indent of 2 spaces, with no tabs	Other	hierarchical_select.module	461	N/A
Use an indent of 2 spaces, with no tabs	Other	hierarchical_select.module	462	N/A
The $string argument to t() should not begin or end with a space. (Drupal Docs)	Other	hierarchical_select.module	479	N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	hierarchical_select.module	774	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	hierarchical_select.module	843	N/A
Potential problem: form_set_error() and form_error() only accept filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	hierarchical_select.module	844	N/A
Use "elseif" in place of "else if"	Other	hierarchical_select.module	1003	N/A
Use "elseif" in place of "else if"	Other	hierarchical_select.module	1022	N/A
Use an indent of 2 spaces, with no tabs	Other	hierarchical_select.module	1345	N/A
Use "elseif" in place of "else if"	Other	hierarchical_select.module	1820	N/A
Use an indent of 2 spaces, with no tabs	Other	hierarchical_select.module	1969	N/A
curly braces { should end a line, not start one	Other	hierarchical_select.module	1970	N/A
global variables should start with a single underscore followed by the module and another underscore	Other	hierarchical_select.module	2336	N/A
global variables should start with a single underscore followed by the module and another underscore	Other	hierarchical_select.module	2361	N/A

includes/common.inc

Message	Group	Filename	Line	Function
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	common.inc	154	N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	common.inc	170	N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	common.inc	301	N/A

modules/hs_content_taxonomy.admin.inc

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	hs_content_taxonomy.admin.inc	-1	N/A
The $text argument to l() should be enclosed within t() so that it is translatable.	Other	hs_content_taxonomy.admin.inc	63	N/A
Potential problem: when FAPI element '#type' is set to 'markup' (default), '#value' only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	hs_content_taxonomy.admin.inc	84	N/A

modules/hs_content_taxonomy.module

Message	Group	Filename	Line	Function
Menu item titles and descriptions should NOT be enclosed within t(). (Drupal Docs)	Other	hs_content_taxonomy.module	25	N/A
Missing period	Other	hs_content_taxonomy.module	52	N/A
There should be no trailing spaces	Other	hs_content_taxonomy.module	54	N/A
There should be no trailing spaces	Other	hs_content_taxonomy.module	59	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	hs_content_taxonomy.module	76	N/A
missing space after comma	Other	hs_content_taxonomy.module	84	N/A
missing space after comma	Other	hs_content_taxonomy.module	123	N/A
There should be no trailing spaces	Other	hs_content_taxonomy.module	179	N/A

modules/hs_taxonomy.module

Message	Group	Filename	Line	Function
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	hs_taxonomy.module	274	N/A
use stdClass caseCapitalization, it's the one exception to the mixed case style standard	Other	hs_taxonomy.module	385	N/A
Use "elseif" in place of "else if"	Other	hs_taxonomy.module	481	N/A
use a space between the closing parenthesis and the open bracket	Other	hs_taxonomy.module	551	N/A
SQL query handling data in a potentially insecure way by using the %%s placeholder without wrapping it in single quotes. This is a potential source of SQL injection attacks when the value can come from user data.	Other	hs_taxonomy.module	847	N/A

modules/hs_taxonomy_views.module

Message	Group	Filename	Line	Function
There should be no trailing spaces	Other	hs_taxonomy_views.module	48	N/A
curly braces { should end a line, not start one	Other	hs_taxonomy_views.module	62	N/A
There should be no trailing spaces	Other	hs_taxonomy_views.module	68	N/A
Use an indent of 2 spaces, with no tabs	Other	hs_taxonomy_views.module	200	N/A
Use an indent of 2 spaces, with no tabs	Other	hs_taxonomy_views.module	203	N/A
Use an indent of 2 spaces, with no tabs	Other	hs_taxonomy_views.module	207	N/A
Use an indent of 2 spaces, with no tabs	Other	hs_taxonomy_views.module	215	N/A
The $text argument to l() should be enclosed within t() so that it is translatable.	Other	hs_taxonomy_views.module	325	N/A
Potential problem: when FAPI element '#type' is set to 'markup' (default), '#value' only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	hs_taxonomy_views.module	351	N/A
use lowercase html tags to comply with XHTML	Other	hs_taxonomy_views.module	401	N/A
use lowercase html tags to comply with XHTML	Other	hs_taxonomy_views.module	432	N/A
Use an indent of 2 spaces, with no tabs	Other	hs_taxonomy_views.module	585	N/A
curly braces { should end a line, not start one	Other	hs_taxonomy_views.module	587	N/A
Use an indent of 2 spaces, with no tabs	Other	hs_taxonomy_views.module	605	N/A

modules/hs_taxonomy_views_handler_filter_term_node_tid.inc

Message	Group	Filename	Line	Function
table names should be enclosed in {curly_brackets}	Other	hs_taxonomy_views_handler_filter_term_node_tid.inc	67	N/A
Use an indent of 2 spaces, with no tabs	Other	hs_taxonomy_views_handler_filter_term_node_tid.inc	123	N/A
Use an indent of 2 spaces, with no tabs	Other	hs_taxonomy_views_handler_filter_term_node_tid.inc	127	N/A
Use an indent of 2 spaces, with no tabs	Other	hs_taxonomy_views_handler_filter_term_node_tid.inc	128	N/A

modules/hs_taxonomy_views_handler_filter_term_node_tid_depth.inc

Message	Group	Filename	Line	Function
Use "elseif" in place of "else if"	Other	hs_taxonomy_views_handler_filter_term_node_tid_depth.inc	40	N/A
Use "elseif" in place of "else if"	Other	hs_taxonomy_views_handler_filter_term_node_tid_depth.inc	55	N/A
Use "elseif" in place of "else if"	Other	hs_taxonomy_views_handler_filter_term_node_tid_depth.inc	79	N/A

All

Test name

Minor

Critical

Normal

hierarchical_select.admin.inc

Message	Group	Filename	Line	Function	Status
Using eval() or drupal_eval() in your module's code could have a security risk if the PHP input provided to the function contains malicious code. (Drupal Docs)	Other	hierarchical_select.admin.inc	207	N/A

hierarchical_select.features.inc

hierarchical_select.install

Message	Group	Filename	Line	Function
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.	Other	hierarchical_select.install	144	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)	Other	hierarchical_select.install	144	N/A
Use update_sql() instead of db_query() in hook_update_N()	Other	hierarchical_select.install	210	N/A

hierarchical_select.module

Message	Group	Filename	Line	Function
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	hierarchical_select.module	319	N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	hierarchical_select.module	324	N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	hierarchical_select.module	366	N/A
Use "elseif" in place of "else if"	Other	hierarchical_select.module	378	N/A
There should be no trailing spaces	Other	hierarchical_select.module	407	N/A
Use an indent of 2 spaces, with no tabs	Other	hierarchical_select.module	448	N/A
Use an indent of 2 spaces, with no tabs	Other	hierarchical_select.module	449	N/A
Use an indent of 2 spaces, with no tabs	Other	hierarchical_select.module	452	N/A
Use an indent of 2 spaces, with no tabs	Other	hierarchical_select.module	461	N/A
Use an indent of 2 spaces, with no tabs	Other	hierarchical_select.module	462	N/A
The $string argument to t() should not begin or end with a space. (Drupal Docs)	Other	hierarchical_select.module	479	N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	hierarchical_select.module	774	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	hierarchical_select.module	843	N/A
Potential problem: form_set_error() and form_error() only accept filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	hierarchical_select.module	844	N/A
Use "elseif" in place of "else if"	Other	hierarchical_select.module	1003	N/A
Use "elseif" in place of "else if"	Other	hierarchical_select.module	1022	N/A
Use an indent of 2 spaces, with no tabs	Other	hierarchical_select.module	1345	N/A
Use "elseif" in place of "else if"	Other	hierarchical_select.module	1820	N/A
Use an indent of 2 spaces, with no tabs	Other	hierarchical_select.module	1969	N/A
curly braces { should end a line, not start one	Other	hierarchical_select.module	1970	N/A
global variables should start with a single underscore followed by the module and another underscore	Other	hierarchical_select.module	2336	N/A
global variables should start with a single underscore followed by the module and another underscore	Other	hierarchical_select.module	2361	N/A

includes/common.inc

Message	Group	Filename	Line	Function
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	common.inc	154	N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	common.inc	170	N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	common.inc	301	N/A

includes/theme.inc

Message	Group	Filename	Line	Function	Status
Use an indent of 2 spaces, with no tabs	Other	theme.inc	80	N/A

modules/hs_content_taxonomy.admin.inc

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	hs_content_taxonomy.admin.inc	-1	N/A
The $text argument to l() should be enclosed within t() so that it is translatable.	Other	hs_content_taxonomy.admin.inc	63	N/A
Potential problem: when FAPI element '#type' is set to 'markup' (default), '#value' only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	hs_content_taxonomy.admin.inc	84	N/A

modules/hs_content_taxonomy.module

Message	Group	Filename	Line	Function
Menu item titles and descriptions should NOT be enclosed within t(). (Drupal Docs)	Other	hs_content_taxonomy.module	25	N/A
Missing period	Other	hs_content_taxonomy.module	52	N/A
There should be no trailing spaces	Other	hs_content_taxonomy.module	54	N/A
There should be no trailing spaces	Other	hs_content_taxonomy.module	59	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	hs_content_taxonomy.module	76	N/A
missing space after comma	Other	hs_content_taxonomy.module	84	N/A
missing space after comma	Other	hs_content_taxonomy.module	123	N/A
There should be no trailing spaces	Other	hs_content_taxonomy.module	179	N/A

modules/hs_flatlist.module

modules/hs_menu.module

Message	Group	Filename	Line	Function	Status
There should be no trailing spaces	Other	hs_menu.module	79	N/A
There should be no trailing spaces	Other	hs_menu.module	152	N/A

modules/hs_smallhierarchy.module

Message	Group	Filename	Line	Function	Status
There should be no trailing spaces	Other	hs_smallhierarchy.module	193	N/A

modules/hs_taxonomy.install

modules/hs_taxonomy.module

Message	Group	Filename	Line	Function
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	hs_taxonomy.module	274	N/A
use stdClass caseCapitalization, it's the one exception to the mixed case style standard	Other	hs_taxonomy.module	385	N/A
Use "elseif" in place of "else if"	Other	hs_taxonomy.module	481	N/A
use a space between the closing parenthesis and the open bracket	Other	hs_taxonomy.module	551	N/A
SQL query handling data in a potentially insecure way by using the %%s placeholder without wrapping it in single quotes. This is a potential source of SQL injection attacks when the value can come from user data.	Other	hs_taxonomy.module	847	N/A

modules/hs_taxonomy_views.install

Message	Group	Filename	Line	Function	Status
There should be no trailing spaces	Other	hs_taxonomy_views.install	27	N/A

modules/hs_taxonomy_views.module

Message	Group	Filename	Line	Function
There should be no trailing spaces	Other	hs_taxonomy_views.module	48	N/A
curly braces { should end a line, not start one	Other	hs_taxonomy_views.module	62	N/A
There should be no trailing spaces	Other	hs_taxonomy_views.module	68	N/A
Use an indent of 2 spaces, with no tabs	Other	hs_taxonomy_views.module	200	N/A
Use an indent of 2 spaces, with no tabs	Other	hs_taxonomy_views.module	203	N/A
Use an indent of 2 spaces, with no tabs	Other	hs_taxonomy_views.module	207	N/A
Use an indent of 2 spaces, with no tabs	Other	hs_taxonomy_views.module	215	N/A
The $text argument to l() should be enclosed within t() so that it is translatable.	Other	hs_taxonomy_views.module	325	N/A
Potential problem: when FAPI element '#type' is set to 'markup' (default), '#value' only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	hs_taxonomy_views.module	351	N/A
use lowercase html tags to comply with XHTML	Other	hs_taxonomy_views.module	401	N/A
use lowercase html tags to comply with XHTML	Other	hs_taxonomy_views.module	432	N/A
Use an indent of 2 spaces, with no tabs	Other	hs_taxonomy_views.module	585	N/A
curly braces { should end a line, not start one	Other	hs_taxonomy_views.module	587	N/A
Use an indent of 2 spaces, with no tabs	Other	hs_taxonomy_views.module	605	N/A

modules/hs_taxonomy_views_handler_filter_term_node_tid.inc

Message	Group	Filename	Line	Function
table names should be enclosed in {curly_brackets}	Other	hs_taxonomy_views_handler_filter_term_node_tid.inc	67	N/A
Use an indent of 2 spaces, with no tabs	Other	hs_taxonomy_views_handler_filter_term_node_tid.inc	123	N/A
Use an indent of 2 spaces, with no tabs	Other	hs_taxonomy_views_handler_filter_term_node_tid.inc	127	N/A
Use an indent of 2 spaces, with no tabs	Other	hs_taxonomy_views_handler_filter_term_node_tid.inc	128	N/A

modules/hs_taxonomy_views_handler_filter_term_node_tid_depth.inc

Message	Group	Filename	Line	Function
Use "elseif" in place of "else if"	Other	hs_taxonomy_views_handler_filter_term_node_tid_depth.inc	40	N/A
Use "elseif" in place of "else if"	Other	hs_taxonomy_views_handler_filter_term_node_tid_depth.inc	55	N/A
Use "elseif" in place of "else if"	Other	hs_taxonomy_views_handler_filter_term_node_tid_depth.inc	79	N/A

tests/internals.test

Review log

[13:51:02] Log initialized (/var/lib/drupaltestbot/sites/default/files/review.test_312038.pifr_coder.1344286262.log)
[13:51:02] Review timestamp: (Mon, 08/06/2012 - 13:51)
[13:51:02] Review host: (drupaltestbot664-mysql)
[13:51:02] Environment variables and review information initialized.
[13:51:02] core_url = [git://git.drupal.org/project/drupal.git];  Test repository = [git://git.drupal.org/project/hierarchical_select.git]
[13:51:02] Review started.
[13:51:02] Invoking operation [setup]...
[13:51:02] Command [chmod -R u+w sites/default/files/checkout 2>&1] succeeded.
[13:51:02] Command [rm -rf sites/default/files/checkout 2>&1] succeeded.
[13:51:02] Command [rm -rf sites/default/files/review 2>&1] succeeded.
[13:51:02] Database backend [mysql] loaded.
[13:51:02] Invoking operation [fetch]...
[13:51:02] Invoking operation [checkout]...
[13:51:02] Version control system backend [git] loaded.
[13:51:11] Command [git clone 'git://git.drupal.org/project/hierarchical_select.git' 'checkout' --reference /var/cache/git/reference 2>&1] succeeded.
[13:51:11] Command [git --work-tree='checkout' --git-dir='checkout/.git' checkout '6.x-3.x' 2>&1] succeeded.
[13:51:11] Command [git --work-tree='checkout' --git-dir='checkout/.git' status 2>&1] succeeded.
[13:51:11] Main branch [6.x-3.x] checkout [complete].
[13:51:11] Invoking operation [check]...
[13:51:11] Ignoring operation [check].
[13:51:11] Invoking operation [apply]...
[13:51:11] Ignoring operation [apply].
[13:51:11] Invoking operation [syntax]...
[13:51:11] Command [php -l -f './includes/common.inc' 2>&1] succeeded.
[13:51:11] Command [php -l -f './includes/theme.inc' 2>&1] succeeded.
[13:51:11] Command [php -l -f './modules/hs_taxonomy_views.install' 2>&1] succeeded.
[13:51:11] Command [php -l -f './modules/hs_taxonomy_views_handler_filter_term_node_tid_depth.inc' 2>&1] succeeded.
[13:51:12] Command [php -l -f './modules/hs_taxonomy.install' 2>&1] succeeded.
[13:51:12] Command [php -l -f './modules/hs_taxonomy_views.module' 2>&1] succeeded.
[13:51:12] Command [php -l -f './modules/hs_taxonomy_views_handler_filter_term_node_tid.inc' 2>&1] succeeded.
[13:51:12] Command [php -l -f './modules/hs_flatlist.module' 2>&1] succeeded.
[13:51:12] Command [php -l -f './modules/hs_smallhierarchy.module' 2>&1] succeeded.
[13:51:12] Command [php -l -f './modules/hs_taxonomy.module' 2>&1] succeeded.
[13:51:12] Command [php -l -f './modules/hs_content_taxonomy.admin.inc' 2>&1] succeeded.
[13:51:12] Command [php -l -f './modules/hs_menu.module' 2>&1] succeeded.
[13:51:12] Command [php -l -f './modules/hs_content_taxonomy.module' 2>&1] succeeded.
[13:51:12] Command [php -l -f './tests/internals.test' 2>&1] succeeded.
[13:51:12] Command [php -l -f './hierarchical_select.module' 2>&1] succeeded.
[13:51:12] Command [php -l -f './hierarchical_select.install' 2>&1] succeeded.
[13:51:12] Command [php -l -f './hierarchical_select.features.inc' 2>&1] succeeded.
[13:51:12] Command [php -l -f './hierarchical_select.admin.inc' 2>&1] succeeded.
[13:51:12] Checked [18 of 18] relevant file(s) for syntax.
[13:51:12] Invoking operation [review]...
[13:51:14] Reviewed [18 of 18] relevant file(s).  Ignored 0 files during the review.
[13:51:14] Review complete. test_id=312038 result code=8 details=Array
(
    [@pass] => 35
    [@fail] => 11
    [@exception] => 25
)

[13:51:14] Static variables reset.