Picasa Slideshow Input Filter - 7.x-1.0-alpha4

Test status
StatusResult
Last receivedSun, 08/05/2012 - 22:20:15
Last requestedSun, 08/05/2012 - 22:21:02
Last testedSun, 08/05/2012 - 22:21:33
Test count2
Environment status
MySQLfail
Code reviewfail
Overall Resultfail
Branch information
Identifier7.x-1.0-alpha4
ProjectPicasa Slideshow Input Filter
LinkProject information
SummaryFAILED: [[Coder]]: [Code review] 14 minor(s), 0 critical(s), and 11 normal(s); [[SimpleTest]]: [MySQL] 20 pass(es), 1 fail(s), and 0 exception(s).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
    Review the test failures below then if necessary run them locally until the problem has been fixed.
  10. Complete test suite with all tests passing
20 pass(es), 1 fail(s), and 0 exception(s)

Non-pass

Test namePassFailException
ExpandPicasa Slideshow Filter Tests (PicasaSlideshowFilterTestCase) [Input filters]2010
MessageGroupFilenameLineFunctionStatus
Raw "<embed type="application/x-shockwave-flash" src="https://picasaweb.google.com/s/c/bin/slideshow.swf" width="400" height="267" flashvars="host=picasaweb.google.com&amp;hl=en_US&amp;feat=flashalbum&amp;RGB=0x000000&amp;feed=https%3A%2F%2Fpicasaweb.google.com%2Fdata%2Ffeed%2Fapi%2Fuser%2Fvejleih%2Falbumid%2F5594661276816655633%3Falt%3Drss%26kind%3Dphoto%26hl%3DDen_US%26captions%3D%26noautoplay%3D1" pluginspage="http://www.macromedia.com/go/getflashplayer"> </embed>" foundOtherpicasa_slideshow_filter.test57PicasaSlideshowFilterTestCase->testEmbedStyle()

All

Test namePassFailException
ExpandPicasa Slideshow Filter Tests (PicasaSlideshowFilterTestCase) [Input filters]2010
MessageGroupFilenameLineFunctionStatus
Raw "<embed type="application/x-shockwave-flash" src="https://picasaweb.google.com/s/c/bin/slideshow.swf" width="400" height="267" flashvars="host=picasaweb.google.com&amp;hl=en_US&amp;feat=flashalbum&amp;RGB=0x000000&amp;feed=https%3A%2F%2Fpicasaweb.google.com%2Fdata%2Ffeed%2Fapi%2Fuser%2Fvejleih%2Falbumid%2F5594661276816655633%3Falt%3Drss%26kind%3Dphoto%26hl%3DDen_US%26captions%3D%26noautoplay%3D1" pluginspage="http://www.macromedia.com/go/getflashplayer"> </embed>" foundOtherpicasa_slideshow_filter.test57PicasaSlideshowFilterTestCase->testEmbedStyle()

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
14 minor(s), 0 critical(s), and 11 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandpicasa_slideshow_filter.install201
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherpicasa_slideshow_filter.install-1N/A
There should be no trailing spacesOtherpicasa_slideshow_filter.install10N/A
There should be no trailing spacesOtherpicasa_slideshow_filter.install11N/A
Expandpicasa_slideshow_filter.module1108
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherpicasa_slideshow_filter.module68N/A
else statements should begin on a new lineOtherpicasa_slideshow_filter.module73N/A
else statements should begin on a new lineOtherpicasa_slideshow_filter.module78N/A
else statements should begin on a new lineOtherpicasa_slideshow_filter.module84N/A
else statements should begin on a new lineOtherpicasa_slideshow_filter.module88N/A
There should be no trailing spacesOtherpicasa_slideshow_filter.module92N/A
There should be no trailing spacesOtherpicasa_slideshow_filter.module97N/A
There should be no trailing spacesOtherpicasa_slideshow_filter.module106N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherpicasa_slideshow_filter.module107N/A
There should be no trailing spacesOtherpicasa_slideshow_filter.module115N/A
There should be no trailing spacesOtherpicasa_slideshow_filter.module124N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherpicasa_slideshow_filter.module133N/A
There should be no trailing spacesOtherpicasa_slideshow_filter.module135N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherpicasa_slideshow_filter.module147N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherpicasa_slideshow_filter.module153N/A
There should be no trailing spacesOtherpicasa_slideshow_filter.module155N/A
There should be no trailing spacesOtherpicasa_slideshow_filter.module164N/A
There should be no trailing spacesOtherpicasa_slideshow_filter.module167N/A
There should be no trailing spacesOtherpicasa_slideshow_filter.module176N/A
Expandpicasa_slideshow_filter.test102
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherpicasa_slideshow_filter.test-1N/A
There should be no trailing spacesOtherpicasa_slideshow_filter.test36N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherpicasa_slideshow_filter.test51N/A

All

Test nameMinorCriticalNormal
Expandpicasa_slideshow_filter.install201
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherpicasa_slideshow_filter.install-1N/A
There should be no trailing spacesOtherpicasa_slideshow_filter.install10N/A
There should be no trailing spacesOtherpicasa_slideshow_filter.install11N/A
Expandpicasa_slideshow_filter.module1108
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherpicasa_slideshow_filter.module68N/A
else statements should begin on a new lineOtherpicasa_slideshow_filter.module73N/A
else statements should begin on a new lineOtherpicasa_slideshow_filter.module78N/A
else statements should begin on a new lineOtherpicasa_slideshow_filter.module84N/A
else statements should begin on a new lineOtherpicasa_slideshow_filter.module88N/A
There should be no trailing spacesOtherpicasa_slideshow_filter.module92N/A
There should be no trailing spacesOtherpicasa_slideshow_filter.module97N/A
There should be no trailing spacesOtherpicasa_slideshow_filter.module106N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherpicasa_slideshow_filter.module107N/A
There should be no trailing spacesOtherpicasa_slideshow_filter.module115N/A
There should be no trailing spacesOtherpicasa_slideshow_filter.module124N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherpicasa_slideshow_filter.module133N/A
There should be no trailing spacesOtherpicasa_slideshow_filter.module135N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherpicasa_slideshow_filter.module147N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherpicasa_slideshow_filter.module153N/A
There should be no trailing spacesOtherpicasa_slideshow_filter.module155N/A
There should be no trailing spacesOtherpicasa_slideshow_filter.module164N/A
There should be no trailing spacesOtherpicasa_slideshow_filter.module167N/A
There should be no trailing spacesOtherpicasa_slideshow_filter.module176N/A
Expandpicasa_slideshow_filter.test102
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherpicasa_slideshow_filter.test-1N/A
There should be no trailing spacesOtherpicasa_slideshow_filter.test36N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherpicasa_slideshow_filter.test51N/A