Internal Nodes - 7.x-1.2

Test status
StatusResult
Last receivedThu, 07/26/2012 - 20:13:15
Last requestedThu, 07/26/2012 - 20:15:20
Last testedThu, 07/26/2012 - 20:15:40
Test count2
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier7.x-1.2
ProjectInternal Nodes
LinkProject information
SummaryPASSED: [[Coder]]: [Code review] 0 minor(s), 2 critical(s), and 0 normal(s); [[SimpleTest]]: [MySQL] 208 pass(es).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing
208 pass(es), 0 fail(s), and 0 exception(s)
Test namePassFailException
LeafInternal nodes - Content Type Tests (InternalNodesTypeCase) [Internal nodes]10400
LeafInternal nodes - Node Tests (InternalNodesNodeCase) [Internal nodes]10400

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
0 minor(s), 2 critical(s), and 0 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandinternal_nodes.module020
MessageGroupFilenameLineFunctionStatus
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Otherinternal_nodes.module193N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otherinternal_nodes.module469N/A

All

Test nameMinorCriticalNormal
Leafinternal_nodes.admin.inc000
Leafinternal_nodes.install000
Expandinternal_nodes.module020
MessageGroupFilenameLineFunctionStatus
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Otherinternal_nodes.module193N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otherinternal_nodes.module469N/A
Leafinternal_nodes.rules.inc000
Leaftests/internal_nodes_ct.test000
Leaftests/internal_nodes_node.test000