Flag - 6.x-1.x

Test status
StatusResult
Last receivedMon, 01/14/2013 - 08:48:10
Last requestedMon, 01/14/2013 - 08:49:05
Last testedMon, 01/14/2013 - 08:49:59
Test count4
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier6.x-1.x
ProjectFlag
LinkProject information
SummaryPASSED: [[Coder]]: [Code review] 22 minor(s), 13 critical(s), and 5 normal(s); [[SimpleTest]]: [MySQL] 65 pass(es).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing
65 pass(es), 0 fail(s), and 0 exception(s)
Test namePassFailException
LeafFlagTestCase6500

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
22 minor(s), 13 critical(s), and 5 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandflag.inc531
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherflag.inc642N/A
There should be no trailing spacesOtherflag.inc649N/A
There should be no trailing spacesOtherflag.inc954N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Otherflag.inc975N/A
There should be no trailing spacesOtherflag.inc1079N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Otherflag.inc1100N/A
use a space between the closing parenthesis and the open bracketOtherflag.inc1153N/A
There should be no trailing spacesOtherflag.inc1193N/A
Potential problem: when FAPI element '#type' is set to 'markup' (default), '#value' only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherflag.inc1234N/A
Expandflag.install011
MessageGroupFilenameLineFunctionStatus
Use update_sql() instead of db_query() in hook_update_N()Otherflag.install386N/A
table names should be enclosed in {curly_brackets}Otherflag.install487N/A
Expandflag.module151
MessageGroupFilenameLineFunctionStatus
'Implementation' should be at the start of the sentence and begin with a capitialized letterOtherflag.module186N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherflag.module257N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherflag.module312N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherflag.module313N/A
use a space between the closing parenthesis and the open bracketOtherflag.module405N/A
Potential problem: confirm_form() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)Otherflag.module524N/A
Potential problem: confirm_form() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherflag.module524N/A
Expandflag_actions.module101
MessageGroupFilenameLineFunctionStatus
Use an indent of 2 spaces, with no tabsOtherflag_actions.module180N/A
Control statements should have one space between the control keyword and opening parenthesisOtherflag_actions.module358N/A
Expandincludes/flag.rules.inc510
MessageGroupFilenameLineFunctionStatus
@file description should be on the following line (Drupal Docs)Otherflag.rules.inc4N/A
There should be no trailing spacesOtherflag.rules.inc47N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherflag.rules.inc54N/A
There should be no trailing spacesOtherflag.rules.inc84N/A
There should be no trailing spacesOtherflag.rules.inc182N/A
There should be no trailing spacesOtherflag.rules.inc260N/A
Expandincludes/flag.views_bookmark.inc110
MessageGroupFilenameLineFunctionStatus
in most cases, replace the string function with the drupal_ equivalent string functionsOtherflag.views_bookmark.inc146N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otherflag.views_bookmark.inc148N/A
Expandincludes/flag_plugin_argument_validate_flaggability.inc020
MessageGroupFilenameLineFunctionStatus
In SQL strings, Use db_query() placeholders in place of variables. This is a potential source of SQL injection attacks when the variable can come from user data. (Drupal Docs)Otherflag_plugin_argument_validate_flaggability.inc205N/A
In SQL strings, Use db_query() placeholders in place of variables. This is a potential source of SQL injection attacks when the variable can come from user data. (Drupal Docs)Otherflag_plugin_argument_validate_flaggability.inc215N/A
Expandtests/flag.test301
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherflag.test-1N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherflag.test34N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherflag.test71N/A
There should be no trailing spacesOtherflag.test117N/A

All

Test nameMinorCriticalNormal
Expandflag.inc531
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherflag.inc642N/A
There should be no trailing spacesOtherflag.inc649N/A
There should be no trailing spacesOtherflag.inc954N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Otherflag.inc975N/A
There should be no trailing spacesOtherflag.inc1079N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Otherflag.inc1100N/A
use a space between the closing parenthesis and the open bracketOtherflag.inc1153N/A
There should be no trailing spacesOtherflag.inc1193N/A
Potential problem: when FAPI element '#type' is set to 'markup' (default), '#value' only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherflag.inc1234N/A
Expandflag.install011
MessageGroupFilenameLineFunctionStatus
Use update_sql() instead of db_query() in hook_update_N()Otherflag.install386N/A
table names should be enclosed in {curly_brackets}Otherflag.install487N/A
Expandflag.module151
MessageGroupFilenameLineFunctionStatus
'Implementation' should be at the start of the sentence and begin with a capitialized letterOtherflag.module186N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherflag.module257N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherflag.module312N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherflag.module313N/A
use a space between the closing parenthesis and the open bracketOtherflag.module405N/A
Potential problem: confirm_form() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)Otherflag.module524N/A
Potential problem: confirm_form() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherflag.module524N/A
Leafflag_actions.install000
Expandflag_actions.module101
MessageGroupFilenameLineFunctionStatus
Use an indent of 2 spaces, with no tabsOtherflag_actions.module180N/A
Control statements should have one space between the control keyword and opening parenthesisOtherflag_actions.module358N/A
Leafincludes/flag.actions.inc000
Leafincludes/flag.admin.inc000
Expandincludes/flag.rules.inc510
MessageGroupFilenameLineFunctionStatus
@file description should be on the following line (Drupal Docs)Otherflag.rules.inc4N/A
There should be no trailing spacesOtherflag.rules.inc47N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherflag.rules.inc54N/A
There should be no trailing spacesOtherflag.rules.inc84N/A
There should be no trailing spacesOtherflag.rules.inc182N/A
There should be no trailing spacesOtherflag.rules.inc260N/A
Expandincludes/flag.rules_forms.inc600
MessageGroupFilenameLineFunctionStatus
@file description should be on the following line (Drupal Docs)Otherflag.rules_forms.inc4N/A
put a space between the asterisk and the comment textOtherflag.rules_forms.inc10N/A
put a space between the asterisk and the comment textOtherflag.rules_forms.inc57N/A
use lowercase html tags to comply with XHTMLOtherflag.rules_forms.inc70N/A
put a space between the asterisk and the comment textOtherflag.rules_forms.inc96N/A
There should be no trailing spacesOtherflag.rules_forms.inc99N/A
Leafincludes/flag.token.inc000
Leafincludes/flag.views.inc000
Expandincludes/flag.views_bookmark.inc110
MessageGroupFilenameLineFunctionStatus
in most cases, replace the string function with the drupal_ equivalent string functionsOtherflag.views_bookmark.inc146N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otherflag.views_bookmark.inc148N/A
Leafincludes/flag.views_convert.inc000
Leafincludes/flag.views_default.inc000
Leafincludes/flag_handler_argument_content_id.inc000
Leafincludes/flag_handler_field_ops.inc000
Leafincludes/flag_handler_filter_flagged.inc000
Leafincludes/flag_handler_relationships.inc000
Expandincludes/flag_plugin_argument_validate_flaggability.inc020
MessageGroupFilenameLineFunctionStatus
In SQL strings, Use db_query() placeholders in place of variables. This is a potential source of SQL injection attacks when the variable can come from user data. (Drupal Docs)Otherflag_plugin_argument_validate_flaggability.inc205N/A
In SQL strings, Use db_query() placeholders in place of variables. This is a potential source of SQL injection attacks when the variable can come from user data. (Drupal Docs)Otherflag_plugin_argument_validate_flaggability.inc215N/A
Expandtests/flag.test301
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherflag.test-1N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherflag.test34N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherflag.test71N/A
There should be no trailing spacesOtherflag.test117N/A
Leaftheme/flag.tpl.php000