GeoNames - 7.x-1.x

Test status
StatusResult
Last receivedThu, 07/19/2012 - 00:20:15
Last requestedThu, 07/19/2012 - 00:21:02
Last testedThu, 07/19/2012 - 00:22:14
Test count2
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier7.x-1.x
ProjectGeoNames
LinkProject information
SummaryPASSED: [[Coder]]: [Code review] 3 minor(s), 1 critical(s), and 2 normal(s); [[SimpleTest]]: [MySQL] 154 pass(es).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing
154 pass(es), 0 fail(s), and 0 exception(s)
Test namePassFailException
LeafGeoNames (GeoNamesTestCase) [GeoNames]3600
LeafGeoNames All (GeoNamesAllTestCase) [GeoNames]11800

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
3 minor(s), 1 critical(s), and 2 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandgeonames.admin.inc001
MessageGroupFilenameLineFunctionStatus
The $text argument to l() should be enclosed within t() so that it is translatable.Othergeonames.admin.inc21N/A
Expandgeonames.install011
MessageGroupFilenameLineFunctionStatus
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Othergeonames.install276N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)Othergeonames.install276N/A

All

Test nameMinorCriticalNormal
Expandgeonames.admin.inc001
MessageGroupFilenameLineFunctionStatus
The $text argument to l() should be enclosed within t() so that it is translatable.Othergeonames.admin.inc21N/A
Leafgeonames.doc.inc000
Expandgeonames.install011
MessageGroupFilenameLineFunctionStatus
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Othergeonames.install276N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)Othergeonames.install276N/A
Expandgeonames.module200
MessageGroupFilenameLineFunctionStatus
in most cases, replace the string function with the drupal_ equivalent string functionsOthergeonames.module94N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOthergeonames.module715N/A
Leafgeonames_config.inc000
Leafgeonames_tools.module000
Expandtests/geonames.all.test100
MessageGroupFilenameLineFunctionStatus
@see should always be followed by a filename, a URL, class/interface name (optionally including method), or a function name including ().Othergeonames.all.test34N/A
Leaftests/geonames.test000