Spam - 6.x-1.x

Test status
StatusResult
Last receivedWed, 07/18/2012 - 06:14:16
Last requestedWed, 07/18/2012 - 06:15:02
Last testedWed, 07/18/2012 - 06:15:22
Test count2
Environment status
MySQLfail
Code reviewfail
Overall Resultfail
Branch information
Identifier6.x-1.x
ProjectSpam
LinkProject information
SummaryFAILED: [[Coder]]: [Code review] 61 minor(s), 12 critical(s), and 47 normal(s); [[SimpleTest]]: [MySQL] 41 pass(es), 0 fail(s), and 43 exception(s).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
    Review the test failures below then if necessary run them locally until the problem has been fixed.
  10. Complete test suite with all tests passing
41 pass(es), 0 fail(s), and 43 exception(s)

Non-pass

Test namePassFailException
ExpandCustom Filter (SpamCustomFilterTestCase) [Spam]41043
MessageGroupFilenameLineFunctionStatus
Undefined offset: 5Noticemenu.inc578_menu_translate()
Undefined offset: 5Noticemenu.inc578_menu_translate()
Undefined variable: allNoticespam_filter_custom.module207spam_filter_custom_admin_settings()
Undefined offset: 5Noticemenu.inc578_menu_translate()
Undefined variable: spam_filter_customNoticespam_filter_custom.module310spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module310spam_filter_custom_admin_filter()
Undefined variable: spam_filter_customNoticespam_filter_custom.module318spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module318spam_filter_custom_admin_filter()
Undefined variable: spam_filter_customNoticespam_filter_custom.module323spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module323spam_filter_custom_admin_filter()
Undefined variable: spam_filter_customNoticespam_filter_custom.module326spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module326spam_filter_custom_admin_filter()
Undefined variable: spam_filter_customNoticespam_filter_custom.module329spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module329spam_filter_custom_admin_filter()
Undefined variable: spam_filter_customNoticespam_filter_custom.module351spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module351spam_filter_custom_admin_filter()
Undefined variable: spam_filter_customNoticespam_filter_custom.module358spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module358spam_filter_custom_admin_filter()
Undefined variable: spam_filter_customNoticespam_filter_custom.module363spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module363spam_filter_custom_admin_filter()
Undefined variable: spam_filter_customNoticespam_filter_custom.module366spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module366spam_filter_custom_admin_filter()
Undefined variable: spam_filter_customNoticespam_filter_custom.module310spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module310spam_filter_custom_admin_filter()
Undefined variable: spam_filter_customNoticespam_filter_custom.module318spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module318spam_filter_custom_admin_filter()
Undefined variable: spam_filter_customNoticespam_filter_custom.module323spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module323spam_filter_custom_admin_filter()
Undefined variable: spam_filter_customNoticespam_filter_custom.module326spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module326spam_filter_custom_admin_filter()
Undefined variable: spam_filter_customNoticespam_filter_custom.module329spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module329spam_filter_custom_admin_filter()
Undefined variable: spam_filter_customNoticespam_filter_custom.module351spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module351spam_filter_custom_admin_filter()
Undefined variable: spam_filter_customNoticespam_filter_custom.module358spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module358spam_filter_custom_admin_filter()
Undefined variable: spam_filter_customNoticespam_filter_custom.module363spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module363spam_filter_custom_admin_filter()
Undefined variable: spam_filter_customNoticespam_filter_custom.module366spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module366spam_filter_custom_admin_filter()
Undefined variable: rowNoticespam_filter_custom.module196spam_filter_custom_admin_settings()
Undefined offset: 5Noticemenu.inc578_menu_translate()
Undefined property: stdClass::$extraNoticespam_filter_custom.module518spam_filter_custom_spam_filter()

All

Test namePassFailException
ExpandCustom Filter (SpamCustomFilterTestCase) [Spam]41043
MessageGroupFilenameLineFunctionStatus
Undefined offset: 5Noticemenu.inc578_menu_translate()
Undefined offset: 5Noticemenu.inc578_menu_translate()
Undefined variable: allNoticespam_filter_custom.module207spam_filter_custom_admin_settings()
Undefined offset: 5Noticemenu.inc578_menu_translate()
Undefined variable: spam_filter_customNoticespam_filter_custom.module310spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module310spam_filter_custom_admin_filter()
Undefined variable: spam_filter_customNoticespam_filter_custom.module318spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module318spam_filter_custom_admin_filter()
Undefined variable: spam_filter_customNoticespam_filter_custom.module323spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module323spam_filter_custom_admin_filter()
Undefined variable: spam_filter_customNoticespam_filter_custom.module326spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module326spam_filter_custom_admin_filter()
Undefined variable: spam_filter_customNoticespam_filter_custom.module329spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module329spam_filter_custom_admin_filter()
Undefined variable: spam_filter_customNoticespam_filter_custom.module351spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module351spam_filter_custom_admin_filter()
Undefined variable: spam_filter_customNoticespam_filter_custom.module358spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module358spam_filter_custom_admin_filter()
Undefined variable: spam_filter_customNoticespam_filter_custom.module363spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module363spam_filter_custom_admin_filter()
Undefined variable: spam_filter_customNoticespam_filter_custom.module366spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module366spam_filter_custom_admin_filter()
Undefined variable: spam_filter_customNoticespam_filter_custom.module310spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module310spam_filter_custom_admin_filter()
Undefined variable: spam_filter_customNoticespam_filter_custom.module318spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module318spam_filter_custom_admin_filter()
Undefined variable: spam_filter_customNoticespam_filter_custom.module323spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module323spam_filter_custom_admin_filter()
Undefined variable: spam_filter_customNoticespam_filter_custom.module326spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module326spam_filter_custom_admin_filter()
Undefined variable: spam_filter_customNoticespam_filter_custom.module329spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module329spam_filter_custom_admin_filter()
Undefined variable: spam_filter_customNoticespam_filter_custom.module351spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module351spam_filter_custom_admin_filter()
Undefined variable: spam_filter_customNoticespam_filter_custom.module358spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module358spam_filter_custom_admin_filter()
Undefined variable: spam_filter_customNoticespam_filter_custom.module363spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module363spam_filter_custom_admin_filter()
Undefined variable: spam_filter_customNoticespam_filter_custom.module366spam_filter_custom_admin_filter()
Trying to get property of non-objectNoticespam_filter_custom.module366spam_filter_custom_admin_filter()
Undefined variable: rowNoticespam_filter_custom.module196spam_filter_custom_admin_settings()
Undefined offset: 5Noticemenu.inc578_menu_translate()
Undefined property: stdClass::$extraNoticespam_filter_custom.module518spam_filter_custom_spam_filter()

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
61 minor(s), 12 critical(s), and 47 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandcontent/spam_content_comment.inc611
MessageGroupFilenameLineFunctionStatus
Use "elseif" in place of "else if"Otherspam_content_comment.inc256N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Otherspam_content_comment.inc351N/A
indent secondary line of comment one space Otherspam_content_comment.inc426N/A
indent secondary line of comment one space Otherspam_content_comment.inc427N/A
indent secondary line of comment one space Otherspam_content_comment.inc428N/A
indent secondary line of comment one space Otherspam_content_comment.inc446N/A
indent secondary line of comment one space Otherspam_content_comment.inc447N/A
indent secondary line of comment one space Otherspam_content_comment.inc448N/A
Expandcontent/spam_content_contact.inc103
MessageGroupFilenameLineFunctionStatus
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherspam_content_contact.inc23N/A
There should be no trailing spacesOtherspam_content_contact.inc126N/A
Control statements should have one space between the control keyword and opening parenthesisOtherspam_content_contact.inc128N/A
Control statements should have one space between the control keyword and opening parenthesisOtherspam_content_contact.inc141N/A
Expandcontent/spam_content_notifications.inc201
MessageGroupFilenameLineFunctionStatus
Missing periodOtherspam_content_notifications.inc9N/A
Control statements should have one space between the control keyword and opening parenthesisOtherspam_content_notifications.inc17N/A
There should be no trailing spacesOtherspam_content_notifications.inc31N/A
Expandfilters/spam_filter_bayesian/spam_filter_bayesian.install113
MessageGroupFilenameLineFunctionStatus
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherspam_filter_bayesian.install114N/A
missing space after commaOtherspam_filter_bayesian.install115N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherspam_filter_bayesian.install115N/A
SQL query handling data in a potentially insecure way by using the %%s placeholder without wrapping it in single quotes. This is a potential source of SQL injection attacks when the value can come from user data.Otherspam_filter_bayesian.install116N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherspam_filter_bayesian.install116N/A
Expandfilters/spam_filter_custom/spam_filter_custom-upgrade.inc001
MessageGroupFilenameLineFunctionStatus
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherspam_filter_custom-upgrade.inc25N/A
Expandfilters/spam_filter_custom/spam_filter_custom.install114
MessageGroupFilenameLineFunctionStatus
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherspam_filter_custom.install41N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherspam_filter_custom.install51N/A
missing space after commaOtherspam_filter_custom.install52N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherspam_filter_custom.install52N/A
SQL query handling data in a potentially insecure way by using the %%s placeholder without wrapping it in single quotes. This is a potential source of SQL injection attacks when the value can come from user data.Otherspam_filter_custom.install53N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherspam_filter_custom.install53N/A
Expandfilters/spam_filter_custom/spam_filter_custom.module004
MessageGroupFilenameLineFunctionStatus
Use "elseif" in place of "else if"Otherspam_filter_custom.module140N/A
The $title argument to drupal_set_title() should be enclosed within t() so that it is translatable.Otherspam_filter_custom.module295N/A
The $title argument to drupal_set_title() should be enclosed within t() so that it is translatable.Otherspam_filter_custom.module303N/A
Use "elseif" in place of "else if"Otherspam_filter_custom.module569N/A
Expandfilters/spam_filter_duplicate/spam_filter_duplicate.install114
MessageGroupFilenameLineFunctionStatus
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherspam_filter_duplicate.install43N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherspam_filter_duplicate.install53N/A
missing space after commaOtherspam_filter_duplicate.install54N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherspam_filter_duplicate.install54N/A
SQL query handling data in a potentially insecure way by using the %%s placeholder without wrapping it in single quotes. This is a potential source of SQL injection attacks when the value can come from user data.Otherspam_filter_duplicate.install55N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherspam_filter_duplicate.install55N/A
Expandfilters/spam_filter_duplicate/spam_filter_duplicate.module112
MessageGroupFilenameLineFunctionStatus
table names should be enclosed in {curly_brackets}Otherspam_filter_duplicate.module241N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherspam_filter_duplicate.module269N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherspam_filter_duplicate.module277N/A
There should be no trailing spacesOtherspam_filter_duplicate.module289N/A
Expandfilters/spam_filter_node_age/spam_filter_node_age.install113
MessageGroupFilenameLineFunctionStatus
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherspam_filter_node_age.install18N/A
missing space after commaOtherspam_filter_node_age.install19N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherspam_filter_node_age.install19N/A
SQL query handling data in a potentially insecure way by using the %%s placeholder without wrapping it in single quotes. This is a potential source of SQL injection attacks when the value can come from user data.Otherspam_filter_node_age.install20N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherspam_filter_node_age.install20N/A
Expandfilters/spam_filter_node_age/spam_filter_node_age.module004
MessageGroupFilenameLineFunctionStatus
Use "elseif" in place of "else if"Otherspam_filter_node_age.module87N/A
else statements should begin on a new lineOtherspam_filter_node_age.module95N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherspam_filter_node_age.module187N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherspam_filter_node_age.module194N/A
Expandfilters/spam_filter_url/spam_filter_url.install113
MessageGroupFilenameLineFunctionStatus
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherspam_filter_url.install18N/A
missing space after commaOtherspam_filter_url.install19N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherspam_filter_url.install19N/A
SQL query handling data in a potentially insecure way by using the %%s placeholder without wrapping it in single quotes. This is a potential source of SQL injection attacks when the value can come from user data.Otherspam_filter_url.install20N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherspam_filter_url.install20N/A
Expandfilters/spam_filter_url/spam_filter_url.module102
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherspam_filter_url.module106N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherspam_filter_url.module262N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherspam_filter_url.module267N/A
Expandspam.module6512
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherspam.module92N/A
Use "elseif" in place of "else if"Otherspam.module206N/A
SQL query handling data in a potentially insecure way by using the %%s placeholder without wrapping it in single quotes. This is a potential source of SQL injection attacks when the value can come from user data.Otherspam.module425N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherspam.module798N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherspam.module799N/A
Potential problem: when FAPI element '#type' is set to 'markup' (default), '#value' only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherspam.module1097N/A
Use "elseif" in place of "else if"Otherspam.module1187N/A
Arrays should be formatted with a space separating each element and assignment operatorOtherspam.module1337N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherspam.module1363N/A
Use "elseif" in place of "else if"Otherspam.module1574N/A
Potential problem: drupal_set_title() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherspam.module1629N/A
There should be no trailing spacesOtherspam.module1745N/A
There should be no trailing spacesOtherspam.module1759N/A
Use "elseif" in place of "else if"Otherspam.module1835N/A
The $title argument to drupal_set_title() should be enclosed within t() so that it is translatable.Otherspam.module1921N/A
Use "elseif" in place of "else if"Otherspam.module1998N/A
indent secondary line of comment one space Otherspam.module2177N/A
Format should be * Implementation of hook_foo().Otherspam.module2177N/A
indent secondary line of comment one space Otherspam.module2178N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherspam.module2184N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherspam.module2185N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherspam.module2190N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherspam.module2191N/A

All

Test nameMinorCriticalNormal
Expandcontent/spam_content_comment.inc611
MessageGroupFilenameLineFunctionStatus
Use "elseif" in place of "else if"Otherspam_content_comment.inc256N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Otherspam_content_comment.inc351N/A
indent secondary line of comment one space Otherspam_content_comment.inc426N/A
indent secondary line of comment one space Otherspam_content_comment.inc427N/A
indent secondary line of comment one space Otherspam_content_comment.inc428N/A
indent secondary line of comment one space Otherspam_content_comment.inc446N/A
indent secondary line of comment one space Otherspam_content_comment.inc447N/A
indent secondary line of comment one space Otherspam_content_comment.inc448N/A
Expandcontent/spam_content_contact.inc103
MessageGroupFilenameLineFunctionStatus
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherspam_content_contact.inc23N/A
There should be no trailing spacesOtherspam_content_contact.inc126N/A
Control statements should have one space between the control keyword and opening parenthesisOtherspam_content_contact.inc128N/A
Control statements should have one space between the control keyword and opening parenthesisOtherspam_content_contact.inc141N/A
Expandcontent/spam_content_node.inc600
MessageGroupFilenameLineFunctionStatus
indent secondary line of comment one space Otherspam_content_node.inc250N/A
indent secondary line of comment one space Otherspam_content_node.inc251N/A
indent secondary line of comment one space Otherspam_content_node.inc252N/A
indent secondary line of comment one space Otherspam_content_node.inc270N/A
indent secondary line of comment one space Otherspam_content_node.inc271N/A
indent secondary line of comment one space Otherspam_content_node.inc272N/A
Expandcontent/spam_content_notifications.inc201
MessageGroupFilenameLineFunctionStatus
Missing periodOtherspam_content_notifications.inc9N/A
Control statements should have one space between the control keyword and opening parenthesisOtherspam_content_notifications.inc17N/A
There should be no trailing spacesOtherspam_content_notifications.inc31N/A
Expandcontent/spam_content_privatemsg.inc2000
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherspam_content_privatemsg.inc26N/A
There should be no trailing spacesOtherspam_content_privatemsg.inc29N/A
There should be no trailing spacesOtherspam_content_privatemsg.inc34N/A
There should be no trailing spacesOtherspam_content_privatemsg.inc36N/A
There should be no trailing spacesOtherspam_content_privatemsg.inc46N/A
There should be no trailing spacesOtherspam_content_privatemsg.inc48N/A
There should be no trailing spacesOtherspam_content_privatemsg.inc51N/A
There should be no trailing spacesOtherspam_content_privatemsg.inc55N/A
There should be no trailing spacesOtherspam_content_privatemsg.inc86N/A
There should be no trailing spacesOtherspam_content_privatemsg.inc99N/A
There should be no trailing spacesOtherspam_content_privatemsg.inc101N/A
There should be no trailing spacesOtherspam_content_privatemsg.inc105N/A
There should be no trailing spacesOtherspam_content_privatemsg.inc111N/A
There should be no trailing spacesOtherspam_content_privatemsg.inc115N/A
There should be no trailing spacesOtherspam_content_privatemsg.inc118N/A
There should be no trailing spacesOtherspam_content_privatemsg.inc129N/A
There should be no trailing spacesOtherspam_content_privatemsg.inc139N/A
There should be no trailing spacesOtherspam_content_privatemsg.inc143N/A
There should be no trailing spacesOtherspam_content_privatemsg.inc161N/A
There should be no trailing spacesOtherspam_content_privatemsg.inc185N/A
Expandcontent/spam_content_user.inc600
MessageGroupFilenameLineFunctionStatus
indent secondary line of comment one space Otherspam_content_user.inc257N/A
indent secondary line of comment one space Otherspam_content_user.inc258N/A
indent secondary line of comment one space Otherspam_content_user.inc259N/A
indent secondary line of comment one space Otherspam_content_user.inc277N/A
indent secondary line of comment one space Otherspam_content_user.inc278N/A
indent secondary line of comment one space Otherspam_content_user.inc279N/A
Expandfilters/spam_filter_bayesian/spam_filter_bayesian.install113
MessageGroupFilenameLineFunctionStatus
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherspam_filter_bayesian.install114N/A
missing space after commaOtherspam_filter_bayesian.install115N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherspam_filter_bayesian.install115N/A
SQL query handling data in a potentially insecure way by using the %%s placeholder without wrapping it in single quotes. This is a potential source of SQL injection attacks when the value can come from user data.Otherspam_filter_bayesian.install116N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherspam_filter_bayesian.install116N/A
Expandfilters/spam_filter_bayesian/spam_filter_bayesian.module100
MessageGroupFilenameLineFunctionStatus
in most cases, replace the string function with the drupal_ equivalent string functionsOtherspam_filter_bayesian.module261N/A
Expandfilters/spam_filter_custom/spam_filter_custom-upgrade.inc001
MessageGroupFilenameLineFunctionStatus
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherspam_filter_custom-upgrade.inc25N/A
Expandfilters/spam_filter_custom/spam_filter_custom.install114
MessageGroupFilenameLineFunctionStatus
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherspam_filter_custom.install41N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherspam_filter_custom.install51N/A
missing space after commaOtherspam_filter_custom.install52N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherspam_filter_custom.install52N/A
SQL query handling data in a potentially insecure way by using the %%s placeholder without wrapping it in single quotes. This is a potential source of SQL injection attacks when the value can come from user data.Otherspam_filter_custom.install53N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherspam_filter_custom.install53N/A
Expandfilters/spam_filter_custom/spam_filter_custom.module004
MessageGroupFilenameLineFunctionStatus
Use "elseif" in place of "else if"Otherspam_filter_custom.module140N/A
The $title argument to drupal_set_title() should be enclosed within t() so that it is translatable.Otherspam_filter_custom.module295N/A
The $title argument to drupal_set_title() should be enclosed within t() so that it is translatable.Otherspam_filter_custom.module303N/A
Use "elseif" in place of "else if"Otherspam_filter_custom.module569N/A
Leaffilters/spam_filter_custom/tests/spam_filter_custom.test000
Expandfilters/spam_filter_duplicate/spam_filter_duplicate.install114
MessageGroupFilenameLineFunctionStatus
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherspam_filter_duplicate.install43N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherspam_filter_duplicate.install53N/A
missing space after commaOtherspam_filter_duplicate.install54N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherspam_filter_duplicate.install54N/A
SQL query handling data in a potentially insecure way by using the %%s placeholder without wrapping it in single quotes. This is a potential source of SQL injection attacks when the value can come from user data.Otherspam_filter_duplicate.install55N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherspam_filter_duplicate.install55N/A
Expandfilters/spam_filter_duplicate/spam_filter_duplicate.module112
MessageGroupFilenameLineFunctionStatus
table names should be enclosed in {curly_brackets}Otherspam_filter_duplicate.module241N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherspam_filter_duplicate.module269N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherspam_filter_duplicate.module277N/A
There should be no trailing spacesOtherspam_filter_duplicate.module289N/A
Expandfilters/spam_filter_node_age/spam_filter_node_age.install113
MessageGroupFilenameLineFunctionStatus
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherspam_filter_node_age.install18N/A
missing space after commaOtherspam_filter_node_age.install19N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherspam_filter_node_age.install19N/A
SQL query handling data in a potentially insecure way by using the %%s placeholder without wrapping it in single quotes. This is a potential source of SQL injection attacks when the value can come from user data.Otherspam_filter_node_age.install20N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherspam_filter_node_age.install20N/A
Expandfilters/spam_filter_node_age/spam_filter_node_age.module004
MessageGroupFilenameLineFunctionStatus
Use "elseif" in place of "else if"Otherspam_filter_node_age.module87N/A
else statements should begin on a new lineOtherspam_filter_node_age.module95N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherspam_filter_node_age.module187N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherspam_filter_node_age.module194N/A
Leaffilters/spam_filter_surbl/spam_filter_surbl.module000
Expandfilters/spam_filter_url/spam_filter_url.install113
MessageGroupFilenameLineFunctionStatus
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherspam_filter_url.install18N/A
missing space after commaOtherspam_filter_url.install19N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherspam_filter_url.install19N/A
SQL query handling data in a potentially insecure way by using the %%s placeholder without wrapping it in single quotes. This is a potential source of SQL injection attacks when the value can come from user data.Otherspam_filter_url.install20N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherspam_filter_url.install20N/A
Expandfilters/spam_filter_url/spam_filter_url.module102
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherspam_filter_url.module106N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherspam_filter_url.module262N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.Otherspam_filter_url.module267N/A
Expandspam.install600
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherspam.install133N/A
There should be no trailing spacesOtherspam.install134N/A
There should be no trailing spacesOtherspam.install141N/A
There should be no trailing spacesOtherspam.install142N/A
There should be no trailing spacesOtherspam.install149N/A
There should be no trailing spacesOtherspam.install150N/A
Expandspam.module6512
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherspam.module92N/A
Use "elseif" in place of "else if"Otherspam.module206N/A
SQL query handling data in a potentially insecure way by using the %%s placeholder without wrapping it in single quotes. This is a potential source of SQL injection attacks when the value can come from user data.Otherspam.module425N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherspam.module798N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherspam.module799N/A
Potential problem: when FAPI element '#type' is set to 'markup' (default), '#value' only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherspam.module1097N/A
Use "elseif" in place of "else if"Otherspam.module1187N/A
Arrays should be formatted with a space separating each element and assignment operatorOtherspam.module1337N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherspam.module1363N/A
Use "elseif" in place of "else if"Otherspam.module1574N/A
Potential problem: drupal_set_title() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherspam.module1629N/A
There should be no trailing spacesOtherspam.module1745N/A
There should be no trailing spacesOtherspam.module1759N/A
Use "elseif" in place of "else if"Otherspam.module1835N/A
The $title argument to drupal_set_title() should be enclosed within t() so that it is translatable.Otherspam.module1921N/A
Use "elseif" in place of "else if"Otherspam.module1998N/A
indent secondary line of comment one space Otherspam.module2177N/A
Format should be * Implementation of hook_foo().Otherspam.module2177N/A
indent secondary line of comment one space Otherspam.module2178N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherspam.module2184N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherspam.module2185N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherspam.module2190N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherspam.module2191N/A
Leaftests/spam.test000