Icon Links - 7.x-1.0 | Drupal Quality Assurance

Latest changes

So Long and Thanks for all the Tests

1 week 2 days ago

Support

In case of troubles

check the FAQ. Please make sure you've tried the test locally.
search known testbot issues and then create a new issue if yours isn't there already. Please give a link to the test.

Test client logs

No clients to display.

Icon Links - 7.x-1.0

Test status

Status	Result
Last received	Tue, 07/10/2012 - 14:23:15
Last requested	Tue, 07/10/2012 - 14:24:02
Last tested	Tue, 07/10/2012 - 14:24:28
Test count	2

Environment status

MySQL	pass
Code review	fail

Overall Result	pass

Branch information

Identifier	7.x-1.0
Project	Icon Links
Link	Project information

Event logView entire log

ID	Message	Timestamp
3993708	Result retrieved by project client.	3 years 33 weeks ago
3993703	Result received from test client #654.	3 years 33 weeks ago
3993698	Result received from test client #659.	3 years 33 weeks ago
3993693	Requested by test client #659.	3 years 33 weeks ago
3993688	Requested by test client #654.	3 years 33 weeks ago
3993683	Test request received.	3 years 33 weeks ago

SummaryPASSED: [[Coder]]: [Code review] 11 minor(s), 1 critical(s), and 38 normal(s); [[SimpleTest]]: [MySQL] 0 pass(es).

Details

MySQL
Code review

MySQL

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a Drupal installation failure
Detect a test run failure
Detect a failing test
Complete test suite with all tests passing

Review log

Code review

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a review run failure
Detect coder flags
Ensure that your code follows the Drupal standard and passes a coder review.
Complete coder review with all passed

11 minor(s), 1 critical(s), and 38 normal(s)

Non-pass

Test name

Minor

Critical

Normal

icon_links.install

Message	Group	Filename	Line	Function
Use an indent of 2 spaces, with no tabs	Other	icon_links.install	13	N/A
Use an indent of 2 spaces, with no tabs	Other	icon_links.install	36	N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	icon_links.install	41	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	icon_links.install	43	N/A
use a space between the closing parenthesis and the open bracket	Other	icon_links.install	43	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	icon_links.install	44	N/A
use a space between the closing parenthesis and the open bracket	Other	icon_links.install	44	N/A

icon_links.module

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	icon_links.module	-1	N/A
There should be no trailing spaces	Other	icon_links.module	5	N/A
There should be no trailing spaces	Other	icon_links.module	9	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	icon_links.module	28	N/A
use a space between the closing parenthesis and the open bracket	Other	icon_links.module	28	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	icon_links.module	29	N/A
use a space between the closing parenthesis and the open bracket	Other	icon_links.module	29	N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	icon_links.module	32	N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	icon_links.module	37	N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	icon_links.module	42	N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	icon_links.module	55	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	icon_links.module	57	N/A
use a space between the closing parenthesis and the open bracket	Other	icon_links.module	57	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	icon_links.module	58	N/A
use a space between the closing parenthesis and the open bracket	Other	icon_links.module	58	N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	icon_links.module	63	N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	icon_links.module	65	N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	icon_links.module	67	N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	icon_links.module	72	N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	icon_links.module	74	N/A
Use an indent of 2 spaces, with no tabs	Other	icon_links.module	78	N/A
There should be no trailing spaces	Other	icon_links.module	90	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	icon_links.module	95	N/A
use a space between the closing parenthesis and the open bracket	Other	icon_links.module	95	N/A
There should be no trailing spaces	Other	icon_links.module	96	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	icon_links.module	97	N/A
use a space between the closing parenthesis and the open bracket	Other	icon_links.module	97	N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	icon_links.module	97	N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	icon_links.module	98	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	icon_links.module	99	N/A
use a space between the closing parenthesis and the open bracket	Other	icon_links.module	99	N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	icon_links.module	102	N/A
missing space after comma	Other	icon_links.module	106	N/A
Functions should be called with no spaces between the function name and opening parentheses	Other	icon_links.module	108	N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	icon_links.module	110	N/A
else statements should begin on a new line	Other	icon_links.module	111	N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	icon_links.module	112	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	icon_links.module	112	N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	icon_links.module	121	N/A
There should be no trailing spaces	Other	icon_links.module	129	N/A
There should be no trailing spaces	Other	icon_links.module	136	N/A
There should be no trailing spaces	Other	icon_links.module	144	N/A
There should be no trailing spaces	Other	icon_links.module	163	N/A

All