Media Gallery - 7.x-1.x

Test status
StatusResult
Last receivedMon, 07/02/2012 - 21:07:15
Last requestedMon, 07/02/2012 - 21:08:02
Last testedMon, 07/02/2012 - 21:08:09
Test count2
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier7.x-1.x
ProjectMedia Gallery
LinkProject information
SummaryPASSED: [[SimpleTest]]: [MySQL] 0 pass(es); [[Coder]]: [Code review] 24 minor(s), 4 critical(s), and 21 normal(s).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
24 minor(s), 4 critical(s), and 21 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandfields_rsi_prevention.inc602
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherfields_rsi_prevention.inc-1N/A
There should be no trailing spacesOtherfields_rsi_prevention.inc18N/A
There should be no trailing spacesOtherfields_rsi_prevention.inc21N/A
There should be no trailing spacesOtherfields_rsi_prevention.inc29N/A
There should be no trailing spacesOtherfields_rsi_prevention.inc35N/A
There should be no trailing spacesOtherfields_rsi_prevention.inc42N/A
There should be no trailing spacesOtherfields_rsi_prevention.inc46N/A
the final ?> should be omitted from all code filesOtherfields_rsi_prevention.inc50N/A
Expandmedia.pages.inc001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Othermedia.pages.inc-1N/A
Expandmedia_gallery.admin.inc001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Othermedia_gallery.admin.inc-1N/A
Expandmedia_gallery.install525
MessageGroupFilenameLineFunctionStatus
Format should be * Implementation of hook_foo().Othermedia_gallery.install57N/A
'Implementation' should be at the start of the sentence and begin with a capitialized letterOthermedia_gallery.install57N/A
There should be no trailing spacesOthermedia_gallery.install121N/A
There should be no trailing spacesOthermedia_gallery.install884N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Othermedia_gallery.install937N/A
There should be no trailing spacesOthermedia_gallery.install975N/A
do not use mixed case (camelCase), use lower case and _Othermedia_gallery.install1007N/A
do not use mixed case (camelCase), use lower case and _Othermedia_gallery.install1016N/A
do not use mixed case (camelCase), use lower case and _Othermedia_gallery.install1018N/A
do not use mixed case (camelCase), use lower case and _Othermedia_gallery.install1047N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Othermedia_gallery.install1054N/A
Control statements should have one space between the control keyword and opening parenthesisOthermedia_gallery.install1055N/A
Expandmedia_gallery.module618
MessageGroupFilenameLineFunctionStatus
Format should be * Implementation of hook_foo().Othermedia_gallery.module202N/A
There should be no trailing spacesOthermedia_gallery.module291N/A
There should be no trailing spacesOthermedia_gallery.module330N/A
There should be no trailing spacesOthermedia_gallery.module335N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Othermedia_gallery.module531N/A
Control statements should have one space between the control keyword and opening parenthesisOthermedia_gallery.module757N/A
Control statements should have one space between the control keyword and opening parenthesisOthermedia_gallery.module889N/A
Control statements should have one space between the control keyword and opening parenthesisOthermedia_gallery.module916N/A
There should be no trailing spacesOthermedia_gallery.module1075N/A
Format should be * Implementation of hook_foo().Othermedia_gallery.module1126N/A
Control statements should have one space between the control keyword and opening parenthesisOthermedia_gallery.module1187N/A
Control statements should have one space between the control keyword and opening parenthesisOthermedia_gallery.module1277N/A
use a space between the closing parenthesis and the open bracketOthermedia_gallery.module1335N/A
missing space after commaOthermedia_gallery.module1362N/A
Control statements should have one space between the control keyword and opening parenthesisOthermedia_gallery.module1389N/A
Expandmedia_gallery.pages.inc612
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Othermedia_gallery.pages.inc-1N/A
There should be no trailing spacesOthermedia_gallery.pages.inc14N/A
Use an indent of 2 spaces, with no tabsOthermedia_gallery.pages.inc60N/A
Potential problem: drupal_set_title() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Othermedia_gallery.pages.inc90N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)Othermedia_gallery.pages.inc147N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)Othermedia_gallery.pages.inc218N/A
There should be no trailing spacesOthermedia_gallery.pages.inc222N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)Othermedia_gallery.pages.inc265N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOthermedia_gallery.pages.inc279N/A
Expandmedia_gallery.theme.inc002
MessageGroupFilenameLineFunctionStatus
else statements should begin on a new lineOthermedia_gallery.theme.inc244N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOthermedia_gallery.theme.inc433N/A

All

Test nameMinorCriticalNormal
Expandfields_rsi_prevention.inc602
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherfields_rsi_prevention.inc-1N/A
There should be no trailing spacesOtherfields_rsi_prevention.inc18N/A
There should be no trailing spacesOtherfields_rsi_prevention.inc21N/A
There should be no trailing spacesOtherfields_rsi_prevention.inc29N/A
There should be no trailing spacesOtherfields_rsi_prevention.inc35N/A
There should be no trailing spacesOtherfields_rsi_prevention.inc42N/A
There should be no trailing spacesOtherfields_rsi_prevention.inc46N/A
the final ?> should be omitted from all code filesOtherfields_rsi_prevention.inc50N/A
Leafmedia-gallery-media-item-thumbnail.tpl.php000
Expandmedia.pages.inc001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Othermedia.pages.inc-1N/A
Expandmedia_gallery.admin.inc001
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Othermedia_gallery.admin.inc-1N/A
Expandmedia_gallery.fields.inc100
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOthermedia_gallery.fields.inc300N/A
Expandmedia_gallery.install525
MessageGroupFilenameLineFunctionStatus
Format should be * Implementation of hook_foo().Othermedia_gallery.install57N/A
'Implementation' should be at the start of the sentence and begin with a capitialized letterOthermedia_gallery.install57N/A
There should be no trailing spacesOthermedia_gallery.install121N/A
There should be no trailing spacesOthermedia_gallery.install884N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Othermedia_gallery.install937N/A
There should be no trailing spacesOthermedia_gallery.install975N/A
do not use mixed case (camelCase), use lower case and _Othermedia_gallery.install1007N/A
do not use mixed case (camelCase), use lower case and _Othermedia_gallery.install1016N/A
do not use mixed case (camelCase), use lower case and _Othermedia_gallery.install1018N/A
do not use mixed case (camelCase), use lower case and _Othermedia_gallery.install1047N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Othermedia_gallery.install1054N/A
Control statements should have one space between the control keyword and opening parenthesisOthermedia_gallery.install1055N/A
Expandmedia_gallery.module618
MessageGroupFilenameLineFunctionStatus
Format should be * Implementation of hook_foo().Othermedia_gallery.module202N/A
There should be no trailing spacesOthermedia_gallery.module291N/A
There should be no trailing spacesOthermedia_gallery.module330N/A
There should be no trailing spacesOthermedia_gallery.module335N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Othermedia_gallery.module531N/A
Control statements should have one space between the control keyword and opening parenthesisOthermedia_gallery.module757N/A
Control statements should have one space between the control keyword and opening parenthesisOthermedia_gallery.module889N/A
Control statements should have one space between the control keyword and opening parenthesisOthermedia_gallery.module916N/A
There should be no trailing spacesOthermedia_gallery.module1075N/A
Format should be * Implementation of hook_foo().Othermedia_gallery.module1126N/A
Control statements should have one space between the control keyword and opening parenthesisOthermedia_gallery.module1187N/A
Control statements should have one space between the control keyword and opening parenthesisOthermedia_gallery.module1277N/A
use a space between the closing parenthesis and the open bracketOthermedia_gallery.module1335N/A
missing space after commaOthermedia_gallery.module1362N/A
Control statements should have one space between the control keyword and opening parenthesisOthermedia_gallery.module1389N/A
Expandmedia_gallery.pages.inc612
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Othermedia_gallery.pages.inc-1N/A
There should be no trailing spacesOthermedia_gallery.pages.inc14N/A
Use an indent of 2 spaces, with no tabsOthermedia_gallery.pages.inc60N/A
Potential problem: drupal_set_title() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Othermedia_gallery.pages.inc90N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)Othermedia_gallery.pages.inc147N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)Othermedia_gallery.pages.inc218N/A
There should be no trailing spacesOthermedia_gallery.pages.inc222N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)Othermedia_gallery.pages.inc265N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOthermedia_gallery.pages.inc279N/A
Expandmedia_gallery.theme.inc002
MessageGroupFilenameLineFunctionStatus
else statements should begin on a new lineOthermedia_gallery.theme.inc244N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOthermedia_gallery.theme.inc433N/A