Commerce Finnish Payments - 7.x-1.x

Test status
StatusResult
Last receivedSun, 07/01/2012 - 17:19:15
Last requestedSun, 07/01/2012 - 17:20:02
Last testedSun, 07/01/2012 - 17:21:03
Test count2
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier7.x-1.x
ProjectCommerce Finnish Payments
LinkProject information
SummaryPASSED: [[Coder]]: [Code review] 18 minor(s), 0 critical(s), and 5 normal(s); [[SimpleTest]]: [MySQL] 0 pass(es).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
18 minor(s), 0 critical(s), and 5 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandcommerce_finnish_payments.module1505
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOthercommerce_finnish_payments.module39N/A
There should be no trailing spacesOthercommerce_finnish_payments.module53N/A
Use an indent of 2 spaces, with no tabsOthercommerce_finnish_payments.module56N/A
There should be no trailing spacesOthercommerce_finnish_payments.module90N/A
Use an indent of 2 spaces, with no tabsOthercommerce_finnish_payments.module107N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOthercommerce_finnish_payments.module143N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOthercommerce_finnish_payments.module202N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOthercommerce_finnish_payments.module240N/A
There should be no trailing spacesOthercommerce_finnish_payments.module256N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOthercommerce_finnish_payments.module261N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOthercommerce_finnish_payments.module266N/A
else statements should begin on a new lineOthercommerce_finnish_payments.module271N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOthercommerce_finnish_payments.module274N/A
There should be no trailing spacesOthercommerce_finnish_payments.module285N/A
There should be no trailing spacesOthercommerce_finnish_payments.module436N/A
There should be no trailing spacesOthercommerce_finnish_payments.module452N/A
There should be no trailing spacesOthercommerce_finnish_payments.module457N/A
There should be no trailing spacesOthercommerce_finnish_payments.module514N/A
There should be no trailing spacesOthercommerce_finnish_payments.module518N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOthercommerce_finnish_payments.module525N/A

All

Test nameMinorCriticalNormal
Expandcommerce_finnish_payments.module1505
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOthercommerce_finnish_payments.module39N/A
There should be no trailing spacesOthercommerce_finnish_payments.module53N/A
Use an indent of 2 spaces, with no tabsOthercommerce_finnish_payments.module56N/A
There should be no trailing spacesOthercommerce_finnish_payments.module90N/A
Use an indent of 2 spaces, with no tabsOthercommerce_finnish_payments.module107N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOthercommerce_finnish_payments.module143N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOthercommerce_finnish_payments.module202N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOthercommerce_finnish_payments.module240N/A
There should be no trailing spacesOthercommerce_finnish_payments.module256N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOthercommerce_finnish_payments.module261N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOthercommerce_finnish_payments.module266N/A
else statements should begin on a new lineOthercommerce_finnish_payments.module271N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOthercommerce_finnish_payments.module274N/A
There should be no trailing spacesOthercommerce_finnish_payments.module285N/A
There should be no trailing spacesOthercommerce_finnish_payments.module436N/A
There should be no trailing spacesOthercommerce_finnish_payments.module452N/A
There should be no trailing spacesOthercommerce_finnish_payments.module457N/A
There should be no trailing spacesOthercommerce_finnish_payments.module514N/A
There should be no trailing spacesOthercommerce_finnish_payments.module518N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOthercommerce_finnish_payments.module525N/A
Leafincludes/banks/aktiasppop.inc000
Leafincludes/banks/alandsbanken.inc000
Expandincludes/banks/handelsbanken.inc100
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherhandelsbanken.inc11N/A
Leafincludes/banks/luottokunta.inc000
Expandincludes/banks/nordea.inc200
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOthernordea.inc16N/A
There should be no trailing spacesOthernordea.inc21N/A
Leafincludes/banks/osuuspankki.inc000
Leafincludes/banks/sampopankki.inc000
Leafincludes/banks/spankki.inc000
Leafincludes/banks/tapiola.inc000