Backup and Migrate - 6.x-2.x

Test status
StatusResult
Last receivedThu, 06/28/2012 - 13:18:15
Last requestedThu, 06/28/2012 - 13:19:03
Last testedThu, 06/28/2012 - 13:19:23
Test count2
Environment status
MySQLfail
Code reviewfail
Overall Resultfail
Branch information
Identifier6.x-2.x
ProjectBackup and Migrate
LinkProject information
SummaryFAILED: [[Coder]]: [Code review] 73 minor(s), 4 critical(s), and 24 normal(s); [[SimpleTest]]: [MySQL] 50 pass(es), 1 fail(s), and 0 exception(s).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
    Review the test failures below then if necessary run them locally until the problem has been fixed.
  10. Complete test suite with all tests passing
50 pass(es), 1 fail(s), and 0 exception(s)

Non-pass

Test namePassFailException
ExpandBackupMigrateUnitTest010
MessageGroupFilenameLineFunctionStatus
The test did not complete due to a fatal error.Completion checkbackup_migrate.unit.test33BackupMigrateUnitTest->testTakeOfflineOnline()

All

Test namePassFailException
LeafBackupMigrateFunctionalityTest5000
ExpandBackupMigrateUnitTest010
MessageGroupFilenameLineFunctionStatus
The test did not complete due to a fatal error.Completion checkbackup_migrate.unit.test33BackupMigrateUnitTest->testTakeOfflineOnline()

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
73 minor(s), 4 critical(s), and 24 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandbackup_migrate.install201
MessageGroupFilenameLineFunctionStatus
Use an indent of 2 spaces, with no tabsOtherbackup_migrate.install99N/A
missing space after commaOtherbackup_migrate.install251N/A
There should be no trailing spacesOtherbackup_migrate.install314N/A
Expandbackup_migrate.module1024
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherbackup_migrate.module21N/A
Use an indent of 2 spaces, with no tabsOtherbackup_migrate.module22N/A
Use an indent of 2 spaces, with no tabsOtherbackup_migrate.module23N/A
There should be no trailing spacesOtherbackup_migrate.module24N/A
There should be no trailing spacesOtherbackup_migrate.module31N/A
There should be no trailing spacesOtherbackup_migrate.module37N/A
There should be no trailing spacesOtherbackup_migrate.module61N/A
Control statements should have one space between the control keyword and opening parenthesisOtherbackup_migrate.module76N/A
There should be no trailing spacesOtherbackup_migrate.module159N/A
There should be no trailing spacesOtherbackup_migrate.module228N/A
Potential problem: when FAPI element '#type' is set to 'markup' (default), '#value' only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherbackup_migrate.module412N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherbackup_migrate.module586N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherbackup_migrate.module587N/A
There should be no trailing spacesOtherbackup_migrate.module671N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otherbackup_migrate.module937N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherbackup_migrate.module966N/A
Expandincludes/backup_migrate.drush.inc402
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherbackup_migrate.drush.inc8N/A
There should be no trailing spacesOtherbackup_migrate.drush.inc18N/A
There should be no trailing spacesOtherbackup_migrate.drush.inc19N/A
There should be no trailing spacesOtherbackup_migrate.drush.inc20N/A
Control statements should have one space between the control keyword and opening parenthesisOtherbackup_migrate.drush.inc99N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherbackup_migrate.drush.inc167N/A
Expandincludes/crud.inc815
MessageGroupFilenameLineFunctionStatus
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOthercrud.inc93N/A
Potential problem: confirm_form() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Othercrud.inc153N/A
Use "elseif" in place of "else if"Othercrud.inc248N/A
There should be no trailing spacesOthercrud.inc264N/A
There should be no trailing spacesOthercrud.inc274N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOthercrud.inc403N/A
There should be no trailing spacesOthercrud.inc415N/A
Use "elseif" in place of "else if"Othercrud.inc436N/A
Use "elseif" in place of "else if"Othercrud.inc442N/A
There should be no trailing spacesOthercrud.inc454N/A
There should be no trailing spacesOthercrud.inc477N/A
There should be no trailing spacesOthercrud.inc486N/A
There should be no trailing spacesOthercrud.inc497N/A
There should be no trailing spacesOthercrud.inc556N/A
Expandincludes/destinations.inc503
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherdestinations.inc45N/A
indent secondary line of comment one space Otherdestinations.inc140N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherdestinations.inc366N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherdestinations.inc367N/A
There should be no trailing spacesOtherdestinations.inc731N/A
There should be no trailing spacesOtherdestinations.inc744N/A
There should be no trailing spacesOtherdestinations.inc835N/A
The $string argument to t() should not begin or end with a space. (Drupal Docs)Otherdestinations.inc1064N/A
Expandincludes/destinations.s3.inc002
MessageGroupFilenameLineFunctionStatus
Control statements should have one space between the control keyword and opening parenthesisOtherdestinations.s3.inc172N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherdestinations.s3.inc181N/A
Expandincludes/filters.backup_restore.inc110
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherfilters.backup_restore.inc79N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherfilters.backup_restore.inc86N/A
Expandincludes/profiles.inc402
MessageGroupFilenameLineFunctionStatus
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherprofiles.inc128N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherprofiles.inc129N/A
There should be no trailing spacesOtherprofiles.inc151N/A
There should be no trailing spacesOtherprofiles.inc210N/A
There should be no trailing spacesOtherprofiles.inc218N/A
There should be no trailing spacesOtherprofiles.inc231N/A
Expandtests/backup_migrate.functionality.test301
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherbackup_migrate.functionality.test-1N/A
indent secondary line of comment one space Otherbackup_migrate.functionality.test5N/A
indent secondary line of comment one space Otherbackup_migrate.functionality.test6N/A
indent secondary line of comment one space Otherbackup_migrate.functionality.test35N/A
Expandtests/backup_migrate.unit.test904
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherbackup_migrate.unit.test-1N/A
indent secondary line of comment one space Otherbackup_migrate.unit.test5N/A
indent secondary line of comment one space Otherbackup_migrate.unit.test6N/A
There should be no trailing spacesOtherbackup_migrate.unit.test38N/A
There should be no trailing spacesOtherbackup_migrate.unit.test40N/A
There should be no trailing spacesOtherbackup_migrate.unit.test45N/A
There should be no trailing spacesOtherbackup_migrate.unit.test65N/A
There should be no trailing spacesOtherbackup_migrate.unit.test81N/A
There should be no trailing spacesOtherbackup_migrate.unit.test84N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherbackup_migrate.unit.test89N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherbackup_migrate.unit.test95N/A
missing space after commaOtherbackup_migrate.unit.test95N/A
There should be no trailing spacesOtherbackup_migrate.unit.test96N/A

All

Test nameMinorCriticalNormal
Expandbackup_migrate.install201
MessageGroupFilenameLineFunctionStatus
Use an indent of 2 spaces, with no tabsOtherbackup_migrate.install99N/A
missing space after commaOtherbackup_migrate.install251N/A
There should be no trailing spacesOtherbackup_migrate.install314N/A
Expandbackup_migrate.module1024
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherbackup_migrate.module21N/A
Use an indent of 2 spaces, with no tabsOtherbackup_migrate.module22N/A
Use an indent of 2 spaces, with no tabsOtherbackup_migrate.module23N/A
There should be no trailing spacesOtherbackup_migrate.module24N/A
There should be no trailing spacesOtherbackup_migrate.module31N/A
There should be no trailing spacesOtherbackup_migrate.module37N/A
There should be no trailing spacesOtherbackup_migrate.module61N/A
Control statements should have one space between the control keyword and opening parenthesisOtherbackup_migrate.module76N/A
There should be no trailing spacesOtherbackup_migrate.module159N/A
There should be no trailing spacesOtherbackup_migrate.module228N/A
Potential problem: when FAPI element '#type' is set to 'markup' (default), '#value' only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherbackup_migrate.module412N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherbackup_migrate.module586N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherbackup_migrate.module587N/A
There should be no trailing spacesOtherbackup_migrate.module671N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otherbackup_migrate.module937N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherbackup_migrate.module966N/A
Expandincludes/backup_migrate.drush.inc402
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherbackup_migrate.drush.inc8N/A
There should be no trailing spacesOtherbackup_migrate.drush.inc18N/A
There should be no trailing spacesOtherbackup_migrate.drush.inc19N/A
There should be no trailing spacesOtherbackup_migrate.drush.inc20N/A
Control statements should have one space between the control keyword and opening parenthesisOtherbackup_migrate.drush.inc99N/A
Functions should be called with no spaces between the function name and opening parenthesesOtherbackup_migrate.drush.inc167N/A
Expandincludes/crud.inc815
MessageGroupFilenameLineFunctionStatus
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOthercrud.inc93N/A
Potential problem: confirm_form() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Othercrud.inc153N/A
Use "elseif" in place of "else if"Othercrud.inc248N/A
There should be no trailing spacesOthercrud.inc264N/A
There should be no trailing spacesOthercrud.inc274N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOthercrud.inc403N/A
There should be no trailing spacesOthercrud.inc415N/A
Use "elseif" in place of "else if"Othercrud.inc436N/A
Use "elseif" in place of "else if"Othercrud.inc442N/A
There should be no trailing spacesOthercrud.inc454N/A
There should be no trailing spacesOthercrud.inc477N/A
There should be no trailing spacesOthercrud.inc486N/A
There should be no trailing spacesOthercrud.inc497N/A
There should be no trailing spacesOthercrud.inc556N/A
Expandincludes/destinations.browser.inc100
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherdestinations.browser.inc17N/A
Expandincludes/destinations.db.inc500
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherdestinations.db.inc27N/A
Use an indent of 2 spaces, with no tabsOtherdestinations.db.inc91N/A
Use an indent of 2 spaces, with no tabsOtherdestinations.db.inc95N/A
There should be no trailing spacesOtherdestinations.db.inc220N/A
There should be no trailing spacesOtherdestinations.db.inc226N/A
Expandincludes/destinations.db.mysql.inc1200
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherdestinations.db.mysql.inc124N/A
There should be no trailing spacesOtherdestinations.db.mysql.inc202N/A
There should be no trailing spacesOtherdestinations.db.mysql.inc209N/A
There should be no trailing spacesOtherdestinations.db.mysql.inc213N/A
There should be no trailing spacesOtherdestinations.db.mysql.inc221N/A
There should be no trailing spacesOtherdestinations.db.mysql.inc233N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherdestinations.db.mysql.inc237N/A
There should be no trailing spacesOtherdestinations.db.mysql.inc239N/A
There should be no trailing spacesOtherdestinations.db.mysql.inc253N/A
There should be no trailing spacesOtherdestinations.db.mysql.inc256N/A
There should be no trailing spacesOtherdestinations.db.mysql.inc273N/A
There should be no trailing spacesOtherdestinations.db.mysql.inc279N/A
Leafincludes/destinations.email.inc000
Expandincludes/destinations.file.inc100
MessageGroupFilenameLineFunctionStatus
in most cases, replace the string function with the drupal_ equivalent string functionsOtherdestinations.file.inc165N/A
Expandincludes/destinations.ftp.inc100
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherdestinations.ftp.inc232N/A
Expandincludes/destinations.inc503
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherdestinations.inc45N/A
indent secondary line of comment one space Otherdestinations.inc140N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherdestinations.inc366N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherdestinations.inc367N/A
There should be no trailing spacesOtherdestinations.inc731N/A
There should be no trailing spacesOtherdestinations.inc744N/A
There should be no trailing spacesOtherdestinations.inc835N/A
The $string argument to t() should not begin or end with a space. (Drupal Docs)Otherdestinations.inc1064N/A
Expandincludes/destinations.s3.inc002
MessageGroupFilenameLineFunctionStatus
Control statements should have one space between the control keyword and opening parenthesisOtherdestinations.s3.inc172N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherdestinations.s3.inc181N/A
Expandincludes/files.inc100
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherfiles.inc76N/A
Expandincludes/filters.backup_restore.inc110
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherfilters.backup_restore.inc79N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherfilters.backup_restore.inc86N/A
Leafincludes/filters.compression.inc000
Expandincludes/filters.encryption.inc200
MessageGroupFilenameLineFunctionStatus
in most cases, replace the string function with the drupal_ equivalent string functionsOtherfilters.encryption.inc117N/A
There should be no trailing spacesOtherfilters.encryption.inc164N/A
Leafincludes/filters.inc000
Expandincludes/filters.statusnotify.inc100
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherfilters.statusnotify.inc15N/A
Leafincludes/filters.utils.inc000
Expandincludes/profiles.inc402
MessageGroupFilenameLineFunctionStatus
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherprofiles.inc128N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSEOtherprofiles.inc129N/A
There should be no trailing spacesOtherprofiles.inc151N/A
There should be no trailing spacesOtherprofiles.inc210N/A
There should be no trailing spacesOtherprofiles.inc218N/A
There should be no trailing spacesOtherprofiles.inc231N/A
Expandincludes/schedules.inc300
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOtherschedules.inc78N/A
There should be no trailing spacesOtherschedules.inc386N/A
There should be no trailing spacesOtherschedules.inc389N/A
Expandtests/backup_migrate.functionality.test301
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherbackup_migrate.functionality.test-1N/A
indent secondary line of comment one space Otherbackup_migrate.functionality.test5N/A
indent secondary line of comment one space Otherbackup_migrate.functionality.test6N/A
indent secondary line of comment one space Otherbackup_migrate.functionality.test35N/A
Expandtests/backup_migrate.unit.test904
MessageGroupFilenameLineFunctionStatus
@file block missing (Drupal Docs)Otherbackup_migrate.unit.test-1N/A
indent secondary line of comment one space Otherbackup_migrate.unit.test5N/A
indent secondary line of comment one space Otherbackup_migrate.unit.test6N/A
There should be no trailing spacesOtherbackup_migrate.unit.test38N/A
There should be no trailing spacesOtherbackup_migrate.unit.test40N/A
There should be no trailing spacesOtherbackup_migrate.unit.test45N/A
There should be no trailing spacesOtherbackup_migrate.unit.test65N/A
There should be no trailing spacesOtherbackup_migrate.unit.test81N/A
There should be no trailing spacesOtherbackup_migrate.unit.test84N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherbackup_migrate.unit.test89N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherbackup_migrate.unit.test95N/A
missing space after commaOtherbackup_migrate.unit.test95N/A
There should be no trailing spacesOtherbackup_migrate.unit.test96N/A