Web service client - 7.x-1.x

Test status
StatusResult
Last receivedSat, 06/16/2012 - 13:01:55
Last requestedSat, 06/16/2012 - 13:02:04
Last testedSat, 06/16/2012 - 13:03:22
Test count2
Environment status
MySQLfail
Code reviewfail
Overall Resultfail
Branch information
Identifier7.x-1.x
ProjectWeb service client
LinkProject information
SummaryFAILED: [[Coder]]: [Code review] 23 minor(s), 1 critical(s), and 2 normal(s); [[SimpleTest]]: [MySQL] 7 pass(es), 3 fail(s), and 1 exception(s).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
    Review the test failures below then if necessary run them locally until the problem has been fixed.
  10. Complete test suite with all tests passing
7 pass(es), 3 fail(s), and 1 exception(s)

Non-pass

Test namePassFailException
ExpandWeb service client REST (WSClientRESTTestCase) [Services]110
MessageGroupFilenameLineFunctionStatus
REST service invocation was successful.Otherwsclient_examples.test87WSClientRESTTestCase->testServiceInvocation()
ExpandWeb service client REST Rules (WSClientRESTRulesTestCase) [Services]121
MessageGroupFilenameLineFunctionStatus
REST service invoked via the action.Otherwsclient_examples.test113WSClientRESTRulesTestCase->testRulesIntegration()
array_pop() expects parameter 1 to be array, null givenWarningwsclient_examples.test125WSClientRESTRulesTestCase->testRulesIntegration()
REST service has been invoked.Otherwsclient_examples.test125WSClientRESTRulesTestCase->testRulesIntegration()

All

Test namePassFailException
ExpandWeb service client REST (WSClientRESTTestCase) [Services]110
MessageGroupFilenameLineFunctionStatus
REST service invocation was successful.Otherwsclient_examples.test87WSClientRESTTestCase->testServiceInvocation()
ExpandWeb service client REST Rules (WSClientRESTRulesTestCase) [Services]121
MessageGroupFilenameLineFunctionStatus
REST service invoked via the action.Otherwsclient_examples.test113WSClientRESTRulesTestCase->testRulesIntegration()
array_pop() expects parameter 1 to be array, null givenWarningwsclient_examples.test125WSClientRESTRulesTestCase->testRulesIntegration()
REST service has been invoked.Otherwsclient_examples.test125WSClientRESTRulesTestCase->testRulesIntegration()
LeafWeb service client SOAP (WSClientSOAPTestCase) [Services]200
LeafWeb service client SOAP Rules (WSClientSOAPRulesTestCase) [Services]300

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
23 minor(s), 1 critical(s), and 2 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandwsclient.inc001
MessageGroupFilenameLineFunctionStatus
missing space after commaOtherwsclient.inc119N/A
Expandwsclient.rules.inc301
MessageGroupFilenameLineFunctionStatus
Control statements should have one space between the control keyword and opening parenthesisOtherwsclient.rules.inc97N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherwsclient.rules.inc122N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherwsclient.rules.inc123N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherwsclient.rules.inc146N/A
Expandwsclient_ui/wsclient_ui.inc510
MessageGroupFilenameLineFunctionStatus
@see should always be followed by a filename, a URL, class/interface name (optionally including method), or a function name including ().Otherwsclient_ui.inc17N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherwsclient_ui.inc374N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherwsclient_ui.inc442N/A
Potential problem: form_set_error() and form_error() only accept filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otherwsclient_ui.inc686N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherwsclient_ui.inc891N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherwsclient_ui.inc966N/A

All

Test nameMinorCriticalNormal
Expandwsclient.api.php100
MessageGroupFilenameLineFunctionStatus
@see should always be followed by a filename, a URL, class/interface name (optionally including method), or a function name including ().Otherwsclient.api.php29N/A
Leafwsclient.features.inc000
Expandwsclient.inc001
MessageGroupFilenameLineFunctionStatus
missing space after commaOtherwsclient.inc119N/A
Leafwsclient.install000
Expandwsclient.module100
MessageGroupFilenameLineFunctionStatus
in most cases, replace the string function with the drupal_ equivalent string functionsOtherwsclient.module242N/A
Expandwsclient.rules.inc301
MessageGroupFilenameLineFunctionStatus
Control statements should have one space between the control keyword and opening parenthesisOtherwsclient.rules.inc97N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherwsclient.rules.inc122N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherwsclient.rules.inc123N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherwsclient.rules.inc146N/A
Leafwsclient_examples/wsclient_examples.module000
Expandwsclient_examples/wsclient_examples.test700
MessageGroupFilenameLineFunctionStatus
Use an indent of 2 spaces, with no tabsOtherwsclient_examples.test52N/A
Use an indent of 2 spaces, with no tabsOtherwsclient_examples.test57N/A
Use an indent of 2 spaces, with no tabsOtherwsclient_examples.test58N/A
Use an indent of 2 spaces, with no tabsOtherwsclient_examples.test112N/A
Use an indent of 2 spaces, with no tabsOtherwsclient_examples.test120N/A
Use an indent of 2 spaces, with no tabsOtherwsclient_examples.test121N/A
Use an indent of 2 spaces, with no tabsOtherwsclient_examples.test122N/A
Leafwsclient_rest/wsclient_rest.module000
Leafwsclient_soap/wsclient_soap.install000
Expandwsclient_soap/wsclient_soap.module600
MessageGroupFilenameLineFunctionStatus
in most cases, replace the string function with the drupal_ equivalent string functionsOtherwsclient_soap.module152N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherwsclient_soap.module156N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherwsclient_soap.module199N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherwsclient_soap.module207N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherwsclient_soap.module237N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherwsclient_soap.module238N/A
Expandwsclient_ui/wsclient_ui.inc510
MessageGroupFilenameLineFunctionStatus
@see should always be followed by a filename, a URL, class/interface name (optionally including method), or a function name including ().Otherwsclient_ui.inc17N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherwsclient_ui.inc374N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherwsclient_ui.inc442N/A
Potential problem: form_set_error() and form_error() only accept filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otherwsclient_ui.inc686N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherwsclient_ui.inc891N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherwsclient_ui.inc966N/A
Leafwsclient_ui/wsclient_ui.install000
Leafwsclient_ui/wsclient_ui.module000