Code review
- Setup environment
- Detect an invalid patch URL
- Detect invalid repository information
- Detect invalid patch format
- Detect a non-applicable patch
- Detect invalid PHP syntax
- Detect a review run failure
- Detect coder flags
Ensure that your code follows the Drupal standard and passes a coder review.
- Complete coder review with all passed
4 minor(s), 2 critical(s), and 1 normal(s)
Non-pass
Test name | Minor | Critical | Normal |
domain_meta.admin.inc | 0 | 1 | 0 |
Message | Group | Filename | Line | Function | Status |
Potential problem: drupal_set_title() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs) | Other | domain_meta.admin.inc | 16 | N/A | |
|
domain_meta.install | 1 | 0 | 1 |
Message | Group | Filename | Line | Function | Status |
Use st() instead of t() in hook_install(), hook_uninstall() and hook_update_N() | Other | domain_meta.install | 40 | N/A | |
Format should be * Implementation of hook_foo(). | Other | domain_meta.install | 71 | N/A | |
|
domain_meta.module | 3 | 1 | 0 |
Message | Group | Filename | Line | Function | Status |
in most cases, replace the string function with the drupal_ equivalent string functions | Other | domain_meta.module | 77 | N/A | |
There should be no trailing spaces | Other | domain_meta.module | 224 | N/A | |
There should be no trailing spaces | Other | domain_meta.module | 235 | N/A | |
Potential problem: when FAPI element '#type' is set to 'markup' (default), '#value' only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. | Other | domain_meta.module | 354 | N/A | |
|
All
Test name | Minor | Critical | Normal |
domain_meta.admin.inc | 0 | 1 | 0 |
Message | Group | Filename | Line | Function | Status |
Potential problem: drupal_set_title() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs) | Other | domain_meta.admin.inc | 16 | N/A | |
|
domain_meta.install | 1 | 0 | 1 |
Message | Group | Filename | Line | Function | Status |
Use st() instead of t() in hook_install(), hook_uninstall() and hook_update_N() | Other | domain_meta.install | 40 | N/A | |
Format should be * Implementation of hook_foo(). | Other | domain_meta.install | 71 | N/A | |
|
domain_meta.module | 3 | 1 | 0 |
Message | Group | Filename | Line | Function | Status |
in most cases, replace the string function with the drupal_ equivalent string functions | Other | domain_meta.module | 77 | N/A | |
There should be no trailing spaces | Other | domain_meta.module | 224 | N/A | |
There should be no trailing spaces | Other | domain_meta.module | 235 | N/A | |
Potential problem: when FAPI element '#type' is set to 'markup' (default), '#value' only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. | Other | domain_meta.module | 354 | N/A | |
|