Domain Meta Tags - 6.x-1.x

Test status
StatusResult
Last receivedThu, 09/27/2012 - 11:35:04
Last requestedThu, 09/27/2012 - 11:35:04
Last testedThu, 09/27/2012 - 11:35:35
Test count12
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier6.x-1.x
ProjectDomain Meta Tags
LinkProject information
SummaryPASSED: [[Coder]]: [Code review] 4 minor(s), 2 critical(s), and 1 normal(s); [[SimpleTest]]: [MySQL] 0 pass(es).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
4 minor(s), 2 critical(s), and 1 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expanddomain_meta.admin.inc010
MessageGroupFilenameLineFunctionStatus
Potential problem: drupal_set_title() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otherdomain_meta.admin.inc16N/A
Expanddomain_meta.install101
MessageGroupFilenameLineFunctionStatus
Use st() instead of t() in hook_install(), hook_uninstall() and hook_update_N()Otherdomain_meta.install40N/A
Format should be * Implementation of hook_foo().Otherdomain_meta.install71N/A
Expanddomain_meta.module310
MessageGroupFilenameLineFunctionStatus
in most cases, replace the string function with the drupal_ equivalent string functionsOtherdomain_meta.module77N/A
There should be no trailing spacesOtherdomain_meta.module224N/A
There should be no trailing spacesOtherdomain_meta.module235N/A
Potential problem: when FAPI element '#type' is set to 'markup' (default), '#value' only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherdomain_meta.module354N/A

All

Test nameMinorCriticalNormal
Expanddomain_meta.admin.inc010
MessageGroupFilenameLineFunctionStatus
Potential problem: drupal_set_title() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otherdomain_meta.admin.inc16N/A
Expanddomain_meta.install101
MessageGroupFilenameLineFunctionStatus
Use st() instead of t() in hook_install(), hook_uninstall() and hook_update_N()Otherdomain_meta.install40N/A
Format should be * Implementation of hook_foo().Otherdomain_meta.install71N/A
Expanddomain_meta.module310
MessageGroupFilenameLineFunctionStatus
in most cases, replace the string function with the drupal_ equivalent string functionsOtherdomain_meta.module77N/A
There should be no trailing spacesOtherdomain_meta.module224N/A
There should be no trailing spacesOtherdomain_meta.module235N/A
Potential problem: when FAPI element '#type' is set to 'markup' (default), '#value' only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Otherdomain_meta.module354N/A