Google Fonts - 7.x-2.x | Drupal Quality Assurance

Latest changes

So Long and Thanks for all the Tests

1 week 2 days ago

Support

In case of troubles

check the FAQ. Please make sure you've tried the test locally.
search known testbot issues and then create a new issue if yours isn't there already. Please give a link to the test.

Test client logs

No clients to display.

Google Fonts - 7.x-2.x

Test status

Status	Result
Last received	Fri, 06/08/2012 - 18:06:34
Last requested	Fri, 06/08/2012 - 18:07:04
Last tested	Fri, 06/08/2012 - 18:07:37
Test count	2

Environment status

MySQL	pass
Code review	fail

Overall Result	pass

Branch information

Identifier	7.x-2.x
Project	Google Fonts
Link	Project information

Event logView entire log

ID	Message	Timestamp
3870853	Result retrieved by project client.	3 years 37 weeks ago
3870848	Result received from test client #659.	3 years 37 weeks ago
3870843	Result received from test client #664.	3 years 37 weeks ago
3870838	Requested by test client #664.	3 years 37 weeks ago
3870833	Requested by test client #659.	3 years 37 weeks ago
3870828	Test request received.	3 years 37 weeks ago

SummaryPASSED: [[Coder]]: [Code review] 67 minor(s), 3 critical(s), and 1 normal(s); [[SimpleTest]]: [MySQL] 0 pass(es).

Details

MySQL
Code review

MySQL

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a Drupal installation failure
Detect a test run failure
Detect a failing test
Complete test suite with all tests passing

Review log

Code review

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a review run failure
Detect coder flags
Ensure that your code follows the Drupal standard and passes a coder review.
Complete coder review with all passed

67 minor(s), 3 critical(s), and 1 normal(s)

Non-pass

Test name

Minor

Critical

Normal

google_fonts.admin.inc

Message	Group	Filename	Line	Function
There should be no trailing spaces	Other	google_fonts.admin.inc	12	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	14	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	21	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	26	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	31	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	37	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	45	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	52	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	65	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	66	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	68	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	83	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	87	N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	google_fonts.admin.inc	92	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	93	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	95	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	101	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	103	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	109	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	111	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	117	N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	google_fonts.admin.inc	123	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	132	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	143	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	144	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	154	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	160	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	174	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	181	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	192	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	201	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	208	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	219	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	226	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	228	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	239	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	243	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	247	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	251	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	255	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	262	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	268	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	272	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	283	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	google_fonts.admin.inc	293	N/A
There should be no trailing spaces	Other	google_fonts.admin.inc	299	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	google_fonts.admin.inc	304	N/A

google_fonts.install

Message	Group	Filename	Line	Function
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	google_fonts.install	9	N/A
There should be no trailing spaces	Other	google_fonts.install	26	N/A
Use update_sql() instead of db_query() in hook_update_N()	Other	google_fonts.install	43	N/A
There should be no trailing spaces	Other	google_fonts.install	47	N/A
There should be no trailing spaces	Other	google_fonts.install	51	N/A

All