simpleSAMLphp Authentication - 7.x-2.x | Drupal Quality Assurance

Latest changes

So Long and Thanks for all the Tests

1 week 2 days ago

Support

In case of troubles

check the FAQ. Please make sure you've tried the test locally.
search known testbot issues and then create a new issue if yours isn't there already. Please give a link to the test.

Test client logs

No clients to display.

simpleSAMLphp Authentication - 7.x-2.x

Test status

Status	Result
Last received	Fri, 06/08/2012 - 14:50:11
Last requested	Fri, 06/08/2012 - 14:51:18
Last tested	Fri, 06/08/2012 - 14:51:38
Test count	2

Environment status

MySQL	pass
Code review	fail

Overall Result	pass

Branch information

Identifier	7.x-2.x
Project	simpleSAMLphp Authentication
Link	Project information

Event logView entire log

ID	Message	Timestamp
3869623	Result retrieved by project client.	3 years 37 weeks ago
3869613	Result received from test client #664.	3 years 37 weeks ago
3869608	Result received from test client #659.	3 years 37 weeks ago
3869598	Requested by test client #659.	3 years 37 weeks ago
3869588	Requested by test client #664.	3 years 37 weeks ago
3869563	Test request received.	3 years 37 weeks ago

SummaryPASSED: [[Coder]]: [Code review] 9 minor(s), 2 critical(s), and 21 normal(s); [[SimpleTest]]: [MySQL] 0 pass(es).

Details

MySQL
Code review

MySQL

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a Drupal installation failure
Detect a test run failure
Detect a failing test
Complete test suite with all tests passing

Review log

[07:51:09] Log initialized (/var/lib/drupaltestbot/sites/default/files/review.test_282633.pifr_simpletest.1339167069.log)
[07:51:09] Review timestamp: (Fri, 06/08/2012 - 07:51)
[07:51:09] Review host: (drupaltestbot664-mysql)
[07:51:09] Environment variables and review information initialized.
[07:51:09] core_url = [git://git.drupal.org/project/drupal.git];  Test repository = [git://git.drupal.org/project/simplesamlphp_auth.git]
[07:51:09] Project directory is [simplesamlphp_auth]
[07:51:09] Review started.
[07:51:09] Invoking operation [setup]...
[07:51:09] Command [chmod -R u+w sites/default/files/checkout 2>&1] succeeded.
[07:51:09] Command [rm -rf sites/default/files/checkout 2>&1] succeeded.
[07:51:09] Command [rm -rf sites/default/files/review 2>&1] succeeded.
[07:51:09] Database backend [mysql] loaded.
[07:51:09] Invoking operation [fetch]...
[07:51:09] Invoking operation [checkout]...
[07:51:09] Version control system backend [git] loaded.
[07:51:10] Command [git clone 'git://git.drupal.org/project/drupal.git' 'checkout' --reference /var/cache/git/reference 2>&1] succeeded.
[07:51:11] Command [git --work-tree='checkout' --git-dir='checkout/.git' checkout '7.x' 2>&1] succeeded.
[07:51:11] Command [git --work-tree='checkout' --git-dir='checkout/.git' status 2>&1] succeeded.
[07:51:11] Main branch [7.x] checkout [complete].
[07:51:17] Command [git clone 'git://git.drupal.org/project/simplesamlphp_auth.git' '/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/simplesamlphp_auth' --reference /var/cache/git/reference 2>&1] succeeded.
[07:51:17] Command [git --work-tree='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/simplesamlphp_auth' --git-dir='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/simplesamlphp_auth/.git' checkout '7.x-2.x' 2>&1] succeeded.
[07:51:17] Command [git --work-tree='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/simplesamlphp_auth' --git-dir='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/simplesamlphp_auth/.git' status 2>&1] succeeded.
[07:51:17] Dependency branch [7.x-2.x] checkout [complete].
[07:51:17] Invoking operation [check]...
[07:51:17] Ignoring operation [check].
[07:51:17] Invoking operation [apply]...
[07:51:17] Ignoring operation [apply].
[07:51:17] Invoking operation [syntax]...
[07:51:17] Command [php -l -f './sites/default/modules/simplesamlphp_auth/simplesamlphp_auth.module' 2>&1] succeeded.
[07:51:17] Command [php -l -f './sites/default/modules/simplesamlphp_auth/simplesamlphp_auth.rules.inc' 2>&1] succeeded.
[07:51:17] Command [php -l -f './sites/default/modules/simplesamlphp_auth/simplesamlphp_auth.install' 2>&1] succeeded.
[07:51:17] Checked [3 of 3] relevant file(s) for syntax.
[07:51:17] Invoking operation [install]...
[07:51:30] Invoking operation [review]...
[07:51:34] Cleaning run-tests.sh environment.
[07:51:35] Command [/usr/bin/php ./scripts/run-tests.sh --concurrency 8 --php /usr/bin/php --url 'http://drupaltestbot664-mysql/checkout' --file  --clean 2>&1] succeeded.
[07:51:35] No Simpletest tests found.  Skipping execution of run_tests.sh.
[07:51:35] Command [/usr/bin/php ./scripts/run-tests.sh --php /usr/bin/php --url 'http://drupaltestbot664-mysql/checkout' --file  --list 2>&1] succeeded.
[07:51:35] Review complete. test_id=282633 result code=10 details=Array
(
    [@pass] => 0
    [@fail] => 0
    [@exception] => 0
    [@debug] => 0
)

[07:51:35] Static variables reset.

Code review

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a review run failure
Detect coder flags
Ensure that your code follows the Drupal standard and passes a coder review.
Complete coder review with all passed

9 minor(s), 2 critical(s), and 21 normal(s)

Non-pass

Test name

Minor

Critical

Normal

simplesamlphp_auth.module

Message	Group	Filename	Line	Function
do not use mixed case (camelCase), use lower case and _	Other	simplesamlphp_auth.module	106	N/A
do not use mixed case (camelCase), use lower case and _	Other	simplesamlphp_auth.module	109	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	simplesamlphp_auth.module	238	N/A
do not use mixed case (camelCase), use lower case and _	Other	simplesamlphp_auth.module	291	N/A
do not use mixed case (camelCase), use lower case and _	Other	simplesamlphp_auth.module	292	N/A
do not use mixed case (camelCase), use lower case and _	Other	simplesamlphp_auth.module	294	N/A
do not use mixed case (camelCase), use lower case and _	Other	simplesamlphp_auth.module	297	N/A
There should be no trailing spaces	Other	simplesamlphp_auth.module	298	N/A
do not use mixed case (camelCase), use lower case and _	Other	simplesamlphp_auth.module	301	N/A
do not use mixed case (camelCase), use lower case and _	Other	simplesamlphp_auth.module	304	N/A
do not use mixed case (camelCase), use lower case and _	Other	simplesamlphp_auth.module	308	N/A
do not use mixed case (camelCase), use lower case and _	Other	simplesamlphp_auth.module	309	N/A
There should be no trailing spaces	Other	simplesamlphp_auth.module	322	N/A
There should be no trailing spaces	Other	simplesamlphp_auth.module	324	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	simplesamlphp_auth.module	347	N/A
There should be no trailing spaces	Other	simplesamlphp_auth.module	374	N/A
There should be no trailing spaces	Other	simplesamlphp_auth.module	376	N/A
There should be no trailing spaces	Other	simplesamlphp_auth.module	431	N/A
There should be no trailing spaces	Other	simplesamlphp_auth.module	457	N/A
There should be no trailing spaces	Other	simplesamlphp_auth.module	461	N/A
The $text argument to l() should be enclosed within t() so that it is translatable.	Other	simplesamlphp_auth.module	550	N/A
The $text argument to l() should be enclosed within t() so that it is translatable.	Other	simplesamlphp_auth.module	557	N/A
do not use mixed case (camelCase), use lower case and _	Other	simplesamlphp_auth.module	607	N/A
do not use mixed case (camelCase), use lower case and _	Other	simplesamlphp_auth.module	611	N/A
do not use mixed case (camelCase), use lower case and _	Other	simplesamlphp_auth.module	614	N/A
do not use mixed case (camelCase), use lower case and _	Other	simplesamlphp_auth.module	615	N/A
do not use mixed case (camelCase), use lower case and _	Other	simplesamlphp_auth.module	616	N/A
The $text argument to l() should be enclosed within t() so that it is translatable.	Other	simplesamlphp_auth.module	616	N/A
do not use mixed case (camelCase), use lower case and _	Other	simplesamlphp_auth.module	640	N/A
The $text argument to l() should be enclosed within t() so that it is translatable.	Other	simplesamlphp_auth.module	746	N/A
The $text argument to l() should be enclosed within t() so that it is translatable.	Other	simplesamlphp_auth.module	749	N/A

All