Galleria - 7.x-1.0-beta3 | Drupal Quality Assurance

Latest changes

So Long and Thanks for all the Tests

1 week 2 days ago

Support

In case of troubles

check the FAQ. Please make sure you've tried the test locally.
search known testbot issues and then create a new issue if yours isn't there already. Please give a link to the test.

Test client logs

No clients to display.

Galleria - 7.x-1.0-beta3

Test status

Status	Result
Last received	Thu, 06/07/2012 - 18:41:19
Last requested	Thu, 06/07/2012 - 18:42:03
Last tested	Thu, 06/07/2012 - 18:42:11
Test count	2

Environment status

MySQL	pass
Code review	fail

Overall Result	pass

Branch information

Identifier	7.x-1.0-beta3
Project	Galleria
Link	Project information

Event logView entire log

ID	Message	Timestamp
3866133	Result retrieved by project client.	3 years 37 weeks ago
3866128	Result received from test client #659.	3 years 37 weeks ago
3866123	Result received from test client #664.	3 years 37 weeks ago
3866118	Requested by test client #659.	3 years 37 weeks ago
3866103	Requested by test client #664.	3 years 37 weeks ago
3866088	Test request received.	3 years 37 weeks ago

SummaryPASSED: [[SimpleTest]]: [MySQL] 0 pass(es); [[Coder]]: [Code review] 8 minor(s), 1 critical(s), and 10 normal(s).

Details

MySQL
Code review

MySQL

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a Drupal installation failure
Detect a test run failure
Detect a failing test
Complete test suite with all tests passing

Review log

[11:41:32] Log initialized (/var/lib/drupaltestbot/sites/default/files/review.test_282153.pifr_simpletest.1339094492.log)
[11:41:32] Review timestamp: (Thu, 06/07/2012 - 11:41)
[11:41:32] Review host: (drupaltestbot664-mysql)
[11:41:32] Environment variables and review information initialized.
[11:41:32] core_url = [git://git.drupal.org/project/drupal.git];  Test repository = [git://git.drupal.org/project/galleria.git]
[11:41:32] Project directory is [galleria]
[11:41:32] Review started.
[11:41:32] Invoking operation [setup]...
[11:41:32] Command [chmod -R u+w sites/default/files/checkout 2>&1] succeeded.
[11:41:32] Command [rm -rf sites/default/files/checkout 2>&1] succeeded.
[11:41:32] Command [rm -rf sites/default/files/review 2>&1] succeeded.
[11:41:32] Database backend [mysql] loaded.
[11:41:32] Invoking operation [fetch]...
[11:41:32] Invoking operation [checkout]...
[11:41:32] Version control system backend [git] loaded.
[11:41:33] Command [git clone 'git://git.drupal.org/project/drupal.git' 'checkout' --reference /var/cache/git/reference 2>&1] succeeded.
[11:41:34] Command [git --work-tree='checkout' --git-dir='checkout/.git' checkout '7.x' 2>&1] succeeded.
[11:41:34] Command [git --work-tree='checkout' --git-dir='checkout/.git' status 2>&1] succeeded.
[11:41:34] Main branch [7.x] checkout [complete].
[11:41:35] Command [git clone 'git://git.drupal.org/project/libraries.git' '/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/libraries' --reference /var/cache/git/reference 2>&1] succeeded.
[11:41:35] Command [git --work-tree='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/libraries' --git-dir='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/libraries/.git' checkout '7.x-1.0' 2>&1] succeeded.
[11:41:35] Command [git --work-tree='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/libraries' --git-dir='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/libraries/.git' status 2>&1] succeeded.
[11:41:35] Dependency branch [7.x-1.0] checkout [complete].
[11:41:45] Command [git clone 'git://git.drupal.org/project/galleria.git' '/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/galleria' --reference /var/cache/git/reference 2>&1] succeeded.
[11:41:45] Command [git --work-tree='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/galleria' --git-dir='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/galleria/.git' checkout '7.x-1.0-beta3' 2>&1] succeeded.
[11:41:45] Command [git --work-tree='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/galleria' --git-dir='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/galleria/.git' status 2>&1] succeeded.
[11:41:45] Dependency branch [7.x-1.0-beta3] checkout [complete].
[11:41:45] Invoking operation [check]...
[11:41:45] Ignoring operation [check].
[11:41:45] Invoking operation [apply]...
[11:41:45] Ignoring operation [apply].
[11:41:45] Invoking operation [syntax]...
[11:41:46] Command [php -l -f './sites/default/modules/galleria/includes/galleria.admin.inc' 2>&1] succeeded.
[11:41:46] Command [php -l -f './sites/default/modules/galleria/includes/views_plugin_style_galleria.inc' 2>&1] succeeded.
[11:41:46] Command [php -l -f './sites/default/modules/galleria/theme/galleria-container.tpl.php' 2>&1] succeeded.
[11:41:46] Command [php -l -f './sites/default/modules/galleria/theme/theme.inc' 2>&1] succeeded.
[11:41:46] Command [php -l -f './sites/default/modules/galleria/galleria.module' 2>&1] succeeded.
[11:41:46] Command [php -l -f './sites/default/modules/galleria/galleria.views.inc' 2>&1] succeeded.
[11:41:46] Command [php -l -f './sites/default/modules/galleria/galleria.install' 2>&1] succeeded.
[11:41:46] Checked [7 of 7] relevant file(s) for syntax.
[11:41:46] Invoking operation [install]...
[11:41:59] Invoking operation [review]...
[11:42:02] Cleaning run-tests.sh environment.
[11:42:03] Command [/usr/bin/php ./scripts/run-tests.sh --concurrency 8 --php /usr/bin/php --url 'http://drupaltestbot664-mysql/checkout' --file  --clean 2>&1] succeeded.
[11:42:03] No Simpletest tests found.  Skipping execution of run_tests.sh.
[11:42:04] Command [/usr/bin/php ./scripts/run-tests.sh --php /usr/bin/php --url 'http://drupaltestbot664-mysql/checkout' --file  --list 2>&1] succeeded.
[11:42:04] Review complete. test_id=282153 result code=10 details=Array
(
    [@pass] => 0
    [@fail] => 0
    [@exception] => 0
    [@debug] => 0
)

[11:42:04] Static variables reset.

Code review

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a review run failure
Detect coder flags
Ensure that your code follows the Drupal standard and passes a coder review.
Complete coder review with all passed

8 minor(s), 1 critical(s), and 10 normal(s)

Non-pass

Test name

Minor

Critical

Normal

galleria.module

Message	Group	Filename	Line	Function
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	galleria.module	75	N/A
There should be no trailing spaces	Other	galleria.module	402	N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	galleria.module	421	N/A
There should be no trailing spaces	Other	galleria.module	509	N/A
There should be no trailing spaces	Other	galleria.module	514	N/A

includes/galleria.admin.inc

Message	Group	Filename	Line	Function
do not use mixed case (camelCase), use lower case and _	Other	galleria.admin.inc	121	N/A
do not use mixed case (camelCase), use lower case and _	Other	galleria.admin.inc	129	N/A
do not use mixed case (camelCase), use lower case and _	Other	galleria.admin.inc	199	N/A
do not use mixed case (camelCase), use lower case and _	Other	galleria.admin.inc	212	N/A
do not use mixed case (camelCase), use lower case and _	Other	galleria.admin.inc	246	N/A
do not use mixed case (camelCase), use lower case and _	Other	galleria.admin.inc	287	N/A
do not use mixed case (camelCase), use lower case and _	Other	galleria.admin.inc	405	N/A
do not use mixed case (camelCase), use lower case and _	Other	galleria.admin.inc	449	N/A
do not use mixed case (camelCase), use lower case and _	Other	galleria.admin.inc	456	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	galleria.admin.inc	717	N/A

All

Test name

Minor

Critical

Normal

galleria.install

galleria.module

Message	Group	Filename	Line	Function
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	galleria.module	75	N/A
There should be no trailing spaces	Other	galleria.module	402	N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	galleria.module	421	N/A
There should be no trailing spaces	Other	galleria.module	509	N/A
There should be no trailing spaces	Other	galleria.module	514	N/A

galleria.views.inc

includes/galleria.admin.inc

Message	Group	Filename	Line	Function
do not use mixed case (camelCase), use lower case and _	Other	galleria.admin.inc	121	N/A
do not use mixed case (camelCase), use lower case and _	Other	galleria.admin.inc	129	N/A
do not use mixed case (camelCase), use lower case and _	Other	galleria.admin.inc	199	N/A
do not use mixed case (camelCase), use lower case and _	Other	galleria.admin.inc	212	N/A
do not use mixed case (camelCase), use lower case and _	Other	galleria.admin.inc	246	N/A
do not use mixed case (camelCase), use lower case and _	Other	galleria.admin.inc	287	N/A
do not use mixed case (camelCase), use lower case and _	Other	galleria.admin.inc	405	N/A
do not use mixed case (camelCase), use lower case and _	Other	galleria.admin.inc	449	N/A
do not use mixed case (camelCase), use lower case and _	Other	galleria.admin.inc	456	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	galleria.admin.inc	717	N/A

includes/views_plugin_style_galleria.inc

theme/galleria-container.tpl.php

Message	Group	Filename	Line	Function	Status
indent secondary line of comment one space	Other	galleria-container.tpl.php	5	N/A

theme/theme.inc

Message	Group	Filename	Line	Function
There should be no trailing spaces	Other	theme.inc	5	N/A
Use an indent of 2 spaces, with no tabs	Other	theme.inc	42	N/A
Use an indent of 2 spaces, with no tabs	Other	theme.inc	45	N/A

Review log