Countries - 7.x-2.0 | Drupal Quality Assurance

Latest changes

So Long and Thanks for all the Tests

1 week 1 day ago

Support

In case of troubles

check the FAQ. Please make sure you've tried the test locally.
search known testbot issues and then create a new issue if yours isn't there already. Please give a link to the test.

Test client logs

No clients to display.

Countries - 7.x-2.0

Test status

Status	Result
Last received	Wed, 09/26/2012 - 04:31:30
Last requested	Wed, 09/26/2012 - 04:32:15
Last tested	Wed, 09/26/2012 - 04:34:22
Test count	4

Environment status

MySQL	pass
Code review	fail

Overall Result	pass

Branch information

Identifier	7.x-2.0
Project	Countries
Link	Project information

Event logView entire log

ID	Message	Timestamp
4411573	Result retrieved by project client.	3 years 21 weeks ago
4411548	Result received from test client #664.	3 years 21 weeks ago
4411538	Result received from test client #654.	3 years 21 weeks ago
4411528	Requested by test client #654.	3 years 21 weeks ago
4411518	Requested by test client #664.	3 years 21 weeks ago
4411493	Test request received.	3 years 21 weeks ago
3821878	Result retrieved by project client.	3 years 39 weeks ago
3821873	Result received from test client #659.	3 years 39 weeks ago
3821868	Result received from test client #654.	3 years 39 weeks ago
3821863	Requested by test client #654.	3 years 39 weeks ago

SummaryPASSED: [[Coder]]: [Code review] 5 minor(s), 7 critical(s), and 1 normal(s); [[SimpleTest]]: [MySQL] 747 pass(es).

Details

MySQL
Code review

MySQL

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a Drupal installation failure
Detect a test run failure
Detect a failing test
Complete test suite with all tests passing

747 pass(es), 0 fail(s), and 0 exception(s)

Test name	Pass	Fail	Exception
Country administration UI (CountriesCRUDUIUnitTest) [Countries]	238	0	0
Country core (CountriesFunctionsUnitTest) [Countries]	167	0	0
Country CRUD functions (CountriesCRUDUnitTest) [Countries]	18	0	0
Country Element (CountriesElementUnitTest) [Countries]	47	0	0
Country imports from CSV file (CountriesBaseImportUnitTest) [Countries]	226	0	0
Country overrides (CountriesBaseInstallUnitTest) [Countries]	51	0	0

Review log

Code review

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a review run failure
Detect coder flags
Ensure that your code follows the Drupal standard and passes a coder review.
Complete coder review with all passed

5 minor(s), 7 critical(s), and 1 normal(s)

Non-pass

Test name

Minor

Critical

Normal

countries.admin.inc

Message	Group	Filename	Line	Function
Potential problem: form_set_error() and form_error() only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	countries.admin.inc	214	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	countries.admin.inc	393	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	countries.admin.inc	419	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	countries.admin.inc	428	N/A
use stdClass caseCapitalization, it's the one exception to the mixed case style standard	Other	countries.admin.inc	461	N/A

countries.install

Message	Group	Filename	Line	Function	Status
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	countries.install	126	N/A

countries.module

Message	Group	Filename	Line	Function	Status
Potential problem: form_set_error() and form_error() only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	countries.module	314	N/A

modules/countries_configuration/countries_configuration.admin.inc

Message	Group	Filename	Line	Function	Status
Potential problem: drupal_set_title() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	countries_configuration.admin.inc	33	N/A

All

Test name

Minor

Critical

Normal

countries.admin.inc

Message	Group	Filename	Line	Function
Potential problem: form_set_error() and form_error() only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	countries.admin.inc	214	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	countries.admin.inc	393	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	countries.admin.inc	419	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	countries.admin.inc	428	N/A
use stdClass caseCapitalization, it's the one exception to the mixed case style standard	Other	countries.admin.inc	461	N/A

countries.elements.inc

countries.feeds.inc

countries.fields.inc

countries.install

Message	Group	Filename	Line	Function	Status
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	countries.install	126	N/A

countries.migrate.inc

countries.module

Message	Group	Filename	Line	Function	Status
Potential problem: form_set_error() and form_error() only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	countries.module	314	N/A

countries.tokens.inc

modules/countries_configuration/countries_configuration.admin.inc

Message	Group	Filename	Line	Function	Status
Potential problem: drupal_set_title() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	countries_configuration.admin.inc	33	N/A

modules/countries_configuration/countries_configuration.api.php

modules/countries_configuration/countries_configuration.install

modules/countries_configuration/countries_configuration.module

modules/countries_example/countries_example.install

modules/countries_example/countries_example.module

modules/countries_i18n/countries_i18n.module

tests/countries.test

Message	Group	Filename	Line	Function
@see should always be followed by a filename, a URL, class/interface name (optionally including method), or a function name including ().	Other	countries.test	9	N/A
@see should always be followed by a filename, a URL, class/interface name (optionally including method), or a function name including ().	Other	countries.test	11	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	countries.test	198	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	countries.test	199	N/A

views/countries.views.inc

views/views_handler_field_countries_continent.inc

views/views_handler_filter_countries_continents_list.inc

views/views_handler_filter_countries_list.inc

Message	Group	Filename	Line	Function	Status
in most cases, replace the string function with the drupal_ equivalent string functions	Other	views_handler_filter_countries_list.inc	88	N/A

Review log