Administration menu - 6.x-3.x

Test status
StatusResult
Last receivedThu, 01/31/2013 - 16:32:11
Last requestedThu, 01/31/2013 - 16:33:02
Last testedThu, 01/31/2013 - 16:33:24
Test count49
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier6.x-3.x
ProjectAdministration menu
LinkProject information
SummaryPASSED: [[Coder]]: [Code review] 2 minor(s), 4 critical(s), and 0 normal(s); [[SimpleTest]]: [MySQL] 115 pass(es).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing
115 pass(es), 0 fail(s), and 0 exception(s)
Test namePassFailException
LeafAdminMenuDynamicLinksTestCase6200
LeafAdminMenuLinkTypesTestCase2000
LeafAdminMenuPermissionsTestCase3300

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
2 minor(s), 4 critical(s), and 0 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandadmin_devel/admin_devel.module010
MessageGroupFilenameLineFunctionStatus
In SQL strings, Use db_query() placeholders in place of variables. This is a potential source of SQL injection attacks when the variable can come from user data. (Drupal Docs)Otheradmin_devel.module72N/A
Expandadmin_menu.inc030
MessageGroupFilenameLineFunctionStatus
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otheradmin_menu.inc360N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otheradmin_menu.inc373N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otheradmin_menu.inc452N/A

All

Test nameMinorCriticalNormal
Expandadmin_devel/admin_devel.module010
MessageGroupFilenameLineFunctionStatus
In SQL strings, Use db_query() placeholders in place of variables. This is a potential source of SQL injection attacks when the variable can come from user data. (Drupal Docs)Otheradmin_devel.module72N/A
Leafadmin_menu.api.php000
Expandadmin_menu.inc030
MessageGroupFilenameLineFunctionStatus
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otheradmin_menu.inc360N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otheradmin_menu.inc373N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)Otheradmin_menu.inc452N/A
Expandadmin_menu.install100
MessageGroupFilenameLineFunctionStatus
indent secondary line of comment one space Otheradmin_menu.install123N/A
Expandadmin_menu.module100
MessageGroupFilenameLineFunctionStatus
in most cases, replace the string function with the drupal_ equivalent string functionsOtheradmin_menu.module181N/A
Leafadmin_menu_toolbar/admin_menu_toolbar.install000
Leafadmin_menu_toolbar/admin_menu_toolbar.module000
Leaftests/admin_menu.test000