Advertisement - 7.x-1.x | Drupal Quality Assurance

Latest changes

So Long and Thanks for all the Tests

1 week 1 day ago

Support

In case of troubles

check the FAQ. Please make sure you've tried the test locally.
search known testbot issues and then create a new issue if yours isn't there already. Please give a link to the test.

Test client logs

No clients to display.

Advertisement - 7.x-1.x

Test status

Status	Result
Last received	Mon, 05/21/2012 - 05:01:33
Last requested	Mon, 05/21/2012 - 05:03:24
Last tested	Mon, 05/21/2012 - 05:03:38
Test count	2

Environment status

MySQL	pass
Code review	fail

Overall Result	pass

Branch information

Identifier	7.x-1.x
Project	Advertisement
Link	Project information

Event logView entire log

ID	Message	Timestamp
3729803	Result retrieved by project client.	3 years 40 weeks ago
3729793	Result received from test client #654.	3 years 40 weeks ago
3729788	Requested by test client #654.	3 years 40 weeks ago
3729783	Result received from test client #654.	3 years 40 weeks ago
3729773	Requested by test client #654.	3 years 40 weeks ago
3729738	Test request received.	3 years 40 weeks ago

SummaryPASSED: [[SimpleTest]]: [MySQL] 0 pass(es); [[Coder]]: [Code review] 77 minor(s), 23 critical(s), and 126 normal(s).

Details

MySQL
Code review

MySQL

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a Drupal installation failure
Detect a test run failure
Detect a failing test
Complete test suite with all tests passing

Review log

Code review

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a review run failure
Detect coder flags
Ensure that your code follows the Drupal standard and passes a coder review.
Complete coder review with all passed

77 minor(s), 23 critical(s), and 126 normal(s)

Non-pass

Test name

Minor

Critical

Normal

actions/ad_actions.module

Message	Group	Filename	Line	Function
Missing parenthesis after function name	Other	ad_actions.module	256	N/A
else statements should begin on a new line	Other	ad_actions.module	263	N/A
There should be no trailing spaces	Other	ad_actions.module	266	N/A
else statements should begin on a new line	Other	ad_actions.module	270	N/A
else statements should begin on a new line	Other	ad_actions.module	277	N/A
else statements should begin on a new line	Other	ad_actions.module	284	N/A
else statements should begin on a new line	Other	ad_actions.module	291	N/A
else statements should begin on a new line	Other	ad_actions.module	298	N/A
Missing parenthesis after function name	Other	ad_actions.module	304	N/A

ad.admin.inc

Message	Group	Filename	Line	Function
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)	Other	ad.admin.inc	32	N/A
Use "elseif" in place of "else if"	Other	ad.admin.inc	381	N/A
Use "elseif" in place of "else if"	Other	ad.admin.inc	393	N/A
Potential problem: when FAPI element '#type' is set to 'markup' (default), '#value' only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	ad.admin.inc	433	N/A

ad.install

Message	Group	Filename	Line	Function	Status
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)	Other	ad.install	318	N/A

ad.module

Message	Group	Filename	Line	Function
Use "elseif" in place of "else if"	Other	ad.module	142	N/A
Use "elseif" in place of "else if"	Other	ad.module	179	N/A
Use "elseif" in place of "else if"	Other	ad.module	213	N/A
Use "elseif" in place of "else if"	Other	ad.module	244	N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.	Other	ad.module	302	N/A
Use an indent of 2 spaces, with no tabs	Other	ad.module	358	N/A
Use an indent of 2 spaces, with no tabs	Other	ad.module	365	N/A
Use an indent of 2 spaces, with no tabs	Other	ad.module	367	N/A
Use an indent of 2 spaces, with no tabs	Other	ad.module	374	N/A
Use an indent of 2 spaces, with no tabs	Other	ad.module	376	N/A
Use an indent of 2 spaces, with no tabs	Other	ad.module	383	N/A
Use an indent of 2 spaces, with no tabs	Other	ad.module	385	N/A
Use an indent of 2 spaces, with no tabs	Other	ad.module	392	N/A
Missing parenthesis after function name	Other	ad.module	443	N/A
Use "elseif" in place of "else if"	Other	ad.module	495	N/A
Use "elseif" in place of "else if"	Other	ad.module	520	N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE	Other	ad.module	578	N/A
Use "elseif" in place of "else if"	Other	ad.module	628	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	ad.module	629	N/A
Use an indent of 2 spaces, with no tabs	Other	ad.module	635	N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	ad.module	694	N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	ad.module	697	N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	ad.module	819	N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	ad.module	821	N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	ad.module	828	N/A
Use "elseif" in place of "else if"	Other	ad.module	880	N/A
Use "elseif" in place of "else if"	Other	ad.module	890	N/A
Use "elseif" in place of "else if"	Other	ad.module	977	N/A
Menu item titles and descriptions should NOT be enclosed within t(). (Drupal Docs)	Other	ad.module	1193	N/A
Use "elseif" in place of "else if"	Other	ad.module	1318	N/A
Use "elseif" in place of "else if"	Other	ad.module	1321	N/A
Use "elseif" in place of "else if"	Other	ad.module	1332	N/A
Use an indent of 2 spaces, with no tabs	Other	ad.module	1491	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	ad.module	1499	N/A

adcache.inc

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	adcache.inc	-1	N/A
Use "elseif" in place of "else if"	Other	adcache.inc	402	N/A
Use "elseif" in place of "else if"	Other	adcache.inc	407	N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE	Other	adcache.inc	540	N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE	Other	adcache.inc	560	N/A

adserve.inc

Message	Group	Filename	Line	Function
Use "elseif" in place of "else if"	Other	adserve.inc	152	N/A
Use an indent of 2 spaces, with no tabs	Other	adserve.inc	160	N/A
Use an indent of 2 spaces, with no tabs	Other	adserve.inc	161	N/A
Use an indent of 2 spaces, with no tabs	Other	adserve.inc	162	N/A
Use an indent of 2 spaces, with no tabs	Other	adserve.inc	163	N/A
Use "elseif" in place of "else if"	Other	adserve.inc	194	N/A
Use "elseif" in place of "else if"	Other	adserve.inc	313	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	adserve.inc	320	N/A

cache/file/ad_cache_file.inc

Message	Group	Filename	Line	Function
Use "elseif" in place of "else if"	Other	ad_cache_file.inc	176	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	ad_cache_file.inc	211	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_cache_file.inc	229	N/A

cache/file/ad_cache_file.module

Message	Group	Filename	Line	Function
missing space after comma	Other	ad_cache_file.module	75	N/A
Missing parenthesis after function name	Other	ad_cache_file.module	104	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	ad_cache_file.module	151	N/A
table names should be enclosed in {curly_brackets}	Other	ad_cache_file.module	231	N/A

channel/ad_channel.inc

Message	Group	Filename	Line	Function
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	ad_channel.inc	101	N/A
Use an indent of 2 spaces, with no tabs	Other	ad_channel.inc	142	N/A
Use "elseif" in place of "else if"	Other	ad_channel.inc	155	N/A
Use "elseif" in place of "else if"	Other	ad_channel.inc	162	N/A

channel/ad_channel.install

Message	Group	Filename	Line	Function	Status
@file block missing (Drupal Docs)	Other	ad_channel.install	-1	N/A

channel/ad_channel.module

Message	Group	Filename	Line	Function
Use an indent of 2 spaces, with no tabs	Other	ad_channel.module	26	N/A
Use an indent of 2 spaces, with no tabs	Other	ad_channel.module	28	N/A
Use an indent of 2 spaces, with no tabs	Other	ad_channel.module	30	N/A
Missing parenthesis after function name	Other	ad_channel.module	45	N/A
Menu item titles and descriptions should NOT be enclosed within t(). (Drupal Docs)	Other	ad_channel.module	51	N/A
Menu item titles and descriptions should NOT be enclosed within t(). (Drupal Docs)	Other	ad_channel.module	57	N/A
Menu item titles and descriptions should NOT be enclosed within t(). (Drupal Docs)	Other	ad_channel.module	63	N/A
Menu item titles and descriptions should NOT be enclosed within t(). (Drupal Docs)	Other	ad_channel.module	70	N/A
Menu item titles and descriptions should NOT be enclosed within t(). (Drupal Docs)	Other	ad_channel.module	77	N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	ad_channel.module	136	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	ad_channel.module	153	N/A
Use an indent of 2 spaces, with no tabs	Other	ad_channel.module	154	N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	ad_channel.module	160	N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	ad_channel.module	161	N/A
Use "elseif" in place of "else if"	Other	ad_channel.module	209	N/A
Use "elseif" in place of "else if"	Other	ad_channel.module	220	N/A
Use "elseif" in place of "else if"	Other	ad_channel.module	259	N/A
Use "elseif" in place of "else if"	Other	ad_channel.module	284	N/A
There should be no trailing spaces	Other	ad_channel.module	331	N/A
Use "elseif" in place of "else if"	Other	ad_channel.module	396	N/A
Use "elseif" in place of "else if"	Other	ad_channel.module	404	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	ad_channel.module	447	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	ad_channel.module	458	N/A
Use "elseif" in place of "else if"	Other	ad_channel.module	519	N/A
Use "elseif" in place of "else if"	Other	ad_channel.module	527	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	ad_channel.module	736	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	ad_channel.module	761	N/A
Use "elseif" in place of "else if"	Other	ad_channel.module	978	N/A
Use ANSI standard <> instead of !=	Other	ad_channel.module	979	N/A
Use "elseif" in place of "else if"	Other	ad_channel.module	1213	N/A
Use ANSI standard <> instead of !=	Other	ad_channel.module	1214	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	ad_channel.module	1313	N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	ad_channel.module	1314	N/A

embed/ad_embed.module

Message	Group	Filename	Line	Function
missing space after comma	Other	ad_embed.module	183	N/A
The control statement should be on a separate line from the control conditional	Other	ad_embed.module	229	N/A
There should be no trailing spaces	Other	ad_embed.module	233	N/A
There should be no trailing spaces	Other	ad_embed.module	235	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_embed.module	237	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_embed.module	245	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_embed.module	250	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_embed.module	280	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_embed.module	281	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_embed.module	283	N/A
Use "elseif" in place of "else if"	Other	ad_embed.module	283	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_embed.module	284	N/A
The control statement should be on a separate line from the control conditional	Other	ad_embed.module	297	N/A
Use "elseif" in place of "else if"	Other	ad_embed.module	302	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_embed.module	312	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_embed.module	313	N/A

external/ad_external.module

Message	Group	Filename	Line	Function	Status
Use an indent of 2 spaces, with no tabs	Other	ad_external.module	155	N/A
Potential problem: when FAPI element '#type' is set to 'markup' (default), '#value' only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	ad_external.module	167	N/A

html/ad_html.module

Message	Group	Filename	Line	Function	Status
Potential problem: when FAPI element '#type' is set to 'markup' (default), '#value' only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	ad_html.module	144	N/A

image/ad_image.module

Message	Group	Filename	Line	Function
indent secondary line of comment one space	Other	ad_image.module	59	N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.	Other	ad_image.module	222	N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.	Other	ad_image.module	255	N/A
Use an indent of 2 spaces, with no tabs	Other	ad_image.module	285	N/A
Use an indent of 2 spaces, with no tabs	Other	ad_image.module	286	N/A
Use "elseif" in place of "else if"	Other	ad_image.module	292	N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.	Other	ad_image.module	303	N/A
Use "elseif" in place of "else if"	Other	ad_image.module	306	N/A
The $text argument to l() should be enclosed within t() so that it is translatable.	Other	ad_image.module	343	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	ad_image.module	346	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	ad_image.module	350	N/A
Use "elseif" in place of "else if"	Other	ad_image.module	372	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_image.module	411	N/A
Use "elseif" in place of "else if"	Other	ad_image.module	417	N/A
Use "elseif" in place of "else if"	Other	ad_image.module	425	N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.	Other	ad_image.module	438	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)	Other	ad_image.module	438	N/A
Use "elseif" in place of "else if"	Other	ad_image.module	460	N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	ad_image.module	505	N/A
Use "elseif" in place of "else if"	Other	ad_image.module	508	N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	ad_image.module	530	N/A
Use "elseif" in place of "else if"	Other	ad_image.module	532	N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	ad_image.module	533	N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	ad_image.module	536	N/A
Use "elseif" in place of "else if"	Other	ad_image.module	539	N/A
Use "elseif" in place of "else if"	Other	ad_image.module	552	N/A

imageserve.inc

Message	Group	Filename	Line	Function	Status
Use "elseif" in place of "else if"	Other	imageserve.inc	54	N/A
Use "elseif" in place of "else if"	Other	imageserve.inc	58	N/A

owners/ad_owners.module

Message	Group	Filename	Line	Function
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	ad_owners.module	137	N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	ad_owners.module	143	N/A
Use "elseif" in place of "else if"	Other	ad_owners.module	236	N/A
Use "elseif" in place of "else if"	Other	ad_owners.module	335	N/A
Use "elseif" in place of "else if"	Other	ad_owners.module	338	N/A
Use an indent of 2 spaces, with no tabs	Other	ad_owners.module	339	N/A

remote/ad_remote.module

Message	Group	Filename	Line	Function	Status
indent secondary line of comment one space	Other	ad_remote.module	4	N/A
missing space after comma	Other	ad_remote.module	67	N/A

report/ad_report.module

Message	Group	Filename	Line	Function
Menu item titles and descriptions should NOT be enclosed within t(). (Drupal Docs)	Other	ad_report.module	17	N/A
Menu item titles and descriptions should NOT be enclosed within t(). (Drupal Docs)	Other	ad_report.module	36	N/A
Menu item titles and descriptions should NOT be enclosed within t(). (Drupal Docs)	Other	ad_report.module	44	N/A
Use "elseif" in place of "else if"	Other	ad_report.module	188	N/A
Use "elseif" in place of "else if"	Other	ad_report.module	191	N/A
Use "elseif" in place of "else if"	Other	ad_report.module	238	N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.	Other	ad_report.module	281	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	ad_report.module	309	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	ad_report.module	310	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	ad_report.module	339	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	ad_report.module	341	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	ad_report.module	344	N/A
Use "elseif" in place of "else if"	Other	ad_report.module	344	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	ad_report.module	348	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	ad_report.module	349	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	ad_report.module	354	N/A
Use "elseif" in place of "else if"	Other	ad_report.module	368	N/A
Use "elseif" in place of "else if"	Other	ad_report.module	622	N/A
Use "elseif" in place of "else if"	Other	ad_report.module	625	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_report.module	662	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_report.module	663	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_report.module	664	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_report.module	665	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_report.module	666	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_report.module	667	N/A
Use "elseif" in place of "else if"	Other	ad_report.module	707	N/A
Use "elseif" in place of "else if"	Other	ad_report.module	815	N/A
Use "elseif" in place of "else if"	Other	ad_report.module	818	N/A
Use "elseif" in place of "else if"	Other	ad_report.module	821	N/A
Use "elseif" in place of "else if"	Other	ad_report.module	824	N/A
Use "elseif" in place of "else if"	Other	ad_report.module	827	N/A
Use "elseif" in place of "else if"	Other	ad_report.module	830	N/A
Use "elseif" in place of "else if"	Other	ad_report.module	833	N/A

serve.php

Message	Group	Filename	Line	Function	Status
Use "elseif" in place of "else if"	Other	serve.php	22	N/A

text/ad_text.module

Message	Group	Filename	Line	Function
Potential problem: when FAPI element '#type' is set to 'markup' (default), '#value' only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	ad_text.module	298	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_text.module	323	N/A
Use "elseif" in place of "else if"	Other	ad_text.module	329	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_text.module	332	N/A
Use "elseif" in place of "else if"	Other	ad_text.module	338	N/A

weight/percent/ad_weight_percent.inc

Message	Group	Filename	Line	Function	Status
Use "elseif" in place of "else if"	Other	ad_weight_percent.inc	23	N/A

weight/percent/ad_weight_percent.install

Message	Group	Filename	Line	Function	Status
@file block missing (Drupal Docs)	Other	ad_weight_percent.install	-1	N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.	Other	ad_weight_percent.install	33	N/A

weight/probability/ad_weight_probability.install

Message	Group	Filename	Line	Function	Status
@file block missing (Drupal Docs)	Other	ad_weight_probability.install	-1	N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.	Other	ad_weight_probability.install	30	N/A

weight/probability/ad_weight_probability.module

Message	Group	Filename	Line	Function	Status
Use "elseif" in place of "else if"	Other	ad_weight_probability.module	41	N/A

All

Test name

Minor

Critical

Normal

actions/ad_actions.install

actions/ad_actions.module

Message	Group	Filename	Line	Function
Missing parenthesis after function name	Other	ad_actions.module	256	N/A
else statements should begin on a new line	Other	ad_actions.module	263	N/A
There should be no trailing spaces	Other	ad_actions.module	266	N/A
else statements should begin on a new line	Other	ad_actions.module	270	N/A
else statements should begin on a new line	Other	ad_actions.module	277	N/A
else statements should begin on a new line	Other	ad_actions.module	284	N/A
else statements should begin on a new line	Other	ad_actions.module	291	N/A
else statements should begin on a new line	Other	ad_actions.module	298	N/A
Missing parenthesis after function name	Other	ad_actions.module	304	N/A

ad.admin.inc

Message	Group	Filename	Line	Function
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)	Other	ad.admin.inc	32	N/A
Use "elseif" in place of "else if"	Other	ad.admin.inc	381	N/A
Use "elseif" in place of "else if"	Other	ad.admin.inc	393	N/A
Potential problem: when FAPI element '#type' is set to 'markup' (default), '#value' only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	ad.admin.inc	433	N/A

ad.install

Message	Group	Filename	Line	Function	Status
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)	Other	ad.install	318	N/A

ad.module

Message	Group	Filename	Line	Function
Use "elseif" in place of "else if"	Other	ad.module	142	N/A
Use "elseif" in place of "else if"	Other	ad.module	179	N/A
Use "elseif" in place of "else if"	Other	ad.module	213	N/A
Use "elseif" in place of "else if"	Other	ad.module	244	N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.	Other	ad.module	302	N/A
Use an indent of 2 spaces, with no tabs	Other	ad.module	358	N/A
Use an indent of 2 spaces, with no tabs	Other	ad.module	365	N/A
Use an indent of 2 spaces, with no tabs	Other	ad.module	367	N/A
Use an indent of 2 spaces, with no tabs	Other	ad.module	374	N/A
Use an indent of 2 spaces, with no tabs	Other	ad.module	376	N/A
Use an indent of 2 spaces, with no tabs	Other	ad.module	383	N/A
Use an indent of 2 spaces, with no tabs	Other	ad.module	385	N/A
Use an indent of 2 spaces, with no tabs	Other	ad.module	392	N/A
Missing parenthesis after function name	Other	ad.module	443	N/A
Use "elseif" in place of "else if"	Other	ad.module	495	N/A
Use "elseif" in place of "else if"	Other	ad.module	520	N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE	Other	ad.module	578	N/A
Use "elseif" in place of "else if"	Other	ad.module	628	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	ad.module	629	N/A
Use an indent of 2 spaces, with no tabs	Other	ad.module	635	N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	ad.module	694	N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	ad.module	697	N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	ad.module	819	N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	ad.module	821	N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	ad.module	828	N/A
Use "elseif" in place of "else if"	Other	ad.module	880	N/A
Use "elseif" in place of "else if"	Other	ad.module	890	N/A
Use "elseif" in place of "else if"	Other	ad.module	977	N/A
Menu item titles and descriptions should NOT be enclosed within t(). (Drupal Docs)	Other	ad.module	1193	N/A
Use "elseif" in place of "else if"	Other	ad.module	1318	N/A
Use "elseif" in place of "else if"	Other	ad.module	1321	N/A
Use "elseif" in place of "else if"	Other	ad.module	1332	N/A
Use an indent of 2 spaces, with no tabs	Other	ad.module	1491	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	ad.module	1499	N/A

ad.pages.inc

Message	Group	Filename	Line	Function
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad.pages.inc	40	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad.pages.inc	41	N/A
l() already contains a check_plain() call by default	Other	ad.pages.inc	193	N/A
l() already contains a check_plain() call by default	Other	ad.pages.inc	255	N/A

adcache.inc

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	adcache.inc	-1	N/A
Use "elseif" in place of "else if"	Other	adcache.inc	402	N/A
Use "elseif" in place of "else if"	Other	adcache.inc	407	N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE	Other	adcache.inc	540	N/A
Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE	Other	adcache.inc	560	N/A

adserve.inc

Message	Group	Filename	Line	Function
Use "elseif" in place of "else if"	Other	adserve.inc	152	N/A
Use an indent of 2 spaces, with no tabs	Other	adserve.inc	160	N/A
Use an indent of 2 spaces, with no tabs	Other	adserve.inc	161	N/A
Use an indent of 2 spaces, with no tabs	Other	adserve.inc	162	N/A
Use an indent of 2 spaces, with no tabs	Other	adserve.inc	163	N/A
Use "elseif" in place of "else if"	Other	adserve.inc	194	N/A
Use "elseif" in place of "else if"	Other	adserve.inc	313	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	adserve.inc	320	N/A

ad_token.inc

cache/file/ad_cache_file.inc

Message	Group	Filename	Line	Function
Use "elseif" in place of "else if"	Other	ad_cache_file.inc	176	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	ad_cache_file.inc	211	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_cache_file.inc	229	N/A

cache/file/ad_cache_file.install

cache/file/ad_cache_file.module

Message	Group	Filename	Line	Function
missing space after comma	Other	ad_cache_file.module	75	N/A
Missing parenthesis after function name	Other	ad_cache_file.module	104	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	ad_cache_file.module	151	N/A
table names should be enclosed in {curly_brackets}	Other	ad_cache_file.module	231	N/A

channel/ad_channel.inc

Message	Group	Filename	Line	Function
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	ad_channel.inc	101	N/A
Use an indent of 2 spaces, with no tabs	Other	ad_channel.inc	142	N/A
Use "elseif" in place of "else if"	Other	ad_channel.inc	155	N/A
Use "elseif" in place of "else if"	Other	ad_channel.inc	162	N/A

channel/ad_channel.install

Message	Group	Filename	Line	Function	Status
@file block missing (Drupal Docs)	Other	ad_channel.install	-1	N/A

channel/ad_channel.module

Message	Group	Filename	Line	Function
Use an indent of 2 spaces, with no tabs	Other	ad_channel.module	26	N/A
Use an indent of 2 spaces, with no tabs	Other	ad_channel.module	28	N/A
Use an indent of 2 spaces, with no tabs	Other	ad_channel.module	30	N/A
Missing parenthesis after function name	Other	ad_channel.module	45	N/A
Menu item titles and descriptions should NOT be enclosed within t(). (Drupal Docs)	Other	ad_channel.module	51	N/A
Menu item titles and descriptions should NOT be enclosed within t(). (Drupal Docs)	Other	ad_channel.module	57	N/A
Menu item titles and descriptions should NOT be enclosed within t(). (Drupal Docs)	Other	ad_channel.module	63	N/A
Menu item titles and descriptions should NOT be enclosed within t(). (Drupal Docs)	Other	ad_channel.module	70	N/A
Menu item titles and descriptions should NOT be enclosed within t(). (Drupal Docs)	Other	ad_channel.module	77	N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	ad_channel.module	136	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	ad_channel.module	153	N/A
Use an indent of 2 spaces, with no tabs	Other	ad_channel.module	154	N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	ad_channel.module	160	N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	ad_channel.module	161	N/A
Use "elseif" in place of "else if"	Other	ad_channel.module	209	N/A
Use "elseif" in place of "else if"	Other	ad_channel.module	220	N/A
Use "elseif" in place of "else if"	Other	ad_channel.module	259	N/A
Use "elseif" in place of "else if"	Other	ad_channel.module	284	N/A
There should be no trailing spaces	Other	ad_channel.module	331	N/A
Use "elseif" in place of "else if"	Other	ad_channel.module	396	N/A
Use "elseif" in place of "else if"	Other	ad_channel.module	404	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	ad_channel.module	447	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	ad_channel.module	458	N/A
Use "elseif" in place of "else if"	Other	ad_channel.module	519	N/A
Use "elseif" in place of "else if"	Other	ad_channel.module	527	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	ad_channel.module	736	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	ad_channel.module	761	N/A
Use "elseif" in place of "else if"	Other	ad_channel.module	978	N/A
Use ANSI standard <> instead of !=	Other	ad_channel.module	979	N/A
Use "elseif" in place of "else if"	Other	ad_channel.module	1213	N/A
Use ANSI standard <> instead of !=	Other	ad_channel.module	1214	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	ad_channel.module	1313	N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	ad_channel.module	1314	N/A

embed/ad_embed.module

Message	Group	Filename	Line	Function
missing space after comma	Other	ad_embed.module	183	N/A
The control statement should be on a separate line from the control conditional	Other	ad_embed.module	229	N/A
There should be no trailing spaces	Other	ad_embed.module	233	N/A
There should be no trailing spaces	Other	ad_embed.module	235	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_embed.module	237	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_embed.module	245	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_embed.module	250	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_embed.module	280	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_embed.module	281	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_embed.module	283	N/A
Use "elseif" in place of "else if"	Other	ad_embed.module	283	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_embed.module	284	N/A
The control statement should be on a separate line from the control conditional	Other	ad_embed.module	297	N/A
Use "elseif" in place of "else if"	Other	ad_embed.module	302	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_embed.module	312	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_embed.module	313	N/A

external/ad_external.install

external/ad_external.module

Message	Group	Filename	Line	Function	Status
Use an indent of 2 spaces, with no tabs	Other	ad_external.module	155	N/A
Potential problem: when FAPI element '#type' is set to 'markup' (default), '#value' only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	ad_external.module	167	N/A

external/external.inc

html/ad_html.install

html/ad_html.module

Message	Group	Filename	Line	Function	Status
Potential problem: when FAPI element '#type' is set to 'markup' (default), '#value' only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	ad_html.module	144	N/A

image/ad_image.install

image/ad_image.module

Message	Group	Filename	Line	Function
indent secondary line of comment one space	Other	ad_image.module	59	N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.	Other	ad_image.module	222	N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.	Other	ad_image.module	255	N/A
Use an indent of 2 spaces, with no tabs	Other	ad_image.module	285	N/A
Use an indent of 2 spaces, with no tabs	Other	ad_image.module	286	N/A
Use "elseif" in place of "else if"	Other	ad_image.module	292	N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.	Other	ad_image.module	303	N/A
Use "elseif" in place of "else if"	Other	ad_image.module	306	N/A
The $text argument to l() should be enclosed within t() so that it is translatable.	Other	ad_image.module	343	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	ad_image.module	346	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	ad_image.module	350	N/A
Use "elseif" in place of "else if"	Other	ad_image.module	372	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_image.module	411	N/A
Use "elseif" in place of "else if"	Other	ad_image.module	417	N/A
Use "elseif" in place of "else if"	Other	ad_image.module	425	N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.	Other	ad_image.module	438	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)	Other	ad_image.module	438	N/A
Use "elseif" in place of "else if"	Other	ad_image.module	460	N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	ad_image.module	505	N/A
Use "elseif" in place of "else if"	Other	ad_image.module	508	N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	ad_image.module	530	N/A
Use "elseif" in place of "else if"	Other	ad_image.module	532	N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	ad_image.module	533	N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote terms	Other	ad_image.module	536	N/A
Use "elseif" in place of "else if"	Other	ad_image.module	539	N/A
Use "elseif" in place of "else if"	Other	ad_image.module	552	N/A

imageserve.inc

Message	Group	Filename	Line	Function	Status
Use "elseif" in place of "else if"	Other	imageserve.inc	54	N/A
Use "elseif" in place of "else if"	Other	imageserve.inc	58	N/A

owners/ad_owners.install

owners/ad_owners.module

Message	Group	Filename	Line	Function
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	ad_owners.module	137	N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	ad_owners.module	143	N/A
Use "elseif" in place of "else if"	Other	ad_owners.module	236	N/A
Use "elseif" in place of "else if"	Other	ad_owners.module	335	N/A
Use "elseif" in place of "else if"	Other	ad_owners.module	338	N/A
Use an indent of 2 spaces, with no tabs	Other	ad_owners.module	339	N/A

remote/ad_remote.module

Message	Group	Filename	Line	Function	Status
indent secondary line of comment one space	Other	ad_remote.module	4	N/A
missing space after comma	Other	ad_remote.module	67	N/A

report/ad_report.install

report/ad_report.module

Message	Group	Filename	Line	Function
Menu item titles and descriptions should NOT be enclosed within t(). (Drupal Docs)	Other	ad_report.module	17	N/A
Menu item titles and descriptions should NOT be enclosed within t(). (Drupal Docs)	Other	ad_report.module	36	N/A
Menu item titles and descriptions should NOT be enclosed within t(). (Drupal Docs)	Other	ad_report.module	44	N/A
Use "elseif" in place of "else if"	Other	ad_report.module	188	N/A
Use "elseif" in place of "else if"	Other	ad_report.module	191	N/A
Use "elseif" in place of "else if"	Other	ad_report.module	238	N/A
The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.	Other	ad_report.module	281	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	ad_report.module	309	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	ad_report.module	310	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	ad_report.module	339	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	ad_report.module	341	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	ad_report.module	344	N/A
Use "elseif" in place of "else if"	Other	ad_report.module	344	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	ad_report.module	348	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	ad_report.module	349	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	ad_report.module	354	N/A
Use "elseif" in place of "else if"	Other	ad_report.module	368	N/A
Use "elseif" in place of "else if"	Other	ad_report.module	622	N/A
Use "elseif" in place of "else if"	Other	ad_report.module	625	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_report.module	662	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_report.module	663	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_report.module	664	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_report.module	665	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_report.module	666	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	ad_report.module	667	N/A
Use "elseif" in place of "else if"	Other	ad_report.module	707	N/A
Use "elseif" in place of "else if"	Other	ad_report.module	815	N/A
Use "elseif" in place of "else if"	Other	ad_report.module	818	N/A
Use "elseif" in place of "else if"	Other	ad_report.module	821	N/A
Use "elseif" in place of "else if"	Other	ad_report.module	824	N/A
Use "elseif" in place of "else if"	Other	ad_report.module	827	N/A
Use "elseif" in place of "else if"	Other	ad_report.module	830	N/A
Use "elseif" in place of "else if"	Other	ad_report.module	833	N/A

serve.php

Message	Group	Filename	Line	Function	Status
Use "elseif" in place of "else if"	Other	serve.php	22	N/A

statistics/click_filter/click_filter.install

statistics/click_filter/click_filter.module

Message	Group	Filename	Line	Function	Status
indent secondary line of comment one space	Other	click_filter.module	4	N/A
There should be no trailing spaces	Other	click_filter.module	88	N/A

text/ad_text.install