Countries - 7.x-1.0 | Drupal Quality Assurance

Latest changes

So Long and Thanks for all the Tests

1 week 1 day ago

Support

In case of troubles

check the FAQ. Please make sure you've tried the test locally.
search known testbot issues and then create a new issue if yours isn't there already. Please give a link to the test.

Test client logs

No clients to display.

Countries - 7.x-1.0

Test status

Status	Result
Last received	Sat, 05/05/2012 - 00:21:33
Last requested	Sat, 05/05/2012 - 00:22:03
Last tested	Sat, 05/05/2012 - 00:22:30
Test count	2

Environment status

MySQL	pass
Code review	fail

Overall Result	pass

Branch information

Identifier	7.x-1.0
Project	Countries
Link	Project information

Event logView entire log

ID	Message	Timestamp
3670978	Result retrieved by project client.	3 years 42 weeks ago
3670973	Result received from test client #.	3 years 42 weeks ago
3670968	Result received from test client #659.	3 years 42 weeks ago
3670963	Requested by test client #659.	3 years 42 weeks ago
3670958	Requested by test client #.	3 years 42 weeks ago
3670953	Test request received.	3 years 42 weeks ago

SummaryPASSED: [[Coder]]: [Code review] 6 minor(s), 2 critical(s), and 6 normal(s); [[SimpleTest]]: [MySQL] 0 pass(es).

Details

MySQL
Code review

MySQL

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a Drupal installation failure
Detect a test run failure
Detect a failing test
Complete test suite with all tests passing

Review log

Code review

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a review run failure
Detect coder flags
Ensure that your code follows the Drupal standard and passes a coder review.
Complete coder review with all passed

6 minor(s), 2 critical(s), and 6 normal(s)

Non-pass

Test name

Minor

Critical

Normal

countries.admin.inc

Message	Group	Filename	Line	Function
Commits to the Git repository do not require the CVS $Id$ keyword in each file. (Drupal Docs)	Other	countries.admin.inc	2	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	countries.admin.inc	214	N/A
Potential problem: form_set_error() and form_error() only accept filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	countries.admin.inc	226	N/A
In SQL strings, Use db_query() placeholders in place of variables. This is a potential source of SQL injection attacks when the variable can come from user data. (Drupal Docs)	Other	countries.admin.inc	243	N/A

countries.install

Message	Group	Filename	Line	Function
Commits to the Git repository do not require the CVS $Id$ keyword in each file. (Drupal Docs)	Other	countries.install	2	N/A
indent secondary line of comment one space	Other	countries.install	96	N/A
indent secondary line of comment one space	Other	countries.install	97	N/A
put a space between the asterisk and the comment text	Other	countries.install	97	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	countries.install	126	N/A

countries.module

Message	Group	Filename	Line	Function
Commits to the Git repository do not require the CVS $Id$ keyword in each file. (Drupal Docs)	Other	countries.module	2	N/A
@see references should be separated by "," followed by a single space and with no trailing punctuation	Other	countries.module	155	N/A
missing space after comma	Other	countries.module	408	N/A
@see should always be followed by a filename, a URL, class/interface name (optionally including method), or a function name including ().	Other	countries.module	525	N/A
@see references should be separated by "," followed by a single space and with no trailing punctuation	Other	countries.module	525	N/A

All