Basic cart - 7.x-2.0-beta1 | Drupal Quality Assurance

Latest changes

So Long and Thanks for all the Tests

1 week 1 day ago

Support

In case of troubles

check the FAQ. Please make sure you've tried the test locally.
search known testbot issues and then create a new issue if yours isn't there already. Please give a link to the test.

Test client logs

No clients to display.

Basic cart - 7.x-2.0-beta1

Test status

Status	Result
Last received	Fri, 05/04/2012 - 19:24:47
Last requested	Fri, 05/04/2012 - 19:25:03
Last tested	Fri, 05/04/2012 - 19:25:29
Test count	2

Environment status

MySQL	pass
Code review	fail

Overall Result	pass

Branch information

Identifier	7.x-2.0-beta1
Project	Basic cart
Link	Project information

Event logView entire log

ID	Message	Timestamp
3670028	Result retrieved by project client.	3 years 42 weeks ago
3669998	Result received from test client #.	3 years 42 weeks ago
3669993	Result received from test client #654.	3 years 42 weeks ago
3669988	Requested by test client #654.	3 years 42 weeks ago
3669983	Requested by test client #.	3 years 42 weeks ago
3669978	Test request received.	3 years 42 weeks ago

SummaryPASSED: [[Coder]]: [Code review] 16 minor(s), 1 critical(s), and 7 normal(s); [[SimpleTest]]: [MySQL] 0 pass(es).

Details

MySQL
Code review

MySQL

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a Drupal installation failure
Detect a test run failure
Detect a failing test
Complete test suite with all tests passing

Review log

Code review

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a review run failure
Detect coder flags
Ensure that your code follows the Drupal standard and passes a coder review.
Complete coder review with all passed

16 minor(s), 1 critical(s), and 7 normal(s)

Non-pass

Test name

Minor

Critical

Normal

basic_cart.cart.inc

Message	Group	Filename	Line	Function
There should be no trailing spaces	Other	basic_cart.cart.inc	138	N/A
There should be no trailing spaces	Other	basic_cart.cart.inc	147	N/A
There should be no trailing spaces	Other	basic_cart.cart.inc	186	N/A
There should be no trailing spaces	Other	basic_cart.cart.inc	242	N/A
There should be no trailing spaces	Other	basic_cart.cart.inc	249	N/A
There should be no trailing spaces	Other	basic_cart.cart.inc	255	N/A
There should be no trailing spaces	Other	basic_cart.cart.inc	328	N/A
There should be no trailing spaces	Other	basic_cart.cart.inc	414	N/A
There should be no trailing spaces	Other	basic_cart.cart.inc	437	N/A
Potential problem: drupal_set_title() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	basic_cart.cart.inc	496	N/A

basic_cart_cart_flat.tpl.php

Message	Group	Filename	Line	Function
Control statements should have one space between the control keyword and opening parenthesis	Other	basic_cart_cart_flat.tpl.php	12	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	basic_cart_cart_flat.tpl.php	13	N/A
There should be no trailing spaces	Other	basic_cart_cart_flat.tpl.php	15	N/A
There should be no trailing spaces	Other	basic_cart_cart_flat.tpl.php	22	N/A
the final ?> should be omitted from all code files	Other	basic_cart_cart_flat.tpl.php	33	N/A

basic_cart_cart_render_block.tpl.php

Message	Group	Filename	Line	Function
Control statements should have one space between the control keyword and opening parenthesis	Other	basic_cart_cart_render_block.tpl.php	12	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	basic_cart_cart_render_block.tpl.php	13	N/A
There should be no trailing spaces	Other	basic_cart_cart_render_block.tpl.php	16	N/A
There should be no trailing spaces	Other	basic_cart_cart_render_block.tpl.php	22	N/A
the final ?> should be omitted from all code files	Other	basic_cart_cart_render_block.tpl.php	33	N/A

basic_cart_order/basic_cart_order.module

Message	Group	Filename	Line	Function	Status
Functions should be called with no spaces between the function name and opening parentheses	Other	basic_cart_order.module	160	N/A

All

Test name

Minor

Critical

Normal

basic_cart.admin.inc

basic_cart.cart.inc

Message	Group	Filename	Line	Function
There should be no trailing spaces	Other	basic_cart.cart.inc	138	N/A
There should be no trailing spaces	Other	basic_cart.cart.inc	147	N/A
There should be no trailing spaces	Other	basic_cart.cart.inc	186	N/A
There should be no trailing spaces	Other	basic_cart.cart.inc	242	N/A
There should be no trailing spaces	Other	basic_cart.cart.inc	249	N/A
There should be no trailing spaces	Other	basic_cart.cart.inc	255	N/A
There should be no trailing spaces	Other	basic_cart.cart.inc	328	N/A
There should be no trailing spaces	Other	basic_cart.cart.inc	414	N/A
There should be no trailing spaces	Other	basic_cart.cart.inc	437	N/A
Potential problem: drupal_set_title() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	basic_cart.cart.inc	496	N/A

basic_cart.install

Message	Group	Filename	Line	Function	Status
There should be no trailing spaces	Other	basic_cart.install	43	N/A

basic_cart.module

Message	Group	Filename	Line	Function	Status
There should be no trailing spaces	Other	basic_cart.module	127	N/A

basic_cart_cart_flat.tpl.php

Message	Group	Filename	Line	Function
Control statements should have one space between the control keyword and opening parenthesis	Other	basic_cart_cart_flat.tpl.php	12	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	basic_cart_cart_flat.tpl.php	13	N/A
There should be no trailing spaces	Other	basic_cart_cart_flat.tpl.php	15	N/A
There should be no trailing spaces	Other	basic_cart_cart_flat.tpl.php	22	N/A
the final ?> should be omitted from all code files	Other	basic_cart_cart_flat.tpl.php	33	N/A

basic_cart_cart_render_block.tpl.php

Message	Group	Filename	Line	Function
Control statements should have one space between the control keyword and opening parenthesis	Other	basic_cart_cart_render_block.tpl.php	12	N/A
Control statements should have one space between the control keyword and opening parenthesis	Other	basic_cart_cart_render_block.tpl.php	13	N/A
There should be no trailing spaces	Other	basic_cart_cart_render_block.tpl.php	16	N/A
There should be no trailing spaces	Other	basic_cart_cart_render_block.tpl.php	22	N/A
the final ?> should be omitted from all code files	Other	basic_cart_cart_render_block.tpl.php	33	N/A

basic_cart_order/basic_cart_order.features.field.inc

basic_cart_order/basic_cart_order.features.inc

basic_cart_order/basic_cart_order.features.menu_custom.inc

basic_cart_order/basic_cart_order.features.menu_links.inc

basic_cart_order/basic_cart_order.features.user_permission.inc

basic_cart_order/basic_cart_order.install

Message	Group	Filename	Line	Function	Status
put a space between the asterisk and the comment text	Other	basic_cart_order.install	44	N/A

basic_cart_order/basic_cart_order.module

Message	Group	Filename	Line	Function	Status
Functions should be called with no spaces between the function name and opening parentheses	Other	basic_cart_order.module	160	N/A

basic_cart_order/basic_cart_order.strongarm.inc

basic_cart_order/basic_cart_order.views_default.inc

basic_cart_order/basic_cart_order_details.tpl.php

Review log