Controller - 6.x-2.0-alpha1 | Drupal Quality Assurance

Latest changes

So Long and Thanks for all the Tests

1 week 1 day ago

Support

In case of troubles

check the FAQ. Please make sure you've tried the test locally.
search known testbot issues and then create a new issue if yours isn't there already. Please give a link to the test.

Test client logs

No clients to display.

Controller - 6.x-2.0-alpha1

Test status

Status	Result
Last received	Mon, 04/16/2012 - 05:18:30
Last requested	Mon, 04/16/2012 - 05:19:03
Last tested	Mon, 04/16/2012 - 05:19:17
Test count	2

Environment status

MySQL	pass
Code review	fail

Overall Result	pass

Branch information

Identifier	6.x-2.0-alpha1
Project	Controller
Link	Project information

Event logView entire log

ID	Message	Timestamp
3582929	Result retrieved by project client.	3 years 45 weeks ago
3582924	Result retrieved by project client.	3 years 45 weeks ago
3582919	Result received from test client #.	3 years 45 weeks ago
3582914	Result received from test client #659.	3 years 45 weeks ago
3582909	Requested by test client #659.	3 years 45 weeks ago
3582904	Requested by test client #.	3 years 45 weeks ago
3582899	Test request received.	3 years 45 weeks ago

SummaryPASSED: [[Coder]]: [Code review] 0 minor(s), 1 critical(s), and 0 normal(s); [[SimpleTest]]: [MySQL] 2 pass(es).

Details

MySQL
Code review

MySQL

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a Drupal installation failure
Detect a test run failure
Detect a failing test
Complete test suite with all tests passing

2 pass(es), 0 fail(s), and 0 exception(s)

Test name	Pass	Fail	Exception
ControllerMenuItemsCollectorTestCase	1	0	0
ControllerMenuItemsNormalizerTestCase	1	0	0

Review log

[22:19:01] Log initialized (/var/lib/drupaltestbot/sites/default/files/review.test_255724.pifr_simpletest.1334553541.log)
[22:19:01] Review timestamp: (Sun, 04/15/2012 - 22:19)
[22:19:01] Review host: (drupaltestbot699-mysql)
[22:19:01] Operations:Array
(
    [0] => setup
    [1] => fetch
    [2] => checkout
    [3] => check
    [4] => apply
    [5] => syntax
    [6] => install
    [7] => review
)

[22:19:01] Result Codes: Array
(
    [fail] => 9
    [pass] => 10
)

[22:19:01] Environment variables and review information initialized.
[22:19:01] core_url = [git://git.drupal.org/project/drupal.git];  Test repository = [git://git.drupal.org/project/controller.git]
[22:19:01] Project directory is [controller]
[22:19:01] Review started.
[22:19:01] Test: Array
(
    [test_id] => 255724
    [review] => Array
        (
            [plugin] => pifr_simpletest
            [argument] => Array
                (
                    [test.title] => 
                    [test.directory.review] => Array
                        (
                            [0] => sites/default/modules/controller
                        )

                    [test.directory.apply] => 
                    [test.directory.dependency] => 
                    [test.files] => Array
                        (
                        )

                    [test.extensions] => Array
                        (
                            [0] => php
                            [1] => inc
                            [2] => install
                            [3] => module
                            [4] => test
                        )

                    [drupal.core.version] => 6
                    [drupal.core.url] => git://git.drupal.org/project/drupal.git
                    [drupal.modules] => Array
                        (
                        )

                    [drupal.user] => admin
                    [drupal.pass] => 
                    [drupal.variables] => Array
                        (
                        )

                    [simpletest.tests] => Array
                        (
                        )

                    [simpletest.db] => 
                )

        )

    [vcs] => Array
        (
            [main] => Array
                (
                    [repository] => Array
                        (
                            [type] => git
                            [url] => git://git.drupal.org/project/drupal.git
                        )

                    [vcs_identifier] => 6.x
                )

            [dependencies] => Array
                (
                    [1] => Array
                        (
                            [repository] => Array
                                (
                                    [type] => git
                                    [url] => git://git.drupal.org/project/controller.git
                                )

                            [vcs_identifier] => 6.x-2.0-alpha1
                        )

                    [2] => Array
                        (
                            [repository] => Array
                                (
                                    [type] => git
                                    [url] => git://git.drupal.org/project/simpletest.git
                                )

                            [vcs_identifier] => 6.x-2.x
                        )

                )

        )

    [files] => Array
        (
        )

)

[22:19:01] Operations: Array
(
    [0] => setup
    [1] => fetch
    [2] => checkout
    [3] => check
    [4] => apply
    [5] => syntax
    [6] => install
    [7] => review
)

[22:19:01] Invoking operation [setup]...
[22:19:01] Command [chmod -R u+w sites/default/files/checkout 2>&1] succeeded.
[22:19:01] Command [rm -rf sites/default/files/checkout 2>&1] succeeded.
[22:19:01] Command [rm -rf sites/default/files/review 2>&1] succeeded.
[22:19:01] Database backend [mysql] loaded.
[22:19:01] Invoking operation [fetch]...
[22:19:01] Invoking operation [checkout]...
[22:19:01] Version control system backend [git] loaded.
[22:19:02] Command [git clone 'git://git.drupal.org/project/drupal.git' 'checkout' --reference /var/cache/git/reference 2>&1] succeeded.
[22:19:03] Command [git --work-tree='checkout' --git-dir='checkout/.git' checkout '6.x' 2>&1] succeeded.
[22:19:03] Command [git --work-tree='checkout' --git-dir='checkout/.git' status 2>&1] succeeded.
[22:19:03] Main branch [6.x] checkout [complete].
[22:19:08] Command [git clone 'git://git.drupal.org/project/controller.git' '/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/controller' --reference /var/cache/git/reference 2>&1] succeeded.
[22:19:08] Command [git --work-tree='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/controller' --git-dir='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/controller/.git' checkout '6.x-2.0-alpha1' 2>&1] succeeded.
[22:19:08] Command [git --work-tree='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/controller' --git-dir='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/controller/.git' status 2>&1] succeeded.
[22:19:08] Dependency branch [6.x-2.0-alpha1] checkout [complete].
[22:19:10] Command [git clone 'git://git.drupal.org/project/simpletest.git' '/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/simpletest' --reference /var/cache/git/reference 2>&1] succeeded.
[22:19:10] Command [git --work-tree='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/simpletest' --git-dir='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/simpletest/.git' checkout '6.x-2.x' 2>&1] succeeded.
[22:19:10] Command [git --work-tree='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/simpletest' --git-dir='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/simpletest/.git' status 2>&1] succeeded.
[22:19:10] Dependency branch [6.x-2.x] checkout [complete].
[22:19:10] Invoking operation [check]...
[22:19:10] Ignoring operation [check].
[22:19:10] Invoking operation [apply]...
[22:19:10] Ignoring operation [apply].
[22:19:10] Invoking operation [syntax]...
[22:19:10] Command [php -l -f './sites/default/modules/controller/tests/_files/MyTestController.php' 2>&1] succeeded.
[22:19:10] Command [php -l -f './sites/default/modules/controller/tests/controller.test' 2>&1] succeeded.
[22:19:10] Command [php -l -f './sites/default/modules/controller/services/MenuItemsManager.php' 2>&1] succeeded.
[22:19:10] Command [php -l -f './sites/default/modules/controller/services/CodeFormatter.php' 2>&1] succeeded.
[22:19:10] Command [php -l -f './sites/default/modules/controller/services/MenuItemsCollector.php' 2>&1] succeeded.
[22:19:10] Command [php -l -f './sites/default/modules/controller/services/NamingService.php' 2>&1] succeeded.
[22:19:10] Command [php -l -f './sites/default/modules/controller/services/MenuItemsNormalizer.php' 2>&1] succeeded.
[22:19:10] Command [php -l -f './sites/default/modules/controller/forms/settings_form.inc' 2>&1] succeeded.
[22:19:10] Command [php -l -f './sites/default/modules/controller/forms/export_form.inc' 2>&1] succeeded.
[22:19:10] Command [php -l -f './sites/default/modules/controller/controllers/SettingsController.php' 2>&1] succeeded.
[22:19:10] Command [php -l -f './sites/default/modules/controller/controller.module' 2>&1] succeeded.
[22:19:10] Command [php -l -f './sites/default/modules/controller/controller.api.php' 2>&1] succeeded.
[22:19:10] Checked [12 of 12] relevant file(s) for syntax.
[22:19:10] Invoking operation [install]...
[22:19:13] Invoking operation [review]...
[22:19:13] Applying in /var/lib/drupaltestbot/sites/default/files/checkout file=sites/default/modules/simpletest/D6-core-simpletest.patch
[22:19:13] Command [git apply --check -p0 sites/default/modules/simpletest/D6-core-simpletest.patch 2>&1] succeeded.
[22:19:13] Command [git apply -v -p0 sites/default/modules/simpletest/D6-core-simpletest.patch 2>&1] succeeded.
[22:19:13] Completed Drupal 6 SimpleTest installation.
[22:19:14] Cleaning run-tests.sh environment.
[22:19:14] Command [/usr/bin/php ./scripts/run-tests.sh --concurrency 8 --php /usr/bin/php --url 'http://drupaltestbot699-mysql/checkout' --file sites/default/modules/controller/tests/controller.test --clean 2>&1] succeeded.
[22:19:14] Initiating run-tests.sh.
[22:19:15] Command [/usr/bin/php ./scripts/run-tests.sh --concurrency 8 --php /usr/bin/php --url 'http://drupaltestbot699-mysql/checkout' --file sites/default/modules/controller/tests/controller.test 2>&1] succeeded
  Duration: 1 seconds
  Directory: [/var/lib/drupaltestbot/sites/default/files/checkout]
  Completion status: [0]
  Output: [Drupal test run
---------------

Tests to be run:
 - ControllerMenuItemsCollectorTestCase (ControllerMenuItemsCollectorTestCase)
 - ControllerMenuItemsNormalizerTestCase (ControllerMenuItemsNormalizerTestCase)

Test run started: Mon, 04/16/2012 - 05:19

Test summary:
-------------

ControllerMenuItemsCollectorTestCase 1 pass, 0 fails, and 0 exceptions
ControllerMenuItemsNormalizerTestCase 1 pass, 0 fails, and 0 exceptions

Test run duration: 1 sec].
[22:19:15] Command [/usr/bin/php ./scripts/run-tests.sh --php /usr/bin/php --url 'http://drupaltestbot699-mysql/checkout' --file sites/default/modules/controller/tests/controller.test --list 2>&1] succeeded.
[22:19:15] Review complete. test_id=255724 result code=10 details=Array
(
    [@pass] => 2
    [@fail] => 0
    [@exception] => 0
    [@debug] => 0
)

[22:19:15] Static variables reset.

Code review

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a review run failure
Detect coder flags
Ensure that your code follows the Drupal standard and passes a coder review.
Complete coder review with all passed

0 minor(s), 1 critical(s), and 0 normal(s)

Non-pass

Test name

Minor

Critical

Normal

services/MenuItemsCollector.php

0

1

0

Message	Group	Filename	Line	Function	Status
Using eval() or drupal_eval() in your module's code could have a security risk if the PHP input provided to the function contains malicious code. (Drupal Docs)	Other	MenuItemsCollector.php	139	N/A

All

Test name

Minor

Critical

Normal

controller.api.php

0

0

0

controller.module

0

0

0

controllers/SettingsController.php

0

0

0

forms/export_form.inc

0

0

0

forms/settings_form.inc

0

0

0

services/CodeFormatter.php

0

0

0

services/MenuItemsCollector.php

0

1

0

Message	Group	Filename	Line	Function	Status
Using eval() or drupal_eval() in your module's code could have a security risk if the PHP input provided to the function contains malicious code. (Drupal Docs)	Other	MenuItemsCollector.php	139	N/A

services/MenuItemsManager.php

0

0

0

services/MenuItemsNormalizer.php

0

0

0

services/NamingService.php

0

0

0

tests/controller.test

0

0

0

tests/_files/MyTestController.php

0

0

0

Review log

[22:19:02] Log initialized (/var/lib/drupaltestbot/sites/default/files/review.test_255724.pifr_coder.1334553542.log)
[22:19:02] Review timestamp: (Sun, 04/15/2012 - 22:19)
[22:19:02] Review host: (drupaltestbot659-mysql)
[22:19:02] Operations:Array
(
    [0] => setup
    [1] => fetch
    [2] => checkout
    [3] => check
    [4] => apply
    [5] => syntax
    [6] => review
)

[22:19:02] Result Codes: Array
(
    [fail] => 8
    [pass] => 9
)

[22:19:02] Environment variables and review information initialized.
[22:19:02] core_url = [git://git.drupal.org/project/drupal.git];  Test repository = [git://git.drupal.org/project/controller.git]
[22:19:02] Review started.
[22:19:02] Test: Array
(
    [test_id] => 255724
    [review] => Array
        (
            [plugin] => pifr_coder
            [argument] => Array
                (
                    [test.title] => 
                    [test.directory.review] => Array
                        (
                            [0] => sites/default/modules/controller
                        )

                    [test.directory.apply] => 
                    [test.directory.dependency] => 
                    [test.files] => Array
                        (
                        )

                    [test.extensions] => Array
                        (
                            [0] => php
                            [1] => inc
                            [2] => install
                            [3] => module
                            [4] => test
                        )

                    [drupal.core.version] => 6
                    [drupal.core.url] => git://git.drupal.org/project/drupal.git
                    [drupal.modules] => Array
                        (
                        )

                    [drupal.user] => admin
                    [drupal.pass] => 
                    [drupal.variables] => Array
                        (
                        )

                    [coder.annotate] => 
                    [coder.reviews] => Array
                        (
                            [0] => comment
                            [1] => sql
                            [2] => i18n
                            [3] => style
                            [4] => security
                        )

                    [advisory] => 1
                )

        )

    [vcs] => Array
        (
            [main] => Array
                (
                    [repository] => Array
                        (
                            [type] => git
                            [url] => git://git.drupal.org/project/controller.git
                        )

                    [vcs_identifier] => 6.x-2.0-alpha1
                )

            [dependencies] => Array
                (
                    [0] => Array
                        (
                            [repository] => Array
                                (
                                    [type] => git
                                    [url] => git://git.drupal.org/project/drupal.git
                                )

                            [vcs_identifier] => 6.x
                        )

                )

        )

    [files] => Array
        (
        )

)

[22:19:02] Operations: Array
(
    [0] => setup
    [1] => fetch
    [2] => checkout
    [3] => check
    [4] => apply
    [5] => syntax
    [6] => review
)

[22:19:02] Invoking operation [setup]...
[22:19:02] Command [chmod -R u+w sites/default/files/checkout 2>&1] succeeded.
[22:19:02] Command [rm -rf sites/default/files/checkout 2>&1] succeeded.
[22:19:02] Command [rm -rf sites/default/files/review 2>&1] succeeded.
[22:19:02] Database backend [mysql] loaded.
[22:19:02] Invoking operation [fetch]...
[22:19:02] Invoking operation [checkout]...
[22:19:02] Version control system backend [git] loaded.
[22:19:08] Command [git clone 'git://git.drupal.org/project/controller.git' 'checkout' --reference /var/cache/git/reference 2>&1] succeeded.
[22:19:08] Command [git --work-tree='checkout' --git-dir='checkout/.git' checkout '6.x-2.0-alpha1' 2>&1] succeeded.
[22:19:08] Command [git --work-tree='checkout' --git-dir='checkout/.git' status 2>&1] succeeded.
[22:19:08] Main branch [6.x-2.0-alpha1] checkout [complete].
[22:19:08] Invoking operation [check]...
[22:19:08] Ignoring operation [check].
[22:19:08] Invoking operation [apply]...
[22:19:08] Ignoring operation [apply].
[22:19:08] Invoking operation [syntax]...
[22:19:08] Command [php -l -f './tests/_files/MyTestController.php' 2>&1] succeeded.
[22:19:08] Command [php -l -f './tests/controller.test' 2>&1] succeeded.
[22:19:08] Command [php -l -f './services/MenuItemsNormalizer.php' 2>&1] succeeded.
[22:19:08] Command [php -l -f './services/NamingService.php' 2>&1] succeeded.
[22:19:08] Command [php -l -f './services/MenuItemsCollector.php' 2>&1] succeeded.
[22:19:08] Command [php -l -f './services/CodeFormatter.php' 2>&1] succeeded.
[22:19:08] Command [php -l -f './services/MenuItemsManager.php' 2>&1] succeeded.
[22:19:08] Command [php -l -f './controllers/SettingsController.php' 2>&1] succeeded.
[22:19:08] Command [php -l -f './forms/export_form.inc' 2>&1] succeeded.
[22:19:08] Command [php -l -f './forms/settings_form.inc' 2>&1] succeeded.
[22:19:08] Command [php -l -f './controller.module' 2>&1] succeeded.
[22:19:08] Command [php -l -f './controller.api.php' 2>&1] succeeded.
[22:19:08] Checked [12 of 12] relevant file(s) for syntax.
[22:19:08] Invoking operation [review]...
[22:19:09] Reviewed [12 of 12] relevant file(s).  Ignored 0 files during the review.
[22:19:09] Review complete. test_id=255724 result code=8 details=Array
(
    [@pass] => 0
    [@fail] => 1
    [@exception] => 0
)

[22:19:09] Static variables reset.