Controller - 6.x-2.x | Drupal Quality Assurance

Latest changes

So Long and Thanks for all the Tests

1 week 1 day ago

Support

In case of troubles

check the FAQ. Please make sure you've tried the test locally.
search known testbot issues and then create a new issue if yours isn't there already. Please give a link to the test.

Test client logs

No clients to display.

Controller - 6.x-2.x

Test status

Status	Result
Last received	Wed, 06/27/2012 - 00:22:10
Last requested	Wed, 06/27/2012 - 00:23:03
Last tested	Wed, 06/27/2012 - 00:23:20
Test count	18

Environment status

MySQL	pass
Code review	fail

Overall Result	pass

Branch information

Identifier	6.x-2.x
Project	Controller
Link	Project information

Event logView entire log

ID	Message	Timestamp
3950328	Result retrieved by project client.	3 years 34 weeks ago
3950308	Result received from test client #664.	3 years 34 weeks ago
3950298	Result received from test client #.	3 years 34 weeks ago
3950288	Requested by test client #.	3 years 34 weeks ago
3950283	Requested by test client #664.	3 years 34 weeks ago
3950278	Test request received.	3 years 34 weeks ago
3950223	Result retrieved by project client.	3 years 34 weeks ago
3950213	Result received from test client #654.	3 years 34 weeks ago
3950208	Result received from test client #.	3 years 34 weeks ago
3950203	Requested by test client #.	3 years 34 weeks ago

SummaryPASSED: [[Coder]]: [Code review] 2 minor(s), 0 critical(s), and 2 normal(s); [[SimpleTest]]: [MySQL] 4 pass(es).

Details

MySQL
Code review

MySQL

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a Drupal installation failure
Detect a test run failure
Detect a failing test
Complete test suite with all tests passing

4 pass(es), 0 fail(s), and 0 exception(s)

Test name	Pass	Fail	Exception
ControllerMenuItemsCollectorTestCase	1	0	0
ControllerMenuItemsNormalizerTestCase	2	0	0
ControllerPhpDocParserTestCase (ControllerPhpDocParserTestCase) [Unknown]	1	0	0

Review log

[17:23:01] Log initialized (/var/lib/drupaltestbot/sites/default/files/review.test_255674.pifr_simpletest.1340756581.log)
[17:23:01] Review timestamp: (Tue, 06/26/2012 - 17:23)
[17:23:01] Review host: (drupaltestbot664-mysql)
[17:23:01] Environment variables and review information initialized.
[17:23:01] core_url = [git://git.drupal.org/project/drupal.git];  Test repository = [git://git.drupal.org/project/controller.git]
[17:23:01] Project directory is [controller]
[17:23:01] Review started.
[17:23:01] Invoking operation [setup]...
[17:23:01] Command [chmod -R u+w sites/default/files/checkout 2>&1] succeeded.
[17:23:01] Command [rm -rf sites/default/files/checkout 2>&1] succeeded.
[17:23:01] Command [rm -rf sites/default/files/review 2>&1] succeeded.
[17:23:01] Database backend [mysql] loaded.
[17:23:01] Invoking operation [fetch]...
[17:23:01] Invoking operation [checkout]...
[17:23:01] Version control system backend [git] loaded.
[17:23:03] Command [git clone 'git://git.drupal.org/project/drupal.git' 'checkout' --reference /var/cache/git/reference 2>&1] succeeded.
[17:23:03] Command [git --work-tree='checkout' --git-dir='checkout/.git' checkout '6.x' 2>&1] succeeded.
[17:23:03] Command [git --work-tree='checkout' --git-dir='checkout/.git' status 2>&1] succeeded.
[17:23:03] Main branch [6.x] checkout [complete].
[17:23:10] Command [git clone 'git://git.drupal.org/project/controller.git' '/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/controller' --reference /var/cache/git/reference 2>&1] succeeded.
[17:23:10] Command [git --work-tree='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/controller' --git-dir='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/controller/.git' checkout '6.x-2.x' 2>&1] succeeded.
[17:23:10] Command [git --work-tree='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/controller' --git-dir='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/controller/.git' status 2>&1] succeeded.
[17:23:10] Dependency branch [6.x-2.x] checkout [complete].
[17:23:12] Command [git clone 'git://git.drupal.org/project/simpletest.git' '/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/simpletest' --reference /var/cache/git/reference 2>&1] succeeded.
[17:23:12] Command [git --work-tree='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/simpletest' --git-dir='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/simpletest/.git' checkout '6.x-2.x' 2>&1] succeeded.
[17:23:12] Command [git --work-tree='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/simpletest' --git-dir='/var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/simpletest/.git' status 2>&1] succeeded.
[17:23:12] Dependency branch [6.x-2.x] checkout [complete].
[17:23:12] Invoking operation [check]...
[17:23:12] Ignoring operation [check].
[17:23:12] Invoking operation [apply]...
[17:23:12] Ignoring operation [apply].
[17:23:12] Invoking operation [syntax]...
[17:23:12] Command [php -l -f './sites/default/modules/controller/forms/settings_form.inc' 2>&1] succeeded.
[17:23:12] Command [php -l -f './sites/default/modules/controller/forms/export_form.inc' 2>&1] succeeded.
[17:23:12] Command [php -l -f './sites/default/modules/controller/tests/_files/MyBarController.php' 2>&1] succeeded.
[17:23:12] Command [php -l -f './sites/default/modules/controller/tests/_files/MyFooController.php' 2>&1] succeeded.
[17:23:12] Command [php -l -f './sites/default/modules/controller/tests/controller.test' 2>&1] succeeded.
[17:23:12] Command [php -l -f './sites/default/modules/controller/controllers/SettingsController.php' 2>&1] succeeded.
[17:23:12] Command [php -l -f './sites/default/modules/controller/services/NamingService.php' 2>&1] succeeded.
[17:23:12] Command [php -l -f './sites/default/modules/controller/services/MenuItemsCollector.php' 2>&1] succeeded.
[17:23:12] Command [php -l -f './sites/default/modules/controller/services/CodeFormatter.php' 2>&1] succeeded.
[17:23:12] Command [php -l -f './sites/default/modules/controller/services/ParserInterface.php' 2>&1] succeeded.
[17:23:12] Command [php -l -f './sites/default/modules/controller/services/MenuItemsNormalizer.php' 2>&1] succeeded.
[17:23:12] Command [php -l -f './sites/default/modules/controller/services/MethodDocParser.php' 2>&1] succeeded.
[17:23:12] Command [php -l -f './sites/default/modules/controller/services/MenuItemsManager.php' 2>&1] succeeded.
[17:23:12] Command [php -l -f './sites/default/modules/controller/controller.module' 2>&1] succeeded.
[17:23:12] Command [php -l -f './sites/default/modules/controller/controller.api.php' 2>&1] succeeded.
[17:23:12] Checked [15 of 15] relevant file(s) for syntax.
[17:23:12] Invoking operation [install]...
[17:23:15] Invoking operation [review]...
[17:23:15] Applying in /var/lib/drupaltestbot/sites/default/files/checkout file=sites/default/modules/simpletest/D6-core-simpletest.patch
[17:23:15] Command [git apply --check -p0 sites/default/modules/simpletest/D6-core-simpletest.patch 2>&1] succeeded.
[17:23:15] Command [git apply -v -p0 sites/default/modules/simpletest/D6-core-simpletest.patch 2>&1] succeeded.
[17:23:15] Completed Drupal 6 SimpleTest installation.
[17:23:16] Cleaning run-tests.sh environment.
[17:23:16] Command [/usr/bin/php ./scripts/run-tests.sh --concurrency 8 --php /usr/bin/php --url 'http://drupaltestbot664-mysql/checkout' --file sites/default/modules/controller/tests/controller.test --clean 2>&1] succeeded.
[17:23:16] Initiating run-tests.sh.
[17:23:18] Command [/usr/bin/php ./scripts/run-tests.sh --concurrency 8 --php /usr/bin/php --url 'http://drupaltestbot664-mysql/checkout' --file sites/default/modules/controller/tests/controller.test 2>&1] succeeded
  Duration: 2 seconds
  Directory: [/var/lib/drupaltestbot/sites/default/files/checkout]
  Completion status: [0]
  Output: [Drupal test run
---------------

Tests to be run:
 - ControllerMenuItemsCollectorTestCase (ControllerMenuItemsCollectorTestCase)
 - ControllerMenuItemsNormalizerTestCase (ControllerMenuItemsNormalizerTestCase)
 - ControllerPhpDocParserTestCase (ControllerPhpDocParserTestCase)

Test run started: Wed, 06/27/2012 - 00:23

Test summary:
-------------

ControllerMenuItemsNormalizerTestCase 2 passes, 0 fails, and 0 exceptions
ControllerMenuItemsCollectorTestCase 1 pass, 0 fails, and 0 exceptions
ControllerPhpDocParserTestCase 1 pass, 0 fails, and 0 exceptions

Test run duration: 1 sec].
[17:23:18] Command [/usr/bin/php ./scripts/run-tests.sh --php /usr/bin/php --url 'http://drupaltestbot664-mysql/checkout' --file sites/default/modules/controller/tests/controller.test --list 2>&1] succeeded.
[17:23:18] Review complete. test_id=255674 result code=10 details=Array
(
    [@pass] => 4
    [@fail] => 0
    [@exception] => 0
    [@debug] => 0
)

[17:23:18] Static variables reset.

Code review

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a review run failure
Detect coder flags
Ensure that your code follows the Drupal standard and passes a coder review.
Complete coder review with all passed

2 minor(s), 0 critical(s), and 2 normal(s)

Non-pass

Test name

Minor

Critical

Normal

services/MethodDocParser.php

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	MethodDocParser.php	-1	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	MethodDocParser.php	47	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	MethodDocParser.php	48	N/A

services/ParserInterface.php

Message	Group	Filename	Line	Function	Status
@file block missing (Drupal Docs)	Other	ParserInterface.php	-1	N/A

All

Test name

Minor

Critical

Normal

controller.api.php

controller.module

controllers/SettingsController.php

forms/export_form.inc

forms/settings_form.inc

services/CodeFormatter.php

services/MenuItemsCollector.php

services/MenuItemsManager.php

services/MenuItemsNormalizer.php

services/MethodDocParser.php

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	MethodDocParser.php	-1	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	MethodDocParser.php	47	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	MethodDocParser.php	48	N/A

services/NamingService.php

services/ParserInterface.php

Message	Group	Filename	Line	Function	Status
@file block missing (Drupal Docs)	Other	ParserInterface.php	-1	N/A

tests/controller.test

tests/_files/MyBarController.php

tests/_files/MyFooController.php

Review log

[17:23:02] Log initialized (/var/lib/drupaltestbot/sites/default/files/review.test_255674.pifr_coder.1340756582.log)
[17:23:02] Review timestamp: (Tue, 06/26/2012 - 17:23)
[17:23:02] Review host: (scratchtestbot-mysql)
[17:23:02] Environment variables and review information initialized.
[17:23:02] core_url = [git://git.drupal.org/project/drupal.git];  Test repository = [git://git.drupal.org/project/controller.git]
[17:23:02] Review started.
[17:23:02] Invoking operation [setup]...
[17:23:02] Command [chmod -R u+w sites/default/files/checkout 2>&1] succeeded.
[17:23:02] Command [rm -rf sites/default/files/checkout 2>&1] succeeded.
[17:23:02] Command [rm -rf sites/default/files/review 2>&1] succeeded.
[17:23:02] Database backend [mysql] loaded.
[17:23:02] Invoking operation [fetch]...
[17:23:02] Invoking operation [checkout]...
[17:23:02] Version control system backend [git] loaded.
[17:23:09] Command [git clone 'git://git.drupal.org/project/controller.git' 'checkout' --reference /var/cache/git/reference 2>&1] succeeded.
[17:23:09] Command [git --work-tree='checkout' --git-dir='checkout/.git' checkout '6.x-2.x' 2>&1] succeeded.
[17:23:09] Command [git --work-tree='checkout' --git-dir='checkout/.git' status 2>&1] succeeded.
[17:23:09] Main branch [6.x-2.x] checkout [complete].
[17:23:09] Invoking operation [check]...
[17:23:09] Ignoring operation [check].
[17:23:09] Invoking operation [apply]...
[17:23:09] Ignoring operation [apply].
[17:23:09] Invoking operation [syntax]...
[17:23:09] Command [php -l -f './tests/_files/MyBarController.php' 2>&1] succeeded.
[17:23:09] Command [php -l -f './tests/_files/MyFooController.php' 2>&1] succeeded.
[17:23:09] Command [php -l -f './tests/controller.test' 2>&1] succeeded.
[17:23:09] Command [php -l -f './controllers/SettingsController.php' 2>&1] succeeded.
[17:23:09] Command [php -l -f './forms/settings_form.inc' 2>&1] succeeded.
[17:23:09] Command [php -l -f './forms/export_form.inc' 2>&1] succeeded.
[17:23:09] Command [php -l -f './services/MenuItemsManager.php' 2>&1] succeeded.
[17:23:09] Command [php -l -f './services/MenuItemsCollector.php' 2>&1] succeeded.
[17:23:09] Command [php -l -f './services/MenuItemsNormalizer.php' 2>&1] succeeded.
[17:23:09] Command [php -l -f './services/NamingService.php' 2>&1] succeeded.
[17:23:09] Command [php -l -f './services/CodeFormatter.php' 2>&1] succeeded.
[17:23:09] Command [php -l -f './services/MethodDocParser.php' 2>&1] succeeded.
[17:23:09] Command [php -l -f './services/ParserInterface.php' 2>&1] succeeded.
[17:23:09] Command [php -l -f './controller.api.php' 2>&1] succeeded.
[17:23:09] Command [php -l -f './controller.module' 2>&1] succeeded.
[17:23:09] Checked [15 of 15] relevant file(s) for syntax.
[17:23:09] Invoking operation [review]...
[17:23:10] Reviewed [15 of 15] relevant file(s).  Ignored 0 files during the review.
[17:23:10] Review complete. test_id=255674 result code=8 details=Array
(
    [@pass] => 2
    [@fail] => 0
    [@exception] => 2
)

[17:23:10] Static variables reset.