Autosave - 7.x-2.x

Test status
StatusResult
Last receivedFri, 04/06/2012 - 00:40:46
Last requestedFri, 04/06/2012 - 00:41:03
Last testedFri, 04/06/2012 - 00:41:28
Test count2
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier7.x-2.x
ProjectAutosave
LinkProject information
SummaryPASSED: [[Coder]]: [Code review] 6 minor(s), 1 critical(s), and 11 normal(s); [[SimpleTest]]: [MySQL] 0 pass(es).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
6 minor(s), 1 critical(s), and 11 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandautosave.install008
MessageGroupFilenameLineFunctionStatus
Remove the empty commented line in your function documentation.Otherautosave.install6N/A
Function summaries should be one line only. (Drupal Docs)Otherautosave.install10N/A
Use the matching Drupal theme functions, not raw HTML.Otherautosave.install14N/A
Function summaries should be one line only. (Drupal Docs)Otherautosave.install18N/A
Doxygen uses @todo and @bug to markup things to be done.Otherautosave.install22N/A
Function summaries should be one line only. (Drupal Docs)Otherautosave.install27N/A
Doxygen uses @todo and @bug to markup things to be done.Otherautosave.install31N/A
Function summaries should be one line only. (Drupal Docs)Otherautosave.install36N/A
Expandautosave.module613
MessageGroupFilenameLineFunctionStatus
indent secondary line of comment one space Otherautosave.module24N/A
indent secondary line of comment one space Otherautosave.module25N/A
Use the matching Drupal theme functions, not raw HTML.Otherautosave.module57N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)Otherautosave.module201N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)Otherautosave.module238N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)Otherautosave.module239N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)Otherautosave.module242N/A
Use db_query_range() instead of the SQL LIMIT clause (Drupal Docs)Otherautosave.module256N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Otherautosave.module256N/A
Function documentation should be less than 80 characters per line.Otherautosave.module292N/A

All

Test nameMinorCriticalNormal
Expandautosave.install008
MessageGroupFilenameLineFunctionStatus
Remove the empty commented line in your function documentation.Otherautosave.install6N/A
Function summaries should be one line only. (Drupal Docs)Otherautosave.install10N/A
Use the matching Drupal theme functions, not raw HTML.Otherautosave.install14N/A
Function summaries should be one line only. (Drupal Docs)Otherautosave.install18N/A
Doxygen uses @todo and @bug to markup things to be done.Otherautosave.install22N/A
Function summaries should be one line only. (Drupal Docs)Otherautosave.install27N/A
Doxygen uses @todo and @bug to markup things to be done.Otherautosave.install31N/A
Function summaries should be one line only. (Drupal Docs)Otherautosave.install36N/A
Expandautosave.module613
MessageGroupFilenameLineFunctionStatus
indent secondary line of comment one space Otherautosave.module24N/A
indent secondary line of comment one space Otherautosave.module25N/A
Use the matching Drupal theme functions, not raw HTML.Otherautosave.module57N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)Otherautosave.module201N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)Otherautosave.module238N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)Otherautosave.module239N/A
Potential problem: use the Form API to prevent against CSRF attacks. If you need to use $_POST variables, ensure they are fully sanitized if displayed by using check_plain(), filter_xss() or similar. (Drupal Docs)Otherautosave.module242N/A
Use db_query_range() instead of the SQL LIMIT clause (Drupal Docs)Otherautosave.module256N/A
Potential problem: "SELECT FROM {node}" statements should probably be wrapped in db_rewrite_sql() and with the alias for {node} table defined (e.g. {node} n)Otherautosave.module256N/A
Function documentation should be less than 80 characters per line.Otherautosave.module292N/A