Taskbar - 7.x-1.x | Drupal Quality Assurance

Latest changes

So Long and Thanks for all the Tests

1 week 2 days ago

Support

In case of troubles

check the FAQ. Please make sure you've tried the test locally.
search known testbot issues and then create a new issue if yours isn't there already. Please give a link to the test.

Test client logs

No clients to display.

Taskbar - 7.x-1.x

Test status

Status	Result
Last received	Tue, 04/10/2012 - 15:22:38
Last requested	Tue, 04/10/2012 - 15:23:03
Last tested	Tue, 04/10/2012 - 15:23:52
Test count	4

Environment status

MySQL	pass
Code review	fail

Overall Result	pass

Branch information

Identifier	7.x-1.x
Project	Taskbar
Link	Project information

Event logView entire log

ID	Message	Timestamp
3555219	Result retrieved by project client.	3 years 46 weeks ago
3555214	Result retrieved by project client.	3 years 46 weeks ago
3555209	Result received from test client #.	3 years 46 weeks ago
3555204	Result received from test client #659.	3 years 46 weeks ago
3555199	Requested by test client #659.	3 years 46 weeks ago
3555194	Requested by test client #.	3 years 46 weeks ago
3555189	Test request received.	3 years 46 weeks ago
3537449	Result retrieved by project client.	3 years 46 weeks ago
3537424	Result retrieved by project client.	3 years 46 weeks ago
3537414	Result received from test client #.	3 years 46 weeks ago

SummaryPASSED: [[Coder]]: [Code review] 1 minor(s), 5 critical(s), and 49 normal(s); [[SimpleTest]]: [MySQL] 0 pass(es).

Details

MySQL
Code review

MySQL

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a Drupal installation failure
Detect a test run failure
Detect a failing test
Complete test suite with all tests passing

Review log

Code review

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a review run failure
Detect coder flags
Ensure that your code follows the Drupal standard and passes a coder review.
Complete coder review with all passed

1 minor(s), 5 critical(s), and 49 normal(s)

Non-pass

Test name

Minor

Critical

Normal

includes/taskbar.theme.inc

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	taskbar.theme.inc	-1	N/A
Separate comments from comment syntax by a space.	Other	taskbar.theme.inc	2	N/A
Separate comments from comment syntax by a space.	Other	taskbar.theme.inc	4	N/A

modules/taskbar_migrate/taskbar_migrate.module

Message	Group	Filename	Line	Function	Status
Doxygen uses @todo and @bug to markup things to be done.	Other	taskbar_migrate.module	85	N/A
In SQL strings, Use db_query() placeholders in place of variables. This is a potential source of SQL injection attacks when the variable can come from user data. (Drupal Docs)	Other	taskbar_migrate.module	86	N/A

modules/taskbar_tacore/taskbar_tacore.api.php

Message	Group	Filename	Line	Function
Function documentation should be less than 80 characters per line.	Other	taskbar_tacore.api.php	15	N/A
Function documentation should be less than 80 characters per line.	Other	taskbar_tacore.api.php	20	N/A
Function documentation should be less than 80 characters per line.	Other	taskbar_tacore.api.php	21	N/A
Remove the empty commented line in your function documentation.	Other	taskbar_tacore.api.php	25	N/A

modules/taskbar_tacore/taskbar_tacore.module

Message	Group	Filename	Line	Function
Separate comments from comment syntax by a space.	Other	taskbar_tacore.module	50	N/A
Separate comments from comment syntax by a space.	Other	taskbar_tacore.module	52	N/A
Separate comments from comment syntax by a space.	Other	taskbar_tacore.module	83	N/A
Separate comments from comment syntax by a space.	Other	taskbar_tacore.module	85	N/A

modules/taskbar_ui/taskbar_ui-list-form.tpl.php

Message	Group	Filename	Line	Function	Status
the final ?> should be omitted from all code files	Other	taskbar_ui-list-form.tpl.php	68	N/A

modules/taskbar_ui/taskbar_ui.module

Message	Group	Filename	Line	Function
Administrative menu items should have a description.	Other	taskbar_ui.module	69	N/A
Administrative menu items should have a description.	Other	taskbar_ui.module	76	N/A
Administrative menu items should have a description.	Other	taskbar_ui.module	83	N/A
Separate comments from comment syntax by a space.	Other	taskbar_ui.module	92	N/A
Separate comments from comment syntax by a space.	Other	taskbar_ui.module	94	N/A
Potential problem: confirm_form() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	taskbar_ui.module	465	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	taskbar_ui.module	474	N/A
Function documentation should be less than 80 characters per line.	Other	taskbar_ui.module	482	N/A
Function documentation should be less than 80 characters per line.	Other	taskbar_ui.module	483	N/A
Using eval() or drupal_eval() in your module's code could have a security risk if the PHP input provided to the function contains malicious code. (Drupal Docs)	Other	taskbar_ui.module	528	N/A
table names should be enclosed in {curly_brackets}	Other	taskbar_ui.module	595	N/A
Separate comments from comment syntax by a space.	Other	taskbar_ui.module	640	N/A
Separate comments from comment syntax by a space.	Other	taskbar_ui.module	642	N/A

modules/taskbar_views/taskbar_views.install

Message	Group	Filename	Line	Function
Doxygen uses @todo and @bug to markup things to be done.	Other	taskbar_views.install	20	N/A
Doxygen uses @todo and @bug to markup things to be done.	Other	taskbar_views.install	104	N/A
Doxygen uses @todo and @bug to markup things to be done.	Other	taskbar_views.install	106	N/A

modules/taskbar_views/taskbar_views.module

Message	Group	Filename	Line	Function
Function summaries should be one line only. (Drupal Docs)	Other	taskbar_views.module	103	N/A
If you define a @param or @return, you should document it as well.	Other	taskbar_views.module	104	N/A
If you define a @param or @return, you should document it as well.	Other	taskbar_views.module	105	N/A

taskbar.api.php

Message	Group	Filename	Line	Function
Function documentation should be less than 80 characters per line.	Other	taskbar.api.php	8	N/A
Function documentation should be less than 80 characters per line.	Other	taskbar.api.php	9	N/A
There should be no trailing spaces	Other	taskbar.api.php	11	N/A
Function documentation should be less than 80 characters per line.	Other	taskbar.api.php	17	N/A
Function documentation should be less than 80 characters per line.	Other	taskbar.api.php	21	N/A
Function documentation should be less than 80 characters per line.	Other	taskbar.api.php	53	N/A
Function documentation should be less than 80 characters per line.	Other	taskbar.api.php	58	N/A
Function documentation should be less than 80 characters per line.	Other	taskbar.api.php	59	N/A
@param and @return descriptions begin indented on the next line. (Drupal Docs)	Other	taskbar.api.php	129	N/A

taskbar.module

Message	Group	Filename	Line	Function
Separate comments from comment syntax by a space.	Other	taskbar.module	142	N/A
Separate comments from comment syntax by a space.	Other	taskbar.module	144	N/A
Function summaries should be one line only. (Drupal Docs)	Other	taskbar.module	173	N/A
If you define a @param or @return, you should document it as well.	Other	taskbar.module	205	N/A
If you define a @param or @return, you should document it as well.	Other	taskbar.module	220	N/A
Function summaries should be one line only. (Drupal Docs)	Other	taskbar.module	287	N/A
Function summaries should be one line only. (Drupal Docs)	Other	taskbar.module	577	N/A
Function summaries should be one line only. (Drupal Docs)	Other	taskbar.module	652	N/A
If you define a @param or @return, you should document it as well.	Other	taskbar.module	653	N/A
@param and @return descriptions begin indented on the next line. (Drupal Docs)	Other	taskbar.module	653	N/A
If you define a @param or @return, you should document it as well.	Other	taskbar.module	654	N/A
@param and @return descriptions begin indented on the next line. (Drupal Docs)	Other	taskbar.module	654	N/A

taskbar.taskbar.inc

Message	Group	Filename	Line	Function	Status
Use sentence case, not title case, for end-user strings. (Wikipedia)	Other	taskbar.taskbar.inc	66	N/A

All

Test name

Minor

Critical

Normal

examples/taskbar_activity_example/taskbar_activity_example.install

examples/taskbar_activity_example/taskbar_activity_example.module

includes/taskbar.theme.inc

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	taskbar.theme.inc	-1	N/A
Separate comments from comment syntax by a space.	Other	taskbar.theme.inc	2	N/A
Separate comments from comment syntax by a space.	Other	taskbar.theme.inc	4	N/A

modules/taskbar_activity/taskbar_activity.admin.inc

modules/taskbar_activity/taskbar_activity.api.php

modules/taskbar_activity/taskbar_activity.install

modules/taskbar_activity/taskbar_activity.module

modules/taskbar_migrate/taskbar_migrate.module

Message	Group	Filename	Line	Function	Status
Doxygen uses @todo and @bug to markup things to be done.	Other	taskbar_migrate.module	85	N/A
In SQL strings, Use db_query() placeholders in place of variables. This is a potential source of SQL injection attacks when the variable can come from user data. (Drupal Docs)	Other	taskbar_migrate.module	86	N/A

modules/taskbar_tacore/taskbar_tacore.api.php

Message	Group	Filename	Line	Function
Function documentation should be less than 80 characters per line.	Other	taskbar_tacore.api.php	15	N/A
Function documentation should be less than 80 characters per line.	Other	taskbar_tacore.api.php	20	N/A
Function documentation should be less than 80 characters per line.	Other	taskbar_tacore.api.php	21	N/A
Remove the empty commented line in your function documentation.	Other	taskbar_tacore.api.php	25	N/A

modules/taskbar_tacore/taskbar_tacore.install

modules/taskbar_tacore/taskbar_tacore.module

Message	Group	Filename	Line	Function
Separate comments from comment syntax by a space.	Other	taskbar_tacore.module	50	N/A
Separate comments from comment syntax by a space.	Other	taskbar_tacore.module	52	N/A
Separate comments from comment syntax by a space.	Other	taskbar_tacore.module	83	N/A
Separate comments from comment syntax by a space.	Other	taskbar_tacore.module	85	N/A

modules/taskbar_ui/taskbar_ui-list-form.tpl.php

Message	Group	Filename	Line	Function	Status
the final ?> should be omitted from all code files	Other	taskbar_ui-list-form.tpl.php	68	N/A

modules/taskbar_ui/taskbar_ui.module

Message	Group	Filename	Line	Function
Administrative menu items should have a description.	Other	taskbar_ui.module	69	N/A
Administrative menu items should have a description.	Other	taskbar_ui.module	76	N/A
Administrative menu items should have a description.	Other	taskbar_ui.module	83	N/A
Separate comments from comment syntax by a space.	Other	taskbar_ui.module	92	N/A
Separate comments from comment syntax by a space.	Other	taskbar_ui.module	94	N/A
Potential problem: confirm_form() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	taskbar_ui.module	465	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	taskbar_ui.module	474	N/A
Function documentation should be less than 80 characters per line.	Other	taskbar_ui.module	482	N/A
Function documentation should be less than 80 characters per line.	Other	taskbar_ui.module	483	N/A
Using eval() or drupal_eval() in your module's code could have a security risk if the PHP input provided to the function contains malicious code. (Drupal Docs)	Other	taskbar_ui.module	528	N/A
table names should be enclosed in {curly_brackets}	Other	taskbar_ui.module	595	N/A
Separate comments from comment syntax by a space.	Other	taskbar_ui.module	640	N/A
Separate comments from comment syntax by a space.	Other	taskbar_ui.module	642	N/A

modules/taskbar_views/taskbar_views.admin.inc

modules/taskbar_views/taskbar_views.install

Message	Group	Filename	Line	Function
Doxygen uses @todo and @bug to markup things to be done.	Other	taskbar_views.install	20	N/A
Doxygen uses @todo and @bug to markup things to be done.	Other	taskbar_views.install	104	N/A
Doxygen uses @todo and @bug to markup things to be done.	Other	taskbar_views.install	106	N/A

modules/taskbar_views/taskbar_views.module

Message	Group	Filename	Line	Function
Function summaries should be one line only. (Drupal Docs)	Other	taskbar_views.module	103	N/A
If you define a @param or @return, you should document it as well.	Other	taskbar_views.module	104	N/A
If you define a @param or @return, you should document it as well.	Other	taskbar_views.module	105	N/A

providers/taskbar_provider.block.inc

providers/taskbar_provider.custom.inc

providers/taskbar_provider.link.inc

taskbar.api.php

Message	Group	Filename	Line	Function
Function documentation should be less than 80 characters per line.	Other	taskbar.api.php	8	N/A
Function documentation should be less than 80 characters per line.	Other	taskbar.api.php	9	N/A
There should be no trailing spaces	Other	taskbar.api.php	11	N/A
Function documentation should be less than 80 characters per line.	Other	taskbar.api.php	17	N/A
Function documentation should be less than 80 characters per line.	Other	taskbar.api.php	21	N/A
Function documentation should be less than 80 characters per line.	Other	taskbar.api.php	53	N/A
Function documentation should be less than 80 characters per line.	Other	taskbar.api.php	58	N/A
Function documentation should be less than 80 characters per line.	Other	taskbar.api.php	59	N/A
@param and @return descriptions begin indented on the next line. (Drupal Docs)	Other	taskbar.api.php	129	N/A

taskbar.install

taskbar.module

Message	Group	Filename	Line	Function
Separate comments from comment syntax by a space.	Other	taskbar.module	142	N/A
Separate comments from comment syntax by a space.	Other	taskbar.module	144	N/A
Function summaries should be one line only. (Drupal Docs)	Other	taskbar.module	173	N/A
If you define a @param or @return, you should document it as well.	Other	taskbar.module	205	N/A
If you define a @param or @return, you should document it as well.	Other	taskbar.module	220	N/A
Function summaries should be one line only. (Drupal Docs)	Other	taskbar.module	287	N/A
Function summaries should be one line only. (Drupal Docs)	Other	taskbar.module	577	N/A
Function summaries should be one line only. (Drupal Docs)	Other	taskbar.module	652	N/A
If you define a @param or @return, you should document it as well.	Other	taskbar.module	653	N/A
@param and @return descriptions begin indented on the next line. (Drupal Docs)	Other	taskbar.module	653	N/A
If you define a @param or @return, you should document it as well.	Other	taskbar.module	654	N/A
@param and @return descriptions begin indented on the next line. (Drupal Docs)	Other	taskbar.module	654	N/A

taskbar.taskbar.inc

Message	Group	Filename	Line	Function	Status
Use sentence case, not title case, for end-user strings. (Wikipedia)	Other	taskbar.taskbar.inc	66	N/A

Review log