Node As Block - 6.x-1.x

Test status
StatusResult
Last receivedTue, 04/03/2012 - 14:48:37
Last requestedTue, 04/03/2012 - 14:49:03
Last testedTue, 04/03/2012 - 14:49:16
Test count2
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier6.x-1.x
ProjectNode As Block
LinkProject information
SummaryPASSED: [[Coder]]: [Code review] 3 minor(s), 1 critical(s), and 6 normal(s); [[SimpleTest]]: [MySQL] 0 pass(es).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
3 minor(s), 1 critical(s), and 6 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandnodeasblock.install202
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOthernodeasblock.install5N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othernodeasblock.install18N/A
Function summaries should be one line only. (Drupal Docs)Othernodeasblock.install34N/A
There should be no trailing spacesOthernodeasblock.install35N/A
Expandnodeasblock.module013
MessageGroupFilenameLineFunctionStatus
Function documentation should be less than 80 characters per line.Othernodeasblock.module15N/A
Function summaries should be one line only. (Drupal Docs)Othernodeasblock.module20N/A
Potential problem: drupal_set_title() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Othernodeasblock.module208N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Othernodeasblock.module376N/A
Expandnodeasblock.tpl.php101
MessageGroupFilenameLineFunctionStatus
@file description should be on the following line (Drupal Docs)Othernodeasblock.tpl.php4N/A
the final ?> should be omitted from all code filesOthernodeasblock.tpl.php16N/A

All

Test nameMinorCriticalNormal
Expandnodeasblock.install202
MessageGroupFilenameLineFunctionStatus
There should be no trailing spacesOthernodeasblock.install5N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Othernodeasblock.install18N/A
Function summaries should be one line only. (Drupal Docs)Othernodeasblock.install34N/A
There should be no trailing spacesOthernodeasblock.install35N/A
Expandnodeasblock.module013
MessageGroupFilenameLineFunctionStatus
Function documentation should be less than 80 characters per line.Othernodeasblock.module15N/A
Function summaries should be one line only. (Drupal Docs)Othernodeasblock.module20N/A
Potential problem: drupal_set_title() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.Othernodeasblock.module208N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Othernodeasblock.module376N/A
Expandnodeasblock.tpl.php101
MessageGroupFilenameLineFunctionStatus
@file description should be on the following line (Drupal Docs)Othernodeasblock.tpl.php4N/A
the final ?> should be omitted from all code filesOthernodeasblock.tpl.php16N/A