Media - 7.x-1.0 | Drupal Quality Assurance

Latest changes

So Long and Thanks for all the Tests

1 week 2 days ago

Support

In case of troubles

check the FAQ. Please make sure you've tried the test locally.
search known testbot issues and then create a new issue if yours isn't there already. Please give a link to the test.

Test client logs

No clients to display.

Media - 7.x-1.0

Test status

Status	Result
Last received	Wed, 04/11/2012 - 10:10:46
Last requested	Wed, 04/11/2012 - 10:11:03
Last tested	Wed, 04/11/2012 - 10:12:03
Test count	2

Environment status

MySQL	pass
Code review	fail

Overall Result	pass

Branch information

Identifier	7.x-1.0
Project	Media
Link	Project information

Event logView entire log

ID	Message	Timestamp
3558914	Result retrieved by project client.	3 years 45 weeks ago
3558864	Result retrieved by project client.	3 years 45 weeks ago
3558849	Result received from test client #.	3 years 45 weeks ago
3558829	Result received from test client #654.	3 years 45 weeks ago
3558824	Requested by test client #654.	3 years 45 weeks ago
3558819	Requested by test client #.	3 years 45 weeks ago
3558814	Test request received.	3 years 45 weeks ago

SummaryPASSED: [[Coder]]: [Code review] 12 minor(s), 7 critical(s), and 6 normal(s); [[SimpleTest]]: [MySQL] 11 pass(es).

Details

MySQL
Code review

MySQL

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a Drupal installation failure
Detect a test run failure
Detect a failing test
Complete test suite with all tests passing

11 pass(es), 0 fail(s), and 0 exception(s)

Test name	Pass	Fail	Exception
Media entity (MediaEntityTest) [Media]	5	0	0
Media types (MediaTypeTest) [Media]	6	0	0

Review log

Code review

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a review run failure
Detect coder flags
Ensure that your code follows the Drupal standard and passes a coder review.
Complete coder review with all passed

12 minor(s), 7 critical(s), and 6 normal(s)

Non-pass

Test name

Minor

Critical

Normal

file_entity/file_entity.admin.inc

Message	Group	Filename	Line	Function
Functions should be called with no spaces between the function name and opening parentheses	Other	file_entity.admin.inc	57	N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	file_entity.admin.inc	76	N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	file_entity.admin.inc	78	N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	file_entity.admin.inc	124	N/A

includes/media.admin.inc

Message	Group	Filename	Line	Function
The control statement should be on a separate line from the control conditional	Other	media.admin.inc	202	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)	Other	media.admin.inc	558	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)	Other	media.admin.inc	561	N/A

includes/MediaReadOnlyStreamWrapper.inc

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	MediaReadOnlyStreamWrapper.inc	-1	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	MediaReadOnlyStreamWrapper.inc	152	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	MediaReadOnlyStreamWrapper.inc	159	N/A

MediaReadOnlyStreamWrapper.inc

Message	Group	Filename	Line	Function	Status
@file block missing (Drupal Docs)	Other	MediaReadOnlyStreamWrapper.inc	-1	N/A

modules/media_internet/media_internet.module

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	media_internet.module	-1	N/A
@see should always be at the beginning of a line, never inline in other comments.	Other	media_internet.module	115	N/A
@see should always be followed by a filename, a URL, class/interface name (optionally including method), or a function name including ().	Other	media_internet.module	115	N/A
@see references should be separated by "," followed by a single space and with no trailing punctuation	Other	media_internet.module	115	N/A

templates/media-dialog-page.tpl.php

Message	Group	Filename	Line	Function	Status
The control statement should be on a separate line from the control conditional	Other	media-dialog-page.tpl.php	71	N/A

All

Test name Minor Critical Normal

file_entity/file_entity.admin.inc 0 3 1

Message	Group	Filename	Line	Function
Functions should be called with no spaces between the function name and opening parentheses	Other	file_entity.admin.inc	57	N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	file_entity.admin.inc	76	N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	file_entity.admin.inc	78	N/A
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	file_entity.admin.inc	124	N/A

file_entity/file_entity.api.php 0 0 0

file_entity/file_entity.file_api.inc 1 0 0

Message	Group	Filename	Line	Function	Status
in most cases, replace the string function with the drupal_ equivalent string functions	Other	file_entity.file_api.inc	345	N/A

file_entity/file_entity.install 0 0 0

file_entity/file_entity.module 2 0 0

Message	Group	Filename	Line	Function	Status
in most cases, replace the string function with the drupal_ equivalent string functions	Other	file_entity.module	254	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	file_entity.module	300	N/A

file_entity/tests/file_entity_test.module 0 0 0

file_entity/tests/file_entity_test.pages.inc 0 0 0

includes/media.admin.inc 0 2 1

Message	Group	Filename	Line	Function
The control statement should be on a separate line from the control conditional	Other	media.admin.inc	202	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)	Other	media.admin.inc	558	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs)	Other	media.admin.inc	561	N/A

includes/media.browser.inc 0 0 0

includes/media.fields.inc 0 0 0

includes/media.filter.inc 2 0 0

Message	Group	Filename	Line	Function	Status
in most cases, replace the string function with the drupal_ equivalent string functions	Other	media.filter.inc	190	N/A
in most cases, replace the string function with the drupal_ equivalent string functions	Other	media.filter.inc	191	N/A

includes/media.pages.inc 1 0 0

Message	Group	Filename	Line	Function	Status
@see references should be separated by "," followed by a single space and with no trailing punctuation	Other	media.pages.inc	46	N/A

includes/media.theme.inc 0 0 0

includes/media.types.inc 2 0 0

Message	Group	Filename	Line	Function	Status
@see should always be followed by a filename, a URL, class/interface name (optionally including method), or a function name including ().	Other	media.types.inc	8	N/A
@see references should be separated by "," followed by a single space and with no trailing punctuation	Other	media.types.inc	8	N/A

includes/media.variables.inc 0 0 0

includes/media.views.inc 0 0 0

includes/media.xml.inc 0 0 0

includes/MediaReadOnlyStreamWrapper.inc 0 2 1

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	MediaReadOnlyStreamWrapper.inc	-1	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	MediaReadOnlyStreamWrapper.inc	152	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	MediaReadOnlyStreamWrapper.inc	159	N/A

media.api.php 0 0 0

media.install 0 0 0

media.media.inc 0 0 0

media.module 1 0 0

Message	Group	Filename	Line	Function	Status
Format should be `* Implementation of hook_foo().`	Other	media.module	89	N/A

MediaReadOnlyStreamWrapper.inc 0 0 1

Message	Group	Filename	Line	Function	Status
@file block missing (Drupal Docs)	Other	MediaReadOnlyStreamWrapper.inc	-1	N/A

modules/media_internet/media_internet.api.php 0 0 0

modules/media_internet/media_internet.media.inc 0 0 0

modules/media_internet/media_internet.module 3 0 1

Message	Group	Filename	Line	Function
@file block missing (Drupal Docs)	Other	media_internet.module	-1	N/A
@see should always be at the beginning of a line, never inline in other comments.	Other	media_internet.module	115	N/A
@see should always be followed by a filename, a URL, class/interface name (optionally including method), or a function name including ().	Other	media_internet.module	115	N/A
@see references should be separated by "," followed by a single space and with no trailing punctuation	Other	media_internet.module	115	N/A

templates/media-dialog-page.tpl.php 0 0 1

Message	Group	Filename	Line	Function	Status
The control statement should be on a separate line from the control conditional	Other	media-dialog-page.tpl.php	71	N/A

test/media.entity.test 0 0 0

test/media.types.test 0 0 0

wysiwyg_plugins/media.inc 0 0 0

Review log