Countries - 7.x-2.0-beta2 | Drupal Quality Assurance

Latest changes

So Long and Thanks for all the Tests

1 week 1 day ago

Support

In case of troubles

check the FAQ. Please make sure you've tried the test locally.
search known testbot issues and then create a new issue if yours isn't there already. Please give a link to the test.

Test client logs

No clients to display.

Countries - 7.x-2.0-beta2

Test status

Status	Result
Last received	Wed, 09/26/2012 - 04:31:30
Last requested	Wed, 09/26/2012 - 04:32:03
Last tested	Wed, 09/26/2012 - 04:32:32
Test count	2

Environment status

MySQL	pass
Code review	fail

Overall Result	pass

Branch information

Identifier	7.x-2.0-beta2
Project	Countries
Link	Project information

Event logView entire log

ID	Message	Timestamp
4411568	Result retrieved by project client.	3 years 21 weeks ago
4411543	Result received from test client #958.	3 years 21 weeks ago
4411523	Result received from test client #654.	3 years 21 weeks ago
4411513	Requested by test client #654.	3 years 21 weeks ago
4411508	Requested by test client #958.	3 years 21 weeks ago
4411488	Test request received.	3 years 21 weeks ago

SummaryPASSED: [[Coder]]: [Code review] 4 minor(s), 8 critical(s), and 0 normal(s); [[SimpleTest]]: [MySQL] 0 pass(es).

Details

MySQL
Code review

MySQL

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a Drupal installation failure
Detect a test run failure
Detect a failing test
Complete test suite with all tests passing

Review log

Code review

Setup environment
Detect an invalid patch URL
Detect invalid repository information
Detect invalid patch format
Detect a non-applicable patch
Detect invalid PHP syntax
Detect a review run failure
Detect coder flags
Ensure that your code follows the Drupal standard and passes a coder review.
Complete coder review with all passed

4 minor(s), 8 critical(s), and 0 normal(s)

Non-pass

Test name

Minor

Critical

Normal

countries.admin.inc

Message	Group	Filename	Line	Function
Potential problem: form_set_error() and form_error() only accept filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	countries.admin.inc	242	N/A
In SQL strings, Use db_query() placeholders in place of variables. This is a potential source of SQL injection attacks when the variable can come from user data. (Drupal Docs)	Other	countries.admin.inc	259	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	countries.admin.inc	420	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	countries.admin.inc	440	N/A

countries.install

Message	Group	Filename	Line	Function	Status
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	countries.install	179	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	countries.install	234	N/A

modules/countries_configuration/countries_configuration.admin.inc

Message	Group	Filename	Line	Function	Status
Potential problem: drupal_set_title() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	countries_configuration.admin.inc	33	N/A

modules/countries_configuration/countries_configuration.api.php

Message	Group	Filename	Line	Function	Status
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	countries_configuration.api.php	63	N/A

All

Test name

Minor

Critical

Normal

countries.admin.inc

Message	Group	Filename	Line	Function
Potential problem: form_set_error() and form_error() only accept filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	countries.admin.inc	242	N/A
In SQL strings, Use db_query() placeholders in place of variables. This is a potential source of SQL injection attacks when the variable can come from user data. (Drupal Docs)	Other	countries.admin.inc	259	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	countries.admin.inc	420	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	countries.admin.inc	440	N/A

countries.install

Message	Group	Filename	Line	Function	Status
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	countries.install	179	N/A
Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar. (Drupal Docs)	Other	countries.install	234	N/A

countries.module

countries.tokens.inc

modules/countries_configuration/countries_configuration.admin.inc

Message	Group	Filename	Line	Function	Status
Potential problem: drupal_set_title() only accepts filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	countries_configuration.admin.inc	33	N/A

modules/countries_configuration/countries_configuration.api.php

Message	Group	Filename	Line	Function	Status
Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.	Other	countries_configuration.api.php	63	N/A

modules/countries_configuration/countries_configuration.install

modules/countries_configuration/countries_configuration.module

modules/countries_example/countries_example.install

modules/countries_example/countries_example.module

views/countries.views.inc

Message	Group	Filename	Line	Function
Use an indent of 2 spaces, with no tabs	Other	countries.views.inc	28	N/A
Use an indent of 2 spaces, with no tabs	Other	countries.views.inc	31	N/A
Use an indent of 2 spaces, with no tabs	Other	countries.views.inc	34	N/A

views/views_handler_field_countries_continent.inc

views/views_handler_filter_countries_continents_list.inc

views/views_handler_filter_countries_list.inc

Message	Group	Filename	Line	Function	Status
in most cases, replace the string function with the drupal_ equivalent string functions	Other	views_handler_filter_countries_list.inc	84	N/A

Review log