Role Expire - 6.x-1.12

Test status
StatusResult
Last receivedTue, 04/10/2012 - 16:23:37
Last requestedTue, 04/10/2012 - 16:24:03
Last testedTue, 04/10/2012 - 16:24:18
Test count4
Environment status
MySQLpass
Code reviewfail
Overall Resultpass
Branch information
Identifier6.x-1.12
ProjectRole Expire
LinkProject information
SummaryPASSED: [[Coder]]: [Code review] 25 minor(s), 1 critical(s), and 48 normal(s); [[SimpleTest]]: [MySQL] 0 pass(es).
Details

MySQL

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a Drupal installation failure
  8. Detect a test run failure
  9. Detect a failing test
  10. Complete test suite with all tests passing

Code review

  1. Setup environment
  2. Detect an invalid patch URL
  3. Detect invalid repository information
  4. Detect invalid patch format
  5. Detect a non-applicable patch
  6. Detect invalid PHP syntax
  7. Detect a review run failure
  8. Detect coder flags
    Ensure that your code follows the Drupal standard and passes a coder review.
  9. Complete coder review with all passed
25 minor(s), 1 critical(s), and 48 normal(s)

Non-pass

Test nameMinorCriticalNormal
Expandrole_expire.install014
MessageGroupFilenameLineFunctionStatus
Commits to the Git repository do not require the CVS $Id$ keyword in each file. (Drupal Docs)Otherrole_expire.install2N/A
table names should be enclosed in {curly_brackets}Otherrole_expire.install177N/A
Function documentation should be less than 80 characters per line.Otherrole_expire.install186N/A
Doxygen uses @todo and @bug to markup things to be done.Otherrole_expire.install206N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otherrole_expire.install210N/A
Expandrole_expire.migrate.inc001
MessageGroupFilenameLineFunctionStatus
Commits to the Git repository do not require the CVS $Id$ keyword in each file. (Drupal Docs)Otherrole_expire.migrate.inc2N/A
Expandrole_expire.module23034
MessageGroupFilenameLineFunctionStatus
Commits to the Git repository do not require the CVS $Id$ keyword in each file. (Drupal Docs)Otherrole_expire.module2N/A
Doxygen uses @todo and @bug to markup things to be done.Otherrole_expire.module12N/A
put a space between the asterisk and the comment textOtherrole_expire.module16N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.module19N/A
If you define a @param or @return, you should document it as well.Otherrole_expire.module24N/A
There should be no trailing spacesOtherrole_expire.module33N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.module52N/A
If you define a @param or @return, you should document it as well.Otherrole_expire.module57N/A
If you define a @param or @return, you should document it as well.Otherrole_expire.module76N/A
If you define a @param or @return, you should document it as well.Otherrole_expire.module89N/A
Doxygen uses @todo and @bug to markup things to be done.Otherrole_expire.module107N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.module116N/A
If you define a @param or @return, you should document it as well.Otherrole_expire.module119N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.module144N/A
put a space between the asterisk and the comment textOtherrole_expire.module173N/A
Separate comments from comment syntax by a space.Otherrole_expire.module175N/A
Missing parenthesis after function nameOtherrole_expire.module176N/A
Format should be * Implementation of hook_foo().Otherrole_expire.module176N/A
Separate comments from comment syntax by a space.Otherrole_expire.module178N/A
Separate comments from comment syntax by a space.Otherrole_expire.module188N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherrole_expire.module244N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.module246N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.module247N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.module260N/A
If you define a @param or @return, you should document it as well.Otherrole_expire.module262N/A
@param and @return descriptions begin indented on the next line. (Drupal Docs)Otherrole_expire.module262N/A
If you define a @param or @return, you should document it as well.Otherrole_expire.module263N/A
@param and @return descriptions begin indented on the next line. (Drupal Docs)Otherrole_expire.module263N/A
missing space after commaOtherrole_expire.module274N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.module277N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.module278N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherrole_expire.module278N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.module298N/A
There should be no trailing spacesOtherrole_expire.module315N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.module324N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.module325N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherrole_expire.module325N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.module330N/A
There should be no trailing spacesOtherrole_expire.module342N/A
There should be no trailing spacesOtherrole_expire.module350N/A
missing space after commaOtherrole_expire.module352N/A
There should be no trailing spacesOtherrole_expire.module358N/A
missing space after commaOtherrole_expire.module371N/A
There should be no trailing spacesOtherrole_expire.module389N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherrole_expire.module424N/A
There should be no trailing spacesOtherrole_expire.module481N/A
Doxygen uses @todo and @bug to markup things to be done.Otherrole_expire.module481N/A
There should be no trailing spacesOtherrole_expire.module483N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherrole_expire.module500N/A
missing space after commaOtherrole_expire.module500N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherrole_expire.module500N/A
There should be no trailing spacesOtherrole_expire.module502N/A
Use Drupal's format_date(), not PHP's default date().Otherrole_expire.module506N/A
put a space between the asterisk and the comment textOtherrole_expire.module516N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.module519N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.module538N/A
If you define a @param or @return, you should document it as well.Otherrole_expire.module539N/A
Expandrole_expire.rules.inc008
MessageGroupFilenameLineFunctionStatus
Commits to the Git repository do not require the CVS $Id$ keyword in each file. (Drupal Docs)Otherrole_expire.rules.inc2N/A
missing space after commaOtherrole_expire.rules.inc57N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.rules.inc65N/A
Separate comments from comment syntax by a space.Otherrole_expire.rules.inc79N/A
missing space after commaOtherrole_expire.rules.inc92N/A
missing space after commaOtherrole_expire.rules.inc96N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.rules.inc118N/A
If you define a @param or @return, you should document it as well.Otherrole_expire.rules.inc121N/A
Expandrole_expire.views.inc201
MessageGroupFilenameLineFunctionStatus
Commits to the Git repository do not require the CVS $Id$ keyword in each file. (Drupal Docs)Otherrole_expire.views.inc2N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.views.inc131N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.views.inc132N/A

All

Test nameMinorCriticalNormal
Expandrole_expire.install014
MessageGroupFilenameLineFunctionStatus
Commits to the Git repository do not require the CVS $Id$ keyword in each file. (Drupal Docs)Otherrole_expire.install2N/A
table names should be enclosed in {curly_brackets}Otherrole_expire.install177N/A
Function documentation should be less than 80 characters per line.Otherrole_expire.install186N/A
Doxygen uses @todo and @bug to markup things to be done.Otherrole_expire.install206N/A
Use sentence case, not title case, for end-user strings. (Wikipedia)Otherrole_expire.install210N/A
Expandrole_expire.migrate.inc001
MessageGroupFilenameLineFunctionStatus
Commits to the Git repository do not require the CVS $Id$ keyword in each file. (Drupal Docs)Otherrole_expire.migrate.inc2N/A
Expandrole_expire.module23034
MessageGroupFilenameLineFunctionStatus
Commits to the Git repository do not require the CVS $Id$ keyword in each file. (Drupal Docs)Otherrole_expire.module2N/A
Doxygen uses @todo and @bug to markup things to be done.Otherrole_expire.module12N/A
put a space between the asterisk and the comment textOtherrole_expire.module16N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.module19N/A
If you define a @param or @return, you should document it as well.Otherrole_expire.module24N/A
There should be no trailing spacesOtherrole_expire.module33N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.module52N/A
If you define a @param or @return, you should document it as well.Otherrole_expire.module57N/A
If you define a @param or @return, you should document it as well.Otherrole_expire.module76N/A
If you define a @param or @return, you should document it as well.Otherrole_expire.module89N/A
Doxygen uses @todo and @bug to markup things to be done.Otherrole_expire.module107N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.module116N/A
If you define a @param or @return, you should document it as well.Otherrole_expire.module119N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.module144N/A
put a space between the asterisk and the comment textOtherrole_expire.module173N/A
Separate comments from comment syntax by a space.Otherrole_expire.module175N/A
Missing parenthesis after function nameOtherrole_expire.module176N/A
Format should be * Implementation of hook_foo().Otherrole_expire.module176N/A
Separate comments from comment syntax by a space.Otherrole_expire.module178N/A
Separate comments from comment syntax by a space.Otherrole_expire.module188N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherrole_expire.module244N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.module246N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.module247N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.module260N/A
If you define a @param or @return, you should document it as well.Otherrole_expire.module262N/A
@param and @return descriptions begin indented on the next line. (Drupal Docs)Otherrole_expire.module262N/A
If you define a @param or @return, you should document it as well.Otherrole_expire.module263N/A
@param and @return descriptions begin indented on the next line. (Drupal Docs)Otherrole_expire.module263N/A
missing space after commaOtherrole_expire.module274N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.module277N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.module278N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherrole_expire.module278N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.module298N/A
There should be no trailing spacesOtherrole_expire.module315N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.module324N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.module325N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherrole_expire.module325N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.module330N/A
There should be no trailing spacesOtherrole_expire.module342N/A
There should be no trailing spacesOtherrole_expire.module350N/A
missing space after commaOtherrole_expire.module352N/A
There should be no trailing spacesOtherrole_expire.module358N/A
missing space after commaOtherrole_expire.module371N/A
There should be no trailing spacesOtherrole_expire.module389N/A
in most cases, replace the string function with the drupal_ equivalent string functionsOtherrole_expire.module424N/A
There should be no trailing spacesOtherrole_expire.module481N/A
Doxygen uses @todo and @bug to markup things to be done.Otherrole_expire.module481N/A
There should be no trailing spacesOtherrole_expire.module483N/A
string concatenation should be formatted with a space separating the operators (dot .) and non-quote termsOtherrole_expire.module500N/A
missing space after commaOtherrole_expire.module500N/A
The $text argument to l() should be enclosed within t() so that it is translatable.Otherrole_expire.module500N/A
There should be no trailing spacesOtherrole_expire.module502N/A
Use Drupal's format_date(), not PHP's default date().Otherrole_expire.module506N/A
put a space between the asterisk and the comment textOtherrole_expire.module516N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.module519N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.module538N/A
If you define a @param or @return, you should document it as well.Otherrole_expire.module539N/A
Expandrole_expire.rules.inc008
MessageGroupFilenameLineFunctionStatus
Commits to the Git repository do not require the CVS $Id$ keyword in each file. (Drupal Docs)Otherrole_expire.rules.inc2N/A
missing space after commaOtherrole_expire.rules.inc57N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.rules.inc65N/A
Separate comments from comment syntax by a space.Otherrole_expire.rules.inc79N/A
missing space after commaOtherrole_expire.rules.inc92N/A
missing space after commaOtherrole_expire.rules.inc96N/A
Function summaries should be one line only. (Drupal Docs)Otherrole_expire.rules.inc118N/A
If you define a @param or @return, you should document it as well.Otherrole_expire.rules.inc121N/A
Expandrole_expire.views.inc201
MessageGroupFilenameLineFunctionStatus
Commits to the Git repository do not require the CVS $Id$ keyword in each file. (Drupal Docs)Otherrole_expire.views.inc2N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.views.inc131N/A
Use an indent of 2 spaces, with no tabsOtherrole_expire.views.inc132N/A